Commit Graph

14 Commits

Author SHA1 Message Date
Kamil Gabryjelski
cddc361adc feat(explore): Don't discard controls with custom sql when changing datasource (#20934) 2022-10-19 15:29:38 +02:00
John Bodley
561d1ac9f2 feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Kamil Gabryjelski
b7cc89c6d4 fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
3061b6ad09 fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
Jesse Yang
08d0deb720 fix: clean up incorrect usage of TypeScript type in PropTypes (#13681) 2021-03-18 09:12:13 -07:00
Yongjie Zhao
817b740f59 chore: metric refactor iteration 1 (#13596) 2021-03-12 23:11:05 +08:00
Kamil Gabryjelski
d439da2fe0 feat: Implement drag and drop for metrics (#13575)
* Convert MetricsControl to functional component

* Implement drag and drop for metrics

* Implement customizable placeholder for DndSelectLabel
2021-03-12 12:31:17 +08:00
Kamil Gabryjelski
7b370e6f17 feat: Implement drag and drop columns for filters (#13340)
* Implement DnD feature for filters

* minor refactor

* Fix types

* Fix undefined error

* Refactor

* Fix ts errors

* Fix conflicting dnd types

* Bump superset-ui packages

* Change DndItemType case to PascalCase

* Remove redundant null check

* Fix

* Fix csrf mock api call
2021-03-07 11:54:08 +02:00
Jesse Yang
3c62069bbb refactor(explore): convert ControlPanelsContainer to typescript (#13221) 2021-02-28 10:10:15 -08:00
Phillip Kelley-Dotson
3bb14ab950 feat: reset metrics on dataset change (#12782)
* reset metrics on dataset change take one

* remove code

* part 2 or reseting adhoc controls

* update input controls and customize defaults

* remove conosles

* remove extra method

* simplify logic for controls reset and have them use their defaults

* remove consoles

* add annotation control to defaultvalues

* remove line
2021-02-05 14:08:27 +08:00
Kamil Gabryjelski
fcaa0acad5 chore: Upgrade react-dnd to 11.1.3 (#12815) 2021-01-28 18:34:56 -08:00
Kamil Gabryjelski
6280b34483 fix(explore): don't allow selecting duplicated saved metric (#12657) 2021-01-21 15:51:59 -08:00
Kamil Gabryjelski
853d34beba fix(explore): Disable saved metric name edit in Metric popover (#12582) 2021-01-19 12:28:55 -08:00
Yongjie Zhao
9771b82c94 refactor(explore): move MetricControl and FilterControl to sub-component (#12446)
* wip

* wip

* wip

* wip

* move spec

* wip

* wip

* remove unused file

* wip

* wip

* Update superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-01-19 22:46:28 +08:00