Commit Graph

18 Commits

Author SHA1 Message Date
Rob Moore
ce65a3b9cd fix(charts): View in SQL Lab with relevant perm (#24903) 2023-08-10 20:04:07 +03:00
Jack Fragassi
44557f5a23 chore(api v1): Deprecate datasource/save and datasource/get endpoints (#23678) 2023-04-18 17:51:24 -07:00
Michael S. Molina
49aa9b4ca8 chore: Removes icon warnings from tests (#23054) 2023-02-13 12:31:09 -05:00
Lyndsi Kay Williams
ddd5cd3aec test: Fix act errors in DatasourceControl test (#22845) 2023-01-25 07:36:05 -06:00
Cody Leff
f5c404fc51 fix(explore): Restore missing dataset states (#22693) 2023-01-13 09:42:38 -07:00
Ville Brofeldt
5b2ca97341 fix(sqllab): remove link to sqllab if missing perms (#22566) 2023-01-09 14:02:36 +02:00
Maxime Beauchemin
888f43c6ad chore: rename 'Change dataset' action to 'Swap dataset' (#22197) 2022-11-23 10:19:59 -08:00
Geido
fa67315f5b fix: Default temporal column in Datasource (#21857) 2022-10-25 14:42:11 +03:00
Lyndsi Kay Williams
3819d5154a test: Fix act errors in DatasourceControl test (#21426) 2022-09-09 20:27:50 -05:00
Hugh A. Miles II
e5e8867394 feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
Phillip Kelley-Dotson
e1a918f141 fix: enable admin to edit dataset in explore (#20613)
* add conditional

* add test

* fix lint
2022-07-08 11:22:45 -07:00
Antonio Rivero Martinez
8a57a71bed fix(sql lab): Save Dataset Modal Autocomplete should display list when overwritting (#20512)
* Save Dataset Modal:

- Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app
- Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting
- We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected
- Updated tests

* Save Dataset Modal:

- Update missing test for DatasourceControl

* Save Dataset Modal:

- Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application

* Save Dataset Modal:

- Remove unused comment

* Save Dataset Modal:

- Add getPopupContainer as prop for Select component

* Save Dataset Modal:

- Add tests for our new getPopupContainer prop in Select component. So if passed it gets called.

* Save Dataset Modal:

- use lowercased property when calling post form data

* Save Dataset Modal:

- Update tests so there is no need to define a null returning func

* Save Dataset Modal:

- Including getPopupContainer from PickedSelectProps instead
- Updating definition in SelectFilterPlugin
2022-07-01 14:40:13 -06:00
Lily Kuang
ab9f72f1a1 fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Lyndsi Kay Williams
c842c9e2d8 feat(explore): Dataset Panel Options when Source = Query II (#20299)
* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Removed isValidDatasourceType check

* Remove the rest of isValidDatasourceType check
2022-06-10 09:55:52 -07:00
Hugh A. Miles II
8b15b68979 fix: Alpha should not be able to edit datasets that they don't own (#19854)
* fix api for checking owners

* fix styles for disabling

* fix styles for disabling

* fix lint

* fix lint

* add owners key

* plzz

* remove

* update test

* add tooltip

* add type

* fix test

* fix user reference

* lit

* fix test

* work
2022-04-29 14:21:05 -07:00
Michael S. Molina
816a2c3e1e chore: Removes direct theme imports (#19368) 2022-03-29 10:15:07 -03:00
Hugh A. Miles II
959fd763a8 fix: Owners selection in dataset edit UX (#17063)
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
2021-10-12 20:27:56 -04:00
Bruno Motta
ec5d2f5f32 test: DatasourceControl (#13605)
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 17:52:45 -07:00