Commit Graph

698 Commits

Author SHA1 Message Date
Lyndsi Kay Williams
d3f9fbb5f9 test: Fix act errors in DatasourcePanelDragOption test (#21410) 2022-09-09 13:10:59 -03:00
Lyndsi Kay Williams
2f8cc44c5d test: Fix act error in FilterInput test (#21407) 2022-09-09 13:10:41 -03:00
Lyndsi Kay Williams
3197cc6eaa test: Fix act errors in DatasourcePanel test (#21409) 2022-09-09 08:34:50 -03:00
Lyndsi Kay Williams
bd1abd3b6e test: Fix act errors in SamplesPane test (#21406) 2022-09-09 08:33:14 -03:00
Lyndsi Kay Williams
295de2d098 test: Fix act errors in ResultsPaneOnDashboard test (#21404) 2022-09-09 08:32:46 -03:00
Lyndsi Kay Williams
fdae29b0f0 test: Fix act error in DataTablesPane test (#21403) 2022-09-09 08:32:10 -03:00
Lyndsi Kay Williams
d635566c16 test: Fix act errors in ExploreChartHeader test (#21402) 2022-09-09 08:31:33 -03:00
Lyndsi Kay Williams
6fad3f9a35 test: Fix act error in ExportToCVSDropdown test (#21401) 2022-09-09 08:30:46 -03:00
Lyndsi Kay Williams
9318e269b1 test: Fix act error in PropertyModal test (#21400) 2022-09-09 08:30:01 -03:00
Lyndsi Kay Williams
714196e745 test: Fix act errors in ControlPanelsContainer test (#21398) 2022-09-09 08:29:23 -03:00
Lyndsi Kay Williams
ac114cae48 test: Fix act errors in ExploreChartPanel test (#21397) 2022-09-09 08:28:47 -03:00
Cody Leff
875e9f8a04 fix(dashboard): Fix scrolling on "View as table" modal (#21282) 2022-09-07 10:16:16 +08:00
aehanno
c382d53478 fix: Add locale for DatePicker component (#20063)
Co-authored-by: Kevin Dethelot <kevin.dethelot@kosmos.fr>
Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
2022-09-07 10:10:05 +08:00
Zef Lin
9be4870c7f feat: only show active user for chart/dashboard/datasource owner drop… (#20837) 2022-09-06 19:17:50 +01:00
Shubham Sinha
b354f2265a fix(dev-server run): Check for environment tag not being undefined (#21232)
* fixed local dev-server run

* removed console log

* removed console log
2022-08-30 14:51:32 +08:00
Geido
f017f98b88 chore: E2E tests for the Drill to detail modal (#21187)
* Add example ECharts Dashboard

* [WIP] E2E test

* Add echarts interactions

* Lint

* DRY
2022-08-29 11:25:27 +03:00
Lyndsi Kay Williams
6094274f0b feat: Create dataset blank state (#21058)
* beginning of routing

* elizabeth review

* changed folder layout

* Dataset layout setup

* Fix DatasetLayout test

* Fixed height issue

* Fix link to sqllab

* Fix DatasetPanel test

* Remove arbitrary right panel

* Add empty state SVGs

* Restructure/rename some Dataset files

* Fixed styling issue

* Fix background color

* Fix header border

* Fix empty DatasetPanel styles

* Adjust description rendering in DatasetPanel to fix tests

* Add spaces back to blank dataset description to fix tests

* Fix blank dataset description styles

Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
2022-08-22 18:45:03 -05:00
Geido
756ed0e36a feat: Add label and tooltip for the color schemes control (#21040)
* Add tooltip

* Remove title

* Add license

* Enhance E2E tests

* Update tests

* Lint and test fixes

* Enhance layout
2022-08-22 10:44:15 +03:00
Yongjie Zhao
dfe5a04938 fix: unable to show view as table modal (#21025) 2022-08-10 11:35:06 +08:00
Elizabeth Thompson
463406ff09 fix: save dataset and repopulate state (#20965)
* save dataset and repopulate state

* disable dashboard button if dataset is missing

* fix error message

* fix tests
2022-08-05 14:32:49 -07:00
Kamil Gabryjelski
9350bbafee fix(explore): Replace url search params only if current page is Explore (#20972)
* fix(explore): Replace url search params only if current page is Explore

* Add unit test
2022-08-05 16:59:52 +02:00
Phillip Kelley-Dotson
fa416fa130 fix: remove extra line for link (#20959)
* fix: remove extra line for link

* add space
2022-08-04 13:29:07 -04:00
Antonio Rivero Martinez
e2206a7151 Annotations: (#20720)
- Fix scrollbar when removing annotations
2022-08-02 14:31:48 -06:00
Diego Medina
dd353ca86a feat: Add resize drag handle to Dataset SQL fields (#20670)
* feat: Add resize drag handle to Dataset SQL fields

* PR comments
2022-08-02 14:13:14 -06:00
Hugh A. Miles II
0d8889dc9c fix: Save dataset + chart when Chart source is Query (#20880)
* feat: save dataset savemodal

* fix lint

* add comments

* enable chart power query

* clean up

* added test

* fix overwrite

* add proper error messaging for save datasetModal

* lint

* fix ts lint

* fix

* Disables Save button while network call is in progress, removing second Chart saved toast message

* change naming

* err

* Update superset-frontend/src/explore/components/SaveModal.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update SaveModal.tsx

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-07-29 17:30:28 -04:00
Cody Leff
e7acb1a79d chore(explore): update Explore icons and icon colors (#20612)
* Update Explore icons and icon colors.

* Change shade of blue and make blue only appear when fields have never been filled in.

* Fix Cypress test.

* Update non-error validation color from blue to yellow.

* Unpack ternary.

* Replace direct AntD imports with our Icons component.
2022-07-29 09:05:15 -06:00
Phillip Kelley-Dotson
2f3e11db66 feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
Geido
a69f016bca chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Kamil Gabryjelski
5c2c2e8040 feat(explore): UX changes in fast viz switcher (#20848)
* feat(explore): UX changes in fast viz switcher

* Fix test
2022-07-26 08:44:17 +02:00
Diego Medina
5d107b86ab fix: explore warnings cleanup (#20864) 2022-07-26 13:28:50 +08:00
Hugh A. Miles II
3de641c3ae change buttons to be only save and overwrite (#20851) 2022-07-25 18:18:17 -04:00
Kamil Gabryjelski
e3c6380258 chore: Change Button background color from primary.dark1 to primary.base (#20846) 2022-07-25 18:02:14 +02:00
Kamil Gabryjelski
0945d4a2f4 feat: Pass dashboard context to explore through local storage (#20743)
* feat: Pass dashboard context to explore through local storage

* Remove console log

* Remove unused local storage keys

* Fix lint

* Fix link

* Fix UT

* fix lint

* fix prettier

* Fix bug

* Fix bug with some sample dashboards

* Roll back unnecessary change

* style fix

* Add comments

* Fix lint

* Address code review comments

* Fix
2022-07-25 16:44:43 +02:00
Diego Medina
6e0ddcf848 fix: [explore][mixed time series chart] when user change size of view query window, query B part will disappear (#20750) 2022-07-22 20:39:13 +08:00
Yongjie Zhao
f011abae2b feat: the samples endpoint supports filters and pagination (#20683) 2022-07-22 20:14:42 +08:00
Diego Medina
279ab954b1 fix: chart empty state & result panel when multiple queries are executed display incorrectly (#20816) 2022-07-22 14:58:42 +08:00
Kamil Gabryjelski
af1bddffad fix(explore): Adhoc columns don't display correctly (#20802)
* fix(explore): Adhoc columns have empty labels

* Add unit test

* Address comments
2022-07-21 21:11:49 +02:00
Michael S. Molina
3311128c5e fix: Reverts #20749 and #20645 (#20796)
* Revert "fix: Error when saving datasource from Explore (#20749)"

This reverts commit 92f3621c75.

* Revert "refactor: Unify shared datasources reducers and actions (#20645)"

This reverts commit 2a705406e1.
2022-07-20 17:03:19 -03:00
Hugh A. Miles II
1101922178 fix change dataset (#20751) 2022-07-18 14:23:11 -04:00
Michael S. Molina
92f3621c75 fix: Error when saving datasource from Explore (#20749) 2022-07-18 14:35:19 -03:00
Hugh A. Miles II
510c1c4817 fix: set reference to columns properly for sqllab -> explore (#20747)
* set reference to columns properly

* fix logic
2022-07-18 12:32:31 -04:00
Hugh A. Miles II
e5e8867394 feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
Michael S. Molina
2a705406e1 refactor: Unify shared datasources reducers and actions (#20645)
* refactor: Unify shared datasources reducers and actions

* Removes column_types

* Adjusts hydrateExplore

* Revert "Removes column_types"

This reverts commit 096bbf7826.

* Fixes test
2022-07-13 13:03:36 -03:00
Usiel Riedl
19247cc92a Fixes datatable crash when dimension is empty (#20680)
Fixes #20679

Co-authored-by: Usiel Riedl <usiel.riedl@automattic.com>
2022-07-13 14:54:33 +08:00
Cody Leff
b1020e3062 chore(explore): Update chart save to use API endpoints (#20498)
* Update SaveModal to use v1 API instead of POST /explore.

* Refactor SaveModal tests and remove obsolete ones.

* Fix redirect to /explore on save.

* Add toasts (but they don't work).

* Move logic inside try block, clarify unary-plus use.

* Add tests.

* Fix owners bug in updateSlice, enable navigation to dashboard w/o reload.

* Fix toasts.

* Fix translated strings.

* Fix unintended removal from dashboard bug.

* Fix native filters bug.

* Don't refresh Explore page after saving

* Use JSON payload shorthand.

* Prevent current dashboards being overwritten on viz type change.
2022-07-13 06:36:31 +02:00
Diego Medina
c29261b63d fix: X Axis should be called Y Axis when using the Bar Chart V2 on Horizontal mode (#20659) 2022-07-09 12:36:16 +08:00
Phillip Kelley-Dotson
e1a918f141 fix: enable admin to edit dataset in explore (#20613)
* add conditional

* add test

* fix lint
2022-07-08 11:22:45 -07:00
AAfghahi
0ce0c6e1eb chore: removing Druid from front- and back- end (#20338)
* first pass at removing native Druid nosql

* removing having_druid

* addressing comments, linting

* fixed all tests

* addressing comments

* redirected to ui-core TimeGranularity type

* query form metric linting

* fixed broken chart type

* implementing feedback
2022-07-08 17:57:03 +02:00
cccs-RyanK
1109fe5fb7 chore: Split Select component into Async and Sync components (#20466)
* Created AsyncSelect Component
Changed files to reference AsyncSelect if needed

* modified import of AsyncSelect, removed async tests and prefixes from select tests

* fixed various import and lint warnings

* fixing lint errors

* fixed frontend test errors

* fixed alertreportmodel tests

* removed accidental import

* fixed lint errors

* updated async select
2022-07-07 15:51:37 -03:00
Michael S. Molina
662bab1e6d feat: Renders Explore in SPA (#20572)
* feat: Renders Explore in SPA

* Adds permalink support

* Replaces navigation from Welcome page

* Fix initializing feature flags

* Remove redundant import

* Adds saveSlice workaround

* Fixes paths

* Fixes lint error

* Fixes tests

* Fix url to explore from Datasets view

* Fix explore page height

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-05 16:58:09 -03:00