Commit Graph

14 Commits

Author SHA1 Message Date
Elizabeth Thompson
fb410b39e6 fix(reports): retrofit execution-id/cache-key tracing onto existing screenshot-capture logs
Extends the log_context plumbing landed for the new tile-wait-budget log
lines to the rest of the report-screenshot capture path, so any log line
in this flow can be traced back to the run that produced it without
cross-referencing: superset/utils/screenshot_utils.py (combine_screenshot_tiles
and the non-budget log lines in take_tiled_screenshot), superset/utils/webdriver.py
(WebDriverPlaywright and WebDriverSelenium get_screenshot/find_unexpected_errors),
and superset/utils/screenshots.py (BaseScreenshot.driver/compute_and_cache/resize_image,
using the thumbnail cache_key where there is no report execution id).

superset/commands/report/execute.py needed no changes: every log line in
its screenshot-acquisition path already carries execution_id.

Message-text/plumbing only -- no behavior or log-level changes here beyond
what already landed. Left untouched, to avoid conflicting with the
concurrent fix-tile-readiness-check PR: the per-tile spinner-wait log
lines inside take_tiled_screenshot, and the two non-tiled ".loading" wait
blocks in webdriver.py (Playwright's wait_for_function-based checks and
Selenium's WebDriverWait-based check).

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-23 01:00:06 +00:00
Elizabeth Thompson
c8bf18da7f fix(reports): downgrade tile-wait-budget logs to WARNING and add execution-id tracing
Budget exhaustion and per-tile spinner timeouts in take_tiled_screenshot()
are customer-side chart-loading issues, not Superset system faults, so log
them at WARNING instead of ERROR -- consistent with the precedent set by
the same way. Genuine system faults (browser crash, uncaught Playwright
errors) remain at the existing exception/ERROR level, unchanged.

Thread an optional log_context string through the screenshot call chain
(ChartScreenshot/DashboardScreenshot.get_screenshot -> WebDriverProxy
implementations -> take_tiled_screenshot) so every log line this PR adds
or touches can be traced back to its run: the report execution id on the
report path, or the thumbnail cache key on the thumbnail path (no new
plumbing invented there -- cache_key was already in scope).

Also add a per-tile DEBUG timing line (spinner wait vs. animation wait)
and richer WARNING diagnostics (tile index, tiles captured so far, elapsed
vs. budget) so a slow dashboard can be profiled and a timeout diagnosed
from logs alone.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-23 00:58:36 +00:00
Elizabeth Thompson
4b659da5c4 fix(reports): positive per-tile chart readiness check for tiled screenshots (#42119)
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: yousoph <sophieyou12@gmail.com>
2026-07-20 17:31:45 -07:00
Elizabeth Thompson
134919ea36 fix(screenshots): catch empty-bytes tiled result and set ERROR on falsy image (#41097)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-29 11:52:40 -07:00
Evan Rusackas
b4dfeef2fd fix(reports): add network timeouts so schedules can't hang forever (#41250)
Co-authored-by: Claude Code <noreply@anthropic.com>
2026-06-23 18:01:03 -07:00
Daniel Vaz Gaspar
27a65257ee perf(screenshots): reuse Playwright browser across tasks instead of launching per-task (#41243)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-06-22 11:32:30 -07:00
Elizabeth Thompson
0c9ece65bb fix(reports): require user in get_screenshot, simplify Selenium lifecycle, and fail on tiled screenshot error (#41080)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-18 15:46:17 -07:00
Elizabeth Thompson
f187a8e1c4 fix(reports): guard null dashboard height in Playwright screenshots (#40179) 2026-05-21 09:19:29 -07:00
Elizabeth Thompson
8d2b655c22 fix(reports): narrow spinner checks to viewport and tighten exception handling (#39895)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-15 13:35:07 -07:00
Elizabeth Thompson
f0d521dfc2 fix(reports): poll for spinner absence instead of snapshotting loading elements (#39579)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-23 22:03:43 -03:00
Elizabeth Thompson
587fe4af63 fix(reports): propagate PlaywrightTimeout so execution transitions to ERROR state (#39176)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-08 11:00:03 -07:00
Amin Ghadersohi
fe7f8062f3 fix: Enable Playwright migration with graceful Selenium fallback (#35063)
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-23 10:47:45 -07:00
Maxime Beauchemin
088ecdd0bf refactor: Enable G logging rules and comprehensive ruff improvements (#35081)
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-15 12:42:49 -07:00
Elizabeth Thompson
385471c34d fix(utils): ensure webdriver timeout compatibility with urllib3 2.x (#34440) 2025-09-05 16:25:15 -07:00