serenajiang
3657cbea7f
fix(dashboard): commit update once ( #17781 )
2021-12-16 11:49:40 -08:00
Geido
12bd1fcde5
fix: Save properties after applying changes in Dashboard ( #17570 )
...
* Refactor PropertiesModal
* Update json_metadata fully
* Clean up
* Verify values
* Catch changed to metadata
* Always updated dashboard info on update
* Avoid unnecessary fetches
* Formt
* Fix copy dashboards
* Fixes onUpdate onCopy handlers
* Pylint
* Update tests
* Clean up
* Handle data on show
* Change Save to Apply
* Update Cypress save test
* Update Cypress edit prop test
* Update PropertiesModal test
* Fix duplicate request with cross filters
* Improve code style
* Fix typo
* Lint
2021-12-09 10:03:07 -07:00
John Bodley
be7065faf8
chore(pylint): Reenable raise-missing-from check ( #16266 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-17 10:26:10 +12:00
Ville Brofeldt
d6f9c48aa1
feat(dao): admin can remove self from object owners ( #15149 )
2021-08-13 12:42:48 +03:00
Amit Miran
8ccf2e8f1e
feat(dashboard_rbac): dashboards API support for roles create/update + roles validation ( #12865 )
2021-02-07 16:16:19 +02:00
John Bodley
91517a56a3
style(mypy): Spit-and-polish pass ( #10001 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-07 08:53:46 -07:00
Daniel Vaz Gaspar
bb80ceaccc
[dashboards] Fix, update dashboard owners not propagating to charts o… ( #9484 )
...
* [dashboards] Fix, update dashboard owners not propagating to charts owners
* Add tests
* Fix tests
* better naming
2020-04-09 09:37:37 +01:00
Ville Brofeldt
980dd2fd41
pylint: accept specific 2 character names by default ( #9460 )
...
* lint: accept 2 letter names by default
* Address review comments
* Remove e and d from good-names
2020-04-08 20:32:26 +03:00
Daniel Vaz Gaspar
f9db3faade
[mypy] Enforcing typing for superset.dashboards ( #9418 )
...
* [mypy] Enforcing typing for superset.dashboards
* Make return types equal on all commands
* Make return types equal on all commands
* [dashboard] address comments same return type on commands
* lint
* lint
2020-04-07 12:52:14 +01:00
Daniel Vaz Gaspar
752de8fe9d
[dashboards] Fix, API update slug uniqueness refusing empty string ( #9417 )
...
* [dashboards] Fix, API update slug uniqueness refusing empty string
* [dashboards] tests
2020-03-30 16:10:08 +01:00
Daniel Vaz Gaspar
c34df6b7b3
[dashboard] Refactor API using SIP-35 ( #9315 )
...
* [dashboard] Refactor API using SIP-35
* [dashboard] Fix, import
* [dashboard] more tests
* [dashboards] a misc of improvements
* [charts] Fix, DAO and tests
* [dashboards] small exceptions refactor
* [dashboards] lint
* [dashboards] Improves comments on base classes
* [dashboards] lint
2020-03-20 16:32:03 +00:00
