Commit Graph

20 Commits

Author SHA1 Message Date
Joe Li
47d3425064 test(subdirectory): align test expectations with Superset.route_base=""
After Superset.route_base="" (c531185d0a) and the FAB-link migration
(28b845ead4), `url_for` for the core blueprint emits `/dashboard/...`,
`/explore/...`, `/explore_json/...`, `/welcome/...` etc. (no `/superset/`
segment). Likewise the Tag component renders `/all_entities/?id=<id>`,
and rewritePermalinkOrigin substitutes window.location.origin into
backend permalinks at the frontend boundary.

Update test expectations to match:

  * Python unit: tests/unit_tests/commands/report/execute_test.py drops
    `superset/` from the 12 `dashboard/p/...` expected paths and the
    `superset/dashboard/` membership check (kept assertion meaningful
    via the existing `dashboard/p/` negative check).
  * Python integration: drop `/superset/` from URLs hit by tests and
    from URLs asserted against API payloads in core_tests, dashboard_tests,
    dashboards/api_tests, event_logger_tests, log_api_tests, security_tests,
    strategy_tests, utils_tests, reports/commands_tests,
    reports/commands/execute_dashboard_report_tests. Fixed the regex in
    test_new_dashboard to match the new Location header shape.
  * Jest: ChartList tag-link assertion drops `/superset/`, and
    URLShortLinkButton tests assert the rewritten URL
    (`${window.location.origin}/123`) the component renders after
    rewritePermalinkOrigin, instead of the raw backend `http://fakeurl.com/123`.

These were called out in PROJECT.md as the queued "integration test sweep
for old `/superset/<endpoint>/` shapes" — this commit closes that item.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-14 19:48:15 -07:00
Sam Firke
aede3bb5ba fix(auth): redirect anonymous attempts to view dashboard with next (#35345) 2025-10-16 16:33:37 -04:00
Maxime Beauchemin
e51b95ffa8 chore: enforce more ruff rules (#31447)
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2024-12-18 17:41:34 -08:00
Maxime Beauchemin
a849c29288 chore: enable lint PT009 'use regular assert over self.assert.*' (#30521) 2024-10-07 13:17:27 -07:00
John Bodley
8fb8199a55 chore(dao/command): Add transaction decorator to try to enforce "unit of work" (#24969) 2024-06-28 12:33:56 -07:00
Maxime Beauchemin
2d63722150 chore: set up ruff as a new linter/formatter (#28158) 2024-04-24 17:19:53 -07:00
John Bodley
bc65c245fe chore(tests): Remove unnecessary/problematic app contexts (#28159) 2024-04-24 13:46:35 -07:00
John Bodley
481a63da55 chore(tests): Remove ineffectual login (#27149) 2024-04-09 09:52:02 -07:00
John Bodley
dd58b31cc4 chore(sqlalchemy): Remove erroneous SQLAlchemy ORM session.merge operations (#24776) 2023-11-20 17:25:41 -08:00
Jack Fragassi
258e56285a fix: Don't let users see dashboards only because it's favorited (#24991) 2023-08-17 17:35:37 -07:00
John Bodley
94c595093b chore: Add explicit ON DELETE CASCADE for dashboard_slices (#24938) 2023-08-10 10:56:11 -03:00
John Bodley
ae00489779 chore(dao): Add explicit ON DELETE CASCADE for ownership (#24628) 2023-07-11 11:39:03 -07:00
Daniel Vaz Gaspar
ca478bd5c4 chore: remove deprecated apis copy_dash, save_dash and add_slices (#24353) 2023-06-13 15:08:47 +01:00
John Bodley
a4d5d7c6b9 chore(pre-commit): Add pyupgrade and pycln hooks (#24197) 2023-06-01 12:01:10 -07:00
Jack Fragassi
050cbe938f chore: Migrate /superset/recent_activity/<user_id>/ to /api/v1/ (#22789) 2023-01-25 09:26:50 +00:00
EugeneTorap
30dab3a00a chore: Bump flask libs (#22355) 2023-01-09 10:10:31 +00:00
Jesse Yang
2cb4fd31f1 refactor(test): add login_as_admin in global conftest (#20703) 2022-07-14 18:10:31 -07:00
Daniel Vaz Gaspar
d6d2777ada feat: deprecate old API and create new API for dashes created by me (#19434)
* feat: deprecate old API and create new API for dashes created by me

* add tests

* fix previous test

* fix test and lint

* fix sqlite test

* fix lint

* fix lint

* lint

* fix tests

* fix tests

* use dashboards get list instead

* clean unnecessary marshmallow schema

* Update superset/views/core.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-04-08 09:05:22 +01:00
Bogdan
afd2e9f2ca chore: update fixtures scope that are loading data into the analytical db (#17780)
* Update db setup fixture scope

* Load data into db only once

* Update fixture scopes for data loading

* cleanup imports

* try import

* Update scope

* fix cleanup

* Import all fixtures

* Separate data log and metadata creation

* Retain table description

* fix dtype

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2021-12-16 16:11:47 -08:00
ofekisr
b5119b8dff refactor(tests): decouple unittests from integration tests (#15473)
* refactor move all tests to be under integration_tests package

* refactor decouple unittests from integration tests - commands

* add unit_tests package

* fix celery_tests.py

* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00