QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,435 Commits 490 Branches 544 Tags
d90bfa65ef9f332430d306cdd1aa2fa032199a6e
Commit Graph

65 Commits

Author SHA1 Message Date
Elizabeth Thompson
2a25e2d7ca update execution logs and states for alerts (#16736) 2021-09-20 14:26:30 -07:00
AAfghahi
c66f278b42 feat: Backend Validation for Creation Method (#16375) 
* backend creation method validation

* added tests

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update tests/integration_tests/reports/api_tests.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update tests/integration_tests/reports/api_tests.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/commands/create.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/commands/exceptions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* revisions

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-09-08 16:35:18 -07:00
Ville Brofeldt
ac1d779a30 chore(ci): bump pylint to 2.10.2 (#16463) 2021-08-26 20:30:41 +03:00
John Bodley
7e4c940314 chore(pylint): Enable useless-suppression check (#16388) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-24 03:58:41 +12:00
Hugh A. Miles II
50d896f1b7 fix: Fix parsing onSaving reports toast when user hasn't saved chart (#16330) 
* don't maniuplate error message

* remove extra idx reference

* u

* change print

* update with test

* add case for dashboards

* fix test
 2021-08-19 14:04:23 -04:00
Beto Dealmeida
afb8bd5fe6 feat: improve embedded data table in text reports (#16335) 
* feat: improve HTML table in text reports

* Remove unused import

* Update tests

* Fix test
 2021-08-18 17:00:29 -07:00
John Bodley
be7065faf8 chore(pylint): Reenable raise-missing-from check (#16266) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-17 10:26:10 +12:00
John Bodley
0df15bf207 chore(pylint): Reenable import-outside-toplevel check (#16263) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-17 05:20:13 +12:00
Beto Dealmeida
9b2dffeb1d fix: pivot columns with ints for name (#16259) 2021-08-13 18:21:20 -07:00
Hugh A. Miles II
4ae88ce3b4 chore: bump py version for integration test (#16213) 
* bump py version for integration test

* bump py

* bump py

* remove files

* lock pylint

* add not-callable
 2021-08-13 12:44:32 -04:00
Ville Brofeldt
d6f9c48aa1 feat(dao): admin can remove self from object owners (#15149) 2021-08-13 12:42:48 +03:00
Elizabeth Thompson
5031a67597 feat: Self subscribe reports (#16027) 
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
 2021-08-02 09:12:09 -07:00
Beto Dealmeida
2d61f15153 feat: send post-processed data in reports (#15953) 
* feat: send post-processed data in reports

* Fix tests and lint

* Use enums

* Limit Slack message to 4k chars
 2021-07-30 09:37:16 -07:00
Beto Dealmeida
6afa840659 feat: send report data to Slack (#15806) 
* feat: send data embedded in report email

* Change post-processing to use new endpoint

* Show TEXT option only to text-based vizs

* Fix test

* feat: send data embedded in report email

* feat: send report data to Slack

* Add unit test

* trigger tests
 2021-07-29 10:13:28 -07:00
John Bodley
671b8f2544 chore: Mypy fix **kwargs type (#15823) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-07-29 04:59:20 +12:00
Beto Dealmeida
3adf8e85cd feat: send data embedded in report email (#15805) 
* feat: send data embedded in report email

* Prettify table

* Change post-processing to use new endpoint

* Show text option only for text viz

* Show TEXT option only to text-based vizs

* Fix test

* Add email test

* Add unit test
 2021-07-28 09:43:04 -07:00
Elizabeth Thompson
ea49aa3d2d feat: add timezones to report cron (#15849) 
* add timezones to report cron

* fix test
 2021-07-27 18:28:24 -07:00
Beto Dealmeida
2ce676d20d feat: call screenshot to store query_context (#15846) 
* feat: call screenshot to store query_context

* Add unit test

* Move updateQueryContext to ExploreChartPanel

* Add error handling

* Fix code

* Fix logic
 2021-07-27 14:02:27 -07:00
Beto Dealmeida
f6fe29db87 feat: use new API endpoint to build CSV reports (#15830) 
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API

* feat: use new API endpoint to build CSV reports
 2021-07-21 17:50:56 -07:00
AAfghahi
e66db63333 reports (#15828) 2021-07-21 16:52:59 -07:00
Beto Dealmeida
c9dad05f2b chore: remove retry dependency in favor of backoff (#15788) 
* chore: remove retry dep in favor of backoff

* Fix lint
 2021-07-20 10:33:37 -07:00
AAfghahi
3a249a0090 feat: add show columns to Reports model (#15712) 
* added logic for creation_method

* revisions

* added index

* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py

* filters

* search columns updated
 2021-07-19 11:47:33 -07:00
AAfghahi
674f234de6 feat: add logic to creation_method for reports schedule (#15685) 
* migration

* added logic for creation_method

* revisions

* added index

* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py

* filters

* Update superset/models/reports.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/schemas.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update tests/integration_tests/reports/api_tests.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* revisions

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-07-15 18:27:54 -07:00
Ben Reinhart
6d9d362ca8 chore: use before_request hook for dynamic routes (#14568) 
* chore: use before_request hook for dynamic routes

* Shorten hook names

* Introduce with_feature_flags and update thumbnail tests

* Disable test that fails in CI but not locally

* Add test for reports
 2021-05-14 12:49:25 -07:00
Lily Kuang
adbe56c8a8 fix image width to 1000px for email (#14527) 2021-05-10 13:38:07 -07:00
Sam Faber-Manning
11260b3117 chore: add stack trace to all calls of logger.error (#14382) 2021-04-30 09:22:05 -07:00
ume
ebc938059b fix: pybabel extract fails (#14338) 2021-04-26 13:59:04 -07:00
Daniel Vaz Gaspar
38a7c537ff feat: add alerts & reports to docker compose (#14267) 
* feat: add alerts & reports to docker compose

* change to firefox

* add missing package
 2021-04-22 17:42:52 +01:00
Jesse Yang
2dd20df03d fix(dashboard): draft dashboards should be viewable (#14207) 
* fix(dashboard): draft dashboards should have open access

* Remove a duplicate test
 2021-04-21 09:54:51 -07:00
Lily Kuang
df7e2b6a8e feat(alert/report): chart as csv format attachment for email and slack (#13828) 
* add ui for setting report format

* refactor default notification format

* init csv data alert report

* add report format to report_schedule model

* add ALERTS_ATTACH_REPORTS feature flag

* fix lint

* update check image tag

* fix migrations

Co-authored-by: samtfm <sam@preset.io>
 2021-04-15 14:07:49 -07:00
Lily Kuang
7980b767c0 feat: Implement Celery SoftTimeLimit handling (#13740) 
* log soft time limit error

* lint

* update test
 2021-04-12 13:18:17 -07:00
Sam Faber-Manning
911462a148 feat: only send alert error emails to owners of the alert (#13862) 
* only send alert error emails to owners of the alert

* reformat long lines

* fix send to owners and add tests

* fix pylint errors

* fix formatting
 2021-04-12 08:51:32 -07:00
Sam Faber-Manning
778bb8e540 feat: add descriptions to report emails (#13827) 
* add description to report email

* add report description to slack notification

* fix issues caught by linter

* fix long line

* remove extra line

* handle missing descriptions

* run python black

* properly run python black
 2021-04-12 08:50:44 -07:00
Daniel Vaz Gaspar
89817d4cee fix(alerts/reports): working timeout with celery kill and logic fix (#13911) 
* fix: working timeout with celery kill and logic fix

* add config flags

* fix typo

* fix python lint

* log query time for alerts

* add tests

* fix lint
 2021-04-08 11:23:31 +01:00
Lily Kuang
762101018b feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894) 
* Add a feature flag ALERTS_ATTACH_REPORTS

* update test

* update feature flag

* add comment for feature flag

* add unit tests for alerts with attachments disabled

* fix lint

Co-authored-by: samtfm <sam@preset.io>
 2021-04-01 13:06:45 -07:00
Jack Fragassi
304e3b36eb feat(alerts & reports): Easier to read execution logs (#13752) 
* Prep for migration

* Migration for execution id column

* Generate execution ids for alerts and reports

* Change execution id range

* Add execution id to API endpoint

* Add execution id to execution log view

* Change execution id range

* Change execution id to a uuid

* Fix execution id type

* Switch state and exec. id columns

* Change db column to UUIDType

* Python lint

* Fix failing frontend tests

* execution_id -> uuid

* Fix migration head

* lint

* Use celery task id as the execution id

* lint

* lint for real

* Fix tests
 2021-03-30 08:46:16 -07:00
Lily Kuang
3f2e2c9976 fix(alert|report): allow null on chart and dashboard field (#13680) 
* allow null on chart and dashboard field

* update api test
 2021-03-18 09:17:50 +00:00
ʈᵃᵢ
3078c84d40 feat(reports): SLACK_API_TOKEN as callable or str (#13634) 2021-03-16 10:06:29 -06:00
Lily Kuang
cd2f53ed7b switch message content between chart and dashboard AlertReportModal (#13537) 2021-03-15 12:00:53 -07:00
Daniel Vaz Gaspar
139c7878a5 fix(alerts&reports): add celery soft timeout support (#13436) 
* fix(alerts&reports): add celery soft timeout support

* make a specific exception for screenshots timeout

* fix docs, add new test
 2021-03-08 14:21:18 +00:00
İbrahim Ercan
b04aebfa99 fix(alerts&reports): Alerts & Reports will use values from WEBDRIVER_WINDOW option (#13157) 
* fix: thumbnails and reports will be use WEBDRIVER_WINDOW option

* changes reformatted

* config change reverted. thumbnails sizes changed to original

* typo fix

* bugfix

defining defaults in thumbnails.py caused thumbnail caches invalidated.
they moved to init.

Co-authored-by: Ibrahim Ercan <ibrahim.ercan@vlmedia.com.tr>
 2021-03-02 10:49:22 +00:00
Daniel Vaz Gaspar
0b114fcbc5 feat(reports): send notification on error with grace (#13135) 
* fix: add config to disable dataset ownership on the old api

* fix CI docker build

* fix logic

* add deprecation comment on the config

* feat: send alerts reports errors to recipients

* update

* feat(reports): send notification on error with grace

* merge and revert config

* fix lint and MySQL test

* fix mysql tests
 2021-02-24 13:31:31 -08:00
Daniel Vaz Gaspar
6e3121268e fix(alerts): Handle None on results (#13289) 2021-02-23 09:50:55 +00:00
Moriah Kreeger
fc180ab2a6 fix: add alert report timeout limits (#12926) 
* prevent working timeout and grace period from being set to negative numbers

* add extra validation

* lint

* fix black

* fix isort

* add js tests

* fix lint + more python schema validation

* add report schema test for timeout limits

* add extra test for null grace period
 2021-02-22 11:12:10 -08:00
Lily Kuang
d8bd8ec896 fix(alert/report): alert modal loading dropdown options (#13222) 
* alert modal loading

* add ui test
 2021-02-22 01:59:33 +00:00
Daniel Vaz Gaspar
13a5b439fe feat(alerts): apply SQL limit to all alerts (#13150) 
* feat(alerts): apply SQL limit to all alerts

* change limit to 2 and test

* undo mock

* mock, mock and mock

* lint
 2021-02-17 18:03:35 +00:00
Daniel Vaz Gaspar
2e6ea76631 fix(alerts): void query with numeric comparison (#13090) 
* fix(alerts): void query with numeric comparison

* remove config changes

* fix tests

* better logic

* fix logic

* fix logic

* Improve test readability
 2021-02-15 17:09:47 +00:00
Daniel Vaz Gaspar
0171a6bee4 fix(reports): don't log user errors and state change has errors (#12277) 2021-01-06 08:57:10 +00:00
Daniel Vaz Gaspar
74f3faf1cd fix(reports): make name unique between alerts and reports (#12196) 
* fix(reports): make name unique between alerts and reports

* add missing migration

* make it work for mySQL and PG only (yet)

* fixing sqlite crazy unique drop

* fixing sqlite missing one col
 2020-12-24 09:18:46 +00:00
Daniel Vaz Gaspar
09a381da1d fix(reports): notification without standalone link back to superset (#12174) 
* fix(reports): notification without standalone link back to superset

* fix comment
 2020-12-23 11:31:08 +00:00