Kasia Kucharczyk
ed3dca420f
Added z index to resizible char ( #11456 )
2020-10-29 10:39:35 -07:00
Jesse Yang
e0503408de
feat(explore): change save button text when users cannot override ( #11281 )
2020-10-29 09:41:29 -07:00
Evan Rusackas
68d493ebf5
fix: dashboard tab only shows move cursor when editing ( #11480 )
2020-10-29 00:35:32 -07:00
Evan Rusackas
e024267447
fix: Unwinds icon fallout that came along with filters PR ( #11474 )
...
* Unwinds icon revamp that came along with filters PR.
* cleanup/linting
* removing unused import
2020-10-28 19:44:39 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e9064c88b2cba37ce0214f0c3972ba486#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com >
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com >
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io >
Co-authored-by: Evan Rusackas <evan@preset.io >
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com >
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com >
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com >
2020-10-28 15:46:24 -07:00
Moriah Kreeger
e9dba18466
feat: annotation layers CRUD list view ( #11432 )
2020-10-28 15:45:07 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource ( #11390 )
...
* ChangeDatasourceModal
* DatasourceModal
* DeleteModal, AddDatasetModal
* Fix tests
* Remove unused file
* Fix e2e tests
* Fix test
* Remove it.only
* Fix after rebase
* Fix e2e tests
* Fix data-test in modal
* Lint fix
2020-10-28 14:42:13 -07:00
Lily Kuang
e5e35634de
feat: annotations list CRUD view ( #11446 )
...
* annotations list CRUD view
* comment out modal
* update test
* fix lint
2020-10-28 12:19:50 -07:00
Kamil Gabryjelski
b2636f01bb
fix: Explore popovers issues ( #11428 )
...
* Fix spaces and comas not working in filter popover
* Fix popup not opening automatically
* Add e2e test
* Remove only from test
* Remove redundant test, add checking label content
* Add comments to e2e test
* Fix unit test
* Use destructuring
* Always open popup for functions and saved metrics, too
* Fix popover for adhoc metrics too
* Small refactor to consistency
* Refactor for consistency
* Remove redundant functions
* Test fix
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
2020-10-28 09:38:52 -07:00
Evan Rusackas
eecabf9b2e
fix: a space adds the space. ( #11401 )
...
* fix: a space adds the space.
* linting. Ugh.
2020-10-27 23:47:42 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals ( #11366 )
...
* Make Modal responsive
* ErrorAlert
* OmniContainer
* dashboard/PropertiesModal
* Fix e2e tests
* Lint fix
* E2E test fix
* Fix test
* Use grid units
* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
adam-stasiak-polidea
a99d795eaf
chore: cypress selectors refactor in explore module ( #11309 )
...
* cypress selectors refactor in explore module
* added delay to typing to make test more stable
* fixed missing click
2020-10-27 13:01:45 -07:00
adam-stasiak-polidea
4bebf51453
chore: Cypress chart selectors refactor ( #11312 )
...
* cypress selectors refactor in chart list tests
* fixed wrong selector
2020-10-27 11:38:05 -07:00
David Aaron Suddjian
055781f4a9
fix filter highlighting ( #11439 )
2020-10-27 08:38:24 -07:00
Ville Brofeldt
ecdff724ea
feat: enable metadata sync for virtual tables ( #10645 )
...
* feat: enable metadata sync for virtual tables
* add migration and check for empty schema name
* simplify request
* truncate trailing column attributes for MySQL
* add unit test
* use db_engine_spec func to truncate collation and charset
* Remove redundant migration
* add more tests
* address review comments and apply templating to query
* add todo for refactoring
* remove schema from tests
* check column datatype
2020-10-27 07:58:38 +02:00
Ville Brofeldt
8575439f48
fix: is_temporal should be overridden by is_dttm value ( #11429 )
2020-10-27 07:22:27 +02:00
Kasia Kucharczyk
94e0f0cc2a
Moved css of inline inputs of DateFilterControl to css of FilterBox where it appears. ( #11427 )
2020-10-26 21:50:27 -07:00
Maxime Beauchemin
5b968e9651
fix: multiple issues with FilterPopover ( #11412 )
...
* fix: Custom SQL in FilterPopover
* Also fix #11394
* linting
* fix tests
2020-10-26 21:48:06 -07:00
Hugh A. Miles II
fd8f4e9215
feat(explore): update the order of datasource dropdown menu ( #11424 )
2020-10-26 20:44:44 -07:00
Hugh A. Miles II
81f77fd28e
feat: hide datasource legacy based on featureflag ( #11371 )
2020-10-26 17:31:29 -07:00
ʈᵃᵢ
2227b13b52
fix: better error messages for dashboard properties modal ( #11382 )
2020-10-26 16:36:37 -07:00
ʈᵃᵢ
59885c4dea
fix: saved query list sort by database ( #11430 )
2020-10-26 16:36:03 -07:00
ʈᵃᵢ
910791b00b
fix: better error message for chart properties modal ( #11381 )
2020-10-26 13:33:19 -07:00
Evan Rusackas
af337b9e5a
Let the header wrap! ( #10724 )
2020-10-26 13:15:16 -07:00
Kamil Gabryjelski
894ca3c09b
refactor: Use Modals from Antd instead of react-bootstrap ( #11330 )
...
* Refactor ModalTrigger to use antd modal
* Refactor a few components
* dynamic width
* Fix unit tests
* Use i18n for button text
2020-10-26 11:20:10 -07:00
Kasia Kucharczyk
604a519d8b
fix: keeping Markdown content while resizing window on Dashboard ( #11392 )
...
* Fix: keeping markup content while resizing it
* Added bind and fixed linter
* Added resize case in Markdown editor to cypress test
2020-10-26 11:12:49 -07:00
Kasia Kucharczyk
ba314c0f6f
Moved frame from below to currently focused window ( #11423 )
...
Thanks for the fix!
2020-10-26 11:11:51 -07:00
Kamil Gabryjelski
6acae9ab6d
refactor: Replace usages of reactable in TimeTable ( #11239 )
...
* Refactor TimeTable to use react-table
* Fix import
* Refactor TimeTable into functional component
2020-10-26 10:25:41 -07:00
Jesse Yang
ac498ddd23
chore: upgrade TypeScript (3.8.3 -> 4.0.3) ( #11421 )
...
* chore: upgrade TypeScript (3.8.3 -> 4.0.3)
* Refactor the button component
2020-10-25 22:01:41 -07:00
Maxime Beauchemin
0ab15373fa
style: fix labels vertical align ( #11415 )
...
* style: fix labels vertical align
* addressed comments
* just adding the space for now
* fix timer
2020-10-25 17:55:22 -07:00
Jesse Yang
8aecffd83b
refactor: typing for explore Control and messageToasts ( #11416 )
2020-10-24 21:40:36 -07:00
ʈᵃᵢ
d02a61f21c
feat(dashboard): fetch charts by owners instead of created_by ( #11336 )
2020-10-24 14:43:20 -07:00
adam-stasiak-polidea
f2c89af83f
chore: Fixed skipped cypress test - refresh dashboard function ( #11375 )
...
* Fixed skipped cypress dashboard/controls.test.js and fixed MenuItem setting state to 'loading' while refreshing
* fixed wrong cypress command in test
2020-10-24 11:29:30 -07:00
Evan Rusackas
efdda8b69e
chore: Button cruft cleanup ( #11342 )
...
* toggleSchedule
* cleaning up run query button
* removing unnecessary (subtle!) style overrides
* bulk action classname to button style prop
* nixing btn-primary
* nixing cancelQuery class
* togglesave
* nixing autocomplete class
* linting
* nixing button classes of 'ok' and 'reset'
* unoing diagnostic test
* begrudgingly adding an m-r-3 class... for now
* this is not a class to worry about
* test fixes for limit control
* updating TODO notes, calling it a day for now.
* gah... copy paste error.
2020-10-23 10:42:29 -07:00
Kamil Gabryjelski
ad88a06d61
refactor: Use Antd Dropdown instead of react-bootstrap in DatasourceControl ( #11395 )
...
* Create Tooltip component
* Refactor DatasourceControl
* Bug fix
* Lint fix
* E2E test fix
* Move menu item keys to constants
* Remove LESS file
* Test fix
* Test fix
* Lint fix
2020-10-23 09:08:35 -07:00
Lily Kuang
93d9bd9a04
fix dataset editor for saving schema ( #11396 )
2020-10-22 21:59:04 -07:00
Evan Rusackas
d64260fc0e
fix: long labels now truncate with ellipsis ( #11400 )
2020-10-22 18:35:37 -07:00
Elizabeth Thompson
43b92b220f
fix: dashboard edit/save errors ( #10834 )
...
* use conditional operator for lookup
* editing dashboard title should update after save
* uncomment test
* fix json metadata save
* json metadata color scheme should overwrite state
* test's functionality is no longer applicable
* add lastModifiedTime to DashboardInfo
2020-10-22 14:33:22 -07:00
Kamil Gabryjelski
30c71fd794
refactor: Replace react-bootstrap tabs with Antd tabs on Profile ( #11211 )
...
* Create styled Antd Tabs and Dropdown
* Replace Tabs in Profile view
* Change some hard coded variables to theme
* Lint fix
2020-10-22 14:19:37 -07:00
Kamil Gabryjelski
dc5e5a978b
refactor: Replace usages of reactable in TableLoader ( #11240 )
...
* Refactor TableLoader to use react-bootstrap
* Remove unnecessary css classes
* Fix import
* Fix styling for no data
* Refactor TableLoader into functional component
* Convert TableLoader to typescript
2020-10-22 14:00:02 -07:00
Maxime Beauchemin
64b5aae6bc
style: improve the "Create New Chart" screen's usability ( #11383 )
...
* style: make disabled buttons more readable
* making more of a CTA for VizControl
2020-10-22 10:16:58 -07:00
Daniel Vaz Gaspar
85e28dd04c
perf(api): improve API info performance ( #11346 )
2020-10-22 08:55:13 +01:00
Moriah Kreeger
a2a614d760
feat: CSS Templates List Actions ( #11271 )
2020-10-21 20:32:59 -07:00
Kamil Gabryjelski
9dfe9aef39
Fix overflowing tabs ( #11367 )
2020-10-21 20:10:52 -07:00
Maxime Beauchemin
69046f08d4
style(sqllab): wrap text in monospace db-provided error messages ( #11354 )
2020-10-21 17:35:20 -07:00
Evan Rusackas
6fe7b4a202
feat: adding feature flags to escape/hide html in markdown ( #11340 )
...
* utilizing feature flag for html escapement
* use src alias
* Feature flag to allow hiding of HTML tags
* strips js attr
* better feature flag naming
* simplifying
* Adding comments to new feature flags
* shorter comment, because pylint,
* pedantic change to get black to format a file
2020-10-21 15:07:27 -07:00
ʈᵃᵢ
225c905bd5
fix(listview): hide actions column if no actions are allowed ( #11337 )
2020-10-21 09:27:48 -07:00
Evan Rusackas
cae54ac00e
style: using correct + icon on New Query button ( #11353 )
...
* style: using correct + icon on New Query button
* non-meaningful whitespace removed.
2020-10-20 22:44:11 -07:00
Maxime Beauchemin
796a2a6924
fix: error around latest partition in BigQuery ( #11274 )
...
* fix: error around latest partition in BigQuery
* lint
* Going with a backend-first approach
* fix test
* add an extra test
2020-10-20 21:34:46 -07:00
Maxime Beauchemin
c360413fc2
style(menu): clean up right menu - leaving only "Settings" ( #11227 )
...
* style(menu): clean up right menu - leaving only settings
* bring pre-commit back
* fix frontend tests
* pre-commit
* re-introduce subtle '+'
2020-10-20 21:33:28 -07:00
