Commit Graph

14 Commits

Author SHA1 Message Date
JUST.in DO IT
51a34d7d58 chore(sqllab): Remove table metadata from state (#24371) 2023-06-22 15:37:03 -07:00
JUST.in DO IT
ca4dd26648 chore(sqllab): Remove schemaOptions from redux store (#23257) 2023-03-22 15:35:22 -06:00
JUST.in DO IT
9ae81b7c33 fix(sqllab): empty large query results from localStorage (#23302) 2023-03-14 12:03:19 +13:00
JUST.in DO IT
034ee1c3c1 fix(sqllab): unable to create new tabs (#21260) 2022-08-30 13:54:42 -07:00
JUST.in DO IT
ad6b98c2b7 fix(sqllab): update persistent queryEditor keys (#21246) 2022-08-30 09:46:31 -07:00
JUST.in DO IT
f77b910e2c perf(sqllab): Rendering perf improvement using immutable state (#20877)
* perf(sqllab): Rendering perf improvement using immutable state

- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only

* revert ISaveableDatasource type cast

* missing trigger prop

* a default of an empty object and optional operator
2022-08-23 12:17:19 -03:00
Lyndsi Kay Williams
8a04536f9d feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Eric Briscoe
9f9aae49c9 chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
Stephen Liu
f9d28a1072 chore: add eslint custom plugin to prevent translation variables (#19828) 2022-04-27 17:44:13 +08:00
Luis Casillas
56381f4ee8 fix: sql lab ctrl t behaved differently from clicking (#19420)
* initial approach

To have consistent behaviour when creating a new tab with ctrl+t

* consistent behaviour when creating tabs

* fixed bug and added tests

* updates to pass checks
2022-04-15 12:28:40 -06:00
Michael S. Molina
1ab36c94f3 chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Beto Dealmeida
8d48d2e37b fix(sqllab): per-tab hide left bar (#13288)
* fix (sqllab): per-tab hide left bar

* Load state when switching tabs
2021-03-05 11:16:11 -08:00
ʈᵃᵢ
74423e5d19 deprecate tslint and configure eslint for typescript (#9172) 2020-02-20 09:54:33 -08:00
David Aaron Suddjian
2913063924 SIP-32: Moving frontend code to the base of the repo (#9098)
* move assets out, get webpack dev working

* update docs to reference superset-frontend

* draw the rest of the owl

* fix docs

* fix webpack script

* rats

* correct docs

* fix tox dox
2020-02-09 17:53:56 -08:00