QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,420 Commits 448 Branches 542 Tags
e660723a2f1ba7205878e8d600e01763514959cd
Commit Graph

63 Commits

Author SHA1 Message Date
Amit Miran
b221417e19 chore: remove harmless incubator refs (#12289) 
* chore: migrate all harmless incubator refs like comments and documentation files

* chore: migrate all superset.incubator.apache.org to superset.apache.org to

* chore: migrate dist.apache.org refs

* chore: removing incubating and Disclaimer

* fix: linting issues
 2021-01-06 13:45:19 +02:00
Daniel Vaz Gaspar
0171a6bee4 fix(reports): don't log user errors and state change has errors (#12277) 2021-01-06 08:57:10 +00:00
Daniel Vaz Gaspar
1a20552c2b fix(reports): increase crontab size and alert fixes (#12056) 
* fix(reports): increase crontab size

* update to current alembic revision

* Merge branch 'master' into feat/security-converge-datasets

# Conflicts:
#	tests/security_tests.py

* Merge branch 'master' into feat/security-converge-datasets

# Conflicts:
#	tests/security_tests.py

* Merge branch 'master' into feat/security-converge-datasets

# Conflicts:
#	tests/security_tests.py

* lint

* update alembic revision

* fix related fields

* fix test
 2020-12-17 18:03:05 +00:00
Rob DiCiuccio
4d329071a1 feat(SIP-39): Async query support for charts (#11499) 
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-12-10 20:21:56 -08:00
Daniel Vaz Gaspar
1e3aaab590 fix(reports): validator_config, report state machine, working_timeout (#11890) 
* fix(reports): expect more exceptions and fix validator config

* use a state pattern on command reports

* use a state pattern on command reports continue

* fix multiple heads

* fix unittests

* add more tests

* fix api tests after enum rename

* fix alembic multiple heads

* fix tests

* fix fixture cleanup

* fix mysql tests

* fix initial and not found state

* fix schema, and private public methods, addressing comments

* add new col to the API
 2020-12-09 18:19:07 +00:00
Daniel Vaz Gaspar
7e6f04fce4 fix(alerts, thumbnails): celery tasks using flask-sqlalchemy sessions (#11950) 
* fix(alerts, thumbnails): celery tasks using flask-sqlalchemy sessions

* selenium user is case sensitive
 2020-12-08 13:03:32 +00:00
Daniel Vaz Gaspar
f27ebc4be5 feat: new reports scheduler (#11711) 
* feat(reports): scheduler and delivery system

* working version

* improvements and fix grace_period

* add tests and fix bugs

* fix report API test

* test MySQL test fail

* delete-orphans

* fix MySQL tests

* address comments

* lint
 2020-11-25 08:50:30 +00:00
Grace Guo
014fe9fd8c fix: [email report] add multiple schedules per hour (#11414) 2020-10-27 09:37:42 -07:00
Bogdan
cb3f649a7f chore: simplify alerting data model to leverage a single class (#11179) 
* Collapse alerting models into a single one

Fixing upgrade migration & tests

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-10-09 19:20:12 -07:00
Kasia Kucharczyk
89bf76553e Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045) 2020-09-29 08:10:46 -07:00
Bogdan
b2fdf12f62 Support jinja templates (#11008) 
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-24 10:29:44 -07:00
Bogdan
56d001835e fix: use nullpool even for user lookup in the celery (#10938) 
* Use nullpool even for user lookup in the celery

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-21 10:34:03 -07:00
Bogdan
801fb4063c Allow empty observations in alerting (#10939) 
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-21 08:48:02 -07:00
Bogdan
c3f1720456 fix: superset alerting misc fixes (#10891) 
* Superset alerting misc fixes

* Test 0 threshold

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-16 11:09:11 -07:00
Bogdan
ac2937a6c5 fix: use nullpool in the celery workers (#10819) 
* Use nullpool in the celery workers

* Address comments

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-10 13:29:57 -07:00
Lily Kuang
8a3ac70c06 feat(databases): test connection api (#10723) 
* test connection api on databases

* update test connection tests

* update database api test and open api description

* moved test connection to commands

* update error message

* fix isort

* fix mypy

* fix black

* fix mypy pre commit
 2020-09-09 13:37:48 -07:00
Jason Davis
54ae3b044f fix: add validator information to email/slack alerts (#10762) 
* added validator info to alerts

* adjusted format of messages

* added nits

Co-authored-by: Jason Davis <@dropbox.com>
 2020-09-03 08:15:05 -07:00
Jason Davis
b59f6b1833 feat: refractored SQL-based alerting framework (#10605) 
* added new tables for alerting refractor

* reformatted inheritance structure

* added workflow for updated framework

* added suggested changes

* cleaned up changes

* added obervations to alert table to enable view

* added comments

* added requested changes

* fix tests

* added styling changes

* mypy

* added requested changes

* updated operator logic

* requested changes, 1 validator, styling changes

* refactored tests

* fix test alert workflow

* fixed create_alert in test

Co-authored-by: Jason Davis <@dropbox.com>
 2020-09-01 13:36:02 -07:00
John Bodley
8581bda2f1 chore: Fix indentation issue (#10690) 2020-08-26 20:09:09 -07:00
Maxime Beauchemin
82dda473b1 fix: dedup groupby in viz.py while preserving order (#10633) 2020-08-21 08:02:02 +03:00
Grace Guo
ca9ca99510 refactor: [migration] convert iframe chart into dashboard markdown component (#10590) 
* refactor: [migration] convert iframe chart into dashboard markdown component

* remove 3 viz_types

* fix comments
 2020-08-16 14:43:30 -07:00
Daniel Vaz Gaspar
4dd1d1df5e fix(thumbnails): missing field, logging and new config var (#10562) 
* fix(thumbnails): missing field, logging and new config var

* deprecate EMAIL_REPORTS_WEBDRIVER

* fix after merge and conflicts

* fix tests

* black
 2020-08-14 14:12:44 +01:00
Daniel Vaz Gaspar
11da6ee812 fix: dataset delete and perm delete (#10578) 2020-08-13 10:18:13 +01:00
Erik Ritter
bd88e12b8b feat: add extra column to tables and sql_metrics (#10592) 2020-08-12 15:27:29 -07:00
Craig Rueda
2aaa4d92d9 chore: Migrating reports to AuthWebdriverProxy (#10567) 
* Migrating reports to AuthWebdriverProxy

* Extracting out webdriver proxy / Adding thumbnail tests to CI

* Adding license

* Adding license again

* Empty commit

* Adding thumbnail tests to CI

* Switching thumbnail test to Postgres

* Linting

* Adding mypy:ignore / removing thumbnail tests from CI

* Putting ignore statement back

* Updating docs

* First cut at authprovider

* First cut at authprovider mostly working - still needs more tests

* Auth provider tests added

* Linting

* Linting again...

* Linting again...

* Busting CI cache

* Reverting workflow change

* Fixing dataclasses

* Reverting back to master

* linting?

* Reverting installation.rst

* Reverting package-lock.json

* Addressing feedback

* Blacking

* Lazy logging strings

* UPDATING.md note
 2020-08-12 13:28:41 -07:00
Jason Davis
c0bb86d0d6 feat: slack integration for SQL-based alerts (#10566) 
* add slack functionality

* deleted unused variable

* updated test

* black

* fix rebase

* added nits

* added slack no screenshot integration

* isort

* added namedtuple for screenshot

* added test

* fix precommit

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-11 11:15:31 -07:00
Bogdan
101e5b670b chore: clean up csv tests (#10556) 
* Clean up csv tests

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* import optional

* Fix mypy error

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-08-10 11:22:38 -07:00
Jason Davis
8b9292ed05 fix: add retry to SQL-based alerting celery task (#10542) 
* added retry and minimized sqlalchemy object lives

* pylint

* added try catch

* adjusted naming

* added scoped session

* update tests for dbsession

* added requested changes

* nit todo

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-10 10:20:43 -07:00
Erik Ritter
fd2d1c58c5 Revert "chore: Cleanup database sessions (#10427)" (#10537) 
This reverts commit 7645fc85c3.
 2020-08-06 15:33:48 -07:00
Jason Davis
0d91b3ee6e fix: make SQL-based alert email links user friendly (#10519) 
* make urls user friendly

* formatting

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-04 15:45:38 -07:00
Jason Davis
aa479fb002 feat: updated email format for SQL-based email alerts (#10512) 
* added sql statement and link to chart in alert email

* pylint

* updated email to include link to alert

* style changes

* pylint

* added todo and fixed formatting of email

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-04 13:20:02 -07:00
Jason Davis
9c5b0e1c86 fix: refactored SQL-based alerts to not pass sqlalchemy objects as args (#10506) 
* refractored alerting to not pass sqlalchemy obj as args

* updated to pass only alert id as arg

* used object id instead of argument

* updated alerts_tests.py to reflect change

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-04 09:52:32 -07:00
John Bodley
7645fc85c3 chore: Cleanup database sessions (#10427) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-07-30 23:07:56 -07:00
Jason Davis
7a329c25e9 feat: add test email functionality to SQL-based email alerts (#10476) 
* added test email functionality

* formatting changes

* more formatting

* applied requested changes

* mypy

Co-authored-by: Jason Davis <@dropbox.com>
 2020-07-30 13:27:22 -07:00
Jason Davis
d065633c81 fix: Implement updates to SQL-based email alerts (#10454) 
* implemented updates to alerting

* fixed imports and teardown

* changed unittest to pytest conventions

* add app_context to tests

Co-authored-by: Jason Davis <@dropbox.com>
 2020-07-28 16:48:42 -07:00
Maxime Beauchemin
318e5347bc feat: Alerts! allowing users to set SQL-based email alerts with screenshots (#9944) 
* feat: add support for alerts

* Add ModelViews

* First pass at adding scheduled Alert support

* Fix syntax errors

* Add log_retention and database to model

* Improving screenshots

* Still refactoring screenshots

* Pass down thumb_size properly

* Progress on screenshot endpoint

* Add alerts.last_eval_dttm and alert query logic

* Getting ready to split compute_screenshot and screenshot/{SHA}

* split the endpoints

* Improving alerting loop

* empty methods

* Add CLI command 'superset alert' that runs a sched loop

* Getting things to work

* email delivery

* A working email\!

* Add feature flag

* Add some description_columns to AlertModelView

* Little tweaks

* Use database.get_df, eval cells for truthiness

* Migrate thumbnail/screenshot functions to use new arg pattern

* Addressing PR feedback

* Update alerts DB migration down_revision

* Resolve _deliver_email arg conflict

* Make mypy happy

* Make isort happy

* Make pylint happy

Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
 2020-07-06 13:12:27 -07:00
Will Barrett
0017b61f51 refactor: Re-enable pylint on 5 files (#10106) 
* Re-enable lint on 5 files

* revert something questionable

* Address PR feedback

* One more PR comment...

* black?

* Update code wrapping

* Disable bugged check

* Add a disable for a failure that's only showing up in CI.

* Fix bad refactor

* A little more lint fixing, bug fixing
 2020-06-25 11:14:41 -07:00
Will Barrett
8e23d4f369 chore: Upgrade pylint to 2.5.3 and fix most new rules (#10101) 
* Bump pylint version to 2.5.3

* Add a global disable for the most common new pylint error

* Fix a bunch of files containing very few errors

* More pylint tweakage, low-hanging fruit

* More easy stuff...

* Fix more erroring files

* Fix the last couple of errors, clean pylint!

* Black

* Fix mypy issue in connectors/druid/models.py
 2020-06-18 14:03:42 -07:00
Bogdan
29e9f2c70b feat: superset report slack integration (#9810) 
* First draft for the slack integration

Fix slack

another typo

another typo

Fix slack

Add channels to the form

another typo

Another set of changes

Make code more transparent

Fix tests

Add logging

logging

use logger

import logging

import logging

import logging

add assert

more logging

Fix channels

Fix channels

* Address comments

* Move slack into a separate module

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-06-17 11:01:25 -07:00
John Bodley
91517a56a3 style(mypy): Spit-and-polish pass (#10001) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-07 08:53:46 -07:00
John Bodley
63e0188f45 style(mypy): Enforcing typing for superset.views (#9939) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-05 08:44:11 -07:00
John Bodley
ee777acd57 fix(mypy): Resolves regression introducted in #9824 (#9973) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-03 00:20:34 -07:00
Bogdan
1d3b264a36 Add extra configration to the email reports (#9342) 
Superset email. Fix slice url

Make WEBDRIVER_BASEURL a function

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-05-13 20:14:12 +03:00
John Bodley
1c656feb95 [mypy] Enforcing typing for a number of modules (#9586) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-04-24 10:07:35 -07:00
Daniel Vaz Gaspar
d81f720502 [thumbnails] API and celery task for dashboards and charts (#8947) 2020-04-15 09:40:14 +01:00
Grace Guo
adebd40d30 [cache warm_up] warm_up slice with dashboard default_filters (#9311) 
* [cache warm_up] warm_up slice with dashboard default_filters

* update Celery warmup tasks

* fix code review comments

* add try catch and type checking for parsed dash metadata

* extra code review fix
 2020-03-18 08:21:10 -07:00
Grace Guo
000a038af1 [fix] use filter_scopes in dashboard warmup strategy (#9235) 
* [fix] use filter_scopes in dashboard warmup strategy

* remove unnecessary comment
 2020-03-05 17:50:32 -08:00
Craig Rueda
607cfd1f29 Moving away from using the root logger everywhere (#9099) 
* Moving away from using the root logger everywhere

* self.logger -> logger
 2020-02-07 23:38:48 -08:00
Hossein Torabi
478e445a5a Add config for celery email task soft time (#8887) 2020-01-04 09:20:57 +02:00
David Aaron Suddjian
016f202423 Refactor Dashboard and Slice models (#8820) 
* refactor dashboard and slice models

* appease various linters

* remove shortcuts & import indirection

* appease mypy

* fix bad imports

* lint

* address various issues

* ignore type issue

* remove unused imports

* lint
 2019-12-18 11:40:45 -08:00