Commit Graph

171 Commits

Author SHA1 Message Date
Sebastian Liebscher
0788b5fdcc chore: fix deprecation warnings for SQLALchemy URL (#23770) 2023-05-11 11:20:53 +03:00
Daniel Vaz Gaspar
6ae5388dcf fix: allow db driver distinction on enforced URI params (#23769) 2023-04-23 15:44:21 +01:00
Ville Brofeldt
764c3c95cf fix(mssql): apply top after distinct (#23751) 2023-04-21 17:02:59 +03:00
Sebastian Liebscher
b31efbae7c chore: remove RemovedInMarshmallow4 warnings (#23704) 2023-04-21 09:11:46 +03:00
Daniel Vaz Gaspar
0ad6c879b3 feat: add enforce URI query params with a specific for MySQL (#23723) 2023-04-18 17:07:37 +01:00
John Bodley
b35b5a6e05 chore(db_engine_specs): Refactor get_index (#23656) 2023-04-13 09:23:16 +12:00
Rémy DUBOIS
07a632891c fix(chart): non existent time grain no longer breaks the application (#23441)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2023-03-23 16:36:50 +02:00
Beto Dealmeida
8588f81855 feat(DB engine spec): get_catalog_names (#23447) 2023-03-22 13:40:14 -07:00
Beto Dealmeida
2c6f581fa6 feat(postgresql): dynamic schema (#23401) 2023-03-17 17:53:42 -07:00
Beto Dealmeida
42e8d1b498 chore: improve schema security (#23385) 2023-03-17 08:05:50 -07:00
Beto Dealmeida
1b95da7487 fix: table schema permissions (#23356) 2023-03-14 15:18:18 -07:00
Daniel Vaz Gaspar
b479e93b49 fix: add disallowed query params for engines specs (#23217)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2023-02-28 12:00:22 +00:00
Ville Brofeldt
d0c54cddb0 fix(clickhouse): add clickhouse connect driver (#23185) 2023-02-24 14:04:12 +02:00
Josh Soref
dec6ac49f6 chore(backend): Spelling (#19677)
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2023-02-17 10:48:24 -07:00
alexclavel-ocient
9dfaad772d fix: Make cte_alias a property of db engine spec (#22947) 2023-02-06 14:27:48 -07:00
Ville Brofeldt
cd6fc35f60 chore(db_engine_specs): clean up column spec logic and add tests (#22871) 2023-01-31 15:54:07 +02:00
Antonio Rivero Martinez
ad758c0802 feat(ssh_tunnel): Rename allow_ssh_tunneling and change the default value to False (#22723) 2023-01-17 19:11:41 -08:00
solanksh
cf00970cde feat(charts): allow query mutator to update queries after splitting original sql (#21645)
Co-authored-by: Akash <Akash.Nallani@bakerhughes.com>
Co-authored-by: anallani <98122184+anallani@users.noreply.github.com>
Co-authored-by: Robert Bean <robert.bean@bakerhughes.com>
Co-authored-by: Akash <anallani@umich.edu>
Co-authored-by: AkashN7 <70606604+AkashN7@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2023-01-12 14:04:03 +02:00
Antonio Rivero Martinez
539936522f feat(ssh_tunnel): SQLAlchemy Form UI (#22513)
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2023-01-11 19:29:52 +00:00
Hugh A. Miles II
ebaad10d6c feat(ssh-tunnelling): Setup SSH Tunneling Commands for Database Connections (#21912)
Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2023-01-03 17:22:42 -05:00
Ville Brofeldt
a7a4561550 fix(explore): support saving undefined time grain (#22565) 2023-01-03 08:53:42 +00:00
Hugh A. Miles II
9c0d6c51f1 chore(ssh-tunnel): Refactor establishing raw connection with contextmanger (#22366) 2022-12-29 14:20:45 -05:00
Ville Brofeldt
b6d39d194c feat(trino): support early cancellation of queries (#22498) 2022-12-24 06:31:46 +02:00
Elizabeth Thompson
5c77f1ad2a feat: add databricks form (#21573) 2022-12-02 10:36:27 -08:00
John Bodley
7e54b88a51 chore: Change get_table_names/get_view_names return type (#22085) 2022-11-18 12:41:21 -08:00
Hugh A. Miles II
e23efefc46 feat: refactor all get_sqla_engine to use contextmanager in codebase (#21943) 2022-11-15 13:45:14 -05:00
Antonio Rivero Martinez
95b4c7b7fe chore(bigquery): Add extra logging for BigQuery exceptions so we can have better insight on exceptions (#22024) 2022-11-09 22:56:08 -05:00
John Bodley
9f7bd1e63f fix(presto/trino): Ensure get_table_names only returns real tables (#21794) 2022-11-09 14:30:49 -08:00
Ville Brofeldt
dc7399540b chore: bubble up more db error messages (#21982) 2022-11-01 07:54:27 +02:00
Elizabeth Thompson
e98943e580 refactor: pass all properties to validate_parameters (#21487) 2022-10-03 17:48:54 -07:00
Elizabeth Thompson
ef78ec6b30 fix: catch error when masking encrypted extra is none (#21570) 2022-10-02 19:49:01 -07:00
Antonio Rivero Martinez
b36bd3f083 fix(databases): GSheets and Clickhouse DBs are not allowed to upload files (#21065) 2022-09-26 10:08:11 -07:00
Yongjie Zhao
737d4dcf0c refactor: refine timestamp expr function (#21510) 2022-09-20 18:51:01 +08:00
John Bodley
eac6fdcd29 chore(sqllab): Cleanup /tables/... endpoint (#21284) 2022-09-13 08:22:12 -07:00
Beto Dealmeida
34a79add04 feat: filter parameters from DB API (#21248) 2022-09-02 11:50:04 -07:00
Beto Dealmeida
8772e2cdb3 fix: improve get_db_engine_spec_for_backend (#21171)
* fix: improve get_db_engine_spec_for_backend

* Fix tests

* Fix docs

* fix lint

* fix fallback

* Fix engine validation

* Fix test
2022-08-29 11:42:42 -07:00
Beto Dealmeida
bb3871ddaf feat: per-db add metrics (#20990)
* feat: per-db add metrics

* Add unit tests
2022-08-08 12:07:16 -07:00
Beto Dealmeida
e60083b45b chore: upgrade SQLAlchemy to 1.4 (#19890)
* chore: upgrade SQLAlchemy

* Convert integration test to unit test

* Fix SQLite

* Update method names/docstrings

* Skip test

* Fix SQLite
2022-07-18 15:21:38 -07:00
Hugh A. Miles II
e5e8867394 feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
Samira El Aabidi
68af5980ea feat(chart): Enable caching per user when user impersonation is enabled (#20114)
* add username to extra cache keys when impersonation is enabled.

* don't put effective_user in extra_cache_key

* get_impersonation_key method in engine_spec class  to construct an impersonation key

* pass datasource when creating query objects

* adding an impersonation key when construction cache key

* add feature flag to control caching per user

* revert changes

* make precommit and pylint happy

* pass a User instance

* remove unnecessary import
2022-06-20 18:14:08 -07:00
John Bodley
449d08b25e fix: Refactor SQL username logic (#19914)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-12 21:03:05 -07:00
Daniel Vaz Gaspar
4fdf230a56 feat: deprecate /superset/extra_table_metadata migrate to api v1 (#19921)
* feat: deprecate /superset/extra_table_metadata migrate to api v1

* use can_read to table_extra_metadata

* troubleshoot sqlite

* fix test

* fix test

* fix test

* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Ville Brofeldt
99f1f9ec61 fix(sqla): replace custom dttm type with literal_column (#19917) 2022-05-03 07:19:36 +03:00
Beto Dealmeida
1ebdaac487 fix: memoize primitives (#19930) 2022-05-02 14:50:56 -07:00
Craig Rueda
f64d654de3 chore(database): Creating helper make_url_safe to wrap potential errors (#19526)
* Creating helper make_url_safe to wrap potential errors

* Fixing imports

* Fixing imports again

* Adding comment

* Linting

* Fixing test

* Fixing test again...

* Fixing import
2022-04-05 11:17:30 -07:00
Yongjie Zhao
d954c3df86 fix: can't sync temporal flag on virtual table (#19366) 2022-04-01 16:40:50 +08:00
Ville Brofeldt
a619cb4ea9 chore: upgrade black (#19410) 2022-03-29 20:03:09 +03:00
John Bodley
82a6811e7e fix(presto/trino): Add TIME/TIMESTAMP WITH TIME ZONE (#19263)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-22 06:33:38 +13:00
Elizabeth Thompson
d645579cdd chore!: update mutator to take kwargs (#19083)
* update mutator to take kwargs

* update updating.md

* lint

* test that the database name is properly passed in to the mutator
2022-03-18 16:01:27 -07:00
Sujith Kumar S
7e51b200b4 fix(mssql): support top syntax for limiting queries (#18746)
* SQL-TOP Fix For Database Engines

MSSQL is not supporting LIMIT syntax in SQLs. For limiting the rows, MSSQL having a different keyword TOP. Added fixes for handling the TOP and LIMIT clauses based on the database engines.

* Teradata code for top clause handling removed from teradata.py

Teradata code for top clause handling removed from teradata.py file, since we added generic section in base engine for the same.

* Changes to handle CTE along with TOP in complex SQLs

Added changes to handle TOP command in CTEs, for DB Engines which are not supporting inline CTEs.

* Test cases for TOP unit testing in MSSQL

Added multiple unit test cases for MSSQL top command handling and also along with CTEs

* Corrected the select_keywords name key in basengine

Corrected the select_keywords name key in basengine

* Changes based on as per review.

made the required corrections based on code review to keep good code readability and code cleanliness.

* Review changes to correct lint and typo issues

Made the changes according to the review comments.

* fix linting errors

* fix teradata tests

* add coverage

* lint

* Code cleanliness

Moved the top/limit flag check from sql_lab to core.

* Changed for code cleanliness

Changes for keeping code cleanliness

* Corrected lint issue

Corrected lint issue.

* Code cleanliness

Code cleanliness

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-21 09:58:39 +02:00