Commit Graph

168 Commits

Author SHA1 Message Date
Bruno Motta
ec5d2f5f32 test: DatasourceControl (#13605)
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 17:52:45 -07:00
Michael S. Molina
28fe6e0ef1 test: Adds tests to the CustomFrame component (#13675)
* test: Adds tests to the CustomFrame component

* Replaces full path with relative path
2021-03-31 15:53:07 -07:00
Michael S. Molina
7ae80e9d66 test: Adds tests to the AdvancedFrame component (#13664)
* test: Adds tests to AdvancedFrame component

* Replaces full path with relative path
2021-03-31 15:52:03 -07:00
Michael S. Molina
8ddcba82e0 chore: Removes Select duplication (#13477) 2021-03-31 15:42:14 -07:00
Michael S. Molina
6fe4cc0c51 chore: Removes Popover duplication (#13462) 2021-03-30 13:54:53 -07:00
Michael S. Molina
4ae9b819d3 fix: Disallows negative options remaining (#13749) 2021-03-30 08:34:12 -07:00
Bruno Motta
416f188328 test: SelectAsyncControl (#13638)
* SelectAsyncControl tests

* fix: lint error

* applying factory to  props
2021-03-25 22:07:05 -07:00
Jesse Yang
08d0deb720 fix: clean up incorrect usage of TypeScript type in PropTypes (#13681) 2021-03-18 09:12:13 -07:00
Erik Ritter
64785c20bd feat: add warning metadata to tables and metrics (#13606) 2021-03-17 21:27:34 -07:00
Yongjie Zhao
7b74eb2730 chore(explore): added debounce in DateFilter (#13660) 2021-03-17 09:04:50 -06:00
Jesse Yang
868e063b03 feat: add ErrorBoundary to chart controls (#13584) 2021-03-15 14:44:18 -07:00
Kamil Gabryjelski
ae66f5fa78 feat(explore): Drag and drop UX improvements (#13598)
* Create a metric immediately when saved metric is dropped

* Display borders around control boxes when metric or column is dragged

* Fix imports

* Display ghost button

* Rename placeholder to ghostButton
2021-03-15 12:47:13 +02:00
Yongjie Zhao
817b740f59 chore: metric refactor iteration 1 (#13596) 2021-03-12 23:11:05 +08:00
Kamil Gabryjelski
d439da2fe0 feat: Implement drag and drop for metrics (#13575)
* Convert MetricsControl to functional component

* Implement drag and drop for metrics

* Implement customizable placeholder for DndSelectLabel
2021-03-12 12:31:17 +08:00
Michael S. Molina
fc36de2d1f test: Adds tests and storybook to PopoverSection component (#13438)
* test: Adds storybook to PopoverSection component

* test: Adds tests and storybook to PopoverSection component
2021-03-09 12:08:10 -08:00
Kamil Gabryjelski
7b370e6f17 feat: Implement drag and drop columns for filters (#13340)
* Implement DnD feature for filters

* minor refactor

* Fix types

* Fix undefined error

* Refactor

* Fix ts errors

* Fix conflicting dnd types

* Bump superset-ui packages

* Change DndItemType case to PascalCase

* Remove redundant null check

* Fix

* Fix csrf mock api call
2021-03-07 11:54:08 +02:00
Michael S. Molina
b6b7982a81 chore: Moves BootstrapSliderWrapper to own folder (#13460) 2021-03-05 20:46:46 -08:00
Erik Ritter
d2e03ab9b4 fix: Remove view in sql lab from druid datasources (#13469) 2021-03-04 14:54:29 -08:00
Mayur
8b38d63b7d changes added (#13431) 2021-03-03 13:52:54 +02:00
Yongjie Zhao
488da65986 feat(viz): implement time picker on filter box (#13377)
* refactor(explore): restructure DateFilterControl

* fix UT

* remove datasource props

* remove unused files

* fix DateFilterControl in filterbox over length
2021-03-02 07:50:58 +08:00
Jesse Yang
3c62069bbb refactor(explore): convert ControlPanelsContainer to typescript (#13221) 2021-02-28 10:10:15 -08:00
Yongjie Zhao
1e3130d588 feat(explore): ColumnSelectControl with drag-and-drop (#13210)
* initial dnd

* shift group by items

* lint

* fix shift options

* wip

* wip

* fix shift action

* support scalar dimentions

* control rename to DndColumnSelectControl

* remove unused files

* added feature flag

* ff to False by default

* fix ut

* lint

* improve code smell

* added indicator

* replace value when column is scalcar

* scalar to isArray

* var rename

* minor fix

* update dependence

* minor fix
2021-02-26 16:48:23 +08:00
Michael S. Molina
9a05d6afe5 Migrates Collapse component from Bootstrap to AntD (#12920) 2021-02-23 10:24:08 -08:00
Jesse Yang
571b53e9cf refactor: add frontend debounce constants (#13250) 2021-02-19 17:47:44 -08:00
Kamil Gabryjelski
42ff4fc19a fix(explore): Reset values in TextControl only when datasource changes (#13211)
* Reset values in TextControl only when datasource changes

* Fix undefined error
2021-02-19 15:28:49 +02:00
Michael S. Molina
fcd443d366 Creates storybook and tests for Tooltip component (#13184) 2021-02-17 22:51:35 -08:00
Kamil Gabryjelski
44723eabbe fix(explore): Certificate icon not displaying for certified metrics (#13133)
* Fix certificate icon not displaying for certified metrics

* Remove redundant function

* Fix grammar mistake
2021-02-16 08:56:19 -08:00
simcha90
d6fc720f4c feat(native-filters): Time native filter (#12992)
* Add Time Filter component

* Improve Time Filter component

* Fix import errors

* Display Time Filter

* Remove console logs

* Change Control Panel

* Remove unnecessary files

* Use time range override

* test: fix tests

* feat: re run pipeline

* fix: fix some case for Time filter

* fix: merge with master

* use original time range

* fix height

* add cross filter behavior

* apply filters on initialization

* add applied filter to overrides

* add unit tests for merge_extra_form_data

Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-13 12:09:54 +02:00
simcha90
956f276e70 feat(cross-filters): add cross filters (#12662)
* feat: add cross filters

* refactor: fix CR notes

* lint: fix lint

* lint: fix lint

* chore: pre-commit

* refactor: under chage

* refactor: move to behaviors

* lint: fix lint

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-12 09:58:19 +02:00
Kamil Gabryjelski
85d02620b7 fix(explore): Enable selecting an option not included in suggestions (#13029) 2021-02-11 23:15:46 -08:00
Ville Brofeldt
42c4facb7e fix(explore): pie chart label bugs (#13052) 2021-02-11 11:23:40 +02:00
Phillip Kelley-Dotson
3bb14ab950 feat: reset metrics on dataset change (#12782)
* reset metrics on dataset change take one

* remove code

* part 2 or reseting adhoc controls

* update input controls and customize defaults

* remove conosles

* remove extra method

* simplify logic for controls reset and have them use their defaults

* remove consoles

* add annotation control to defaultvalues

* remove line
2021-02-05 14:08:27 +08:00
Victor Malai
77093a874e Add inclusive and exclusive for date start and end (#12859) 2021-02-04 14:55:02 +08:00
Michael S. Molina
5a79a7d993 Migrates Radio component from Bootstrap to AntD. (#12738) 2021-02-02 11:26:26 -08:00
Michael S. Molina
2adfb85597 Migrates Label component from Bootstrap to AntD. (#12774) 2021-02-01 22:15:07 -08:00
Michael S. Molina
c781ab8adf Migrates Button component from Bootstrap to AntD (#12832) 2021-02-01 15:13:10 -08:00
Ville Brofeldt
61e56b5027 fix(explore): add current savedMetric to dropdown (#12835) 2021-01-29 22:51:35 +02:00
Kamil Gabryjelski
c6093a7469 fix: Remove double tooltip from metric label (#12736)
* Remove tooltip from AdhocMetricOption

* Lint fix

* Add tooltip for adhoc metrics

* Typo fix
2021-01-29 17:01:58 +02:00
Nikola Gigić
1603e82a03 chore(explore): Metric/Column and Filter popover unexpectedly closes on scroll (#12817)
* fix

* address filter popup
2021-01-29 16:53:00 +02:00
Yongjie Zhao
642a76f6cc fix(explore): time picker can not be switched between now and specific (#12793)
* fix(explore): time picker can not be switched between now and specifc

* fix linting

* fix type

* fix UT
2021-01-29 13:35:57 +08:00
Kamil Gabryjelski
fcaa0acad5 chore: Upgrade react-dnd to 11.1.3 (#12815) 2021-01-28 18:34:56 -08:00
Kamil Gabryjelski
14de7b4791 feat(explore): Make metric title respond to changes immediately (#12747)
* Make metric title respond to changes immediately

* Bug fix

* Change type to Metric

* Bug fix
2021-01-28 08:58:39 +02:00
Ville Brofeldt
997befcacd fix(explore): pass partitionColumn when creating new adhoc filter (#12789)
* fix(explore): pass partitionColumn when creating new adhoc filter

* add default value to state

* remove duplicated code

* update translations
2021-01-27 15:48:54 +02:00
Ayan Ginet
7acbb3c845 fix(explore): Dataset icon remains constant when dragging. (#12761)
* fix: constant icon size

* clean up
2021-01-27 14:10:36 +08:00
Jesse Yang
ab741d7218 fix(explore): incorrect missing datasource condition (#12758) 2021-01-26 12:37:38 +08:00
Phillip Kelley-Dotson
a5df4c60a2 feat: default timepicker to last week when dataset is changed (#12609)
* set up timepicker to last when dataset is changed

* simplify logic for dataset change

* update modal code

* remove uneeded code

* fix bug

* fix bug
2021-01-26 11:14:52 +08:00
Jesse Yang
55c8f9ba60 feat(explore): allow opening charts with missing dataset (#12705) 2021-01-25 15:09:03 -08:00
Kamil Gabryjelski
90856544e9 Replace space with tabulator and enter as separators (#12730) 2021-01-25 17:01:10 +02:00
Nikola Gigić
9ab804b2bd chore[explore]: Save date if Ok not clicked (#12731)
* Save date if Ok not clicked

* answering. comments
2021-01-25 19:48:45 +08:00
Yongjie Zhao
307e3a9f65 chore(explore): added tooltips to timepicker (#12580)
* wip

* wip

* fix lint

* fix: tooltip cosmetic

* wip

* add license
2021-01-25 15:58:15 +08:00