Commit Graph

55 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson
fa416fa130 fix: remove extra line for link (#20959)
* fix: remove extra line for link

* add space
2022-08-04 13:29:07 -04:00
Phillip Kelley-Dotson
2f3e11db66 feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
AAfghahi
0ce0c6e1eb chore: removing Druid from front- and back- end (#20338)
* first pass at removing native Druid nosql

* removing having_druid

* addressing comments, linting

* fixed all tests

* addressing comments

* redirected to ui-core TimeGranularity type

* query form metric linting

* fixed broken chart type

* implementing feedback
2022-07-08 17:57:03 +02:00
Diego Medina
5bfc95e79e feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed (#19898)
* feature: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed

* Apply emotion templating to input/input labels
2022-06-08 16:52:53 -06:00
Yongjie Zhao
25e572a56e fix: count(distinct column_name) in metrics (#19842) 2022-04-26 20:03:55 +08:00
Kamil Gabryjelski
a076ae6d99 feat(explore): UI changes in dataset panel on Explore page (#19394)
* feat(explore): Implement new design for dataset panel

* Fixes

* Replace drag handle in dashboard builder

* Add missing types

* Type fix

* Fix tests

* Fix non-dnd version

* Fix test

* Replace margin with height
2022-03-29 21:11:08 +02:00
Diego Medina
0277ebc225 fix: Popovers in Explore not attached to the fields they are triggered by (#19139)
* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
2022-03-16 20:46:52 -06:00
Michael S. Molina
fd4bd1edbc chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Kamil Gabryjelski
c1205b5279 feat(explore): Implement metrics and columns popovers empty states (#18681)
* feat(explore): Implement empty states for column and metrics popovers

* Fix test

* Change copy
2022-02-14 15:26:56 +01:00
Michael S. Molina
647bbf1ea1 chore: Moves spec files to the src folder - iteration 10 (#17902)
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
2022-01-07 15:24:15 -03:00
Michael S. Molina
53d8d383cc chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Yongjie Zhao
9070b6b19c refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Ville Brofeldt
e2a429b0c8 feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
John Bodley
561d1ac9f2 feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Kamil Gabryjelski
fa44325a36 fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00
Geido
913df18075 chore: Select component refactoring - MetricControl - Iteration 5 (#16423)
* Refactor Select

* Render saved metric option

* Update tests

* Fix Cypress and ariaLabels

* Fix lint

* Lint Cypress

* Reconcile with latest Select changes
2021-09-27 17:25:51 +03:00
Michael S. Molina
9b17e86b44 chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Kamil Gabryjelski
a547dcb73e fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
ccfc95fbe6 fix(explore): adhoc metrics popover resets label after hovering outside (#16196)
* fix(explore): adhoc metrics popover resets label after hovering outside

* Remove irrelevant tests and skip rest

* Use ensureIsArray
2021-08-11 10:05:08 -06:00
Kamil Gabryjelski
b7cc89c6d4 fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
3061b6ad09 fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
Kamil Gabryjelski
5e1c469f42 feat(explore): default aggregate for string/numeric columns when creating metric (#15798)
* feat(explore): default aggregate for string/numeric columns when creating metric

* Fix for editing items with the same label

* Replace componentDidUpdate with getDerivedStateFromProps

* Wrap changes in feature flag
2021-07-22 18:23:10 +02:00
gordern
22494b642e fix: remove form invalid title (#15679) (#15680) 2021-07-14 16:55:47 -06:00
Ajay M
f8b270d419 fix(explore): Explore page boolean filter is broken for Presto DB (#14952)
* Front end update - modify OPERATORS, to have SQL operation and display value

* Updated tests

* More tests

* Remove OPERATOR imports

* Fix break tests

* PR comments

* fix issue with comparator loading

* rename a variable

* Linting
2021-06-10 09:08:04 -07:00
Michael S. Molina
9deb7aa3c1 chore: Replaces Icon with Icons component - iteration 1 (#14469) 2021-05-17 10:24:56 -07:00
Geido
3466cb253e Fix class name (#14609) 2021-05-14 11:05:52 -07:00
Michael S. Molina
331eb10fb9 refactor: Bootstrap to AntD - Form - iteration 4 (#14546) 2021-05-12 23:01:43 -07:00
Michael S. Molina
79ff96269b refactor: Bootstrap to AntD - Form - iteration 3 (#14502) 2021-05-08 12:34:52 -07:00
Michael S. Molina
331310db9b refactor: Bootstrap to AntD - Form - iteration 2 (#14379) 2021-05-05 22:00:37 -07:00
Michael S. Molina
f9567efe81 fix: Fix #13831 (#14490) 2021-05-05 13:48:48 -07:00
Kamil Gabryjelski
b030c9801c chore: Move styles from .less stylesheet to emotion in Explore (#14485)
* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
2021-05-05 15:36:52 +02:00
Michael S. Molina
d0be1ff79e chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
Michael S. Molina
8441590812 chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
Michael S. Molina
cfe927bebb test: Adds tests for the FixedOrMetricControl component (#13705) 2021-04-13 15:26:31 -07:00
Bruno Motta
284402c583 test: AdhocMetricEditPopover (#13787)
* tests for AdhocMetricEditPopover

* replace "factoryProps" for "createProps"

* removing unnecessary if

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-07 10:34:29 -07:00
Grace Guo
4b29789b64 fix: null exception from adhoc metric popover (#13955) 2021-04-06 13:36:59 +08:00
Michael S. Molina
6fd62e3f7e test: Adds tests to the OptionControls component (#13729) 2021-03-31 18:07:22 -07:00
Michael S. Molina
8ddcba82e0 chore: Removes Select duplication (#13477) 2021-03-31 15:42:14 -07:00
Michael S. Molina
6fe4cc0c51 chore: Removes Popover duplication (#13462) 2021-03-30 13:54:53 -07:00
Jesse Yang
08d0deb720 fix: clean up incorrect usage of TypeScript type in PropTypes (#13681) 2021-03-18 09:12:13 -07:00
Yongjie Zhao
817b740f59 chore: metric refactor iteration 1 (#13596) 2021-03-12 23:11:05 +08:00
Kamil Gabryjelski
d439da2fe0 feat: Implement drag and drop for metrics (#13575)
* Convert MetricsControl to functional component

* Implement drag and drop for metrics

* Implement customizable placeholder for DndSelectLabel
2021-03-12 12:31:17 +08:00
Kamil Gabryjelski
7b370e6f17 feat: Implement drag and drop columns for filters (#13340)
* Implement DnD feature for filters

* minor refactor

* Fix types

* Fix undefined error

* Refactor

* Fix ts errors

* Fix conflicting dnd types

* Bump superset-ui packages

* Change DndItemType case to PascalCase

* Remove redundant null check

* Fix

* Fix csrf mock api call
2021-03-07 11:54:08 +02:00
Jesse Yang
3c62069bbb refactor(explore): convert ControlPanelsContainer to typescript (#13221) 2021-02-28 10:10:15 -08:00
Kamil Gabryjelski
44723eabbe fix(explore): Certificate icon not displaying for certified metrics (#13133)
* Fix certificate icon not displaying for certified metrics

* Remove redundant function

* Fix grammar mistake
2021-02-16 08:56:19 -08:00
Phillip Kelley-Dotson
3bb14ab950 feat: reset metrics on dataset change (#12782)
* reset metrics on dataset change take one

* remove code

* part 2 or reseting adhoc controls

* update input controls and customize defaults

* remove conosles

* remove extra method

* simplify logic for controls reset and have them use their defaults

* remove consoles

* add annotation control to defaultvalues

* remove line
2021-02-05 14:08:27 +08:00
Ville Brofeldt
61e56b5027 fix(explore): add current savedMetric to dropdown (#12835) 2021-01-29 22:51:35 +02:00
Kamil Gabryjelski
c6093a7469 fix: Remove double tooltip from metric label (#12736)
* Remove tooltip from AdhocMetricOption

* Lint fix

* Add tooltip for adhoc metrics

* Typo fix
2021-01-29 17:01:58 +02:00
Nikola Gigić
1603e82a03 chore(explore): Metric/Column and Filter popover unexpectedly closes on scroll (#12817)
* fix

* address filter popup
2021-01-29 16:53:00 +02:00
Kamil Gabryjelski
fcaa0acad5 chore: Upgrade react-dnd to 11.1.3 (#12815) 2021-01-28 18:34:56 -08:00