Commit Graph

612 Commits

Author SHA1 Message Date
Stephen Liu
2ae29c9281 fix(Select): options will be overwritten due to seState (#17951) 2022-01-07 08:09:25 -07:00
Michael S. Molina
aa91662ec8 chore: Moves the Menu to views/components folder (#17897)
* chore: Moves the Menu to views/components folder

* Fixes imports
2022-01-07 09:25:31 -03:00
Michael S. Molina
53d8d383cc chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Yongjie Zhao
ceecc7047b chore: remove unused eslintrc (#17860)
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
2022-01-05 19:31:12 +08:00
Beto Dealmeida
2cd8054358 feat: add force option to report screenshots (#17853)
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts
2021-12-22 12:16:04 -08:00
Lyndsi Kay Williams
d2ed1b72dc chore: Help user to find the input fields in the dataset editor (#17824)
* Updated fields in Metrics and Calculated Columns tabs inside dataset editor, deleted label in expanded Metrics tab

* Fix tests

* Vertically aligned rows in columns tab
2021-12-22 12:21:37 -06:00
Stephen Liu
142b5bc506 fix: local warning in the frontend development (#17727) 2021-12-15 09:52:42 +02:00
Beto Dealmeida
63d9693f21 feat: add main datetime column to dataset editor (#17739)
* feat: add main dttm col to dataset editor

* Add tests
2021-12-14 14:47:08 -08:00
Geido
4b969710e4 Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Geido
8de93871d7 Fix flacky header (#17690) 2021-12-10 18:25:40 +02:00
Corbin Robb
f476ba23a2 fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Ville Brofeldt
c4b04952d0 feat: customize recent activity access (#17589)
* feat: customize recent activity access

* address comments

* fix and add tests

* add alert assertion and UPDATING.md entry

* replace .get_id() with .id

* fix updating comment

* update config name
2021-12-08 11:30:23 +02:00
Lyndsi Kay Williams
05752e3fe8 fix(sqllab): Floating numbers not sorting correctly in result column (#17573)
* Floating nums now sorting correctly with parseFloatingNums function

* Floating numbers AND strings now sorting correctly, +locale comparison

* Added NULL handling back to sort function

* Moved parseFloatingNums outside of sortResults

* Removed localeCompare and added testing

* Add equality check back to sort function

* Added floatValue nit
2021-12-03 16:31:46 -08:00
Hugh A. Miles II
d9e9c3a3de refactor: Add AutoSizer to react-virtualized Grid (#17606)
* remove styles from renderCell

* remove styling on grid
2021-12-02 12:47:47 -05:00
Phillip Kelley-Dotson
4e76637252 initial fix (#17547) 2021-11-30 08:24:18 -08:00
Holger Bruch
6604a6ab28 chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Geido
83e49fc9ee feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-11-24 13:42:52 +02:00
Corbin Robb
c216565190 Remove loading span, add empty-loading-bar css class, change empty loading rows length to 12, remove width logic on empty loading columns (#17515)
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-11-23 15:13:53 -08:00
Ville Brofeldt
18c7aec985 chore: remove deprecated selects and deps (#17522) 2021-11-23 12:41:16 +02:00
Yongjie Zhao
9070b6b19c refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Lyndsi Kay Williams
eb029ab068 fix(sql lab): NULL styling in grid cell (#17385)
* Fix NULL styling in gridCell

* removed unnecessary imports

* Added null styling back to renderGridCell

* Cleaned up a little code as per Elizabeth

* Found another little cleanup spot
2021-11-15 10:49:35 -08:00
Yongjie Zhao
33a8e87513 fix: failed timezone selector UT (#17370) 2021-11-08 23:52:22 +08:00
Michael S. Molina
ed4a628861 fix: Database selector overflow (#17369)
* fix: Database selector overflow

* Fix TImezoneSelector test

* Removes unused imports
2021-11-08 11:25:16 -03:00
Beto Dealmeida
43f4ab845a fix: clear 'delete' confirmation (#17345)
* fix: clear 'delete' confirmation

* Add tests
2021-11-04 16:26:38 -07:00
AAfghahi
5948a9fd02 fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Hugh A. Miles II
d0bad96b1a fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log
2021-10-29 14:19:37 -07:00
Phillip Kelley-Dotson
93f59e055e chore: remove supersetTheme with withTheme (#17069)
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
2021-10-27 12:42:56 -07:00
Michael S. Molina
dd71035e58 chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Geido
48fd3c185c chore: Add docs to the Select component props (#17171)
* Add docs

* Add overall description

* Remove trailing space
2021-10-26 12:50:23 +03:00
Michael S. Molina
4c96ae76e3 chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Michael S. Molina
55be249870 fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
Shiva Raisinghani
ef3afbde82 refactor: Repeated boilerplate code between upload to database forms (#16756)
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
2021-10-25 13:53:06 +03:00
Hugh A. Miles II
b5246b29df feat: Hide nav create with RBAC (#17157)
* recommit

* Update MenuRight.tsx
2021-10-23 03:47:56 -04:00
Hugh A. Miles II
cd9e99402d feat: Add prettier to pre-commit workflow (#17134)
* save

* fix

* fix pre-commit
2021-10-20 20:53:52 -04:00
Geido
f580f6bcba fix(Explore): Undefined owners (#17167)
* Reconcile owners data

* Fix on save
2021-10-20 09:45:58 -06:00
Michael S. Molina
e32acd22fd chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
Grace Guo
96f4421961 fix: sql lab crash caused by invalid template (#17133) 2021-10-18 11:09:23 -07:00
Elizabeth Thompson
ae4ced8da6 fix: update values for default timezone selector (#17124)
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx
2021-10-18 09:39:20 -07:00
Lyndsi Kay Williams
635898a76d fix(sqllab): Hover tooltip flashes in SQL Lab (#17068)
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global
2021-10-14 16:23:22 -07:00
Beto Dealmeida
40e9add641 fix: accept headers on import (#17080)
* fix: accept headers on import

* Add unit test
2021-10-13 10:06:00 -07:00
Erik Ritter
153469dba9 fix: error alert levels again (#17027) 2021-10-11 12:28:36 -07:00
Beto Dealmeida
16a1df75fc fix: clear modal state after adding dataset (#17044)
* fix: clear modal state after adding dataset

* Fix test

* Small fixes
2021-10-10 16:21:14 -07:00
Michael S. Molina
7c1c89c94b fix: Loading indicator of table and schema selectors (#17040) 2021-10-08 16:17:43 -03:00
Geido
42efcdf027 chore(Dashboard): Implement dedicated message for missing dataset (#16959)
* Implement dedicated message

* Clean up
2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3 fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
Michael S. Molina
be211437de fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Evan Rusackas
5f73ca85d5 feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001)
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
2021-10-07 08:26:57 -06:00
Geido
66b0877445 Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Geido
a782a62097 chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00