docs(ci): auto-regenerate openapi files used for docs

.github/workflows/superset-docs-deploy.yml

@@ -41,6 +41,8 @@ jobs:
           node-version-file: './docs/.nvmrc'
       - name: Setup Python
         uses: ./.github/actions/setup-backend/
+      - name: Update openapi docs
+        run: superset update_api_docs
       - uses: actions/setup-java@v4
         with:
           distribution: 'zulu'

docs/docs/configuration/configuring-superset.mdx

@@ -302,15 +302,6 @@ AUTH_USER_REGISTRATION = True
 AUTH_USER_REGISTRATION_ROLE = "Public"
 ```
 
-In case you want to assign the `Admin` role on new user registration, it can be assigned as follows:
-```python
-AUTH_USER_REGISTRATION_ROLE = "Admin"
-```
-If you encounter the [issue](https://github.com/apache/superset/issues/13243) of not being able to list users from the Superset main page settings, although a newly registered user has an `Admin` role, please re-run `superset init` to sync the required permissions. Below is the command to re-run `superset init` using docker compose.
-```
-docker-compose exec superset superset init
-```
-
 Then, create a `CustomSsoSecurityManager` that extends `SupersetSecurityManager` and overrides
 `oauth_user_info`:
 

docs/package.json

@@ -26,7 +26,7 @@
     "@emotion/styled": "^10.0.27",
     "@saucelabs/theme-github-codeblock": "^0.3.0",
     "@superset-ui/style": "^0.14.23",
-    "antd": "^5.24.9",
+    "antd": "^5.24.5",
     "docusaurus-plugin-less": "^2.0.2",
     "less": "^4.3.0",
     "less-loader": "^11.0.0",

docs/yarn.lock

@@ -1092,13 +1092,20 @@
     core-js-pure "^3.30.2"
     regenerator-runtime "^0.14.0"
 
-"@babel/runtime@^7.1.2", "@babel/runtime@^7.10.1", "@babel/runtime@^7.10.3", "@babel/runtime@^7.10.4", "@babel/runtime@^7.11.1", "@babel/runtime@^7.11.2", "@babel/runtime@^7.12.13", "@babel/runtime@^7.12.5", "@babel/runtime@^7.16.7", "@babel/runtime@^7.18.0", "@babel/runtime@^7.18.3", "@babel/runtime@^7.20.0", "@babel/runtime@^7.20.7", "@babel/runtime@^7.21.0", "@babel/runtime@^7.22.5", "@babel/runtime@^7.23.2", "@babel/runtime@^7.23.6", "@babel/runtime@^7.23.9", "@babel/runtime@^7.24.4", "@babel/runtime@^7.24.7", "@babel/runtime@^7.24.8", "@babel/runtime@^7.25.7", "@babel/runtime@^7.25.9", "@babel/runtime@^7.26.0", "@babel/runtime@^7.3.1", "@babel/runtime@^7.5.5", "@babel/runtime@^7.7.2", "@babel/runtime@^7.8.4":
+"@babel/runtime@^7.1.2", "@babel/runtime@^7.10.3", "@babel/runtime@^7.12.13", "@babel/runtime@^7.12.5", "@babel/runtime@^7.25.9", "@babel/runtime@^7.8.4":
   version "7.27.0"
   resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.27.0.tgz#fbee7cf97c709518ecc1f590984481d5460d4762"
   integrity sha512-VtPOkrdPHZsKc/clNqyi9WUA8TINkZ4cGk63UUE3u4pmB2k+ZMQRDuIOagv8UVd6j7k0T3+RRIb7beKTebNbcw==
   dependencies:
     regenerator-runtime "^0.14.0"
 
+"@babel/runtime@^7.10.1", "@babel/runtime@^7.10.4", "@babel/runtime@^7.11.1", "@babel/runtime@^7.11.2", "@babel/runtime@^7.16.7", "@babel/runtime@^7.18.0", "@babel/runtime@^7.18.3", "@babel/runtime@^7.20.0", "@babel/runtime@^7.20.7", "@babel/runtime@^7.21.0", "@babel/runtime@^7.22.5", "@babel/runtime@^7.23.2", "@babel/runtime@^7.23.6", "@babel/runtime@^7.23.9", "@babel/runtime@^7.24.4", "@babel/runtime@^7.24.7", "@babel/runtime@^7.24.8", "@babel/runtime@^7.25.7", "@babel/runtime@^7.26.0", "@babel/runtime@^7.3.1", "@babel/runtime@^7.5.5", "@babel/runtime@^7.7.2":
+  version "7.26.10"
+  resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.26.10.tgz#a07b4d8fa27af131a633d7b3524db803eb4764c2"
+  integrity sha512-2WJMeRQPHKSPemqk/awGrAiuFfzBmOIPXKizAsVhWH9YJqLZ0H+HS4c8loHGgW6utJ3E/ejXQUsiGaQy2NZ9Fw==
+  dependencies:
+    regenerator-runtime "^0.14.0"
+
 "@babel/template@^7.25.9", "@babel/template@^7.26.9", "@babel/template@^7.27.0":
   version "7.27.0"
   resolved "https://registry.yarnpkg.com/@babel/template/-/template-7.27.0.tgz#b253e5406cc1df1c57dcd18f11760c2dbf40c0b4"
@@ -4179,10 +4186,10 @@ ansi-styles@^6.1.0:
   resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-6.2.1.tgz#0e62320cf99c21afff3b3012192546aacbfb05c5"
   integrity sha512-bN798gFfQX+viw3R7yrGWRqnrN2oRkEkUjjl4JNn4E8GxxbjtG3FbrEIIY3l8/hrwUwIeCZvi4QuOTP4MErVug==
 
-antd@^5.24.9:
+antd@^5.24.5:
-  version "5.24.9"
+  version "5.24.5"
-  resolved "https://registry.yarnpkg.com/antd/-/antd-5.24.9.tgz#c5862e02ed770bd95e312961f4f0b7b158a004d9"
+  resolved "https://registry.yarnpkg.com/antd/-/antd-5.24.5.tgz#b0976a113163888d1477f9e666c3c23352b098e9"
-  integrity sha512-liB+Y/JwD5/KSKbK1Z1EVAbWcoWYvWJ1s97AbbT+mOdigpJQuWwH7kG8IXNEljI7onvj0DdD43TXhSRLUu9AMA==
+  integrity sha512-1lAv/G+9ewQanyoAo3JumQmIlVxwo5QwWGb6QCHYc40Cq0NxC/EzITcjsgq1PSaTUpLkKq8A2l7Fjtu47vqQBg==
   dependencies:
     "@ant-design/colors" "^7.2.0"
     "@ant-design/cssinjs" "^1.23.0"
@@ -4206,13 +4213,13 @@ antd@^5.24.9:
     rc-drawer "~7.2.0"
     rc-dropdown "~4.2.1"
     rc-field-form "~2.7.0"
-    rc-image "~7.12.0"
+    rc-image "~7.11.1"
-    rc-input "~1.8.0"
+    rc-input "~1.7.3"
-    rc-input-number "~9.5.0"
+    rc-input-number "~9.4.0"
-    rc-mentions "~2.20.0"
+    rc-mentions "~2.19.1"
     rc-menu "~9.16.1"
     rc-motion "^2.9.5"
-    rc-notification "~5.6.4"
+    rc-notification "~5.6.3"
     rc-pagination "~5.1.0"
     rc-picker "~4.11.3"
     rc-progress "~4.0.0"
@@ -4224,8 +4231,8 @@ antd@^5.24.9:
     rc-steps "~6.0.1"
     rc-switch "~4.1.0"
     rc-table "~7.50.4"
-    rc-tabs "~15.6.1"
+    rc-tabs "~15.5.1"
-    rc-textarea "~1.10.0"
+    rc-textarea "~1.9.0"
     rc-tooltip "~6.4.0"
     rc-tree "~5.13.1"
     rc-tree-select "~5.27.0"
@@ -5667,7 +5674,12 @@ data-view-byte-offset@^1.0.1:
     es-errors "^1.3.0"
     is-data-view "^1.0.1"
 
-dayjs@^1.11.11, dayjs@^1.11.13:
+dayjs@^1.11.11:
+  version "1.11.12"
+  resolved "https://registry.npmjs.org/dayjs/-/dayjs-1.11.12.tgz"
+  integrity sha512-Rt2g+nTbLlDWZTwwrIXjy9MeiZmSDI375FvZs72ngxx8PDC6YXOeR3q5LAuPzjZQxhiWdRKac7RKV+YyQYfYIg==
+
+dayjs@^1.11.13:
   version "1.11.13"
   resolved "https://registry.yarnpkg.com/dayjs/-/dayjs-1.11.13.tgz#92430b0139055c3ebb60150aa13e860a4b5a366c"
   integrity sha512-oaMBel6gjolK862uaPQOVTA7q3TZhuSvuMQAAglQDOWYO9A91IrAOUJEyKVlqJlHE0vq5p5UXxzdPfMH/x6xNg==
@@ -10676,10 +10688,10 @@ rc-field-form@~2.7.0:
     "@rc-component/async-validator" "^5.0.3"
     rc-util "^5.32.2"
 
-rc-image@~7.12.0:
+rc-image@~7.11.1:
-  version "7.12.0"
+  version "7.11.1"
-  resolved "https://registry.yarnpkg.com/rc-image/-/rc-image-7.12.0.tgz#95e9314701e668217d113c1f29b4f01ac025cafe"
+  resolved "https://registry.yarnpkg.com/rc-image/-/rc-image-7.11.1.tgz#3ab290708dc053d3681de94186522e4e594f6772"
-  integrity sha512-cZ3HTyyckPnNnUb9/DRqduqzLfrQRyi+CdHjdqgsyDpI3Ln5UX1kXnAhPBSJj9pVRzwRFgqkN7p9b6HBDjmu/Q==
+  integrity sha512-XuoWx4KUXg7hNy5mRTy1i8c8p3K8boWg6UajbHpDXS5AlRVucNfTi5YxTtPBTBzegxAZpvuLfh3emXFt6ybUdA==
   dependencies:
     "@babel/runtime" "^7.11.2"
     "@rc-component/portal" "^1.0.2"
@@ -10688,37 +10700,37 @@ rc-image@~7.12.0:
     rc-motion "^2.6.2"
     rc-util "^5.34.1"
 
-rc-input-number@~9.5.0:
+rc-input-number@~9.4.0:
-  version "9.5.0"
+  version "9.4.0"
-  resolved "https://registry.yarnpkg.com/rc-input-number/-/rc-input-number-9.5.0.tgz#b47963d0f2cbd85ab2f1badfdc089a904c073f38"
+  resolved "https://registry.npmjs.org/rc-input-number/-/rc-input-number-9.4.0.tgz"
-  integrity sha512-bKaEvB5tHebUURAEXw35LDcnRZLq3x1k7GxfAqBMzmpHkDGzjAtnUL8y4y5N15rIFIg5IJgwr211jInl3cipag==
+  integrity sha512-Tiy4DcXcFXAf9wDhN8aUAyMeCLHJUHA/VA/t7Hj8ZEx5ETvxG7MArDOSE6psbiSCo+vJPm4E3fGN710ITVn6GA==
   dependencies:
     "@babel/runtime" "^7.10.1"
     "@rc-component/mini-decimal" "^1.0.1"
     classnames "^2.2.5"
-    rc-input "~1.8.0"
+    rc-input "~1.7.1"
     rc-util "^5.40.1"
 
-rc-input@~1.8.0:
+rc-input@~1.7.1, rc-input@~1.7.3:
-  version "1.8.0"
+  version "1.7.3"
-  resolved "https://registry.yarnpkg.com/rc-input/-/rc-input-1.8.0.tgz#d2f4404befebf2fbdc28390d5494c302f74ae974"
+  resolved "https://registry.yarnpkg.com/rc-input/-/rc-input-1.7.3.tgz#cb334a17b93ce985bceb243b4c111a5ed641e0e3"
-  integrity sha512-KXvaTbX+7ha8a/k+eg6SYRVERK0NddX8QX7a7AnRvUa/rEH0CNMlpcBzBkhI0wp2C8C4HlMoYl8TImSN+fuHKA==
+  integrity sha512-A5w4egJq8+4JzlQ55FfQjDnPvOaAbzwC3VLOAdOytyek3TboSOP9qxN+Gifup+shVXfvecBLBbWBpWxmk02SWQ==
   dependencies:
     "@babel/runtime" "^7.11.1"
     classnames "^2.2.1"
     rc-util "^5.18.1"
 
-rc-mentions@~2.20.0:
+rc-mentions@~2.19.1:
-  version "2.20.0"
+  version "2.19.1"
-  resolved "https://registry.yarnpkg.com/rc-mentions/-/rc-mentions-2.20.0.tgz#3bbeac0352b02e0ce3e1244adb48701bb6903bf7"
+  resolved "https://registry.npmjs.org/rc-mentions/-/rc-mentions-2.19.1.tgz"
-  integrity sha512-w8HCMZEh3f0nR8ZEd466ATqmXFCMGMN5UFCzEUL0bM/nGw/wOS2GgRzKBcm19K++jDyuWCOJOdgcKGXU3fXfbQ==
+  integrity sha512-KK3bAc/bPFI993J3necmaMXD2reZTzytZdlTvkeBbp50IGH1BDPDvxLdHDUrpQx2b2TGaVJsn+86BvYa03kGqA==
   dependencies:
     "@babel/runtime" "^7.22.5"
     "@rc-component/trigger" "^2.0.0"
     classnames "^2.2.6"
-    rc-input "~1.8.0"
+    rc-input "~1.7.1"
     rc-menu "~9.16.0"
-    rc-textarea "~1.10.0"
+    rc-textarea "~1.9.0"
     rc-util "^5.34.1"
 
 rc-menu@~9.16.0, rc-menu@~9.16.1:
@@ -10742,10 +10754,10 @@ rc-motion@^2.0.0, rc-motion@^2.0.1, rc-motion@^2.3.0, rc-motion@^2.3.4, rc-motio
     classnames "^2.2.1"
     rc-util "^5.44.0"
 
-rc-notification@~5.6.4:
+rc-notification@~5.6.3:
-  version "5.6.4"
+  version "5.6.3"
-  resolved "https://registry.yarnpkg.com/rc-notification/-/rc-notification-5.6.4.tgz#ea89c39c13cd517fdfd97fe63f03376fabb78544"
+  resolved "https://registry.npmjs.org/rc-notification/-/rc-notification-5.6.3.tgz"
-  integrity sha512-KcS4O6B4qzM3KH7lkwOB7ooLPZ4b6J+VMmQgT51VZCeEcmghdeR4IrMcFq0LG+RPdnbe/ArT086tGM8Snimgiw==
+  integrity sha512-42szwnn8VYQoT6GnjO00i1iwqV9D1TTMvxObWsuLwgl0TsOokzhkYiufdtQBsJMFjJravS1hfDKVMHLKLcPE4g==
   dependencies:
     "@babel/runtime" "^7.10.1"
     classnames "2.x"
@@ -10873,10 +10885,10 @@ rc-table@~7.50.4:
     rc-util "^5.44.3"
     rc-virtual-list "^3.14.2"
 
-rc-tabs@~15.6.1:
+rc-tabs@~15.5.1:
-  version "15.6.1"
+  version "15.5.1"
-  resolved "https://registry.yarnpkg.com/rc-tabs/-/rc-tabs-15.6.1.tgz#f0b6c65384dfa09a64eb539e86a0667c7a650708"
+  resolved "https://registry.npmjs.org/rc-tabs/-/rc-tabs-15.5.1.tgz"
-  integrity sha512-/HzDV1VqOsUWyuC0c6AkxVYFjvx9+rFPKZ32ejxX0Uc7QCzcEjTA9/xMgv4HemPKwzBNX8KhGVbbumDjnj92aA==
+  integrity sha512-yiWivLAjEo5d1v2xlseB2dQocsOhkoVSfo1krS8v8r+02K+TBUjSjXIf7dgyVSxp6wRIPv5pMi5hanNUlQMgUA==
   dependencies:
     "@babel/runtime" "^7.11.2"
     classnames "2.x"
@@ -10886,14 +10898,14 @@ rc-tabs@~15.6.1:
     rc-resize-observer "^1.0.0"
     rc-util "^5.34.1"
 
-rc-textarea@~1.10.0:
+rc-textarea@~1.9.0:
-  version "1.10.0"
+  version "1.9.0"
-  resolved "https://registry.yarnpkg.com/rc-textarea/-/rc-textarea-1.10.0.tgz#f8f962ef83be0b8e35db97cf03dbfb86ddd9c46c"
+  resolved "https://registry.npmjs.org/rc-textarea/-/rc-textarea-1.9.0.tgz"
-  integrity sha512-ai9IkanNuyBS4x6sOL8qu/Ld40e6cEs6pgk93R+XLYg0mDSjNBGey6/ZpDs5+gNLD7urQ14po3V6Ck2dJLt9SA==
+  integrity sha512-dQW/Bc/MriPBTugj2Kx9PMS5eXCCGn2cxoIaichjbNvOiARlaHdI99j4DTxLl/V8+PIfW06uFy7kjfUIDDKyxQ==
   dependencies:
     "@babel/runtime" "^7.10.1"
     classnames "^2.2.1"
-    rc-input "~1.8.0"
+    rc-input "~1.7.1"
     rc-resize-observer "^1.0.0"
     rc-util "^5.27.0"
 

superset-frontend/cypress-base/cypress/e2e/explore/visualizations/table.test.ts

@@ -252,215 +252,4 @@ describe('Visualization > Table', () => {
     });
     cy.get('td').contains(/\d*%/);
   });
-
-  it('Test row limit with server pagination toggle', () => {
-    cy.visitChartByParams({
-      ...VIZ_DEFAULTS,
-      metrics: ['count'],
-      row_limit: 100,
-    });
-
-    // Enable server pagination
-    cy.get('[data-test="server_pagination-header"] div.pull-left').click();
-
-    // Click row limit control and select high value (200k)
-    cy.get('div[aria-label="Row limit"]').click();
-
-    // Type 200000 and press enter to select the option
-    cy.get('div[aria-label="Row limit"]')
-      .find('.ant-select-selection-search-input:visible')
-      .type('200000{enter}');
-
-    // Verify that there is no error tooltip when server pagination is enabled
-    cy.get('[data-test="error-tooltip"]').should('not.exist');
-
-    // Disable server pagination
-    cy.get('[data-test="server_pagination-header"] div.pull-left').click();
-
-    // Verify error tooltip appears
-    cy.get('[data-test="error-tooltip"]').should('be.visible');
-
-    // Trigger mouseover and verify tooltip text
-    cy.get('[data-test="error-tooltip"]').trigger('mouseover');
-
-    // Verify tooltip content
-    cy.get('.antd5-tooltip-inner').should('be.visible');
-    cy.get('.antd5-tooltip-inner').should(
-      'contain',
-      'Server pagination needs to be enabled for values over',
-    );
-
-    // Hide the tooltip by adding display:none style
-    cy.get('.antd5-tooltip').invoke('attr', 'style', 'display: none');
-
-    // Enable server pagination again
-    cy.get('[data-test="server_pagination-header"] div.pull-left').click();
-
-    cy.get('[data-test="error-tooltip"]').should('not.exist');
-
-    cy.get('div[aria-label="Row limit"]').click();
-
-    // Type 1000000
-    cy.get('div[aria-label="Row limit"]')
-      .find('.ant-select-selection-search-input:visible')
-      .type('1000000');
-
-    // Wait for 1 second
-    cy.wait(1000);
-
-    // Press enter
-    cy.get('div[aria-label="Row limit"]')
-      .find('.ant-select-selection-search-input:visible')
-      .type('{enter}');
-
-    // Wait for error tooltip to appear and verify its content
-    cy.get('[data-test="error-tooltip"]')
-      .should('be.visible')
-      .trigger('mouseover');
-
-    // Wait for tooltip content and verify
-    cy.get('.antd5-tooltip-inner').should('exist');
-    cy.get('.antd5-tooltip-inner').should('be.visible');
-
-    // Verify tooltip content separately
-    cy.get('.antd5-tooltip-inner').should('contain', 'Value cannot exceed');
-  });
-
-  it('Test sorting with server pagination enabled', () => {
-    cy.visitChartByParams({
-      ...VIZ_DEFAULTS,
-      metrics: ['count'],
-      groupby: ['name'],
-      row_limit: 100000,
-      server_pagination: true, // Enable server pagination
-    });
-
-    // Wait for the initial data load
-    cy.wait('@chartData');
-
-    // Get the first column header (name)
-    cy.get('.chart-container th').contains('name').as('nameHeader');
-
-    // Click to sort ascending
-    cy.get('@nameHeader').click();
-    cy.wait('@chartData');
-
-    // Verify first row starts with 'A'
-    cy.get('.chart-container td:first').invoke('text').should('match', /^[Aa]/);
-
-    // Click again to sort descending
-    cy.get('@nameHeader').click();
-    cy.wait('@chartData');
-
-    // Verify first row starts with 'Z'
-    cy.get('.chart-container td:first').invoke('text').should('match', /^[Zz]/);
-
-    // Test numeric sorting
-    cy.get('.chart-container th').contains('COUNT').as('countHeader');
-
-    // Click to sort ascending by count
-    cy.get('@countHeader').click();
-    cy.wait('@chartData');
-
-    // Get first two count values and verify ascending order
-    cy.get('.chart-container td:nth-child(2)').then($cells => {
-      const first = parseFloat($cells[0].textContent || '0');
-      const second = parseFloat($cells[1].textContent || '0');
-      expect(first).to.be.at.most(second);
-    });
-
-    // Click again to sort descending
-    cy.get('@countHeader').click();
-    cy.wait('@chartData');
-
-    // Get first two count values and verify descending order
-    cy.get('.chart-container td:nth-child(2)').then($cells => {
-      const first = parseFloat($cells[0].textContent || '0');
-      const second = parseFloat($cells[1].textContent || '0');
-      expect(first).to.be.at.least(second);
-    });
-  });
-
-  it('Test search with server pagination enabled', () => {
-    cy.visitChartByParams({
-      ...VIZ_DEFAULTS,
-      metrics: ['count'],
-      groupby: ['name', 'state'],
-      row_limit: 100000,
-      server_pagination: true,
-      include_search: true,
-    });
-
-    cy.wait('@chartData');
-
-    // Basic search test
-    cy.get('span.dt-global-filter input.form-control.input-sm').should(
-      'be.visible',
-    );
-
-    cy.get('span.dt-global-filter input.form-control.input-sm').type('John');
-
-    cy.wait('@chartData');
-
-    cy.get('.chart-container tbody tr').each($row => {
-      cy.wrap($row).contains(/John/i);
-    });
-
-    // Clear and test case-insensitive search
-    cy.get('span.dt-global-filter input.form-control.input-sm').clear();
-
-    cy.wait('@chartData');
-
-    cy.get('span.dt-global-filter input.form-control.input-sm').type('mary');
-
-    cy.wait('@chartData');
-
-    cy.get('.chart-container tbody tr').each($row => {
-      cy.wrap($row).contains(/Mary/i);
-    });
-
-    // Test special characters
-    cy.get('span.dt-global-filter input.form-control.input-sm').clear();
-
-    cy.get('span.dt-global-filter input.form-control.input-sm').type('Nicole');
-
-    cy.wait('@chartData');
-
-    cy.get('.chart-container tbody tr').each($row => {
-      cy.wrap($row).contains(/Nicole/i);
-    });
-
-    // Test no results
-    cy.get('span.dt-global-filter input.form-control.input-sm').clear();
-
-    cy.get('span.dt-global-filter input.form-control.input-sm').type('XYZ123');
-
-    cy.wait('@chartData');
-
-    cy.get('.chart-container').contains('No records found');
-
-    // Test column-specific search
-    cy.get('.search-select').should('be.visible');
-
-    cy.get('.search-select').click();
-
-    cy.get('.ant-select-dropdown').should('be.visible');
-
-    cy.get('.ant-select-item-option').contains('state').should('be.visible');
-
-    cy.get('.ant-select-item-option').contains('state').click();
-
-    cy.get('span.dt-global-filter input.form-control.input-sm').clear();
-
-    cy.get('span.dt-global-filter input.form-control.input-sm').type('CA');
-
-    cy.wait('@chartData');
-    cy.wait(1000);
-
-    cy.get('td[aria-labelledby="header-state"]').should('be.visible');
-
-    cy.get('td[aria-labelledby="header-state"]')
-      .first()
-      .should('contain', 'CA');
-  });
 });

superset-frontend/packages/superset-ui-chart-controls/src/constants.ts

@@ -26,7 +26,6 @@ import {
 import { ColumnMeta, SortSeriesData, SortSeriesType } from './types';
 
 export const DEFAULT_MAX_ROW = 100000;
-export const DEFAULT_MAX_ROW_TABLE_SERVER = 500000;
 
 // eslint-disable-next-line import/prefer-default-export
 export const TIME_FILTER_LABELS = {

superset-frontend/packages/superset-ui-core/src/validator/index.ts

@@ -25,4 +25,3 @@ export { default as validateNonEmpty } from './validateNonEmpty';
 export { default as validateMaxValue } from './validateMaxValue';
 export { default as validateMapboxStylesUrl } from './validateMapboxStylesUrl';
 export { default as validateTimeComparisonRangeValues } from './validateTimeComparisonRangeValues';
-export { default as validateServerPagination } from './validateServerPagination';

superset-frontend/packages/superset-ui-core/src/validator/validateServerPagination.ts

@@ -1,30 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { t } from '../translation';
-
-export default function validateServerPagination(
-  v: unknown,
-  serverPagination: boolean,
-  max: number,
-) {
-  if (Number(v) > +max && !serverPagination) {
-    return t('Server pagination needs to be enabled for values over %s', max);
-  }
-  return false;
-}

superset-frontend/packages/superset-ui-core/test/validator/validateServerPagination.test.ts

@@ -1,46 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { validateServerPagination } from '@superset-ui/core';
-import './setup';
-
-test('validateServerPagination returns warning message when server pagination is disabled and value exceeds max', () => {
-  expect(validateServerPagination(100001, false, 100000)).toBeTruthy();
-  expect(validateServerPagination('150000', false, 100000)).toBeTruthy();
-  expect(validateServerPagination(200000, false, 100000)).toBeTruthy();
-});
-
-test('validateServerPagination returns false when server pagination is enabled', () => {
-  expect(validateServerPagination(100001, true, 100000)).toBeFalsy();
-  expect(validateServerPagination(150000, true, 100000)).toBeFalsy();
-  expect(validateServerPagination('200000', true, 100000)).toBeFalsy();
-});
-
-test('validateServerPagination returns false when value is below max', () => {
-  expect(validateServerPagination(50000, false, 100000)).toBeFalsy();
-  expect(validateServerPagination('75000', false, 100000)).toBeFalsy();
-  expect(validateServerPagination(99999, false, 100000)).toBeFalsy();
-});
-
-test('validateServerPagination handles edge cases', () => {
-  expect(validateServerPagination(undefined, false, 100000)).toBeFalsy();
-  expect(validateServerPagination(null, false, 100000)).toBeFalsy();
-  expect(validateServerPagination(NaN, false, 100000)).toBeFalsy();
-  expect(validateServerPagination('invalid', false, 100000)).toBeFalsy();
-});

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/PopKPI.tsx

@@ -36,25 +36,13 @@ import {
 } from './types';
 import { useOverflowDetection } from './useOverflowDetection';
 
-const MetricNameText = styled.div<{ metricNameFontSize?: number }>`
-  ${({ theme, metricNameFontSize }) => `
-    font-family: ${theme.typography.families.sansSerif};
-    font-weight: ${theme.typography.weights.normal};
-    font-size: ${metricNameFontSize || theme.typography.sizes.s * 2}px;
-    text-align: center;
-    margin-bottom: ${theme.gridUnit * 3}px;
-  `}
-`;
-
 const NumbersContainer = styled.div`
   display: flex;
   justify-content: center;
   align-items: center;
   flex-direction: column;
   width: 100%;
-  height: 100%;
   overflow: auto;
-  padding: 12px;
 `;
 
 const ComparisonValue = styled.div<PopKPIComparisonValueStyleProps>`
@@ -85,8 +73,6 @@ export default function PopKPI(props: PopKPIProps) {
     prevNumber,
     valueDifference,
     percentDifferenceFormattedString,
-    metricName,
-    metricNameFontSize,
     headerFontSize,
     subheaderFontSize,
     comparisonColorEnabled,
@@ -98,8 +84,8 @@ export default function PopKPI(props: PopKPIProps) {
     subtitle,
     subtitleFontSize,
     dashboardTimeRange,
-    showMetricName,
   } = props;
+
   const [comparisonRange, setComparisonRange] = useState<string>('');
 
   useEffect(() => {
@@ -274,16 +260,9 @@ export default function PopKPI(props: PopKPIProps) {
             width: fit-content;
             margin: auto;
             align-items: flex-start;
-            overflow: auto;
           `
         }
       >
-        {showMetricName && metricName && (
-          <MetricNameText metricNameFontSize={metricNameFontSize}>
-            {metricName}
-          </MetricNameText>
-        )}
-
         <div css={bigValueContainerStyles}>
           {bigNumber}
           {percentDifferenceNumber !== 0 && (

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts

@@ -28,8 +28,6 @@ import {
   subheaderFontSize,
   subtitleControl,
   subtitleFontSize,
-  showMetricNameControl,
-  metricNameFontSizeWithVisibility,
 } from '../sharedControls';
 import { ColorSchemeEnum } from './types';
 
@@ -72,8 +70,6 @@ const config: ControlPanelConfig = {
         ],
         [subtitleControl],
         [subtitleFontSize],
-        [showMetricNameControl],
-        [metricNameFontSizeWithVisibility],
         [
           {
             ...subheaderFontSize,

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/index.ts

@@ -32,7 +32,6 @@ export default class PopKPIPlugin extends ChartPlugin {
       tags: [
         t('Comparison'),
         t('Business'),
-        t('ECharts'),
         t('Percentages'),
         t('Report'),
         t('Advanced-Analytics'),

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts

@@ -26,13 +26,7 @@ import {
   SimpleAdhocFilter,
   ensureIsArray,
 } from '@superset-ui/core';
-import {
+import { getComparisonFontSize, getHeaderFontSize } from './utils';
-  getComparisonFontSize,
-  getHeaderFontSize,
-  getMetricNameFontSize,
-} from './utils';
-
-import { getOriginalLabel } from '../utils';
 
 dayjs.extend(utc);
 
@@ -89,7 +83,6 @@ export default function transformProps(chartProps: ChartProps) {
     headerFontSize,
     headerText,
     metric,
-    metricNameFontSize,
     yAxisFormat,
     currencyFormat,
     subheaderFontSize,
@@ -98,14 +91,11 @@ export default function transformProps(chartProps: ChartProps) {
     percentDifferenceFormat,
     subtitle = '',
     subtitleFontSize,
-    columnConfig = {},
+    columnConfig,
   } = formData;
   const { data: dataA = [] } = queriesData[0];
   const data = dataA;
   const metricName = metric ? getMetricLabel(metric) : '';
-  const metrics = chartProps.datasource?.metrics || [];
-  const originalLabel = getOriginalLabel(metric, metrics);
-  const showMetricName = chartProps.rawFormData?.show_metric_name ?? false;
   const timeComparison = ensureIsArray(chartProps.rawFormData?.time_compare)[0];
   const startDateOffset = chartProps.rawFormData?.start_date_offset;
   const currentTimeRangeFilter = chartProps.rawFormData?.adhoc_filters?.filter(
@@ -189,7 +179,7 @@ export default function transformProps(chartProps: ChartProps) {
     width,
     height,
     data,
-    metricName: originalLabel,
+    metricName,
     bigNumber,
     prevNumber,
     valueDifference,
@@ -197,8 +187,6 @@ export default function transformProps(chartProps: ChartProps) {
     boldText,
     subtitle,
     subtitleFontSize,
-    showMetricName,
-    metricNameFontSize: getMetricNameFontSize(metricNameFontSize),
     headerFontSize: getHeaderFontSize(headerFontSize),
     subheaderFontSize: getComparisonFontSize(subheaderFontSize),
     headerText,

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/types.ts

@@ -61,8 +61,6 @@ export type PopKPIProps = PopKPIStylesProps &
     data: TimeseriesDataRecord[];
     metrics: Metric[];
     metricName: string;
-    metricNameFontSize?: number;
-    showMetricName: boolean;
     bigNumber: string;
     prevNumber: string;
     subtitle?: string;

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/utils.ts

@@ -16,19 +16,10 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
+import { headerFontSize, subheaderFontSize } from '../sharedControls';
-  headerFontSize,
-  subheaderFontSize,
-  metricNameFontSize,
-} from '../sharedControls';
 
 const headerFontSizes = [16, 20, 30, 48, 60];
-const sharedFontSizes = [16, 20, 26, 32, 40];
+const comparisonFontSizes = [16, 20, 26, 32, 40];
-
-const metricNameProportionValues =
-  metricNameFontSize.config.options.map(
-    (option: { label: string; value: number }) => option.value,
-  ) ?? [];
 
 const headerProportionValues =
   headerFontSize.config.options.map(
@@ -49,10 +40,6 @@ const getFontSizeMapping = (
     return acc;
   }, {});
 
-const metricNameFontSizesMapping = getFontSizeMapping(
-  metricNameProportionValues,
-  sharedFontSizes,
-);
 const headerFontSizesMapping = getFontSizeMapping(
   headerProportionValues,
   headerFontSizes,
@@ -60,17 +47,13 @@ const headerFontSizesMapping = getFontSizeMapping(
 
 const comparisonFontSizesMapping = getFontSizeMapping(
   subheaderProportionValues,
-  sharedFontSizes,
+  comparisonFontSizes,
 );
 
-export const getMetricNameFontSize = (proportionValue: number) =>
-  metricNameFontSizesMapping[proportionValue] ??
-  sharedFontSizes[sharedFontSizes.length - 1];
-
 export const getHeaderFontSize = (proportionValue: number) =>
   headerFontSizesMapping[proportionValue] ??
   headerFontSizes[headerFontSizes.length - 1];
 
 export const getComparisonFontSize = (proportionValue: number) =>
   comparisonFontSizesMapping[proportionValue] ??
-  sharedFontSizes[sharedFontSizes.length - 1];
+  comparisonFontSizes[comparisonFontSizes.length - 1];

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/controlPanel.ts

@@ -28,8 +28,6 @@ import {
   headerFontSize,
   subtitleFontSize,
   subtitleControl,
-  showMetricNameControl,
-  metricNameFontSizeWithVisibility,
 } from '../sharedControls';
 
 export default {
@@ -46,8 +44,6 @@ export default {
         [headerFontSize],
         [subtitleControl],
         [subtitleFontSize],
-        [showMetricNameControl],
-        [metricNameFontSizeWithVisibility],
         ['y_axis_format'],
         ['currency_format'],
         [

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/index.ts

@@ -39,7 +39,6 @@ const metadata = {
   tags: [
     t('Additive'),
     t('Business'),
-    t('ECharts'),
     t('Legacy'),
     t('Percentages'),
     t('Featured'),

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.test.ts

@@ -36,7 +36,6 @@ jest.mock('@superset-ui/core', () => ({
 jest.mock('../utils', () => ({
   getDateFormatter: jest.fn(() => (v: any) => `${v}pm`),
   parseMetricValue: jest.fn(val => Number(val)),
-  getOriginalLabel: jest.fn((metric, metrics) => metric),
 }));
 
 describe('BigNumberTotal transformProps', () => {

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts

@@ -29,7 +29,7 @@ import {
   getValueFormatter,
 } from '@superset-ui/core';
 import { BigNumberTotalChartProps, BigNumberVizProps } from '../types';
-import { getDateFormatter, getOriginalLabel, parseMetricValue } from '../utils';
+import { getDateFormatter, parseMetricValue } from '../utils';
 import { Refs } from '../../types';
 
 export default function transformProps(
@@ -45,7 +45,6 @@ export default function transformProps(
     datasource: { currencyFormats = {}, columnFormats = {} },
   } = chartProps;
   const {
-    metricNameFontSize,
     headerFontSize,
     metric = 'value',
     subtitle,
@@ -59,12 +58,9 @@ export default function transformProps(
     subheaderFontSize,
   } = formData;
   const refs: Refs = {};
-  const { data = [], coltypes = [] } = queriesData[0] || {};
+  const { data = [], coltypes = [] } = queriesData[0];
   const granularity = extractTimegrain(rawFormData as QueryFormData);
-  const metrics = chartProps.datasource?.metrics || [];
-  const originalLabel = getOriginalLabel(metric, metrics);
   const metricName = getMetricLabel(metric);
-  const showMetricName = chartProps.rawFormData?.show_metric_name ?? false;
   const formattedSubtitle = subtitle?.trim() ? subtitle : subheader || '';
   const formattedSubtitleFontSize = subtitle?.trim()
     ? (subtitleFontSize ?? 1)
@@ -107,6 +103,7 @@ export default function transformProps(
   const colorThresholdFormatters =
     getColorFormatters(conditionalFormatting, data, false) ??
     defaultColorFormatters;
+
   return {
     width,
     height,
@@ -119,8 +116,5 @@ export default function transformProps(
     onContextMenu,
     refs,
     colorThresholdFormatters,
-    metricName: originalLabel,
-    showMetricName,
-    metricNameFontSize,
   };
 }

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { PureComponent, MouseEvent, createRef } from 'react';
+import { PureComponent, MouseEvent } from 'react';
 import {
   t,
   getNumberFormatter,
@@ -35,7 +35,6 @@ const defaultNumberFormatter = getNumberFormatter();
 
 const PROPORTION = {
   // text size: proportion of the chart container sans trendline
-  METRIC_NAME: 0.125,
   KICKER: 0.1,
   HEADER: 0.3,
   SUBHEADER: 0.125,
@@ -43,20 +42,13 @@ const PROPORTION = {
   TRENDLINE: 0.3,
 };
 
-type BigNumberVisState = {
+class BigNumberVis extends PureComponent<BigNumberVizProps> {
-  elementsRendered: boolean;
-  recalculateTrigger: boolean;
-};
-
-class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
   static defaultProps = {
     className: '',
     headerFormatter: defaultNumberFormatter,
     formatTime: getTimeFormatter(SMART_DATE_VERBOSE_ID),
     headerFontSize: PROPORTION.HEADER,
     kickerFontSize: PROPORTION.KICKER,
-    metricNameFontSize: PROPORTION.METRIC_NAME,
-    showMetricName: true,
     mainColor: BRAND_COLOR,
     showTimestamp: false,
     showTrendLine: false,
@@ -66,40 +58,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
     timeRangeFixed: false,
   };
 
-  // Create refs for each component to measure heights
-  metricNameRef = createRef<HTMLDivElement>();
-
-  kickerRef = createRef<HTMLDivElement>();
-
-  headerRef = createRef<HTMLDivElement>();
-
-  subheaderRef = createRef<HTMLDivElement>();
-
-  subtitleRef = createRef<HTMLDivElement>();
-
-  state = {
-    elementsRendered: false,
-    recalculateTrigger: false,
-  };
-
-  componentDidMount() {
-    // Wait for elements to render and then calculate heights
-    setTimeout(() => {
-      this.setState({ elementsRendered: true });
-    }, 0);
-  }
-
-  componentDidUpdate(prevProps: BigNumberVizProps) {
-    if (
-      prevProps.height !== this.props.height ||
-      prevProps.showTrendLine !== this.props.showTrendLine
-    ) {
-      this.setState(prevState => ({
-        recalculateTrigger: !prevState.recalculateTrigger,
-      }));
-    }
-  }
-
   getClassName() {
     const { className, showTrendLine, bigNumberFallback } = this.props;
     const names = `superset-legacy-chart-big-number ${className} ${
@@ -134,37 +92,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
     );
   }
 
-  renderMetricName(maxHeight: number) {
-    const { metricName, width, showMetricName } = this.props;
-    if (!showMetricName || !metricName) return null;
-
-    const text = metricName;
-
-    const container = this.createTemporaryContainer();
-    document.body.append(container);
-    const fontSize = computeMaxFontSize({
-      text,
-      maxWidth: width,
-      maxHeight,
-      className: 'metric-name',
-      container,
-    });
-    container.remove();
-
-    return (
-      <div
-        ref={this.metricNameRef}
-        className="metric-name"
-        style={{
-          fontSize,
-          height: 'auto',
-        }}
-      >
-        {text}
-      </div>
-    );
-  }
-
   renderKicker(maxHeight: number) {
     const { timestamp, showTimestamp, formatTime, width } = this.props;
     if (
@@ -191,7 +118,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
 
     return (
       <div
-        ref={this.kickerRef}
         className="kicker"
         style={{
           fontSize,
@@ -247,7 +173,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
 
     return (
       <div
-        ref={this.headerRef}
         className="header-line"
         style={{
           display: 'flex',
@@ -286,7 +211,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
 
       return (
         <div
-          ref={this.subheaderRef}
           className="subheader-line"
           style={{
             fontSize,
@@ -332,7 +256,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
       return (
         <>
           <div
-            ref={this.subtitleRef}
             className="subtitle-line subheader-line"
             style={{
               fontSize: `${fontSize}px`,
@@ -393,35 +316,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
     );
   }
 
-  getTotalElementsHeight() {
-    const marginPerElement = 8; // theme.gridUnit = 4, so margin-bottom = 8px
-
-    const refs = [
-      this.metricNameRef,
-      this.kickerRef,
-      this.headerRef,
-      this.subheaderRef,
-      this.subtitleRef,
-    ];
-
-    // Filter refs to only those with a current element
-    const visibleRefs = refs.filter(ref => ref.current);
-
-    const totalHeight = visibleRefs.reduce((sum, ref, index) => {
-      const height = ref.current?.offsetHeight || 0;
-      const margin = index < visibleRefs.length - 1 ? marginPerElement : 0;
-      return sum + height + margin;
-    }, 0);
-
-    return totalHeight;
-  }
-
-  shouldApplyOverflow(availableHeight: number) {
-    if (!this.state.elementsRendered) return false;
-    const totalHeight = this.getTotalElementsHeight();
-    return totalHeight > availableHeight;
-  }
-
   render() {
     const {
       showTrendLine,
@@ -429,7 +323,6 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
       kickerFontSize,
       headerFontSize,
       subtitleFontSize,
-      metricNameFontSize,
       subheaderFontSize,
     } = this.props;
     const className = this.getClassName();
@@ -437,31 +330,11 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
     if (showTrendLine) {
       const chartHeight = Math.floor(PROPORTION.TRENDLINE * height);
       const allTextHeight = height - chartHeight;
-      const shouldApplyOverflow = this.shouldApplyOverflow(allTextHeight);
 
       return (
         <div className={className}>
-          <div
+          <div className="text-container" style={{ height: allTextHeight }}>
-            className="text-container"
-            style={{
-              height: allTextHeight,
-              ...(shouldApplyOverflow
-                ? {
-                    display: 'block',
-                    boxSizing: 'border-box',
-                    overflowX: 'hidden',
-                    overflowY: 'auto',
-                    width: '100%',
-                  }
-                : {}),
-            }}
-          >
             {this.renderFallbackWarning()}
-            {this.renderMetricName(
-              Math.ceil(
-                (metricNameFontSize || 0) * (1 - PROPORTION.TRENDLINE) * height,
-              ),
-            )}
             {this.renderKicker(
               Math.ceil(
                 (kickerFontSize || 0) * (1 - PROPORTION.TRENDLINE) * height,
@@ -483,33 +356,16 @@ class BigNumberVis extends PureComponent<BigNumberVizProps, BigNumberVisState> {
         </div>
       );
     }
-    const shouldApplyOverflow = this.shouldApplyOverflow(height);
+
     return (
-      <div
+      <div className={className} style={{ height }}>
-        className={className}
+        {this.renderFallbackWarning()}
-        style={{
+        {this.renderKicker((kickerFontSize || 0) * height)}
-          height,
+        {this.renderHeader(Math.ceil(headerFontSize * height))}
-          ...(shouldApplyOverflow
+        {this.rendermetricComparisonSummary(
-            ? {
+          Math.ceil(subheaderFontSize * height),
-                display: 'block',
+        )}
-                boxSizing: 'border-box',
+        {this.renderSubtitle(Math.ceil(subtitleFontSize * height))}
-                overflowX: 'hidden',
-                overflowY: 'auto',
-                width: '100%',
-              }
-            : {}),
-        }}
-      >
-        <div className="text-container">
-          {this.renderFallbackWarning()}
-          {this.renderMetricName((metricNameFontSize || 0) * height)}
-          {this.renderKicker((kickerFontSize || 0) * height)}
-          {this.renderHeader(Math.ceil(headerFontSize * height))}
-          {this.rendermetricComparisonSummary(
-            Math.ceil(subheaderFontSize * height),
-          )}
-          {this.renderSubtitle(Math.ceil(subtitleFontSize * height))}
-        </div>
       </div>
     );
   }
@@ -544,12 +400,7 @@ export default styled(BigNumberVis)`
 
     .kicker {
       line-height: 1em;
-      margin-bottom: ${theme.gridUnit * 2}px;
+      padding-bottom: 2em;
-    }
-
-    .metric-name {
-      line-height: 1em;
-      margin-bottom: ${theme.gridUnit * 2}px;
     }
 
     .header-line {
@@ -565,12 +416,12 @@ export default styled(BigNumberVis)`
 
     .subheader-line {
       line-height: 1em;
-      margin-bottom: ${theme.gridUnit * 2}px;
+      padding-bottom: 0;
     }
 
     .subtitle-line {
       line-height: 1em;
-      margin-bottom: ${theme.gridUnit * 2}px;
+      padding-bottom: 0;
     }
 
     &.is-fallback-value {

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/controlPanel.tsx

@@ -31,8 +31,6 @@ import {
   subheaderFontSize,
   subtitleFontSize,
   subtitleControl,
-  showMetricNameControl,
-  metricNameFontSizeWithVisibility,
 } from '../sharedControls';
 
 const config: ControlPanelConfig = {
@@ -143,8 +141,6 @@ const config: ControlPanelConfig = {
         [subheaderFontSize],
         [subtitleControl],
         [subtitleFontSize],
-        [showMetricNameControl],
-        [metricNameFontSizeWithVisibility],
         ['y_axis_format'],
         ['currency_format'],
         [

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/index.ts

@@ -37,7 +37,6 @@ const metadata = {
   name: t('Big Number with Trendline'),
   tags: [
     t('Advanced-Analytics'),
-    t('ECharts'),
     t('Line'),
     t('Percentages'),
     t('Featured'),

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.test.ts

@@ -39,7 +39,6 @@ jest.mock('@superset-ui/core', () => ({
 jest.mock('../utils', () => ({
   getDateFormatter: jest.fn(() => (v: any) => `${v}pm`),
   parseMetricValue: jest.fn(val => Number(val)),
-  getOriginalLabel: jest.fn((metric, metrics) => metric),
 }));
 
 jest.mock('../../utils/tooltip', () => ({

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts

@@ -35,7 +35,7 @@ import {
   BigNumberWithTrendlineChartProps,
   TimeSeriesDatum,
 } from '../types';
-import { getDateFormatter, parseMetricValue, getOriginalLabel } from '../utils';
+import { getDateFormatter, parseMetricValue } from '../utils';
 import { getDefaultTooltip } from '../../utils/tooltip';
 import { Refs } from '../../types';
 
@@ -62,7 +62,6 @@ export default function transformProps(
     compareLag: compareLag_,
     compareSuffix = '',
     timeFormat,
-    metricNameFontSize,
     headerFontSize,
     metric = 'value',
     showTimestamp,
@@ -97,9 +96,6 @@ export default function transformProps(
   const aggregatedData = hasAggregatedData ? aggregatedQueryData.data[0] : null;
   const refs: Refs = {};
   const metricName = getMetricLabel(metric);
-  const metrics = chartProps.datasource?.metrics || [];
-  const originalLabel = getOriginalLabel(metric, metrics);
-  const showMetricName = chartProps.rawFormData?.show_metric_name ?? false;
   const compareLag = Number(compareLag_) || 0;
   let formattedSubheader = subheader;
 
@@ -307,9 +303,6 @@ export default function transformProps(
     headerFormatter,
     formatTime,
     formData,
-    metricName: originalLabel,
-    showMetricName,
-    metricNameFontSize,
     headerFontSize,
     subtitleFontSize,
     subtitle,

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/sharedControls.ts

@@ -21,68 +21,106 @@
 import { t } from '@superset-ui/core';
 import { CustomControlItem } from '@superset-ui/chart-controls';
 
-const FONT_SIZE_OPTIONS_SMALL = [
+export const headerFontSize: CustomControlItem = {
-  { label: t('Tiny'), value: 0.125 },
+  name: 'header_font_size',
-  { label: t('Small'), value: 0.15 },
+  config: {
-  { label: t('Normal'), value: 0.2 },
+    type: 'SelectControl',
-  { label: t('Large'), value: 0.3 },
+    label: t('Big Number Font Size'),
-  { label: t('Huge'), value: 0.4 },
+    renderTrigger: true,
-];
+    clearable: false,
+    default: 0.4,
+    // Values represent the percentage of space a header should take
+    options: [
+      {
+        label: t('Tiny'),
+        value: 0.2,
+      },
+      {
+        label: t('Small'),
+        value: 0.3,
+      },
+      {
+        label: t('Normal'),
+        value: 0.4,
+      },
+      {
+        label: t('Large'),
+        value: 0.5,
+      },
+      {
+        label: t('Huge'),
+        value: 0.6,
+      },
+    ],
+  },
+};
 
-const FONT_SIZE_OPTIONS_LARGE = [
+export const subtitleFontSize: CustomControlItem = {
-  { label: t('Tiny'), value: 0.2 },
+  name: 'subtitle_font_size',
-  { label: t('Small'), value: 0.3 },
+  config: {
-  { label: t('Normal'), value: 0.4 },
+    type: 'SelectControl',
-  { label: t('Large'), value: 0.5 },
+    label: t('Subtitle Font Size'),
-  { label: t('Huge'), value: 0.6 },
+    renderTrigger: true,
-];
+    clearable: false,
-
+    default: 0.15,
-function makeFontSizeControl(
+    // Values represent the percentage of space a subtitle should take
-  name: string,
+    options: [
-  label: string,
+      {
-  defaultValue: number,
+        label: t('Tiny'),
-  options: { label: string; value: number }[],
+        value: 0.125,
-): CustomControlItem {
+      },
-  return {
+      {
-    name,
+        label: t('Small'),
-    config: {
+        value: 0.15,
-      type: 'SelectControl',
+      },
-      label: t(label),
+      {
-      renderTrigger: true,
+        label: t('Normal'),
-      clearable: false,
+        value: 0.2,
-      default: defaultValue,
+      },
-      options,
+      {
-    },
+        label: t('Large'),
-  };
+        value: 0.3,
-}
+      },
-
+      {
-export const headerFontSize = makeFontSizeControl(
+        label: t('Huge'),
-  'header_font_size',
+        value: 0.4,
-  'Big Number Font Size',
+      },
-  0.4,
+    ],
-  FONT_SIZE_OPTIONS_LARGE,
+  },
-);
+};
-
+export const subheaderFontSize: CustomControlItem = {
-export const subtitleFontSize = makeFontSizeControl(
+  name: 'subheader_font_size',
-  'subtitle_font_size',
+  config: {
-  'Subtitle Font Size',
+    type: 'SelectControl',
-  0.15,
+    label: t('Subheader Font Size'),
-  FONT_SIZE_OPTIONS_SMALL,
+    renderTrigger: true,
-);
+    clearable: false,
-
+    default: 0.15,
-export const subheaderFontSize = makeFontSizeControl(
+    // Values represent the percentage of space a subheader should take
-  'subheader_font_size',
+    options: [
-  'Subheader Font Size',
+      {
-  0.15,
+        label: t('Tiny'),
-  FONT_SIZE_OPTIONS_SMALL,
+        value: 0.125,
-);
+      },
-
+      {
-export const metricNameFontSize = makeFontSizeControl(
+        label: t('Small'),
-  'metric_name_font_size',
+        value: 0.15,
-  'Metric Name Font Size',
+      },
-  0.15,
+      {
-  FONT_SIZE_OPTIONS_SMALL,
+        label: t('Normal'),
-);
+        value: 0.2,
+      },
+      {
+        label: t('Large'),
+        value: 0.3,
+      },
+      {
+        label: t('Huge'),
+        value: 0.4,
+      },
+    ],
+  },
+};
 
 export const subtitleControl: CustomControlItem = {
   name: 'subtitle',
@@ -93,23 +131,3 @@ export const subtitleControl: CustomControlItem = {
     description: t('Description text that shows up below your Big Number'),
   },
 };
-
-export const showMetricNameControl: CustomControlItem = {
-  name: 'show_metric_name',
-  config: {
-    type: 'CheckboxControl',
-    label: t('Show Metric Name'),
-    renderTrigger: true,
-    default: false,
-    description: t('Whether to display the metric name'),
-  },
-};
-
-export const metricNameFontSizeWithVisibility: CustomControlItem = {
-  ...metricNameFontSize,
-  config: {
-    ...metricNameFontSize.config,
-    visibility: ({ controls }) => controls?.show_metric_name?.value === true,
-    resetOnHide: false,
-  },
-};

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/types.ts

@@ -75,10 +75,6 @@ export type BigNumberVizProps = {
   bigNumberFallback?: TimeSeriesDatum;
   headerFormatter: ValueFormatter | TimeFormatter;
   formatTime?: TimeFormatter;
-  metricName?: string;
-  friendlyMetricName?: string;
-  metricNameFontSize?: number;
-  showMetricName?: boolean;
   headerFontSize: number;
   kickerFontSize?: number;
   subheader?: string;

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts

@@ -22,10 +22,6 @@ import utc from 'dayjs/plugin/utc';
 import {
   getTimeFormatter,
   getTimeFormatterForGranularity,
-  isAdhocMetricSimple,
-  isSavedMetric,
-  Metric,
-  QueryFormMetric,
   SMART_DATE_ID,
   TimeGranularity,
 } from '@superset-ui/core';
@@ -51,43 +47,3 @@ export const getDateFormatter = (
   timeFormat === SMART_DATE_ID
     ? getTimeFormatterForGranularity(granularity)
     : getTimeFormatter(timeFormat ?? fallbackFormat);
-
-export function getOriginalLabel(
-  metric: QueryFormMetric,
-  metrics: Metric[] = [],
-): string {
-  const metricLabel = typeof metric === 'string' ? metric : metric.label || '';
-
-  if (isSavedMetric(metric)) {
-    const metricEntry = metrics.find(m => m.metric_name === metric);
-    return (
-      metricEntry?.verbose_name ||
-      metricEntry?.metric_name ||
-      metric ||
-      'Unknown Metric'
-    );
-  }
-
-  if (isAdhocMetricSimple(metric)) {
-    const column = metric.column || {};
-    const columnName = column.column_name || 'unknown_column';
-    const verboseName = column.verbose_name || columnName;
-    const aggregate = metric.aggregate || 'UNKNOWN';
-    return metric.hasCustomLabel && metric.label
-      ? metric.label
-      : `${aggregate}(${verboseName})`;
-  }
-
-  if (
-    typeof metric === 'object' &&
-    'expressionType' in metric &&
-    metric.expressionType === 'SQL' &&
-    'sqlExpression' in metric
-  ) {
-    return metric.hasCustomLabel && metric.label
-      ? metric.label
-      : metricLabel || 'Custom Metric';
-  }
-
-  return metricLabel || 'Unknown Metric';
-}

superset-frontend/plugins/plugin-chart-echarts/src/Sankey/index.ts

@@ -57,7 +57,7 @@ export default class EchartsSankeyChartPlugin extends ChartPlugin<
         ),
         exampleGallery: [{ url: example1 }, { url: example2 }],
         name: t('Sankey Chart'),
-        tags: [t('Directional'), t('ECharts'), t('Distribution'), t('Flow')],
+        tags: [t('Directional'), t('Distribution'), t('Flow')],
         thumbnail,
       }),
       transformProps,

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/index.ts

@@ -58,7 +58,6 @@ export default class EchartsTimeseriesChartPlugin extends EchartsChartPlugin<
         name: t('Generic Chart'),
         tags: [
           t('Advanced-Analytics'),
-          t('ECharts'),
           t('Line'),
           t('Predictive'),
           t('Time'),

superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx

@@ -16,7 +16,6 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-/* eslint-disable import/no-extraneous-dependencies */
 import {
   useCallback,
   useRef,
@@ -25,7 +24,6 @@ import {
   MutableRefObject,
   CSSProperties,
   DragEvent,
-  useEffect,
 } from 'react';
 
 import {
@@ -41,9 +39,8 @@ import {
   Row,
 } from 'react-table';
 import { matchSorter, rankings } from 'match-sorter';
-import { styled, typedMemo, usePrevious } from '@superset-ui/core';
+import { typedMemo, usePrevious } from '@superset-ui/core';
 import { isEqual } from 'lodash';
-import { Space } from 'antd';
 import GlobalFilter, { GlobalFilterProps } from './components/GlobalFilter';
 import SelectPageSize, {
   SelectPageSizeProps,
@@ -53,8 +50,6 @@ import SimplePagination from './components/Pagination';
 import useSticky from './hooks/useSticky';
 import { PAGE_SIZE_OPTIONS } from '../consts';
 import { sortAlphanumericCaseInsensitive } from './utils/sortAlphanumericCaseInsensitive';
-import { SearchOption, SortByItem } from '../types';
-import SearchSelectDropdown from './components/SearchSelectDropdown';
 
 export interface DataTableProps<D extends object> extends TableOptions<D> {
   tableClassName?: string;
@@ -67,12 +62,7 @@ export interface DataTableProps<D extends object> extends TableOptions<D> {
   height?: string | number;
   serverPagination?: boolean;
   onServerPaginationChange: (pageNumber: number, pageSize: number) => void;
-  serverPaginationData: {
+  serverPaginationData: { pageSize?: number; currentPage?: number };
-    pageSize?: number;
-    currentPage?: number;
-    sortBy?: SortByItem[];
-    searchColumn?: string;
-  };
   pageSize?: number;
   noResults?: string | ((filterString: string) => ReactNode);
   sticky?: boolean;
@@ -81,14 +71,6 @@ export interface DataTableProps<D extends object> extends TableOptions<D> {
   onColumnOrderChange: () => void;
   renderGroupingHeaders?: () => JSX.Element;
   renderTimeComparisonDropdown?: () => JSX.Element;
-  handleSortByChange: (sortBy: SortByItem[]) => void;
-  sortByFromParent: SortByItem[];
-  manualSearch?: boolean;
-  onSearchChange?: (searchText: string) => void;
-  initialSearchText?: string;
-  searchInputId?: string;
-  onSearchColChange: (searchCol: string) => void;
-  searchOptions: SearchOption[];
 }
 
 export interface RenderHTMLCellProps extends HTMLProps<HTMLTableCellElement> {
@@ -99,20 +81,6 @@ const sortTypes = {
   alphanumeric: sortAlphanumericCaseInsensitive,
 };
 
-const StyledSpace = styled(Space)`
-  display: flex;
-  justify-content: flex-end;
-
-  .search-select-container {
-    display: flex;
-  }
-
-  .search-by-label {
-    align-self: center;
-    margin-right: 4px;
-  }
-`;
-
 // Be sure to pass our updateMyData and the skipReset option
 export default typedMemo(function DataTable<D extends object>({
   tableClassName,
@@ -137,14 +105,6 @@ export default typedMemo(function DataTable<D extends object>({
   onColumnOrderChange,
   renderGroupingHeaders,
   renderTimeComparisonDropdown,
-  handleSortByChange,
-  sortByFromParent = [],
-  manualSearch = false,
-  onSearchChange,
-  initialSearchText,
-  searchInputId,
-  onSearchColChange,
-  searchOptions,
   ...moreUseTableOptions
 }: DataTableProps<D>): JSX.Element {
   const tableHooks: PluginHook<D>[] = [
@@ -155,7 +115,6 @@ export default typedMemo(function DataTable<D extends object>({
     doSticky ? useSticky : [],
     hooks || [],
   ].flat();
-
   const columnNames = Object.keys(data?.[0] || {});
   const previousColumnNames = usePrevious(columnNames);
   const resultsSize = serverPagination ? rowCount : data.length;
@@ -168,8 +127,7 @@ export default typedMemo(function DataTable<D extends object>({
     ...initialState_,
     // zero length means all pages, the `usePagination` plugin does not
     // understand pageSize = 0
-    // sortBy: sortByRef.current,
+    sortBy: sortByRef.current,
-    sortBy: serverPagination ? sortByFromParent : sortByRef.current,
     pageSize: initialPageSize > 0 ? initialPageSize : resultsSize || 10,
   };
   const defaultWrapperRef = useRef<HTMLDivElement>(null);
@@ -230,13 +188,7 @@ export default typedMemo(function DataTable<D extends object>({
     wrapStickyTable,
     setColumnOrder,
     allColumns,
-    state: {
+    state: { pageIndex, pageSize, globalFilter: filterValue, sticky = {} },
-      pageIndex,
-      pageSize,
-      globalFilter: filterValue,
-      sticky = {},
-      sortBy,
-    },
   } = useTable<D>(
     {
       columns,
@@ -246,46 +198,10 @@ export default typedMemo(function DataTable<D extends object>({
       globalFilter: defaultGlobalFilter,
       sortTypes,
       autoResetSortBy: !isEqual(columnNames, previousColumnNames),
-      manualSortBy: !!serverPagination,
       ...moreUseTableOptions,
     },
     ...tableHooks,
   );
-
-  const handleSearchChange = useCallback(
-    (query: string) => {
-      if (manualSearch && onSearchChange) {
-        onSearchChange(query);
-      } else {
-        setGlobalFilter(query);
-      }
-    },
-    [manualSearch, onSearchChange, setGlobalFilter],
-  );
-
-  // updating the sort by to the own State of table viz
-  useEffect(() => {
-    const serverSortBy = serverPaginationData?.sortBy || [];
-
-    if (serverPagination && !isEqual(sortBy, serverSortBy)) {
-      if (Array.isArray(sortBy) && sortBy.length > 0) {
-        const [sortByItem] = sortBy;
-        const matchingColumn = columns.find(col => col?.id === sortByItem?.id);
-
-        if (matchingColumn && 'columnKey' in matchingColumn) {
-          const sortByWithColumnKey: SortByItem = {
-            ...sortByItem,
-            key: (matchingColumn as { columnKey: string }).columnKey,
-          };
-
-          handleSortByChange([sortByWithColumnKey]);
-        }
-      } else {
-        handleSortByChange([]);
-      }
-    }
-  }, [sortBy]);
-
   // make setPageSize accept 0
   const setPageSize = (size: number) => {
     if (serverPagination) {
@@ -439,7 +355,6 @@ export default typedMemo(function DataTable<D extends object>({
     resultOnPageChange = (pageNumber: number) =>
       onServerPaginationChange(pageNumber, serverPageSize);
   }
-
   return (
     <div
       ref={wrapperRef}
@@ -466,31 +381,16 @@ export default typedMemo(function DataTable<D extends object>({
               ) : null}
             </div>
             {searchInput ? (
-              <StyledSpace className="col-sm-6">
+              <div className="col-sm-6">
-                {serverPagination && (
-                  <div className="search-select-container">
-                    <span className="search-by-label">Search by: </span>
-                    <SearchSelectDropdown
-                      searchOptions={searchOptions}
-                      value={serverPaginationData?.searchColumn || ''}
-                      onChange={onSearchColChange}
-                    />
-                  </div>
-                )}
                 <GlobalFilter<D>
                   searchInput={
                     typeof searchInput === 'boolean' ? undefined : searchInput
                   }
                   preGlobalFilteredRows={preGlobalFilteredRows}
-                  setGlobalFilter={
+                  setGlobalFilter={setGlobalFilter}
-                    manualSearch ? handleSearchChange : setGlobalFilter
+                  filterValue={filterValue}
-                  }
-                  filterValue={manualSearch ? initialSearchText : filterValue}
-                  id={searchInputId}
-                  serverPagination={!!serverPagination}
-                  rowCount={rowCount}
                 />
-              </StyledSpace>
+              </div>
             ) : null}
             {renderTimeComparisonDropdown ? (
               <div

superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx

@@ -16,13 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import {
+import { memo, ComponentType, ChangeEventHandler } from 'react';
-  memo,
-  ComponentType,
-  ChangeEventHandler,
-  useRef,
-  useEffect,
-} from 'react';
 import { Row, FilterValue } from 'react-table';
 import useAsyncState from '../utils/useAsyncState';
 
@@ -30,12 +24,8 @@ export interface SearchInputProps {
   count: number;
   value: string;
   onChange: ChangeEventHandler<HTMLInputElement>;
-  onBlur?: () => void;
-  inputRef?: React.RefObject<HTMLInputElement>;
 }
 
-const isSearchFocused = new Map();
-
 export interface GlobalFilterProps<D extends object> {
   preGlobalFilteredRows: Row<D>[];
   // filter value cannot be `undefined` otherwise React will report component
@@ -43,28 +33,17 @@ export interface GlobalFilterProps<D extends object> {
   filterValue: string;
   setGlobalFilter: (filterValue: FilterValue) => void;
   searchInput?: ComponentType<SearchInputProps>;
-  id?: string;
-  serverPagination: boolean;
-  rowCount: number;
 }
 
-function DefaultSearchInput({
+function DefaultSearchInput({ count, value, onChange }: SearchInputProps) {
-  count,
-  value,
-  onChange,
-  onBlur,
-  inputRef,
-}: SearchInputProps) {
   return (
     <span className="dt-global-filter">
       Search{' '}
       <input
-        ref={inputRef}
         className="form-control input-sm"
         placeholder={`${count} records...`}
         value={value}
         onChange={onChange}
-        onBlur={onBlur}
       />
     </span>
   );
@@ -77,13 +56,8 @@ export default (memo as <T>(fn: T) => T)(function GlobalFilter<
   filterValue = '',
   searchInput,
   setGlobalFilter,
-  id = '',
-  serverPagination,
-  rowCount,
 }: GlobalFilterProps<D>) {
-  const count = serverPagination ? rowCount : preGlobalFilteredRows.length;
+  const count = preGlobalFilteredRows.length;
-  const inputRef = useRef<HTMLInputElement>(null);
-
   const [value, setValue] = useAsyncState(
     filterValue,
     (newValue: string) => {
@@ -92,37 +66,17 @@ export default (memo as <T>(fn: T) => T)(function GlobalFilter<
     200,
   );
 
-  // Preserve focus during server-side filtering to maintain a better user experience
-  useEffect(() => {
-    if (
-      serverPagination &&
-      isSearchFocused.get(id) &&
-      document.activeElement !== inputRef.current
-    ) {
-      inputRef.current?.focus();
-    }
-  }, [value, serverPagination]);
-
-  const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
-    const target = e.target as HTMLInputElement;
-    e.preventDefault();
-    isSearchFocused.set(id, true);
-    setValue(target.value);
-  };
-
-  const handleBlur = () => {
-    isSearchFocused.set(id, false);
-  };
-
   const SearchInput = searchInput || DefaultSearchInput;
 
   return (
     <SearchInput
       count={count}
       value={value}
-      inputRef={inputRef}
+      onChange={e => {
-      onChange={handleChange}
+        const target = e.target as HTMLInputElement;
-      onBlur={handleBlur}
+        e.preventDefault();
+        setValue(target.value);
+      }}
     />
   );
 });

superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx

@@ -1,53 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-/* eslint-disable import/no-extraneous-dependencies */
-import { styled } from '@superset-ui/core';
-import { Select } from 'antd';
-import { SearchOption } from '../../types';
-
-const StyledSelect = styled(Select)`
-  width: 120px;
-  margin-right: 8px;
-`;
-
-interface SearchSelectDropdownProps {
-  /** The currently selected search column value */
-  value?: string;
-  /** Callback triggered when a new search column is selected */
-  onChange: (searchCol: string) => void;
-  /** Available search column options to populate the dropdown */
-  searchOptions: SearchOption[];
-}
-
-function SearchSelectDropdown({
-  value,
-  onChange,
-  searchOptions,
-}: SearchSelectDropdownProps) {
-  return (
-    <StyledSelect
-      className="search-select"
-      value={value || (searchOptions?.[0]?.value ?? '')}
-      options={searchOptions}
-      onChange={onChange}
-    />
-  );
-}
-
-export default SearchSelectDropdown;

superset-frontend/plugins/plugin-chart-table/src/DataTable/types/react-table.d.ts

@@ -115,11 +115,3 @@ declare module 'react-table' {
     extends UseTableHooks<D>,
       UseSortByHooks<D> {}
 }
-
-interface TableOwnState {
-  currentPage?: number;
-  pageSize?: number;
-  sortColumn?: string;
-  sortOrder?: 'asc' | 'desc';
-  searchText?: string;
-}

superset-frontend/plugins/plugin-chart-table/src/DataTable/utils/externalAPIs.ts

@@ -18,7 +18,6 @@
  */
 
 import { SetDataMaskHook } from '@superset-ui/core';
-import { TableOwnState } from '../types/react-table';
 
 export const updateExternalFormData = (
   setDataMask: SetDataMaskHook = () => {},
@@ -31,11 +30,3 @@ export const updateExternalFormData = (
       pageSize,
     },
   });
-
-export const updateTableOwnState = (
-  setDataMask: SetDataMaskHook = () => {},
-  modifiedOwnState: TableOwnState,
-) =>
-  setDataMask({
-    ownState: modifiedOwnState,
-  });

superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx

@@ -24,7 +24,6 @@ import {
   useState,
   MouseEvent,
   KeyboardEvent as ReactKeyboardEvent,
-  useEffect,
 } from 'react';
 
 import {
@@ -62,12 +61,10 @@ import {
   PlusCircleOutlined,
   TableOutlined,
 } from '@ant-design/icons';
-import { debounce, isEmpty, isEqual } from 'lodash';
+import { isEmpty } from 'lodash';
 import {
   ColorSchemeEnum,
   DataColumnMeta,
-  SearchOption,
-  SortByItem,
   TableChartTransformedProps,
 } from './types';
 import DataTable, {
@@ -80,7 +77,7 @@ import DataTable, {
 import Styles from './Styles';
 import { formatColumnValue } from './utils/formatValue';
 import { PAGE_SIZE_OPTIONS } from './consts';
-import { updateTableOwnState } from './DataTable/utils/externalAPIs';
+import { updateExternalFormData } from './DataTable/utils/externalAPIs';
 import getScrollBarSize from './DataTable/utils/getScrollBarSize';
 
 type ValueRange = [number, number];
@@ -179,26 +176,20 @@ function SortIcon<D extends object>({ column }: { column: ColumnInstance<D> }) {
   return sortIcon;
 }
 
-const SearchInput = ({
+function SearchInput({ count, value, onChange }: SearchInputProps) {
-  count,
+  return (
-  value,
+    <span className="dt-global-filter">
-  onChange,
+      {t('Search')}{' '}
-  onBlur,
+      <input
-  inputRef,
+        aria-label={t('Search %s records', count)}
-}: SearchInputProps) => (
+        className="form-control input-sm"
-  <span className="dt-global-filter">
+        placeholder={tn('search.num_records', count)}
-    {t('Search')}{' '}
+        value={value}
-    <input
+        onChange={onChange}
-      ref={inputRef}
+      />
-      aria-label={t('Search %s records', count)}
+    </span>
-      className="form-control input-sm"
+  );
-      placeholder={tn('search.num_records', count)}
+}
-      value={value}
-      onChange={onChange}
-      onBlur={onBlur}
-    />
-  </span>
-);
 
 function SelectPageSize({
   options,
@@ -276,9 +267,6 @@ export default function TableChart<D extends DataRecord = DataRecord>(
     isUsingTimeComparison,
     basicColorFormatters,
     basicColorColumnFormatters,
-    hasServerPageLengthChanged,
-    serverPageLength,
-    slice_id,
   } = props;
   const comparisonColumns = [
     { key: 'all', label: t('Display all') },
@@ -691,12 +679,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
   );
 
   const getColumnConfigs = useCallback(
-    (
+    (column: DataColumnMeta, i: number): ColumnWithLooseAccessor<D> => {
-      column: DataColumnMeta,
-      i: number,
-    ): ColumnWithLooseAccessor<D> & {
-      columnKey: string;
-    } => {
       const {
         key,
         label: originalLabel,
@@ -783,7 +766,6 @@ export default function TableChart<D extends DataRecord = DataRecord>(
         // must use custom accessor to allow `.` in column names
         // typing is incorrect in current version of `@types/react-table`
         // so we ask TS not to check.
-        columnKey: key,
         accessor: ((datum: D) => datum[key]) as never,
         Cell: ({ value, row }: { value: DataRecordValue; row: Row<D> }) => {
           const [isHtml, text] = formatColumnValue(column, value);
@@ -1076,50 +1058,13 @@ export default function TableChart<D extends DataRecord = DataRecord>(
     [visibleColumnsMeta, getColumnConfigs],
   );
 
-  const [searchOptions, setSearchOptions] = useState<SearchOption[]>([]);
-
-  useEffect(() => {
-    const options = (
-      columns as unknown as ColumnWithLooseAccessor &
-        {
-          columnKey: string;
-          sortType?: string;
-        }[]
-    )
-      .filter(col => col?.sortType === 'alphanumeric')
-      .map(column => ({
-        value: column.columnKey,
-        label: column.columnKey,
-      }));
-
-    if (!isEqual(options, searchOptions)) {
-      setSearchOptions(options || []);
-    }
-  }, [columns]);
-
   const handleServerPaginationChange = useCallback(
     (pageNumber: number, pageSize: number) => {
-      const modifiedOwnState = {
+      updateExternalFormData(setDataMask, pageNumber, pageSize);
-        ...serverPaginationData,
-        currentPage: pageNumber,
-        pageSize,
-      };
-      updateTableOwnState(setDataMask, modifiedOwnState);
     },
     [setDataMask],
   );
 
-  useEffect(() => {
-    if (hasServerPageLengthChanged) {
-      const modifiedOwnState = {
-        ...serverPaginationData,
-        currentPage: 0,
-        pageSize: serverPageLength,
-      };
-      updateTableOwnState(setDataMask, modifiedOwnState);
-    }
-  }, []);
-
   const handleSizeChange = useCallback(
     ({ width, height }: { width: number; height: number }) => {
       setTableSize({ width, height });
@@ -1155,42 +1100,6 @@ export default function TableChart<D extends DataRecord = DataRecord>(
 
   const { width: widthFromState, height: heightFromState } = tableSize;
 
-  const handleSortByChange = useCallback(
-    (sortBy: SortByItem[]) => {
-      if (!serverPagination) return;
-      const modifiedOwnState = {
-        ...serverPaginationData,
-        sortBy,
-      };
-      updateTableOwnState(setDataMask, modifiedOwnState);
-    },
-    [setDataMask, serverPagination],
-  );
-
-  const handleSearch = (searchText: string) => {
-    const modifiedOwnState = {
-      ...(serverPaginationData || {}),
-      searchColumn:
-        serverPaginationData?.searchColumn || searchOptions[0]?.value,
-      searchText,
-      currentPage: 0, // Reset to first page when searching
-    };
-    updateTableOwnState(setDataMask, modifiedOwnState);
-  };
-
-  const debouncedSearch = debounce(handleSearch, 800);
-
-  const handleChangeSearchCol = (searchCol: string) => {
-    if (!isEqual(searchCol, serverPaginationData?.searchColumn)) {
-      const modifiedOwnState = {
-        ...(serverPaginationData || {}),
-        searchColumn: searchCol,
-        searchText: '',
-      };
-      updateTableOwnState(setDataMask, modifiedOwnState);
-    }
-  };
-
   return (
     <Styles>
       <DataTable<D>
@@ -1206,9 +1115,6 @@ export default function TableChart<D extends DataRecord = DataRecord>(
         serverPagination={serverPagination}
         onServerPaginationChange={handleServerPaginationChange}
         onColumnOrderChange={() => setColumnOrderToggle(!columnOrderToggle)}
-        initialSearchText={serverPaginationData?.searchText || ''}
-        sortByFromParent={serverPaginationData?.sortBy || []}
-        searchInputId={`${slice_id}-search`}
         // 9 page items in > 340px works well even for 100+ pages
         maxPageItemCount={width > 340 ? 9 : 7}
         noResults={getNoResultsMessage}
@@ -1222,11 +1128,6 @@ export default function TableChart<D extends DataRecord = DataRecord>(
         renderTimeComparisonDropdown={
           isUsingTimeComparison ? renderTimeComparisonDropdown : undefined
         }
-        handleSortByChange={handleSortByChange}
-        onSearchColChange={handleChangeSearchCol}
-        manualSearch={serverPagination}
-        onSearchChange={debouncedSearch}
-        searchOptions={searchOptions}
       />
     </Styles>
   );

superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts

@@ -22,7 +22,6 @@ import {
   ensureIsArray,
   getMetricLabel,
   isPhysicalColumn,
-  QueryFormOrderBy,
   QueryMode,
   QueryObject,
   removeDuplicates,
@@ -35,7 +34,7 @@ import {
 } from '@superset-ui/chart-controls';
 import { isEmpty } from 'lodash';
 import { TableChartFormData } from './types';
-import { updateTableOwnState } from './DataTable/utils/externalAPIs';
+import { updateExternalFormData } from './DataTable/utils/externalAPIs';
 
 /**
  * Infer query mode from form data. If `all_columns` is set, then raw records mode,
@@ -192,40 +191,18 @@ const buildQuery: BuildQuery<TableChartFormData> = (
 
     const moreProps: Partial<QueryObject> = {};
     const ownState = options?.ownState ?? {};
-    // Build Query flag to check if its for either download as csv, excel or json
+    if (formDataCopy.server_pagination) {
-    const isDownloadQuery =
+      moreProps.row_limit =
-      ['csv', 'xlsx'].includes(formData?.result_format || '') ||
+        ownState.pageSize ?? formDataCopy.server_page_length;
-      (formData?.result_format === 'json' &&
+      moreProps.row_offset =
-        formData?.result_type === 'results');
+        (ownState.currentPage ?? 0) * (ownState.pageSize ?? 0);
-
-    if (isDownloadQuery) {
-      moreProps.row_limit = Number(formDataCopy.row_limit) || 0;
-      moreProps.row_offset = 0;
-    }
-
-    if (!isDownloadQuery && formDataCopy.server_pagination) {
-      const pageSize = ownState.pageSize ?? formDataCopy.server_page_length;
-      const currentPage = ownState.currentPage ?? 0;
-
-      moreProps.row_limit = pageSize;
-      moreProps.row_offset = currentPage * pageSize;
-    }
-
-    // getting sort by in case of server pagination from own state
-    let sortByFromOwnState: QueryFormOrderBy[] | undefined;
-    if (Array.isArray(ownState?.sortBy) && ownState?.sortBy.length > 0) {
-      const sortByItem = ownState?.sortBy[0];
-      sortByFromOwnState = [[sortByItem?.key, !sortByItem?.desc]];
     }
 
     let queryObject = {
       ...baseQueryObject,
       columns,
       extras,
-      orderby:
+      orderby,
-        formData.server_pagination && sortByFromOwnState
-          ? sortByFromOwnState
-          : orderby,
       metrics,
       post_processing: postProcessing,
       time_offsets: timeOffsets,
@@ -239,12 +216,11 @@ const buildQuery: BuildQuery<TableChartFormData> = (
         JSON.stringify(queryObject.filters)
     ) {
       queryObject = { ...queryObject, row_offset: 0 };
-      const modifiedOwnState = {
+      updateExternalFormData(
-        ...(options?.ownState || {}),
+        options?.hooks?.setDataMask,
-        currentPage: 0,
+        0,
-        pageSize: queryObject.row_limit ?? 0,
+        queryObject.row_limit ?? 0,
-      };
+      );
-      updateTableOwnState(options?.hooks?.setDataMask, modifiedOwnState);
     }
     // Because we use same buildQuery for all table on the page we need split them by id
     options?.hooks?.setCachedChanges({
@@ -276,32 +252,12 @@ const buildQuery: BuildQuery<TableChartFormData> = (
     }
 
     if (formData.server_pagination) {
-      // Add search filter if search text exists
-      if (ownState.searchText && ownState?.searchColumn) {
-        queryObject = {
-          ...queryObject,
-          filters: [
-            ...(queryObject.filters || []),
-            {
-              col: ownState?.searchColumn,
-              op: 'ILIKE',
-              val: `${ownState.searchText}%`,
-            },
-          ],
-        };
-      }
-    }
-
-    // Now since row limit control is always visible even
-    // in case of server pagination
-    // we must use row limit from form data
-    if (formData.server_pagination && !isDownloadQuery) {
       return [
         { ...queryObject },
         {
           ...queryObject,
           time_offsets: [],
-          row_limit: Number(formData?.row_limit) ?? 0,
+          row_limit: 0,
           row_offset: 0,
           post_processing: [],
           is_rowcount: true,

superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx

@@ -28,10 +28,7 @@ import {
   ControlStateMapping,
   D3_TIME_FORMAT_OPTIONS,
   Dataset,
-  DEFAULT_MAX_ROW,
-  DEFAULT_MAX_ROW_TABLE_SERVER,
   defineSavedMetrics,
-  formatSelectOptions,
   getStandardizedControls,
   QueryModeLabel,
   sections,
@@ -43,14 +40,11 @@ import {
   getMetricLabel,
   isAdhocColumn,
   isPhysicalColumn,
-  legacyValidateInteger,
   QueryFormColumn,
   QueryFormMetric,
   QueryMode,
   SMART_DATE_ID,
   t,
-  validateMaxValue,
-  validateServerPagination,
 } from '@superset-ui/core';
 
 import { isEmpty, last } from 'lodash';
@@ -194,15 +188,6 @@ const processComparisonColumns = (columns: any[], suffix: string) =>
     })
     .flat();
 
-/*
-Options for row limit control
-*/
-
-export const ROW_LIMIT_OPTIONS_TABLE = [
-  10, 50, 100, 250, 500, 1000, 5000, 10000, 50000, 100000, 150000, 200000,
-  250000, 300000, 350000, 400000, 450000, 500000,
-];
-
 const config: ControlPanelConfig = {
   controlPanelSections: [
     {
@@ -357,6 +342,14 @@ const config: ControlPanelConfig = {
           },
         ],
         [
+          {
+            name: 'row_limit',
+            override: {
+              default: 1000,
+              visibility: ({ controls }: ControlPanelsContainerProps) =>
+                !controls?.server_pagination?.value,
+            },
+          },
           {
             name: 'server_page_length',
             config: {
@@ -371,47 +364,6 @@ const config: ControlPanelConfig = {
             },
           },
         ],
-        [
-          {
-            name: 'row_limit',
-            config: {
-              type: 'SelectControl',
-              freeForm: true,
-              label: t('Row limit'),
-              clearable: false,
-              mapStateToProps: state => ({
-                maxValue: state?.common?.conf?.TABLE_VIZ_MAX_ROW_SERVER,
-                server_pagination: state?.form_data?.server_pagination,
-                maxValueWithoutServerPagination:
-                  state?.common?.conf?.SQL_MAX_ROW,
-              }),
-              validators: [
-                legacyValidateInteger,
-                (v, state) =>
-                  validateMaxValue(
-                    v,
-                    state?.maxValue || DEFAULT_MAX_ROW_TABLE_SERVER,
-                  ),
-                (v, state) =>
-                  validateServerPagination(
-                    v,
-                    state?.server_pagination,
-                    state?.maxValueWithoutServerPagination || DEFAULT_MAX_ROW,
-                  ),
-              ],
-              // Re run the validations when this control value
-              validationDependancies: ['server_pagination'],
-              default: 10000,
-              choices: formatSelectOptions(ROW_LIMIT_OPTIONS_TABLE),
-              description: t(
-                'Limits the number of the rows that are computed in the query that is the source of the data used for this chart.',
-              ),
-            },
-            override: {
-              default: 1000,
-            },
-          },
-        ],
         [
           {
             name: 'order_desc',

superset-frontend/plugins/plugin-chart-table/src/transformProps.ts

@@ -90,15 +90,6 @@ const processDataRecords = memoizeOne(function processDataRecords(
   return data;
 });
 
-// Create a map to store cached values per slice
-const sliceCache = new Map<
-  number,
-  {
-    cachedServerLength: number;
-    passedColumns?: DataColumnMeta[];
-  }
->();
-
 const calculateDifferences = (
   originalValue: number,
   comparisonValue: number,
@@ -489,7 +480,6 @@ const transformProps = (
     comparison_color_enabled: comparisonColorEnabled = false,
     comparison_color_scheme: comparisonColorScheme = ColorSchemeEnum.Green,
     comparison_type,
-    slice_id,
   } = formData;
   const isUsingTimeComparison =
     !isEmpty(time_compare) &&
@@ -685,26 +675,6 @@ const transformProps = (
     conditionalFormatting,
   );
 
-  // Get cached values for this slice
-  const cachedValues = sliceCache.get(slice_id);
-  let hasServerPageLengthChanged = false;
-
-  if (
-    cachedValues?.cachedServerLength !== undefined &&
-    cachedValues.cachedServerLength !== serverPageLength
-  ) {
-    hasServerPageLengthChanged = true;
-  }
-
-  // Update cache with new values
-  sliceCache.set(slice_id, {
-    cachedServerLength: serverPageLength,
-    passedColumns:
-      Array.isArray(passedColumns) && passedColumns?.length > 0
-        ? passedColumns
-        : cachedValues?.passedColumns,
-  });
-
   const startDateOffset = chartProps.rawFormData?.start_date_offset;
   return {
     height,
@@ -712,10 +682,7 @@ const transformProps = (
     isRawRecords: queryMode === QueryMode.Raw,
     data: passedData,
     totals,
-    columns:
+    columns: passedColumns,
-      Array.isArray(passedColumns) && passedColumns?.length > 0
-        ? passedColumns
-        : cachedValues?.passedColumns || [],
     serverPagination,
     metrics,
     percentMetrics,
@@ -730,9 +697,7 @@ const transformProps = (
     includeSearch,
     rowCount,
     pageSize: serverPagination
-      ? serverPaginationData?.pageSize
+      ? serverPageLength
-        ? serverPaginationData?.pageSize
-        : serverPageLength
       : getPageSize(pageLength, data.length, columns.length),
     filters: filterState.filters,
     emitCrossFilters,
@@ -746,9 +711,6 @@ const transformProps = (
     basicColorFormatters,
     startDateOffset,
     basicColorColumnFormatters,
-    hasServerPageLengthChanged,
-    serverPageLength,
-    slice_id,
   };
 };
 

superset-frontend/plugins/plugin-chart-table/src/types.ts

@@ -114,32 +114,13 @@ export type BasicColorFormatterType = {
   mainArrow: string;
 };
 
-export type SortByItem = {
-  id: string;
-  key: string;
-  desc?: boolean;
-};
-
-export type SearchOption = {
-  value: string;
-  label: string;
-};
-
-export interface ServerPaginationData {
-  pageSize?: number;
-  currentPage?: number;
-  sortBy?: SortByItem[];
-  searchText?: string;
-  searchColumn?: string;
-}
-
 export interface TableChartTransformedProps<D extends DataRecord = DataRecord> {
   timeGrain?: TimeGranularity;
   height: number;
   width: number;
   rowCount?: number;
   serverPagination: boolean;
-  serverPaginationData: ServerPaginationData;
+  serverPaginationData: { pageSize?: number; currentPage?: number };
   setDataMask: SetDataMaskHook;
   isRawRecords?: boolean;
   data: D[];
@@ -171,11 +152,6 @@ export interface TableChartTransformedProps<D extends DataRecord = DataRecord> {
   basicColorFormatters?: { [Key: string]: BasicColorFormatterType }[];
   basicColorColumnFormatters?: { [Key: string]: BasicColorFormatterType }[];
   startDateOffset?: string;
-  // For explore page to reset the server Pagination data
-  // if server page length is changed from control panel
-  hasServerPageLengthChanged: boolean;
-  serverPageLength: number;
-  slice_id: number;
 }
 
 export enum ColorSchemeEnum {

superset-frontend/src/components/Chart/ChartRenderer.jsx

@@ -327,10 +327,6 @@ class ChartRenderer extends Component {
       ?.behaviors.find(behavior => behavior === Behavior.DrillToDetail)
       ? { inContextMenu: this.state.inContextMenu }
       : {};
-    // By pass no result component when server pagination is enabled & the table has a backend search query
-    const bypassNoResult = !(
-      formData?.server_pagination && (ownState?.searchText?.length || 0) > 0
-    );
 
     return (
       <>
@@ -371,7 +367,6 @@ class ChartRenderer extends Component {
             postTransformProps={postTransformProps}
             emitCrossFilters={emitCrossFilters}
             legendState={this.state.legendState}
-            enableNoResults={bypassNoResult}
             {...drillToDetailProps}
           />
         </div>

superset-frontend/src/components/Datasource/DatasourceEditor.jsx

@@ -34,7 +34,6 @@ import {
   t,
   withTheme,
   getClientErrorObject,
-  getExtensionsRegistry,
 } from '@superset-ui/core';
 import { Select, AsyncSelect, Row, Col } from 'src/components';
 import { FormLabel } from 'src/components/Form';
@@ -54,15 +53,10 @@ import SpatialControl from 'src/explore/components/controls/SpatialControl';
 import withToasts from 'src/components/MessageToasts/withToasts';
 import { Icons } from 'src/components/Icons';
 import CurrencyControl from 'src/explore/components/controls/CurrencyControl';
-import { executeQuery, resetDatabaseState } from 'src/database/actions';
-import { connect } from 'react-redux';
 import CollectionTable from './CollectionTable';
 import Fieldset from './Fieldset';
 import Field from './Field';
 import { fetchSyncedColumns, updateColumns } from './utils';
-import FilterableTable from '../FilterableTable';
-
-const extensionsRegistry = getExtensionsRegistry();
 
 const DatasourceContainer = styled.div`
   .change-warning {
@@ -592,8 +586,6 @@ function OwnersSelector({ datasource, onChange }) {
     />
   );
 }
-const ResultTable =
-  extensionsRegistry.get('sqleditor.extension.resultTable') ?? FilterableTable;
 
 class DatasourceEditor extends PureComponent {
   constructor(props) {
@@ -706,23 +698,6 @@ class DatasourceEditor extends PureComponent {
     this.validate(this.onChange);
   }
 
-  async onQueryRun() {
-    this.props.runQuery({
-      client_id: this.props.clientId,
-      database_id: this.state.datasource.database.id,
-      json: true,
-      runAsync: false,
-      catalog: this.state.datasource.catalog,
-      schema: this.state.datasource.schema,
-      sql: this.state.datasource.sql,
-      tmp_table_name: '',
-      select_as_cta: false,
-      ctas_method: 'TABLE',
-      queryLimit: 25,
-      expand_data: true,
-    });
-  }
-
   tableChangeAndSyncMetadata() {
     this.validate(() => {
       this.syncMetadata();
@@ -1103,62 +1078,14 @@ class DatasourceEditor extends PureComponent {
                       <TextAreaControl
                         language="sql"
                         offerEditInModal={false}
-                        minLines={10}
+                        minLines={20}
                         maxLines={Infinity}
                         readOnly={!this.state.isEditMode}
                         resize="both"
                         tooltipOptions={sqlTooltipOptions}
                       />
                     }
-                    additionalControl={
-                      <div
-                        css={css`
-                          position: absolute;
-                          right: 0;
-                          top: 0;
-                          z-index: 2;
-                        `}
-                      >
-                        <Button
-                          css={css`
-                            align-self: flex-end;
-                            height: 24px;
-                            padding-left: 6px;
-                            padding-right: 6px;
-                          `}
-                          size="small"
-                          buttonStyle="primary"
-                          onClick={() => {
-                            this.onQueryRun();
-                          }}
-                        >
-                          <Icons.CaretRightFilled
-                            iconSize="s"
-                            css={theme => ({
-                              color: theme.colors.grayscale.light5,
-                            })}
-                          />
-                        </Button>
-                      </div>
-                    }
-                    errorMessage={
-                      this.props.database?.error && t('Error executing query.')
-                    }
                   />
-                  {this.props.database?.queryResult && (
-                    <ResultTable
-                      data={this.props.database.queryResult.data}
-                      queryId={this.props.database.queryResult.query.id}
-                      orderedColumnKeys={this.props.database.queryResult.columns.map(
-                        col => col.column_name,
-                      )}
-                      height={100}
-                      expandedColumns={
-                        this.props.database.queryResult.expandedColumns
-                      }
-                      allowHTML
-                    />
-                  )}
                 </>
               )}
             </div>
@@ -1539,10 +1466,6 @@ class DatasourceEditor extends PureComponent {
       </DatasourceContainer>
     );
   }
-
-  componentWillUnmount() {
-    this.props.resetQuery();
-  }
 }
 
 DatasourceEditor.defaultProps = defaultProps;
@@ -1550,14 +1473,4 @@ DatasourceEditor.propTypes = propTypes;
 
 const DataSourceComponent = withTheme(DatasourceEditor);
 
-const mapDispatchToProps = dispatch => ({
+export default withToasts(DataSourceComponent);
-  runQuery: payload => dispatch(executeQuery(payload)),
-  resetQuery: () => dispatch(resetDatabaseState()),
-});
-const mapStateToProps = state => ({
-  test: state.queryApi,
-  database: state.database,
-});
-export default withToasts(
-  connect(mapStateToProps, mapDispatchToProps)(DataSourceComponent),
-);

superset-frontend/src/components/Datasource/DatasourceModal.tsx

@@ -120,83 +120,71 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
   const [isEditing, setIsEditing] = useState<boolean>(false);
   const dialog = useRef<any>(null);
   const [modal, contextHolder] = Modal.useModal();
-  const buildPayload = (datasource: Record<string, any>) => {
+  const buildPayload = (datasource: Record<string, any>) => ({
-    const payload: Record<string, any> = {
+    table_name: datasource.table_name,
-      table_name: datasource.table_name,
+    database_id: datasource.database?.id,
-      database_id: datasource.database?.id,
+    sql: datasource.sql,
-      sql: datasource.sql,
+    filter_select_enabled: datasource.filter_select_enabled,
-      filter_select_enabled: datasource.filter_select_enabled,
+    fetch_values_predicate: datasource.fetch_values_predicate,
-      fetch_values_predicate: datasource.fetch_values_predicate,
+    schema:
-      schema:
+      datasource.tableSelector?.schema ||
-        datasource.tableSelector?.schema ||
+      datasource.databaseSelector?.schema ||
-        datasource.databaseSelector?.schema ||
+      datasource.schema,
-        datasource.schema,
+    description: datasource.description,
-      description: datasource.description,
+    main_dttm_col: datasource.main_dttm_col,
-      main_dttm_col: datasource.main_dttm_col,
+    normalize_columns: datasource.normalize_columns,
-      normalize_columns: datasource.normalize_columns,
+    always_filter_main_dttm: datasource.always_filter_main_dttm,
-      always_filter_main_dttm: datasource.always_filter_main_dttm,
+    offset: datasource.offset,
-      offset: datasource.offset,
+    default_endpoint: datasource.default_endpoint,
-      default_endpoint: datasource.default_endpoint,
+    cache_timeout:
-      cache_timeout:
+      datasource.cache_timeout === '' ? null : datasource.cache_timeout,
-        datasource.cache_timeout === '' ? null : datasource.cache_timeout,
+    is_sqllab_view: datasource.is_sqllab_view,
-      is_sqllab_view: datasource.is_sqllab_view,
+    template_params: datasource.template_params,
-      template_params: datasource.template_params,
+    extra: datasource.extra,
-      extra: datasource.extra,
+    is_managed_externally: datasource.is_managed_externally,
-      is_managed_externally: datasource.is_managed_externally,
+    external_url: datasource.external_url,
-      external_url: datasource.external_url,
+    metrics: datasource?.metrics?.map((metric: DatasetObject['metrics'][0]) => {
-      metrics: datasource?.metrics?.map(
+      const metricBody: any = {
-        (metric: DatasetObject['metrics'][0]) => {
+        expression: metric.expression,
-          const metricBody: any = {
+        description: metric.description,
-            expression: metric.expression,
+        metric_name: metric.metric_name,
-            description: metric.description,
+        metric_type: metric.metric_type,
-            metric_name: metric.metric_name,
+        d3format: metric.d3format || null,
-            metric_type: metric.metric_type,
+        currency: !isDefined(metric.currency)
-            d3format: metric.d3format || null,
+          ? null
-            currency: !isDefined(metric.currency)
+          : JSON.stringify(metric.currency),
-              ? null
+        verbose_name: metric.verbose_name,
-              : JSON.stringify(metric.currency),
+        warning_text: metric.warning_text,
-            verbose_name: metric.verbose_name,
+        uuid: metric.uuid,
-            warning_text: metric.warning_text,
+        extra: buildExtraJsonObject(metric),
-            uuid: metric.uuid,
+      };
-            extra: buildExtraJsonObject(metric),
+      if (!Number.isNaN(Number(metric.id))) {
-          };
+        metricBody.id = metric.id;
-          if (!Number.isNaN(Number(metric.id))) {
+      }
-            metricBody.id = metric.id;
+      return metricBody;
-          }
+    }),
-          return metricBody;
+    columns: datasource?.columns?.map(
-        },
+      (column: DatasetObject['columns'][0]) => ({
-      ),
+        id: typeof column.id === 'number' ? column.id : undefined,
-      columns: datasource?.columns?.map(
+        column_name: column.column_name,
-        (column: DatasetObject['columns'][0]) => ({
+        type: column.type,
-          id: typeof column.id === 'number' ? column.id : undefined,
+        advanced_data_type: column.advanced_data_type,
-          column_name: column.column_name,
+        verbose_name: column.verbose_name,
-          type: column.type,
+        description: column.description,
-          advanced_data_type: column.advanced_data_type,
+        expression: column.expression,
-          verbose_name: column.verbose_name,
+        filterable: column.filterable,
-          description: column.description,
+        groupby: column.groupby,
-          expression: column.expression,
+        is_active: column.is_active,
-          filterable: column.filterable,
+        is_dttm: column.is_dttm,
-          groupby: column.groupby,
+        python_date_format: column.python_date_format || null,
-          is_active: column.is_active,
+        uuid: column.uuid,
-          is_dttm: column.is_dttm,
+        extra: buildExtraJsonObject(column),
-          python_date_format: column.python_date_format || null,
+      }),
-          uuid: column.uuid,
+    ),
-          extra: buildExtraJsonObject(column),
+    owners: datasource.owners.map(
-        }),
+      (o: Record<string, number>) => o.value || o.id,
-      ),
+    ),
-      owners: datasource.owners.map(
+  });
-        (o: Record<string, number>) => o.value || o.id,
-      ),
-    };
-    // Handle catalog based on database's allow_multi_catalog setting
-    // If multi-catalog is disabled, don't include catalog in payload
-    // The backend will use the default catalog
-    // If multi-catalog is enabled, include the selected catalog
-    if (datasource.database?.allow_multi_catalog) {
-      payload.catalog = datasource.catalog;
-    }
-    return payload;
-  };
   const onConfirmSave = async () => {
     // Pull out extra fields into the extra object
     setIsSaving(true);

superset-frontend/src/components/Datasource/Field.test.tsx

@@ -29,20 +29,13 @@ const defaultProps = {
   onChange: jest.fn(),
   compact: false,
   inline: false,
-  additionalControl: (
-    <input type="button" data-test="mock-text-aditional-control" />
-  ),
 };
 
 test('should render', () => {
   const { container } = render(<Field {...defaultProps} />);
   expect(container).toBeInTheDocument();
 });
-test('should render with aditional control', () => {
+
-  const { getByTestId } = render(<Field {...defaultProps} />);
-  const additionalControl = getByTestId('mock-text-aditional-control');
-  expect(additionalControl).toBeInTheDocument();
-});
 test('should call onChange', () => {
   const { getByTestId } = render(<Field {...defaultProps} />);
   const textArea = getByTestId('mock-text-control');
@@ -54,9 +47,3 @@ test('should render compact', () => {
   render(<Field {...defaultProps} compact />);
   expect(screen.queryByText(defaultProps.description)).not.toBeInTheDocument();
 });
-test('shiuld render error message', () => {
-  const { getByText } = render(
-    <Field {...defaultProps} errorMessage="error message" />,
-  );
-  expect(getByText('error message')).toBeInTheDocument();
-});

superset-frontend/src/components/Datasource/Field.tsx

@@ -21,7 +21,6 @@ import { useCallback, ReactNode, ReactElement, cloneElement } from 'react';
 import { css, SupersetTheme } from '@superset-ui/core';
 import { Tooltip } from 'src/components/Tooltip';
 import { FormItem, FormLabel } from 'src/components/Form';
-import { Icons } from 'src/components/Icons';
 
 const formItemInlineCss = css`
   .ant-form-item-control-input-content {
@@ -29,17 +28,16 @@ const formItemInlineCss = css`
     flex-direction: row;
   }
 `;
+
 interface FieldProps<V> {
   fieldKey: string;
   value?: V;
   label: string;
   description?: ReactNode;
   control: ReactElement;
-  additionalControl?: ReactElement;
   onChange: (fieldKey: string, newValue: V) => void;
   compact: boolean;
   inline: boolean;
-  errorMessage?: string;
 }
 
 export default function Field<V>({
@@ -48,11 +46,9 @@ export default function Field<V>({
   label,
   description = null,
   control,
-  additionalControl,
   onChange = () => {},
   compact = false,
   inline,
-  errorMessage,
 }: FieldProps<V>) {
   const onControlChange = useCallback(
     newValue => {
@@ -66,51 +62,32 @@ export default function Field<V>({
     onChange: onControlChange,
   });
   return (
-    <div
+    <FormItem
-      css={
+      label={
-        additionalControl &&
+        <FormLabel className="m-r-5">
-        css`
+          {label || fieldKey}
-          position: relative;
+          {compact && description && (
-        `
+            <Tooltip id="field-descr" placement="right" title={description}>
+              {/* TODO: Remove fa-icon */}
+              {/* eslint-disable-next-line icons/no-fa-icons-usage */}
+              <i className="fa fa-info-circle m-l-5" />
+            </Tooltip>
+          )}
+        </FormLabel>
       }
+      css={inline && formItemInlineCss}
     >
-      {additionalControl}
+      {hookedControl}
-      <FormItem
+      {!compact && description && (
-        label={
-          <FormLabel className="m-r-5">
-            {label || fieldKey}
-            {compact && description && (
-              <Tooltip id="field-descr" placement="right" title={description}>
-                <Icons.InfoCircleFilled iconSize="s" className="m-l-5" />
-              </Tooltip>
-            )}
-          </FormLabel>
-        }
-        css={inline && formItemInlineCss}
-      >
-        {hookedControl}
-        {!compact && description && (
-          <div
-            css={(theme: SupersetTheme) => ({
-              color: theme.colors.grayscale.base,
-              [inline ? 'marginLeft' : 'marginTop']: theme.gridUnit,
-            })}
-          >
-            {description}
-          </div>
-        )}
-      </FormItem>
-      {errorMessage && (
         <div
           css={(theme: SupersetTheme) => ({
-            color: theme.colors.error.base,
+            color: theme.colors.grayscale.base,
-            marginTop: -16,
+            [inline ? 'marginLeft' : 'marginTop']: theme.gridUnit,
-            fontSize: theme.typography.sizes.s,
           })}
         >
-          {errorMessage}
+          {description}
         </div>
       )}
-    </div>
+    </FormItem>
   );
 }

superset-frontend/src/components/Icons/AntdEnhanced.tsx

@@ -34,7 +34,6 @@ import {
   CaretDownOutlined,
   CaretLeftOutlined,
   CaretRightOutlined,
-  CaretRightFilled,
   CalendarOutlined,
   CheckOutlined,
   CheckCircleOutlined,
@@ -135,7 +134,6 @@ const AntdIcons = {
   CaretDownOutlined,
   CaretLeftOutlined,
   CaretRightOutlined,
-  CaretRightFilled,
   CalendarOutlined,
   CheckOutlined,
   CheckCircleOutlined,

superset-frontend/src/dashboard/components/gridComponents/Row.jsx

@@ -51,7 +51,6 @@ import WithPopoverMenu from 'src/dashboard/components/menu/WithPopoverMenu';
 import { componentShape } from 'src/dashboard/util/propShapes';
 import backgroundStyleOptions from 'src/dashboard/util/backgroundStyleOptions';
 import { BACKGROUND_TRANSPARENT } from 'src/dashboard/util/constants';
-import { isEmbedded } from 'src/dashboard/util/isEmbedded';
 import { EMPTY_CONTAINER_Z_INDEX } from 'src/dashboard/constants';
 import { isCurrentUserBot } from 'src/utils/isBot';
 import { useDebouncedEffect } from '../../../explore/exploreUtils';
@@ -189,10 +188,7 @@ const Row = props => {
       observerDisabler = new IntersectionObserver(
         ([entry]) => {
           if (!entry.isIntersecting && isComponentVisibleRef.current) {
-            // Reference: https://www.w3.org/TR/intersection-observer/#dom-intersectionobserver-rootmargin
+            setIsInView(false);
-            if (!isEmbedded()) {
-              setIsInView(false);
-            }
           }
         },
         {

superset-frontend/src/dashboard/util/isEmbedded.ts

@@ -1,26 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-export const isEmbedded = () => {
-  try {
-    return window.self !== window.top || window.frameElement !== null;
-  } catch (e) {
-    return true;
-  }
-};

superset-frontend/src/database/actions.ts

@@ -1,68 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { makeApi } from '@superset-ui/core';
-import { ThunkDispatch } from 'redux-thunk';
-import { AnyAction } from 'redux';
-import { QueryExecutePayload, QueryExecuteResponse } from './types';
-
-export const executeQueryApi = makeApi<
-  QueryExecutePayload,
-  QueryExecuteResponse
->({
-  method: 'POST',
-  endpoint: '/api/v1/sqllab/execute',
-});
-
-export function setQueryIsLoading(isLoading: boolean) {
-  return {
-    type: 'SET_QUERY_IS_LOADING',
-    payload: isLoading,
-  };
-}
-export function setQueryResult(queryResult: QueryExecuteResponse) {
-  return {
-    type: 'SET_QUERY_RESULT',
-    payload: queryResult,
-  };
-}
-export function resetDatabaseState() {
-  return {
-    type: 'RESET_DATABASE_STATE',
-  };
-}
-export function setQueryError(error: string) {
-  return {
-    type: 'SET_QUERY_ERROR',
-    payload: error,
-  };
-}
-export function executeQuery(payload: QueryExecutePayload) {
-  return async function (dispatch: ThunkDispatch<any, undefined, AnyAction>) {
-    try {
-      dispatch(setQueryIsLoading(true));
-      const result = await executeQueryApi(payload);
-      dispatch(setQueryResult(result as QueryExecuteResponse));
-    } catch (error) {
-      dispatch(setQueryError(error.message));
-    } finally {
-      dispatch(setQueryIsLoading(false));
-    }
-  };
-}

superset-frontend/src/database/reducers.ts

@@ -1,56 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import type { QueryAdhocState } from './types';
-
-const initialState: QueryAdhocState = {
-  isLoading: null,
-  sql: null,
-  queryResult: null,
-  error: null,
-};
-
-export default function databaseReducer(
-  state: QueryAdhocState = initialState,
-  action: any,
-): QueryAdhocState {
-  switch (action.type) {
-    case 'SET_QUERY_IS_LOADING':
-      return {
-        ...state,
-        isLoading: action.payload,
-      };
-    case 'SET_QUERY_RESULT':
-      return {
-        ...state,
-        sql: action.payload.query.sql ?? '',
-        queryResult: action.payload,
-        error: null,
-      };
-    case 'SET_QUERY_ERROR':
-      return {
-        ...initialState,
-        error: action.payload,
-      };
-    case 'RESET_DATABASE_STATE':
-      return initialState;
-    default:
-      return state;
-  }
-}

superset-frontend/src/database/types.ts

@@ -1,57 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-export interface QueryExecutePayload {
-  client_id: string;
-  database_id: number;
-  json: boolean;
-  runAsync: boolean;
-  catalog: string | null;
-  schema: string;
-  sql: string;
-  tmp_table_name: string;
-  select_as_cta: boolean;
-  ctas_method: string;
-  queryLimit: number;
-  expand_data: boolean;
-}
-export interface Column {
-  name: string;
-  type: string;
-  is_dttm: boolean;
-  type_generic: number;
-  is_hidden: boolean;
-  column_name: string;
-}
-export interface QueryExecuteResponse {
-  status: string;
-  query_id: string;
-  data: any[];
-  columns: Column[];
-  selected_columns: Column[];
-  expanded_columns: Column[];
-  query: any;
-}
-
-export interface QueryAdhocState {
-  isLoading: boolean | null;
-  sql: string | null;
-  queryResult: QueryExecuteResponse | null;
-  error: string | null;
-}

superset-frontend/src/embedded/index.tsx

@@ -23,7 +23,7 @@ import ReactDOM from 'react-dom';
 import { BrowserRouter as Router, Route } from 'react-router-dom';
 import { makeApi, t, logging } from '@superset-ui/core';
 import Switchboard from '@superset-ui/switchboard';
-import getBootstrapData, { applicationRoot } from 'src/utils/getBootstrapData';
+import getBootstrapData from 'src/utils/getBootstrapData';
 import setupClient from 'src/setup/setupClient';
 import setupPlugins from 'src/setup/setupPlugins';
 import { useUiConfig } from 'src/components/UiConfigContext';
@@ -94,7 +94,7 @@ const EmbeddedRoute = () => (
 );
 
 const EmbeddedApp = () => (
-  <Router basename={applicationRoot()}>
+  <Router>
     {/* todo (embedded) remove this line after uuids are deployed */}
     <Route path="/dashboard/:idOrSlug/embedded/" component={EmbeddedRoute} />
     <Route path="/embedded/:uuid/" component={EmbeddedRoute} />
@@ -187,7 +187,6 @@ function start() {
  */
 function setupGuestClient(guestToken: string) {
   setupClient({
-    appRoot: applicationRoot(),
     guestToken,
     guestTokenHeaderName: bootstrapData.config?.GUEST_TOKEN_HEADER_NAME,
     unauthorizedHandler: guestUnauthorizedHandler,

superset-frontend/src/explore/reducers/exploreReducer.js

@@ -214,52 +214,6 @@ export default function exploreReducer(state = {}, action) {
         currentControlsState = transformed.controlsState;
       }
 
-      const dependantControls = Object.entries(state.controls)
-        .filter(
-          ([, item]) =>
-            Array.isArray(item?.validationDependancies) &&
-            item.validationDependancies.includes(controlName),
-        )
-        .map(([key, item]) => ({
-          controlState: item,
-          dependantControlName: key,
-        }));
-
-      let updatedControlStates = {};
-      if (dependantControls.length > 0) {
-        const updatedControls = dependantControls.map(
-          ({ controlState, dependantControlName }) => {
-            // overwrite state form data with current control value as the redux state will not
-            // have latest action value
-            const overWrittenState = {
-              ...state,
-              form_data: {
-                ...state.form_data,
-                [controlName]: action.value,
-              },
-            };
-
-            return {
-              // Re run validation for dependant controls
-              controlState: getControlStateFromControlConfig(
-                controlState,
-                overWrittenState,
-                controlState?.value,
-              ),
-              dependantControlName,
-            };
-          },
-        );
-
-        updatedControlStates = updatedControls.reduce(
-          (acc, { controlState, dependantControlName }) => {
-            acc[dependantControlName] = { ...controlState };
-            return acc;
-          },
-          {},
-        );
-      }
-
       return {
         ...state,
         form_data: new_form_data,
@@ -273,7 +227,6 @@ export default function exploreReducer(state = {}, action) {
             },
           }),
           ...rerenderedControls,
-          ...updatedControlStates,
         },
       };
     },

superset-frontend/src/features/datasets/types.ts

@@ -62,7 +62,6 @@ export type DatasetObject = {
   filter_select_enabled?: boolean;
   fetch_values_predicate?: string;
   schema?: string;
-  catalog?: string;
   description: string | null;
   main_dttm_col: string;
   offset?: number;

superset-frontend/src/views/store.ts

@@ -38,6 +38,7 @@ import logger from 'src/middleware/loggerMiddleware';
 import saveModal from 'src/explore/reducers/saveModalReducer';
 import explore from 'src/explore/reducers/exploreReducer';
 import exploreDatasources from 'src/explore/reducers/datasourcesReducer';
+
 import { persistSqlLabStateEnhancer } from 'src/SqlLab/middlewares/persistSqlLabStateEnhancer';
 import sqlLabReducer from 'src/SqlLab/reducers/sqlLab';
 import getInitialState from 'src/SqlLab/reducers/getInitialState';
@@ -56,7 +57,6 @@ import { AnyDatasourcesAction } from 'src/explore/actions/datasourcesActions';
 import { HydrateExplore } from 'src/explore/actions/hydrateExplore';
 import getBootstrapData from 'src/utils/getBootstrapData';
 import { Dataset } from '@superset-ui/chart-controls';
-import databaseReducer from 'src/database/reducers';
 
 // Some reducers don't do anything, and redux is just used to reference the initial "state".
 // This may change later, as the client application takes on more responsibilities.
@@ -139,7 +139,6 @@ const reducers = {
   reports,
   saveModal,
   explore,
-  database: databaseReducer,
 };
 
 /* In some cases the jinja template injects two separate React apps into basic.html

superset/commands/dataset/exceptions.py

@@ -33,18 +33,6 @@ def get_dataset_exist_error_msg(table: Table) -> str:
     return _("Dataset %(table)s already exists", table=table)
 
 
-class MultiCatalogDisabledValidationError(ValidationError):
-    """
-    Validation error for using a non-default catalog when multi-catalog is disabled
-    """
-
-    def __init__(self) -> None:
-        super().__init__(
-            [_("Only the default catalog is supported for this connection")],
-            field_name="catalog",
-        )
-
-
 class DatabaseNotFoundValidationError(ValidationError):
     """
     Marshmallow validation error for database does not exist
@@ -54,6 +42,15 @@ class DatabaseNotFoundValidationError(ValidationError):
         super().__init__([_("Database does not exist")], field_name="database")
 
 
+class DatabaseChangeValidationError(ValidationError):
+    """
+    Marshmallow validation error database changes are not allowed on update
+    """
+
+    def __init__(self) -> None:
+        super().__init__([_("Database not allowed to change")], field_name="database")
+
+
 class DatasetExistsValidationError(ValidationError):
     """
     Marshmallow validation error for dataset already exists

superset/commands/dataset/update.py

@@ -14,8 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from __future__ import annotations
-
 import logging
 from collections import Counter
 from functools import partial
@@ -28,7 +26,7 @@ from sqlalchemy.exc import SQLAlchemyError
 from superset import is_feature_enabled, security_manager
 from superset.commands.base import BaseCommand, UpdateMixin
 from superset.commands.dataset.exceptions import (
-    DatabaseNotFoundValidationError,
+    DatabaseChangeValidationError,
     DatasetColumnNotFoundValidationError,
     DatasetColumnsDuplicateValidationError,
     DatasetColumnsExistsValidationError,
@@ -40,13 +38,11 @@ from superset.commands.dataset.exceptions import (
     DatasetMetricsNotFoundValidationError,
     DatasetNotFoundError,
     DatasetUpdateFailedError,
-    MultiCatalogDisabledValidationError,
 )
 from superset.connectors.sqla.models import SqlaTable, SqlMetric, TableColumn
 from superset.daos.dataset import DatasetDAO
 from superset.datasets.schemas import FolderSchema
 from superset.exceptions import SupersetSecurityException
-from superset.models.core import Database
 from superset.sql_parse import Table
 from superset.utils.decorators import on_error, transaction
 
@@ -90,12 +86,38 @@ class UpdateDatasetCommand(UpdateMixin, BaseCommand):
         if not self._model:
             raise DatasetNotFoundError()
 
-        # Check permission to update the dataset
+        # Check ownership
         try:
             security_manager.raise_for_ownership(self._model)
         except SupersetSecurityException as ex:
             raise DatasetForbiddenError() from ex
 
+        database_id = self._properties.get("database")
+
+        catalog = self._properties.get("catalog")
+        if not catalog:
+            catalog = self._properties["catalog"] = (
+                self._model.database.get_default_catalog()
+            )
+
+        table = Table(
+            self._properties.get("table_name"),  # type: ignore
+            self._properties.get("schema"),
+            catalog,
+        )
+
+        # Validate uniqueness
+        if not DatasetDAO.validate_update_uniqueness(
+            self._model.database,
+            table,
+            self._model_id,
+        ):
+            exceptions.append(DatasetExistsValidationError(table))
+
+        # Validate/Populate database not allowed to change
+        if database_id and database_id != self._model:
+            exceptions.append(DatabaseChangeValidationError())
+
         # Validate/Populate owner
         try:
             owners = self.compute_owners(
@@ -106,68 +128,15 @@ class UpdateDatasetCommand(UpdateMixin, BaseCommand):
         except ValidationError as ex:
             exceptions.append(ex)
 
-        self._validate_dataset_source(exceptions)
         self._validate_semantics(exceptions)
 
         if exceptions:
             raise DatasetInvalidError(exceptions=exceptions)
 
-    def _validate_dataset_source(self, exceptions: list[ValidationError]) -> None:
-        # we know we have a valid model
-        self._model = cast(SqlaTable, self._model)
-        database_id = self._properties.pop("database_id", None)
-        catalog = self._properties.get("catalog")
-        new_db_connection: Database | None = None
-
-        if database_id and database_id != self._model.database.id:
-            if new_db_connection := DatasetDAO.get_database_by_id(database_id):
-                self._properties["database"] = new_db_connection
-            else:
-                exceptions.append(DatabaseNotFoundValidationError())
-        db = new_db_connection or self._model.database
-        default_catalog = db.get_default_catalog()
-
-        # If multi-catalog is disabled, and catalog provided is not
-        # the default one, fail
-        if (
-            "catalog" in self._properties
-            and catalog != default_catalog
-            and not db.allow_multi_catalog
-        ):
-            exceptions.append(MultiCatalogDisabledValidationError())
-
-        # If the DB connection does not support multi-catalog,
-        # use the default catalog
-        elif not db.allow_multi_catalog:
-            catalog = self._properties["catalog"] = default_catalog
-
-        # Fallback to using the previous value if not provided
-        elif "catalog" not in self._properties:
-            catalog = self._model.catalog
-
-        schema = (
-            self._properties["schema"]
-            if "schema" in self._properties
-            else self._model.schema
-        )
-
-        table = Table(
-            self._properties.get("table_name", self._model.table_name),
-            schema,
-            catalog,
-        )
-
-        # Validate uniqueness
-        if not DatasetDAO.validate_update_uniqueness(
-            db,
-            table,
-            self._model_id,
-        ):
-            exceptions.append(DatasetExistsValidationError(table))
-
     def _validate_semantics(self, exceptions: list[ValidationError]) -> None:
         # we know we have a valid model
         self._model = cast(SqlaTable, self._model)
+
         if columns := self._properties.get("columns"):
             self._validate_columns(columns, exceptions)
 

superset/common/query_context_factory.py

@@ -65,23 +65,12 @@ class QueryContextFactory:  # pylint: disable=too-few-public-methods
 
         result_type = result_type or ChartDataResultType.FULL
         result_format = result_format or ChartDataResultFormat.JSON
-
-        # The server pagination var is extracted from form data as the
-        # row limit for server pagination is more
-        # This particular flag server_pagination only exists for table viz type
-        server_pagination = (
-            bool(form_data.get("server_pagination")) if form_data else False
-        )
-
         queries_ = [
             self._process_query_object(
                 datasource_model_instance,
                 form_data,
                 self._query_object_factory.create(
-                    result_type,
+                    result_type, datasource=datasource, **query_obj
-                    datasource=datasource,
-                    server_pagination=server_pagination,
-                    **query_obj,
                 ),
             )
             for query_obj in queries

superset/common/query_object_factory.py

@@ -57,7 +57,6 @@ class QueryObjectFactory:  # pylint: disable=too-few-public-methods
         row_limit: int | None = None,
         time_range: str | None = None,
         time_shift: str | None = None,
-        server_pagination: bool | None = None,
         **kwargs: Any,
     ) -> QueryObject:
         datasource_model_instance = None
@@ -65,12 +64,7 @@ class QueryObjectFactory:  # pylint: disable=too-few-public-methods
             datasource_model_instance = self._convert_to_model(datasource)
         processed_extras = self._process_extras(extras)
         result_type = kwargs.setdefault("result_type", parent_result_type)
-
+        row_limit = self._process_row_limit(row_limit, result_type)
-        # Process row limit taking server pagination into account
-        row_limit = self._process_row_limit(
-            row_limit, result_type, server_pagination=server_pagination
-        )
-
         processed_time_range = self._process_time_range(
             time_range, kwargs.get("filters"), kwargs.get("columns")
         )
@@ -102,27 +96,14 @@ class QueryObjectFactory:  # pylint: disable=too-few-public-methods
         return extras
 
     def _process_row_limit(
-        self,
+        self, row_limit: int | None, result_type: ChartDataResultType
-        row_limit: int | None,
-        result_type: ChartDataResultType,
-        server_pagination: bool | None = None,
     ) -> int:
-        """Process row limit taking into account server pagination.
-
-        :param row_limit: The requested row limit
-        :param result_type: The type of result being processed
-        :param server_pagination: Whether server-side pagination is enabled
-        :return: The processed row limit
-        """
         default_row_limit = (
             self._config["SAMPLES_ROW_LIMIT"]
             if result_type == ChartDataResultType.SAMPLES
             else self._config["ROW_LIMIT"]
         )
-        return apply_max_row_limit(
+        return apply_max_row_limit(row_limit or default_row_limit)
-            row_limit or default_row_limit,
-            server_pagination=server_pagination,
-        )
 
     @staticmethod
     def _process_time_range(

superset/config.py

@@ -969,10 +969,6 @@ MAPBOX_API_KEY = os.environ.get("MAPBOX_API_KEY", "")
 # Maximum number of rows returned for any analytical database query
 SQL_MAX_ROW = 100000
 
-# Maximum number of rows for any query with Server Pagination in Table Viz type
-TABLE_VIZ_MAX_ROW_SERVER = 500000
-
-
 # Maximum number of rows displayed in SQL Lab UI
 # Is set to avoid out of memory/localstorage issues in browsers. Does not affect
 # exported CSVs

superset/examples/bart_lines.py

@@ -16,6 +16,7 @@
 # under the License.
 import logging
 
+import pandas as pd
 import polyline
 from sqlalchemy import inspect, String, Text
 
@@ -24,7 +25,7 @@ from superset.sql_parse import Table
 from superset.utils import json
 
 from ..utils.database import get_example_database
-from .helpers import get_table_connector_registry, read_example_data
+from .helpers import get_example_url, get_table_connector_registry
 
 logger = logging.getLogger(__name__)
 
@@ -37,9 +38,8 @@ def load_bart_lines(only_metadata: bool = False, force: bool = False) -> None:
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            df = read_example_data(
+            url = get_example_url("bart-lines.json.gz")
-                "bart-lines.json.gz", encoding="latin-1", compression="gzip"
+            df = pd.read_json(url, encoding="latin-1", compression="gzip")
-            )
             df["path_json"] = df.path.map(json.dumps)
             df["polyline"] = df.path.map(polyline.encode)
             del df["path"]

superset/examples/birth_names.py

@@ -33,11 +33,11 @@ from superset.utils.core import DatasourceType
 
 from ..utils.database import get_example_database
 from .helpers import (
+    get_example_url,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
     misc_dash_slices,
-    read_example_data,
     update_slice_ids,
 )
 
@@ -57,8 +57,8 @@ def gen_filter(
 
 
 def load_data(tbl_name: str, database: Database, sample: bool = False) -> None:
-    pdf = read_example_data("birth_names2.json.gz", compression="gzip")
+    url = get_example_url("birth_names2.json.gz")
-
+    pdf = pd.read_json(url, compression="gzip")
     # TODO(bkyryliuk): move load examples data into the pytest fixture
     if database.backend == "presto":
         pdf.ds = pd.to_datetime(pdf.ds, unit="ms")

superset/examples/country_map.py

@@ -17,6 +17,7 @@
 import datetime
 import logging
 
+import pandas as pd
 from sqlalchemy import BigInteger, Date, inspect, String
 from sqlalchemy.sql import column
 
@@ -28,11 +29,11 @@ from superset.sql_parse import Table
 from superset.utils.core import DatasourceType
 
 from .helpers import (
+    get_example_url,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
     misc_dash_slices,
-    read_example_data,
 )
 
 logger = logging.getLogger(__name__)
@@ -48,9 +49,8 @@ def load_country_map_data(only_metadata: bool = False, force: bool = False) -> N
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            data = read_example_data(
+            url = get_example_url("birth_france_data_for_country_map.csv")
-                "birth_france_data_for_country_map.csv", encoding="utf-8"
+            data = pd.read_csv(url, encoding="utf-8")
-            )
             data["dttm"] = datetime.datetime.now().date()
             data.to_sql(
                 tbl_name,

superset/examples/energy.py

@@ -17,6 +17,7 @@
 import logging
 import textwrap
 
+import pandas as pd
 from sqlalchemy import Float, inspect, String
 from sqlalchemy.sql import column
 
@@ -28,11 +29,11 @@ from superset.sql_parse import Table
 from superset.utils.core import DatasourceType
 
 from .helpers import (
+    get_example_url,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
     misc_dash_slices,
-    read_example_data,
 )
 
 logger = logging.getLogger(__name__)
@@ -50,7 +51,8 @@ def load_energy(
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            pdf = read_example_data("energy.json.gz", compression="gzip")
+            url = get_example_url("energy.json.gz")
+            pdf = pd.read_json(url, compression="gzip")
             pdf = pdf.head(100) if sample else pdf
             pdf.to_sql(
                 tbl_name,

superset/examples/flights.py

@@ -23,7 +23,7 @@ import superset.utils.database as database_utils
 from superset import db
 from superset.sql_parse import Table
 
-from .helpers import get_table_connector_registry, read_example_data
+from .helpers import get_example_url, get_table_connector_registry
 
 logger = logging.getLogger(__name__)
 
@@ -37,14 +37,12 @@ def load_flights(only_metadata: bool = False, force: bool = False) -> None:
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            pdf = read_example_data(
+            flight_data_url = get_example_url("flight_data.csv.gz")
-                "flight_data.csv.gz", encoding="latin-1", compression="gzip"
+            pdf = pd.read_csv(flight_data_url, encoding="latin-1", compression="gzip")
-            )
 
             # Loading airports info to join and get lat/long
-            airports = read_example_data(
+            airports_url = get_example_url("airports.csv.gz")
-                "airports.csv.gz", encoding="latin-1", compression="gzip"
+            airports = pd.read_csv(airports_url, encoding="latin-1", compression="gzip")
-            )
             airports = airports.set_index("IATA_CODE")
 
             pdf[  # pylint: disable=unsupported-assignment-operation,useless-suppression

superset/examples/helpers.py

@@ -43,11 +43,7 @@ Environment knobs
 from __future__ import annotations
 
 import os
-import time
 from typing import Any
-from urllib.error import HTTPError
-
-import pandas as pd
 
 from superset import app, db
 from superset.connectors.sqla.models import SqlaTable
@@ -123,33 +119,3 @@ def get_example_url(filepath: str) -> str:
     paths like ``datasets/examples/slack/messages.csv``.
     """
     return f"{BASE_URL}{filepath}"
-
-
-def read_example_data(
-    filepath: str,
-    max_attempts: int = 5,
-    wait_seconds: float = 60,
-    **kwargs: Any,
-) -> pd.DataFrame:
-    """Load CSV or JSON from example data mirror with retry/backoff."""
-    from superset.examples.helpers import get_example_url
-
-    url = get_example_url(filepath)
-    is_json = filepath.endswith(".json") or filepath.endswith(".json.gz")
-
-    for attempt in range(1, max_attempts + 1):
-        try:
-            if is_json:
-                return pd.read_json(url, **kwargs)
-            return pd.read_csv(url, **kwargs)
-        except HTTPError as e:
-            if e.code == 429 and attempt < max_attempts:
-                sleep_time = wait_seconds * (2 ** (attempt - 1))
-                print(
-                    f"HTTP 429 received from {url}. ",
-                    f"Retrying in {sleep_time:.1f}s ",
-                    f"(attempt {attempt}/{max_attempts})...",
-                )
-                time.sleep(sleep_time)
-            else:
-                raise

superset/examples/long_lat.py

@@ -19,6 +19,7 @@ import logging
 import random
 
 import geohash
+import pandas as pd
 from sqlalchemy import DateTime, Float, inspect, String
 
 import superset.utils.database as database_utils
@@ -28,11 +29,11 @@ from superset.sql_parse import Table
 from superset.utils.core import DatasourceType
 
 from .helpers import (
+    get_example_url,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
     misc_dash_slices,
-    read_example_data,
 )
 
 logger = logging.getLogger(__name__)
@@ -47,9 +48,8 @@ def load_long_lat_data(only_metadata: bool = False, force: bool = False) -> None
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            pdf = read_example_data(
+            url = get_example_url("san_francisco.csv.gz")
-                "san_francisco.csv.gz", encoding="utf-8", compression="gzip"
+            pdf = pd.read_csv(url, encoding="utf-8", compression="gzip")
-            )
             start = datetime.datetime.now().replace(
                 hour=0, minute=0, second=0, microsecond=0
             )

superset/examples/multiformat_time_series.py

@@ -27,11 +27,11 @@ from superset.utils.core import DatasourceType
 
 from ..utils.database import get_example_database
 from .helpers import (
+    get_example_url,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
     misc_dash_slices,
-    read_example_data,
 )
 
 logger = logging.getLogger(__name__)
@@ -48,10 +48,8 @@ def load_multiformat_time_series(  # pylint: disable=too-many-locals
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            pdf = read_example_data(
+            url = get_example_url("multiformat_time_series.json.gz")
-                "multiformat_time_series.json.gz", compression="gzip"
+            pdf = pd.read_json(url, compression="gzip")
-            )
-
             # TODO(bkyryliuk): move load examples data into the pytest fixture
             if database.backend == "presto":
                 pdf.ds = pd.to_datetime(pdf.ds, unit="s")

superset/examples/paris.py

@@ -17,6 +17,7 @@
 
 import logging
 
+import pandas as pd
 from sqlalchemy import inspect, String, Text
 
 import superset.utils.database as database_utils
@@ -24,7 +25,7 @@ from superset import db
 from superset.sql_parse import Table
 from superset.utils import json
 
-from .helpers import get_table_connector_registry, read_example_data
+from .helpers import get_example_url, get_table_connector_registry
 
 logger = logging.getLogger(__name__)
 
@@ -37,7 +38,8 @@ def load_paris_iris_geojson(only_metadata: bool = False, force: bool = False) ->
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            df = read_example_data("paris_iris.json.gz", compression="gzip")
+            url = get_example_url("paris_iris.json.gz")
+            df = pd.read_json(url, compression="gzip")
             df["features"] = df.features.map(json.dumps)
 
             df.to_sql(

superset/examples/random_time_series.py

@@ -26,10 +26,10 @@ from superset.sql_parse import Table
 from superset.utils.core import DatasourceType
 
 from .helpers import (
+    get_example_url,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
-    read_example_data,
 )
 
 logger = logging.getLogger(__name__)
@@ -46,7 +46,8 @@ def load_random_time_series_data(
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            pdf = read_example_data("random_time_series.json.gz", compression="gzip")
+            url = get_example_url("random_time_series.json.gz")
+            pdf = pd.read_json(url, compression="gzip")
             if database.backend == "presto":
                 pdf.ds = pd.to_datetime(pdf.ds, unit="s")
                 pdf.ds = pdf.ds.dt.strftime("%Y-%m-%d %H:%M%:%S")

superset/examples/sf_population_polygons.py

@@ -17,6 +17,7 @@
 
 import logging
 
+import pandas as pd
 from sqlalchemy import BigInteger, Float, inspect, Text
 
 import superset.utils.database as database_utils
@@ -24,7 +25,7 @@ from superset import db
 from superset.sql_parse import Table
 from superset.utils import json
 
-from .helpers import get_table_connector_registry, read_example_data
+from .helpers import get_example_url, get_table_connector_registry
 
 logger = logging.getLogger(__name__)
 
@@ -39,7 +40,8 @@ def load_sf_population_polygons(
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            df = read_example_data("sf_population.json.gz", compression="gzip")
+            url = get_example_url("sf_population.json.gz")
+            df = pd.read_json(url, compression="gzip")
             df["contour"] = df.contour.map(json.dumps)
 
             df.to_sql(

superset/examples/world_bank.py

@@ -25,12 +25,12 @@ import superset.utils.database
 from superset import app, db
 from superset.connectors.sqla.models import BaseDatasource, SqlMetric
 from superset.examples.helpers import (
+    get_example_url,
     get_examples_folder,
     get_slice_json,
     get_table_connector_registry,
     merge_slice,
     misc_dash_slices,
-    read_example_data,
     update_slice_ids,
 )
 from superset.models.dashboard import Dashboard
@@ -55,7 +55,8 @@ def load_world_bank_health_n_pop(  # pylint: disable=too-many-locals
         table_exists = database.has_table(Table(tbl_name, schema))
 
         if not only_metadata and (not table_exists or force):
-            pdf = read_example_data("countries.json.gz", compression="gzip")
+            url = get_example_url("countries.json.gz")
+            pdf = pd.read_json(url, compression="gzip")
             pdf.columns = [col.replace(".", "_") for col in pdf.columns]
             if database.backend == "presto":
                 pdf.year = pd.to_datetime(pdf.year)

superset/translations/zh_TW/LC_MESSAGES/messages.po

@@ -123,7 +123,7 @@ msgid ""
 msgstr ""
 "來確保字符的表達順序與時間順序一致的標準。如果時間戳格式不符合 ISO 8601 "
 "標準，则需要定義表達式和類型，以便將字符串轉换為日期或時間戳。注意：當前不支持時區。如果時間以 epoch 格式儲存，請输入 `epoch_s` "
-"or `epoch_ms` 。如果没有指定任何模式，我們可以通過額外的参數在每個 資料庫/欄位 名稱級別上使用可選的預設值。"
+"or `epoch_ms` 。如果没有指定任何模式，我們可以通過額外的参數在每個資料庫/列名級别上使用可選的預設值。"
 
 #, fuzzy
 msgid " to add calculated columns"
@@ -155,11 +155,11 @@ msgstr "% 計算"
 
 #, fuzzy, python-format
 msgid "% of parent"
-msgstr "% 父類"
+msgstr "父類"
 
 #, fuzzy, python-format
 msgid "% of total"
-msgstr "% 顯示總計"
+msgstr "顯示總計"
 
 #, python-format
 msgid "%(dialect)s cannot be used as a data source for security reasons."
@@ -278,7 +278,7 @@ msgstr "%s 個選項"
 
 #, fuzzy, python-format
 msgid "%s recipients"
-msgstr "%s 最近"
+msgstr "最近"
 
 #, fuzzy, python-format
 msgid "%s row"
@@ -1174,7 +1174,7 @@ msgstr "所有"
 
 #, fuzzy, python-format
 msgid "All %s hidden columns"
-msgstr "所有 %s 隱藏的欄位"
+msgstr "表的列"
 
 msgid "All Text"
 msgstr "所有文本"
@@ -1625,7 +1625,7 @@ msgstr "應用的過濾器 (%d)"
 
 #, fuzzy, python-format
 msgid "Applied filters (%s)"
-msgstr "應用的過濾器 (%s)"
+msgstr "應用的過濾器 (%d)"
 
 #, fuzzy, python-format
 msgid "Applied filters: %s"
@@ -3615,7 +3615,7 @@ msgstr "無法從结果後端檢索數據。您需要重新運行原始查詢。
 
 #, fuzzy, python-format
 msgid "Data for %s"
-msgstr "給 %s 的數據"
+msgstr "給 JS 的額外數據"
 
 #, fuzzy
 msgid "Data imported"
@@ -3729,7 +3729,7 @@ msgstr "數據集"
 
 #, fuzzy, python-format
 msgid "Dataset %(table)s already exists"
-msgstr "數據集 %(table)s 已存在"
+msgstr "數據集 %(name)s 已存在"
 
 #, fuzzy
 msgid "Dataset Name"
@@ -4471,7 +4471,7 @@ msgstr "複製"
 
 #, fuzzy, python-format
 msgid "Duplicate role %(name)s"
-msgstr "重复的角色 %(name)s"
+msgstr "重复的列名%(columns)s"
 
 msgid "Duplicate tab"
 msgstr "複製選項卡"
@@ -5948,7 +5948,7 @@ msgstr "描述要發送給你的報告"
 
 #, fuzzy, python-format
 msgid "Include description to be sent with %s"
-msgstr ""
+msgstr "描述要發送給你的報告"
 
 msgid "Include series name as an axis"
 msgstr "包括系列名稱作為軸"
@@ -9393,7 +9393,7 @@ msgstr "搜索"
 
 #, fuzzy, python-format
 msgid "Search %s records"
-msgstr "搜索 %s 紀錄"
+msgstr "搜索 / 過濾"
 
 msgid "Search / Filter"
 msgstr "搜索 / 過濾"
@@ -9913,7 +9913,7 @@ msgstr "顯示"
 
 #, fuzzy, python-format
 msgid "Show %s entries"
-msgstr "顯示 %s 指標"
+msgstr "顯示指標"
 
 msgid "Show Bubbles"
 msgstr "顯示氣泡"
@@ -10659,7 +10659,7 @@ msgstr "表名"
 msgid ""
 "Table [%(table)s] could not be found, please double check your database "
 "connection, schema, and table name"
-msgstr "找不到 [%(table)s] 資料表，請仔細檢查您的資料庫連接、Schema 和 資料表名稱"
+msgstr "找不到 [%(table_name)s] 表，請仔細檢查您的資料庫連接、Schema 和 表名"
 
 #, fuzzy
 msgid "Table actions"
@@ -12968,7 +12968,7 @@ msgstr ""
 
 #, fuzzy, python-format
 msgid "Waiting on %s"
-msgstr "等待 %s 中"
+msgstr "顯示 %s 個 總計 %s 個"
 
 #, fuzzy
 msgid "Waiting on database..."
@@ -14252,14 +14252,14 @@ msgid ""
 " Lab tabs using this database open. Are you sure you want to continue? "
 "Deleting the database will break those objects."
 msgstr ""
-"已經關聯了 %s 圖表和 %s 看板，並且用戶在該資料庫上打開了 %s 個 SQL "
+"資料庫 %s 已經關聯了 %s 圖表和 %s 看板，並且用戶在該資料庫上打開了 %s 個 SQL "
-"編輯器選項卡。確定要繼續嗎？删除資料庫將破壞這些對象。"
+"編輯器選項卡。確定要繼續嗎？删除資料庫將破坏這些對象。"
 
 #, fuzzy, python-format
 msgid ""
 "is linked to %s charts that appear on %s dashboards. Are you sure you "
 "want to continue? Deleting the dataset will break those objects."
-msgstr "已經關聯到 %s 圖表和 %s 看板内。確定要繼續嗎？删除數據集將破壞這些對象。"
+msgstr "數據集 %s 已經链接到 %s 圖表和 %s 看板内。確定要繼續嗎？删除數據集將破坏這些對象。"
 
 msgid "is not"
 msgstr ""

superset/utils/cache.py

@@ -109,7 +109,7 @@ def memoized_func(key: str, cache: Cache = cache_manager.cache) -> Callable[...,
     force means whether to force refresh the cache and is treated as False by default,
     except force = True is passed to the decorated function.
 
-    timeout of cache is set to CACHE_DEFAULT_TIMEOUT seconds by default,
+    timeout of cache is set to 600 seconds by default,
     except cache_timeout = {timeout in seconds} is passed to the decorated function.
 
     :param key: a callable function that takes function arguments and returns
@@ -121,9 +121,7 @@ def memoized_func(key: str, cache: Cache = cache_manager.cache) -> Callable[...,
         def wrapped_f(*args: Any, **kwargs: Any) -> Any:
             should_cache = kwargs.pop("cache", True)
             force = kwargs.pop("force", False)
-            cache_timeout = kwargs.pop(
+            cache_timeout = kwargs.pop("cache_timeout", 0)
-                "cache_timeout", app.config["CACHE_DEFAULT_TIMEOUT"]
-            )
 
             if not should_cache:
                 return f(*args, **kwargs)

superset/utils/core.py

@@ -1741,30 +1741,24 @@ def parse_boolean_string(bool_str: str | None) -> bool:
 
 def apply_max_row_limit(
     limit: int,
-    server_pagination: bool | None = None,
+    max_limit: int | None = None,
 ) -> int:
     """
-    Override row limit based on server pagination setting
+    Override row limit if max global limit is defined
 
     :param limit: requested row limit
-    :param server_pagination: whether server-side pagination
+    :param max_limit: Maximum allowed row limit
-    is enabled, defaults to None
     :return: Capped row limit
 
-    >>> apply_max_row_limit(600000, server_pagination=True)  # Server pagination
+    >>> apply_max_row_limit(100000, 10)
-    500000
+    10
-    >>> apply_max_row_limit(600000, server_pagination=False)  # No pagination
+    >>> apply_max_row_limit(10, 100000)
-    50000
+    10
-    >>> apply_max_row_limit(5000)  # No server_pagination specified
+    >>> apply_max_row_limit(0, 10000)
-    5000
+    10000
-    >>> apply_max_row_limit(0)  # Zero returns default max limit
-    50000
     """
-    max_limit = (
+    if max_limit is None:
-        current_app.config["TABLE_VIZ_MAX_ROW_SERVER"]
+        max_limit = current_app.config["SQL_MAX_ROW"]
-        if server_pagination
-        else current_app.config["SQL_MAX_ROW"]
-    )
     if limit != 0:
         return min(max_limit, limit)
     return max_limit

superset/views/base.py

@@ -109,7 +109,6 @@ FRONTEND_CONF_KEYS = (
     "JWT_ACCESS_CSRF_COOKIE_NAME",
     "SQLLAB_QUERY_RESULT_TIMEOUT",
     "SYNC_DB_PERMISSIONS_IN_ASYNC_MODE",
-    "TABLE_VIZ_MAX_ROW_SERVER",
 )
 
 logger = logging.getLogger(__name__)

tests/integration_tests/datasets/api_tests.py

@@ -14,10 +14,11 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from __future__ import annotations
+"""Unit tests for Superset"""
 
 import unittest
 from io import BytesIO
+from typing import Optional
 from unittest.mock import ANY, patch
 from zipfile import is_zipfile, ZipFile
 
@@ -69,26 +70,14 @@ from tests.integration_tests.fixtures.importexport import (
 class TestDatasetApi(SupersetTestCase):
     fixture_tables_names = ("ab_permission", "ab_permission_view", "ab_view_menu")
     fixture_virtual_table_names = ("sql_virtual_dataset_1", "sql_virtual_dataset_2")
-    items_to_delete: list[SqlaTable | Database | TableColumn] = []
-
-    def setUp(self):
-        self.items_to_delete = []
-
-    def tearDown(self):
-        for item in self.items_to_delete:
-            db.session.delete(item)
-        db.session.commit()
-        super().tearDown()
 
     @staticmethod
     def insert_dataset(
         table_name: str,
         owners: list[int],
         database: Database,
-        sql: str | None = None,
+        sql: Optional[str] = None,
-        schema: str | None = None,
+        schema: Optional[str] = None,
-        catalog: str | None = None,
-        fetch_metadata: bool = True,
     ) -> SqlaTable:
         obj_owners = list()  # noqa: C408
         for owner in owners:
@@ -100,12 +89,10 @@ class TestDatasetApi(SupersetTestCase):
             owners=obj_owners,
             database=database,
             sql=sql,
-            catalog=catalog,
         )
         db.session.add(table)
         db.session.commit()
-        if fetch_metadata:
+        table.fetch_metadata()
-            table.fetch_metadata()
         return table
 
     def insert_default_dataset(self):
@@ -113,16 +100,6 @@ class TestDatasetApi(SupersetTestCase):
             "ab_permission", [self.get_user("admin").id], get_main_database()
         )
 
-    def insert_database(self, name: str, allow_multi_catalog: bool = False) -> Database:
-        db_connection = Database(
-            database_name=name,
-            sqlalchemy_uri=get_example_database().sqlalchemy_uri,
-            extra=('{"allow_multi_catalog": true}' if allow_multi_catalog else "{}"),
-        )
-        db.session.add(db_connection)
-        db.session.commit()
-        return db_connection
-
     def get_fixture_datasets(self) -> list[SqlaTable]:
         return (
             db.session.query(SqlaTable)
@@ -338,7 +315,8 @@ class TestDatasetApi(SupersetTestCase):
 
         # revert gamma permission
         gamma_role.permissions.remove(main_db_pvm)
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_get_dataset_related_database_gamma(self):
         """
@@ -502,7 +480,8 @@ class TestDatasetApi(SupersetTestCase):
             ],
         }
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_get_dataset_render_jinja_exceptions(self):
         """
@@ -568,7 +547,8 @@ class TestDatasetApi(SupersetTestCase):
             == "Unable to render expression from dataset calculated column."
         )
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_get_dataset_distinct_schema(self):
         """
@@ -638,7 +618,9 @@ class TestDatasetApi(SupersetTestCase):
                 },
             )
 
-        self.items_to_delete = datasets
+        for dataset in datasets:
+            db.session.delete(dataset)
+        db.session.commit()
 
     def test_get_dataset_distinct_not_allowed(self):
         """
@@ -665,7 +647,8 @@ class TestDatasetApi(SupersetTestCase):
         assert response["count"] == 0
         assert response["result"] == []
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_get_dataset_info(self):
         """
@@ -739,7 +722,8 @@ class TestDatasetApi(SupersetTestCase):
         )
         assert columns[0].expression == "COUNT(*)"
 
-        self.items_to_delete = [model]
+        db.session.delete(model)
+        db.session.commit()
 
     def test_create_dataset_item_normalize(self):
         """
@@ -765,7 +749,8 @@ class TestDatasetApi(SupersetTestCase):
         assert model.database_id == table_data["database"]
         assert model.normalize_columns is True
 
-        self.items_to_delete = [model]
+        db.session.delete(model)
+        db.session.commit()
 
     def test_create_dataset_item_gamma(self):
         """
@@ -806,7 +791,8 @@ class TestDatasetApi(SupersetTestCase):
         model = db.session.query(SqlaTable).get(data.get("id"))
         assert admin in model.owners
         assert alpha in model.owners
-        self.items_to_delete = [model]
+        db.session.delete(model)
+        db.session.commit()
 
     def test_create_dataset_item_owners_invalid(self):
         """
@@ -853,7 +839,8 @@ class TestDatasetApi(SupersetTestCase):
         model = db.session.query(SqlaTable).get(data.get("id"))
         assert admin in model.owners
         assert alpha in model.owners
-        self.items_to_delete = [model]
+        db.session.delete(model)
+        db.session.commit()
 
     @unittest.skip("test is failing stochastically")
     def test_create_dataset_same_name_different_schema(self):
@@ -1004,7 +991,8 @@ class TestDatasetApi(SupersetTestCase):
         model = db.session.query(SqlaTable).get(dataset.id)
         assert model.owners == current_owners
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_clear_owner_list(self):
         """
@@ -1020,7 +1008,8 @@ class TestDatasetApi(SupersetTestCase):
         model = db.session.query(SqlaTable).get(dataset.id)
         assert model.owners == []
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_populate_owner(self):
         """
@@ -1037,7 +1026,8 @@ class TestDatasetApi(SupersetTestCase):
         model = db.session.query(SqlaTable).get(dataset.id)
         assert model.owners == [gamma]
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_item(self):
         """
@@ -1055,7 +1045,8 @@ class TestDatasetApi(SupersetTestCase):
         assert model.description == dataset_data["description"]
         assert model.owners == current_owners
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_item_w_override_columns(self):
         """
@@ -1091,7 +1082,8 @@ class TestDatasetApi(SupersetTestCase):
             col.advanced_data_type for col in columns
         ]
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_item_w_override_columns_same_columns(self):
         """
@@ -1138,7 +1130,8 @@ class TestDatasetApi(SupersetTestCase):
         columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
         assert len(columns) != prev_col_len
         assert len(columns) == 3
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_create_column_and_metric(self):
         """
@@ -1233,7 +1226,8 @@ class TestDatasetApi(SupersetTestCase):
         assert metrics[1].warning_text == new_metric_data["warning_text"]
         assert str(metrics[1].uuid) == new_metric_data["uuid"]
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_delete_column(self):
         """
@@ -1282,7 +1276,8 @@ class TestDatasetApi(SupersetTestCase):
         assert columns[1].column_name == "name"
         assert len(columns) == 2
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_update_column(self):
         """
@@ -1318,7 +1313,8 @@ class TestDatasetApi(SupersetTestCase):
             assert columns[0].groupby is False
             assert columns[0].filterable is False
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_delete_metric(self):
         """
@@ -1361,7 +1357,8 @@ class TestDatasetApi(SupersetTestCase):
         metrics = metrics_query.all()
         assert len(metrics) == 1
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_update_column_uniqueness(self):
         """
@@ -1381,7 +1378,8 @@ class TestDatasetApi(SupersetTestCase):
             "message": {"columns": ["One or more columns already exist"]}
         }
         assert data == expected_result
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_update_metric_uniqueness(self):
         """
@@ -1401,7 +1399,8 @@ class TestDatasetApi(SupersetTestCase):
             "message": {"metrics": ["One or more metrics already exist"]}
         }
         assert data == expected_result
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_update_column_duplicate(self):
         """
@@ -1426,7 +1425,8 @@ class TestDatasetApi(SupersetTestCase):
             "message": {"columns": ["One or more columns are duplicated"]}
         }
         assert data == expected_result
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_update_metric_duplicate(self):
         """
@@ -1451,7 +1451,8 @@ class TestDatasetApi(SupersetTestCase):
             "message": {"metrics": ["One or more metrics are duplicated"]}
         }
         assert data == expected_result
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_item_gamma(self):
         """
@@ -1464,7 +1465,8 @@ class TestDatasetApi(SupersetTestCase):
         uri = f"api/v1/dataset/{dataset.id}"
         rv = self.client.put(uri, json=table_data)
         assert rv.status_code == 403
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_dataset_get_list_no_username(self):
         """
@@ -1489,7 +1491,8 @@ class TestDatasetApi(SupersetTestCase):
         assert current_dataset["description"] == "changed_description"
         assert "username" not in current_dataset["changed_by"].keys()
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_dataset_get_no_username(self):
         """
@@ -1509,7 +1512,8 @@ class TestDatasetApi(SupersetTestCase):
         assert res["description"] == "changed_description"
         assert "username" not in res["changed_by"].keys()
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_item_not_owned(self):
         """
@@ -1522,7 +1526,8 @@ class TestDatasetApi(SupersetTestCase):
         uri = f"api/v1/dataset/{dataset.id}"
         rv = self.put_assert_metric(uri, table_data, "put")
         assert rv.status_code == 403
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_update_dataset_item_owners_invalid(self):
         """
@@ -1535,7 +1540,8 @@ class TestDatasetApi(SupersetTestCase):
         uri = f"api/v1/dataset/{dataset.id}"
         rv = self.put_assert_metric(uri, table_data, "put")
         assert rv.status_code == 422
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     @patch("superset.daos.dataset.DatasetDAO.update")
     def test_update_dataset_sqlalchemy_error(self, mock_dao_update):
@@ -1554,7 +1560,8 @@ class TestDatasetApi(SupersetTestCase):
         assert rv.status_code == 422
         assert data == {"message": "Dataset could not be updated."}
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     @with_feature_flags(DATASET_FOLDERS=True)
     def test_update_dataset_add_folders(self):
@@ -1600,6 +1607,7 @@ class TestDatasetApi(SupersetTestCase):
 
         uri = f"api/v1/dataset/{dataset.id}"
         rv = self.put_assert_metric(uri, dataset_data, "put")
+        print(rv.data.decode("utf-8"))
         assert rv.status_code == 200
 
         model = db.session.query(SqlaTable).get(dataset.id)
@@ -1635,229 +1643,8 @@ class TestDatasetApi(SupersetTestCase):
             },
         ]
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
-
+        db.session.commit()
-    def test_update_dataset_change_db_connection_multi_catalog_disabled(self):
-        """
-        Dataset API: Test changing the DB connection powering the dataset
-        to a connection with multi-catalog disabled.
-        """
-        self.login(ADMIN_USERNAME)
-
-        db_connection = self.insert_database("db_connection")
-        new_db_connection = self.insert_database("new_db_connection")
-        dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=db_connection,
-            sql="select 1 as one",
-            schema="test_schema",
-            catalog="old_default_catalog",
-            fetch_metadata=False,
-        )
-
-        with patch.object(
-            new_db_connection, "get_default_catalog", return_value="new_default_catalog"
-        ):
-            payload = {"database_id": new_db_connection.id}
-            uri = f"api/v1/dataset/{dataset.id}"
-            rv = self.put_assert_metric(uri, payload, "put")
-            assert rv.status_code == 200
-
-            model = db.session.query(SqlaTable).get(dataset.id)
-            assert model.database == new_db_connection
-            # Catalog should have been updated to new connection's default catalog
-            assert model.catalog == "new_default_catalog"
-
-        self.items_to_delete = [dataset, db_connection, new_db_connection]
-
-    def test_update_dataset_change_db_connection_multi_catalog_enabled(self):
-        """
-        Dataset API: Test changing the DB connection powering the dataset
-        to a connection with multi-catalog enabled.
-        """
-        self.login(ADMIN_USERNAME)
-
-        db_connection = self.insert_database("db_connection")
-        new_db_connection = self.insert_database(
-            "new_db_connection", allow_multi_catalog=True
-        )
-        dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=db_connection,
-            sql="select 1 as one",
-            schema="test_schema",
-            catalog="old_default_catalog",
-            fetch_metadata=False,
-        )
-
-        with patch.object(
-            new_db_connection, "get_default_catalog", return_value="default"
-        ):
-            payload = {"database_id": new_db_connection.id}
-            uri = f"api/v1/dataset/{dataset.id}"
-            rv = self.put_assert_metric(uri, payload, "put")
-            assert rv.status_code == 200
-
-        model = db.session.query(SqlaTable).get(dataset.id)
-        assert model.database == new_db_connection
-        # Catalog was not changed as not provided and multi-catalog is enabled
-        assert model.catalog == "old_default_catalog"
-
-        self.items_to_delete = [dataset, db_connection, new_db_connection]
-
-    def test_update_dataset_change_db_connection_not_found(self):
-        """
-        Dataset API: Test changing the DB connection powering the dataset
-        to an invalid DB connection.
-        """
-        self.login(ADMIN_USERNAME)
-
-        dataset = self.insert_default_dataset()
-
-        payload = {"database_id": 1500}
-        uri = f"api/v1/dataset/{dataset.id}"
-        rv = self.put_assert_metric(uri, payload, "put")
-        response = json.loads(rv.data.decode("utf-8"))
-        assert rv.status_code == 422
-        assert response["message"] == {"database": ["Database does not exist"]}
-
-        self.items_to_delete = [dataset]
-
-    def test_update_dataset_change_catalog(self):
-        """
-        Dataset API: Test changing the catalog associated with the dataset.
-        """
-        self.login(ADMIN_USERNAME)
-
-        db_connection = self.insert_database("db_connection", allow_multi_catalog=True)
-        dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=db_connection,
-            sql="select 1 as one",
-            schema="test_schema",
-            catalog="test_catalog",
-            fetch_metadata=False,
-        )
-
-        with patch.object(db_connection, "get_default_catalog", return_value="default"):
-            payload = {"catalog": "other_catalog"}
-            uri = f"api/v1/dataset/{dataset.id}"
-            rv = self.put_assert_metric(uri, payload, "put")
-            assert rv.status_code == 200
-
-            model = db.session.query(SqlaTable).get(dataset.id)
-            assert model.catalog == "other_catalog"
-
-        self.items_to_delete = [dataset, db_connection]
-
-    def test_update_dataset_change_catalog_not_allowed(self):
-        """
-        Dataset API: Test changing the catalog associated with the dataset fails
-        when multi-catalog is disabled on the DB connection.
-        """
-        self.login(ADMIN_USERNAME)
-
-        db_connection = self.insert_database("db_connection")
-        dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=db_connection,
-            sql="select 1 as one",
-            schema="test_schema",
-            catalog="test_catalog",
-            fetch_metadata=False,
-        )
-
-        with patch.object(db_connection, "get_default_catalog", return_value="default"):
-            payload = {"catalog": "other_catalog"}
-            uri = f"api/v1/dataset/{dataset.id}"
-            rv = self.put_assert_metric(uri, payload, "put")
-            response = json.loads(rv.data.decode("utf-8"))
-            assert rv.status_code == 422
-            assert response["message"] == {
-                "catalog": ["Only the default catalog is supported for this connection"]
-            }
-
-        self.items_to_delete = [dataset, db_connection]
-
-    def test_update_dataset_validate_uniqueness(self):
-        """
-        Dataset API: Test the dataset uniqueness validation takes into
-        consideration the new database connection.
-        """
-        test_db = get_main_database()
-        if test_db.backend == "sqlite":
-            # Skip this test for SQLite as it doesn't support multiple
-            # schemas.
-            return
-
-        self.login(ADMIN_USERNAME)
-
-        db_connection = self.insert_database("db_connection")
-        new_db_connection = self.insert_database("new_db_connection")
-        first_schema_dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=db_connection,
-            sql="select 1 as one",
-            schema="first_schema",
-            fetch_metadata=False,
-        )
-        second_schema_dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=db_connection,
-            sql="select 1 as one",
-            schema="second_schema",
-            fetch_metadata=False,
-        )
-        new_db_conn_dataset = self.insert_dataset(
-            table_name="test_dataset",
-            owners=[],
-            database=new_db_connection,
-            sql="select 1 as one",
-            schema="first_schema",
-            fetch_metadata=False,
-        )
-
-        with patch.object(
-            db_connection,
-            "get_default_catalog",
-            return_value=None,
-        ):
-            payload = {"schema": "second_schema"}
-            uri = f"api/v1/dataset/{first_schema_dataset.id}"
-            rv = self.put_assert_metric(uri, payload, "put")
-            response = json.loads(rv.data.decode("utf-8"))
-            assert rv.status_code == 422
-            assert response["message"] == {
-                "table": ["Dataset second_schema.test_dataset already exists"]
-            }
-
-        with patch.object(
-            new_db_connection,
-            "get_default_catalog",
-            return_value=None,
-        ):
-            payload["database_id"] = new_db_connection.id
-            uri = f"api/v1/dataset/{first_schema_dataset.id}"
-            rv = self.put_assert_metric(uri, payload, "put")
-            assert rv.status_code == 200
-
-        model = db.session.query(SqlaTable).get(first_schema_dataset.id)
-        assert model.database == new_db_connection
-        assert model.schema == "second_schema"
-
-        self.items_to_delete = [
-            first_schema_dataset,
-            second_schema_dataset,
-            new_db_conn_dataset,
-            new_db_connection,
-            db_connection,
-        ]
 
     def test_delete_dataset_item(self):
         """
@@ -1887,7 +1674,8 @@ class TestDatasetApi(SupersetTestCase):
         uri = f"api/v1/dataset/{dataset.id}"
         rv = self.delete_assert_metric(uri, "delete")
         assert rv.status_code == 403
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_delete_dataset_item_not_authorized(self):
         """
@@ -1899,7 +1687,8 @@ class TestDatasetApi(SupersetTestCase):
         uri = f"api/v1/dataset/{dataset.id}"
         rv = self.client.delete(uri)
         assert rv.status_code == 403
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     @patch("superset.daos.dataset.DatasetDAO.delete")
     def test_delete_dataset_sqlalchemy_error(self, mock_dao_delete):
@@ -1916,7 +1705,8 @@ class TestDatasetApi(SupersetTestCase):
         data = json.loads(rv.data.decode("utf-8"))
         assert rv.status_code == 422
         assert data == {"message": "Datasets could not be deleted."}
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     @pytest.mark.usefixtures("create_datasets")
     def test_delete_dataset_column(self):
@@ -2157,7 +1947,8 @@ class TestDatasetApi(SupersetTestCase):
             .filter_by(table_id=dataset.id, column_name="id")
             .one()
         )
-        self.items_to_delete = [id_column]
+        db.session.delete(id_column)
+        db.session.commit()
 
         self.login(ADMIN_USERNAME)
         uri = f"api/v1/dataset/{dataset.id}/refresh"
@@ -2170,7 +1961,8 @@ class TestDatasetApi(SupersetTestCase):
             .one()
         )
         assert id_column is not None
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     def test_dataset_item_refresh_not_found(self):
         """
@@ -2195,7 +1987,8 @@ class TestDatasetApi(SupersetTestCase):
         rv = self.put_assert_metric(uri, {}, "refresh")
         assert rv.status_code == 403
 
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     @unittest.skip("test is failing stochastically")
     def test_export_dataset(self):
@@ -2457,7 +2250,8 @@ class TestDatasetApi(SupersetTestCase):
         dataset = (
             db.session.query(SqlaTable).filter_by(table_name="birth_names_2").one()
         )
-        self.items_to_delete = [dataset]
+        db.session.delete(dataset)
+        db.session.commit()
 
     @patch("superset.commands.database.importers.v1.utils.add_permissions")
     def test_import_dataset_overwrite(self, mock_add_permissions):
@@ -2653,7 +2447,8 @@ class TestDatasetApi(SupersetTestCase):
         response = json.loads(rv.data.decode("utf-8"))
         assert response.get("count") == 1
 
-        self.items_to_delete = [table_w_certification]
+        db.session.delete(table_w_certification)
+        db.session.commit()
 
     @pytest.mark.usefixtures("create_virtual_datasets")
     def test_duplicate_virtual_dataset(self):
@@ -2678,7 +2473,8 @@ class TestDatasetApi(SupersetTestCase):
         assert len(new_dataset.columns) == 2
         assert new_dataset.columns[0].column_name == "id"
         assert new_dataset.columns[1].column_name == "name"
-        self.items_to_delete = [new_dataset]
+        db.session.delete(new_dataset)
+        db.session.commit()
 
     @pytest.mark.usefixtures("create_datasets")
     def test_duplicate_physical_dataset(self):
@@ -2808,7 +2604,8 @@ class TestDatasetApi(SupersetTestCase):
         assert table.template_params == '{"param": 1}'
         assert table.normalize_columns is False
 
-        self.items_to_delete = [table]
+        db.session.delete(table)
+        db.session.commit()
 
         with examples_db.get_sqla_engine() as engine:
             engine.execute("DROP TABLE test_create_sqla_table_api")

tests/unit_tests/commands/dataset/test_update.py

@@ -15,125 +15,78 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from typing import Any, cast
+from typing import cast
+from unittest.mock import MagicMock
 
 import pytest
 from marshmallow import ValidationError
 from pytest_mock import MockerFixture
 
-from superset.commands.dataset.exceptions import (
+from superset import db
-    DatabaseNotFoundValidationError,
+from superset.commands.dataset.exceptions import DatasetInvalidError
-    DatasetExistsValidationError,
-    DatasetForbiddenError,
-    DatasetInvalidError,
-    DatasetNotFoundError,
-    MultiCatalogDisabledValidationError,
-)
 from superset.commands.dataset.update import UpdateDatasetCommand, validate_folders
-from superset.commands.exceptions import OwnersNotFoundValidationError
+from superset.connectors.sqla.models import SqlaTable
 from superset.datasets.schemas import FolderSchema
-from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
+from superset.models.core import Database
-from superset.exceptions import SupersetSecurityException
 from tests.unit_tests.conftest import with_feature_flags
 
 
-def test_update_dataset_not_found(mocker: MockerFixture) -> None:
+@pytest.mark.usefixture("session")
+def test_update_uniqueness_error(mocker: MockerFixture) -> None:
     """
-    Test updating an unexisting ID raises a `DatasetNotFoundError`.
+    Test uniqueness validation in dataset update command.
     """
-    mock_dataset_dao = mocker.patch("superset.commands.dataset.update.DatasetDAO")
+    SqlaTable.metadata.create_all(db.session.get_bind())
-    mock_dataset_dao.find_by_id.return_value = None
 
-    with pytest.raises(DatasetNotFoundError):
+    # First, make sure session is clean
-        UpdateDatasetCommand(1, {"name": "test"}).run()
+    db.session.rollback()
 
+    try:
+        # Set up test data
+        database = Database(database_name="my_db", sqlalchemy_uri="sqlite://")
+        bar = SqlaTable(table_name="bar", schema="foo", database=database)
+        baz = SqlaTable(table_name="baz", schema="qux", database=database)
+        db.session.add_all([database, bar, baz])
+        db.session.commit()
 
-def test_update_dataset_forbidden(mocker: MockerFixture) -> None:
+        # Set up mocks
-    """
+        mock_g = mocker.patch("superset.security.manager.g")
-    Test try updating a dataset without permission raises a `DatasetForbiddenError`.
+        mock_g.user = MagicMock()
-    """
+        mocker.patch(
-    mock_dataset_dao = mocker.patch("superset.commands.dataset.update.DatasetDAO")
+            "superset.views.base.security_manager.can_access_all_datasources",
-    mock_dataset_dao.find_by_id.return_value = mocker.MagicMock()
+            return_value=True,
+        )
+        mocker.patch(
+            "superset.commands.dataset.update.security_manager.raise_for_ownership",
+            return_value=None,
+        )
+        mocker.patch.object(UpdateDatasetCommand, "compute_owners", return_value=[])
 
-    mocker.patch(
+        # Run the test that should fail
-        "superset.commands.dataset.update.security_manager.raise_for_ownership",
+        with pytest.raises(DatasetInvalidError):
-        side_effect=SupersetSecurityException(
+            UpdateDatasetCommand(
-            SupersetError(
+                bar.id,
-                error_type=SupersetErrorType.MISSING_OWNERSHIP_ERROR,
+                {
-                message="Sample message",
+                    "table_name": "baz",
-                level=ErrorLevel.ERROR,
+                    "schema": "qux",
+                },
+            ).run()
+    except Exception:
+        db.session.rollback()
+        raise
+    finally:
+        # Clean up - this will run even if the test fails
+        try:
+            db.session.query(SqlaTable).filter(
+                SqlaTable.table_name.in_(["bar", "baz"]),
+                SqlaTable.schema.in_(["foo", "qux"]),
+            ).delete(synchronize_session=False)
+            db.session.query(Database).filter(Database.database_name == "my_db").delete(
+                synchronize_session=False
             )
-        ),
+            db.session.commit()
-    )
+        except Exception:
-
+            db.session.rollback()
-    with pytest.raises(DatasetForbiddenError):
-        UpdateDatasetCommand(1, {"name": "test"}).run()
-
-
-@pytest.mark.parametrize(
-    ("payload, exception, error_msg"),
-    [
-        (
-            {"database_id": 2},
-            DatabaseNotFoundValidationError,
-            "Database does not exist",
-        ),
-        (
-            {"catalog": "test"},
-            MultiCatalogDisabledValidationError,
-            "Only the default catalog is supported for this connection",
-        ),
-        (
-            {"table_name": "table", "schema": "schema"},
-            DatasetExistsValidationError,
-            "Dataset catalog.schema.table already exists",
-        ),
-        (
-            {"owners": [1]},
-            OwnersNotFoundValidationError,
-            "Owners are invalid",
-        ),
-    ],
-)
-def test_update_validation_errors(
-    payload: dict[str, Any],
-    exception: Exception,
-    error_msg: str,
-    mocker: MockerFixture,
-) -> None:
-    """
-    Test validation errors for the `UpdateDatasetCommand`.
-    """
-    mock_dataset_dao = mocker.patch("superset.commands.dataset.update.DatasetDAO")
-    mocker.patch(
-        "superset.commands.dataset.update.security_manager.raise_for_ownership",
-    )
-    mocker.patch("superset.commands.utils.security_manager.is_admin", return_value=True)
-    mocker.patch(
-        "superset.commands.utils.security_manager.get_user_by_id", return_value=None
-    )
-    mock_database = mocker.MagicMock()
-    mock_database.id = 1
-    mock_database.get_default_catalog.return_value = "catalog"
-    mock_database.allow_multi_catalog = False
-    mock_dataset = mocker.MagicMock()
-    mock_dataset.database = mock_database
-    mock_dataset.catalog = "catalog"
-    mock_dataset_dao.find_by_id.return_value = mock_dataset
-
-    if exception == DatabaseNotFoundValidationError:
-        mock_dataset_dao.get_database_by_id.return_value = None
-    else:
-        mock_dataset_dao.get_database_by_id.return_value = mock_database
-
-    if exception == DatasetExistsValidationError:
-        mock_dataset_dao.validate_update_uniqueness.return_value = False
-    else:
-        mock_dataset_dao.validate_update_uniqueness.return_value = True
-
-    with pytest.raises(DatasetInvalidError) as excinfo:
-        UpdateDatasetCommand(1, payload).run()
-    assert any(error_msg in str(exc) for exc in excinfo.value._exceptions)
 
 
 @with_feature_flags(DATASET_FOLDERS=True)

tests/unit_tests/common/test_query_object_factory.py

@@ -14,7 +14,7 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from typing import Any
+from typing import Any, Optional
 from unittest.mock import Mock
 
 from pytest import fixture  # noqa: PT013
@@ -45,15 +45,9 @@ def connector_registry() -> Mock:
     return mock
 
 
-def apply_max_row_limit(
+def apply_max_row_limit(limit: int, max_limit: Optional[int] = None) -> int:
-    limit: int,
+    if max_limit is None:
-    server_pagination: bool | None = None,
+        max_limit = create_app_config()["SQL_MAX_ROW"]
-) -> int:
-    max_limit = (
-        create_app_config()["TABLE_VIZ_MAX_ROW_SERVER"]
-        if server_pagination
-        else create_app_config()["SQL_MAX_ROW"]
-    )
     if limit != 0:
         return min(max_limit, limit)
     return max_limit