# Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. from __future__ import annotations import functools import inspect import logging import textwrap from abc import ABC, abstractmethod from collections.abc import Iterator from contextlib import contextmanager from datetime import datetime, timedelta from typing import Any, Callable, cast, Literal, TYPE_CHECKING from flask import g, has_request_context, request from flask_appbuilder.const import API_URI_RIS_KEY from sqlalchemy.exc import SQLAlchemyError from superset.extensions import stats_logger_manager from superset.utils import json from superset.utils.core import get_user_id, LoggerLevel, to_int if TYPE_CHECKING: pass logger = logging.getLogger(__name__) def collect_request_payload() -> dict[str, Any]: """Collect log payload identifiable from request context""" if not request: return {} payload: dict[str, Any] = { "path": request.path, **request.form.to_dict(), # url search params can overwrite POST body **request.args.to_dict(), } if request.is_json: json_payload = request.get_json(cache=True, silent=True) or {} payload.update(json_payload) # save URL match pattern in addition to the request path url_rule = str(request.url_rule) if url_rule != request.path: payload["url_rule"] = url_rule # remove rison raw string (q=xxx in search params) in favor of # rison object (could come from `payload_override`) if "rison" in payload and API_URI_RIS_KEY in payload: del payload[API_URI_RIS_KEY] # delete empty rison object if "rison" in payload and not payload["rison"]: del payload["rison"] return payload def get_logger_from_status( status: int, ) -> tuple[Callable[..., None], str]: """ Return logger method by status of exception. Maps logger level to status code level """ log_map = { "2": LoggerLevel.INFO, "3": LoggerLevel.INFO, "4": LoggerLevel.WARNING, "5": LoggerLevel.EXCEPTION, } log_level = log_map[str(status)[0]] return (getattr(logger, log_level), log_level) class AbstractEventLogger(ABC): # Parameters that are passed under the `curated_payload` arg to the log method curated_payload_params = { "force", "standalone", "runAsync", "json", "csv", "queryLimit", "select_as_cta", } # Similarly, parameters that are passed under the `curated_form_data` arg curated_form_data_params = { "dashboardId", "sliceId", "viz_type", "force", "compare_lag", "forecastPeriods", "granularity_sqla", "legendType", "legendOrientation", "show_legend", "time_grain_sqla", } def __call__( self, action: str, object_ref: str | None = None, log_to_statsd: bool = True, duration: timedelta | None = None, **payload_override: dict[str, Any], ) -> object: # pylint: disable=W0201 self.action = action self.object_ref = object_ref self.log_to_statsd = log_to_statsd self.payload_override = payload_override return self def __enter__(self) -> None: # pylint: disable=W0201 self.start = datetime.now() def __exit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> None: # Log data w/ arguments being passed in self.log_with_context( action=self.action, object_ref=self.object_ref, log_to_statsd=self.log_to_statsd, duration=datetime.now() - self.start, **self.payload_override, ) @classmethod def curate_payload(cls, payload: dict[str, Any]) -> dict[str, Any]: """Curate payload to only include relevant keys/safe keys""" return {k: v for k, v in payload.items() if k in cls.curated_payload_params} @classmethod def curate_form_data(cls, payload: dict[str, Any]) -> dict[str, Any]: """Curate form_data to only include relevant keys/safe keys""" return {k: v for k, v in payload.items() if k in cls.curated_form_data_params} @abstractmethod def log( # pylint: disable=too-many-arguments self, user_id: int | None, action: str, dashboard_id: int | None, duration_ms: int | None, slice_id: int | None, referrer: str | None, curated_payload: dict[str, Any] | None, curated_form_data: dict[str, Any] | None, *args: Any, **kwargs: Any, ) -> None: pass def log_with_context( # pylint: disable=too-many-locals,too-many-arguments self, action: str, duration: timedelta | None = None, object_ref: str | None = None, log_to_statsd: bool = True, database: Any | None = None, **payload_override: dict[str, Any] | None, ) -> None: # pylint: disable=import-outside-toplevel from superset import db from superset.views.core import get_form_data referrer = request.referrer[:1000] if request and request.referrer else None duration_ms = int(duration.total_seconds() * 1000) if duration else None # Initial try and grab user_id via flask.g.user user_id = get_user_id() # Whenever a user is not bounded to a session we # need to add them back before logging to capture user_id if user_id is None and has_request_context(): try: actual_user = g.get("user", None) if actual_user is not None: db.session.add(actual_user) user_id = get_user_id() except Exception as ex: logging.warning("Failed to add user to db session: %s", ex) user_id = None payload = collect_request_payload() if object_ref: payload["object_ref"] = object_ref if payload_override: payload.update(payload_override) dashboard_id = to_int(payload.get("dashboard_id")) database_params = {"database_id": payload.get("database_id")} if database and type(database).__name__ == "Database": database_params = { "database_id": database.id, "engine": database.backend, "database_driver": database.driver, } form_data: dict[str, Any] = {} if "form_data" in payload: form_data, _ = get_form_data() payload["form_data"] = form_data slice_id = form_data.get("slice_id") else: slice_id = payload.get("slice_id") slice_id = to_int(slice_id) if log_to_statsd: stats_logger_manager.instance.incr(action) try: # bulk insert explode_by = payload.get("explode") records = json.loads(payload.get(explode_by)) # type: ignore except Exception: # pylint: disable=broad-except records = [payload] self.log( user_id, action, records=records, dashboard_id=dashboard_id, slice_id=slice_id, duration_ms=duration_ms, referrer=referrer, curated_payload=self.curate_payload(payload), curated_form_data=self.curate_form_data(form_data), **database_params, ) @contextmanager def log_context( self, action: str, object_ref: str | None = None, log_to_statsd: bool = True, **kwargs: Any, ) -> Iterator[Callable[..., None]]: """ Log an event with additional information from the request context. :param action: a name to identify the event :param object_ref: reference to the Python object that triggered this action :param log_to_statsd: whether to update statsd counter for the action """ payload_override = kwargs.copy() start = datetime.now() # yield a helper to add additional payload yield lambda **kwargs: payload_override.update(kwargs) duration = datetime.now() - start # take the action from payload_override else take the function param action action_str = payload_override.pop("action", action) self.log_with_context( action_str, duration, object_ref, log_to_statsd, **payload_override ) def _wrapper( self, f: Callable[..., Any], action: str | Callable[..., str] | None = None, object_ref: str | Callable[..., str] | Literal[False] | None = None, allow_extra_payload: bool | None = False, **wrapper_kwargs: Any, ) -> Callable[..., Any]: @functools.wraps(f) def wrapper(*args: Any, **kwargs: Any) -> Any: action_str = ( action(*args, **kwargs) if callable(action) else action ) or f.__name__ object_ref_str = ( object_ref(*args, **kwargs) if callable(object_ref) else object_ref ) or (f.__qualname__ if object_ref is not False else None) with self.log_context( action=action_str, object_ref=object_ref_str, **wrapper_kwargs ) as log: log(**kwargs) if allow_extra_payload: # add a payload updater to the decorated function value = f(*args, add_extra_log_payload=log, **kwargs) else: value = f(*args, **kwargs) return value return wrapper def log_this(self, f: Callable[..., Any]) -> Callable[..., Any]: """Decorator that uses the function name as the action""" return self._wrapper(f) def log_this_with_context( self, allow_extra_payload: bool = False, **kwargs: Any ) -> Callable[..., Any]: """Decorator that can override kwargs of log_context""" def func(f: Callable[..., Any]) -> Callable[..., Any]: return self._wrapper(f, allow_extra_payload=allow_extra_payload, **kwargs) return func def log_this_with_extra_payload(self, f: Callable[..., Any]) -> Callable[..., Any]: """Decorator that instrument `update_log_payload` to kwargs""" return self._wrapper(f, allow_extra_payload=True) def get_event_logger_from_cfg_value(cfg_value: Any) -> AbstractEventLogger: """ This function implements the deprecation of assignment of class objects to EVENT_LOGGER configuration, and validates type of configured loggers. The motivation for this method is to gracefully deprecate the ability to configure EVENT_LOGGER with a class type, in favor of preconfigured instances which may have required construction-time injection of proprietary or locally-defined dependencies. :param cfg_value: The configured EVENT_LOGGER value to be validated :return: if cfg_value is a class type, will return a new instance created using a default con """ result: Any = cfg_value if inspect.isclass(cfg_value): logging.warning( textwrap.dedent( """ In superset private config, EVENT_LOGGER has been assigned a class object. In order to accommodate pre-configured instances without a default constructor, assignment of a class is deprecated and may no longer work at some point in the future. Please assign an object instance of a type that implements superset.utils.log.AbstractEventLogger. """ ) ) event_logger_type = cast(type[Any], cfg_value) result = event_logger_type() # Verify that we have a valid logger impl if not isinstance(result, AbstractEventLogger): raise TypeError( "EVENT_LOGGER must be configured with a concrete instance" "of superset.utils.log.AbstractEventLogger." ) logging.debug("Configured event logger of type %s", type(result)) return cast(AbstractEventLogger, result) class DBEventLogger(AbstractEventLogger): """Event logger that commits logs to Superset DB""" def log( # pylint: disable=too-many-arguments,too-many-locals self, user_id: int | None, action: str, dashboard_id: int | None, duration_ms: int | None, slice_id: int | None, referrer: str | None, *args: Any, **kwargs: Any, ) -> None: # pylint: disable=import-outside-toplevel from superset import db from superset.models.core import Log records = kwargs.get("records", []) logs = [] for record in records: json_string: str | None try: json_string = json.dumps(record) except Exception: # pylint: disable=broad-except json_string = None log = Log( action=action, json=json_string, dashboard_id=dashboard_id or record.get("dashboard_id"), slice_id=slice_id or record.get("slice_id"), duration_ms=duration_ms, referrer=referrer, user_id=user_id, ) logs.append(log) try: db.session.bulk_save_objects(logs) db.session.commit() # pylint: disable=consider-using-transaction except SQLAlchemyError as ex: # Log errors but don't raise - logging failures should not break the # application. Common in tests where the session may be in prepared state or # db is locked logging.error("DBEventLogger failed to log event(s)") logging.exception(ex) # Rollback to clean up the session state try: db.session.rollback() except Exception: # pylint: disable=broad-except # If rollback also fails, just continue - don't let issues crash the app logging.error( "DBEventLogger failed to rollback the session after failure" ) class StdOutEventLogger(AbstractEventLogger): """Event logger that prints to stdout for debugging purposes""" def log( # pylint: disable=too-many-arguments self, user_id: int | None, action: str, dashboard_id: int | None, duration_ms: int | None, slice_id: int | None, referrer: str | None, curated_payload: dict[str, Any] | None, curated_form_data: dict[str, Any] | None, *args: Any, **kwargs: Any, ) -> None: data = dict( # pylint: disable=use-dict-literal user_id=user_id, action=action, dashboard_id=dashboard_id, duration_ms=duration_ms, slice_id=slice_id, referrer=referrer, curated_payload=curated_payload, curated_form_data=curated_form_data, **kwargs, ) print("StdOutEventLogger: ", data)