mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
7e51b200b4
* SQL-TOP Fix For Database Engines MSSQL is not supporting LIMIT syntax in SQLs. For limiting the rows, MSSQL having a different keyword TOP. Added fixes for handling the TOP and LIMIT clauses based on the database engines. * Teradata code for top clause handling removed from teradata.py Teradata code for top clause handling removed from teradata.py file, since we added generic section in base engine for the same. * Changes to handle CTE along with TOP in complex SQLs Added changes to handle TOP command in CTEs, for DB Engines which are not supporting inline CTEs. * Test cases for TOP unit testing in MSSQL Added multiple unit test cases for MSSQL top command handling and also along with CTEs * Corrected the select_keywords name key in basengine Corrected the select_keywords name key in basengine * Changes based on as per review. made the required corrections based on code review to keep good code readability and code cleanliness. * Review changes to correct lint and typo issues Made the changes according to the review comments. * fix linting errors * fix teradata tests * add coverage * lint * Code cleanliness Moved the top/limit flag check from sql_lab to core. * Changed for code cleanliness Changes for keeping code cleanliness * Corrected lint issue Corrected lint issue. * Code cleanliness Code cleanliness Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
50 lines
1.9 KiB
Python
50 lines
1.9 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from superset.db_engine_specs.base import BaseEngineSpec, LimitMethod
|
|
|
|
|
|
class TeradataEngineSpec(BaseEngineSpec):
|
|
"""Dialect for Teradata DB."""
|
|
|
|
engine = "teradatasql"
|
|
engine_name = "Teradata"
|
|
limit_method = LimitMethod.WRAP_SQL
|
|
max_column_name_length = 30 # since 14.10 this is 128
|
|
allow_limit_clause = False
|
|
select_keywords = {"SELECT", "SEL"}
|
|
top_keywords = {"TOP", "SAMPLE"}
|
|
|
|
_time_grain_expressions = {
|
|
None: "{col}",
|
|
"PT1M": "TRUNC(CAST({col} as DATE), 'MI')",
|
|
"PT1H": "TRUNC(CAST({col} as DATE), 'HH')",
|
|
"P1D": "TRUNC(CAST({col} as DATE), 'DDD')",
|
|
"P1W": "TRUNC(CAST({col} as DATE), 'WW')",
|
|
"P1M": "TRUNC(CAST({col} as DATE), 'MONTH')",
|
|
"P0.25Y": "TRUNC(CAST({col} as DATE), 'Q')",
|
|
"P1Y": "TRUNC(CAST({col} as DATE), 'YEAR')",
|
|
}
|
|
|
|
@classmethod
|
|
def epoch_to_dttm(cls) -> str:
|
|
return (
|
|
"CAST(((CAST(DATE '1970-01-01' + ({col} / 86400) AS TIMESTAMP(0) "
|
|
"AT 0)) AT 0) + (({col} MOD 86400) * INTERVAL '00:00:01' "
|
|
"HOUR TO SECOND) AS TIMESTAMP(0))"
|
|
)
|