mirror of
https://github.com/apache/superset.git
synced 2026-05-07 17:04:58 +00:00
d79eb5842a
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
109 lines
3.7 KiB
Python
109 lines
3.7 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""Tests for MCP privacy helpers."""
|
|
|
|
import pytest
|
|
|
|
from superset.mcp_service.chart.schemas import ChartInfo
|
|
from superset.mcp_service.dashboard.schemas import DashboardInfo
|
|
from superset.mcp_service.database.schemas import DatabaseInfo
|
|
from superset.mcp_service.dataset.schemas import DatasetInfo
|
|
from superset.mcp_service.privacy import (
|
|
is_data_model_metadata_error,
|
|
redact_chart_data_model_fields,
|
|
)
|
|
|
|
|
|
def test_is_data_model_metadata_error_accepts_missing_privacy_scope() -> None:
|
|
assert (
|
|
is_data_model_metadata_error(
|
|
{
|
|
"error": "denied",
|
|
"error_type": "DataModelMetadataRestricted",
|
|
"timestamp": "2026-04-23T11:20:54.286885",
|
|
}
|
|
)
|
|
is True
|
|
)
|
|
|
|
|
|
def test_is_data_model_metadata_error_rejects_wrong_privacy_scope() -> None:
|
|
assert (
|
|
is_data_model_metadata_error(
|
|
{
|
|
"error": "denied",
|
|
"error_type": "DataModelMetadataRestricted",
|
|
"privacy_scope": "user_directory",
|
|
}
|
|
)
|
|
is False
|
|
)
|
|
|
|
|
|
def test_redact_chart_data_model_fields_removes_restricted_fields() -> None:
|
|
chart_info = ChartInfo(
|
|
id=1,
|
|
slice_name="Revenue",
|
|
datasource_name="sales",
|
|
datasource_type="table",
|
|
filters={"time_range": "Last year"},
|
|
form_data={"datasource": "1__table"},
|
|
)
|
|
|
|
redacted = redact_chart_data_model_fields(chart_info)
|
|
|
|
assert redacted.datasource_name is None
|
|
assert redacted.datasource_type is None
|
|
assert redacted.filters is None
|
|
assert redacted.form_data is None
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"model",
|
|
[
|
|
ChartInfo(id=1, slice_name="Revenue"),
|
|
DashboardInfo(id=1, dashboard_title="Executive Dashboard", owners=[], roles=[]),
|
|
DatasetInfo(id=1, table_name="sales"),
|
|
DatabaseInfo(id=1, database_name="warehouse"),
|
|
],
|
|
)
|
|
def test_user_directory_fields_removed_from_python_and_json_dumps(model):
|
|
"""Privacy fields are stripped regardless of Pydantic serialization mode."""
|
|
for mode in (None, "json"):
|
|
data = model.model_dump() if mode is None else model.model_dump(mode=mode)
|
|
|
|
for field in ("created_by", "changed_by", "owners", "roles"):
|
|
assert field not in data
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("schema_cls", "omitted_fields"),
|
|
[
|
|
(ChartInfo, {"created_by", "changed_by", "changed_by_name", "owners"}),
|
|
(DashboardInfo, {"created_by", "changed_by", "owners", "roles"}),
|
|
(DatasetInfo, {"created_by", "changed_by", "owners"}),
|
|
(DatabaseInfo, {"created_by", "changed_by"}),
|
|
],
|
|
)
|
|
def test_user_directory_fields_removed_from_json_schema(schema_cls, omitted_fields):
|
|
"""Privacy-only response fields should not appear in the published schema."""
|
|
properties = schema_cls.model_json_schema().get("properties", {})
|
|
|
|
for field in omitted_fields:
|
|
assert field not in properties
|