Files
superset2/superset-frontend/spec
Joe Li 34f1b2712e refactor(subdirectory): trim over-commented helpers and tests
The first iteration carried a lot of conversation context as inline
prose — section banners, "Layer N example", reinstatement plans for
parallel files that don't exist yet, multi-paragraph rationale for
single-line decisions. Code that lives in master should explain only
what's not obvious from the code itself.

This commit removes ~350 lines of comments from 9 files. Behaviour is
unchanged. Notable trims:

  • normalizeBackendUrls.ts: 210 → 124 lines. First line of code now at
    line 28 instead of line 61. Lengthy "why this is conservative" prose
    folded into a short three-line note; per-helper docstrings kept only
    where they explain non-obvious contracts.
  • navigationUtils.ts: 177 → 107 lines. Section banners removed; the
    short rationale for declaring primitives first and the comment on
    the safe-URL allow-list kept since both surface non-obvious gotchas
    (oxlint hoisting, CodeQL sanitiser visibility).
  • Test files: dropped "Layer N example", "the full PR adds parallel
    suites for X", and "this file ships one as a template" framing.
    Kept the mock-prefix and TDZ comments in the SliceHeaderControls
    test since both rules are easy to violate.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-08 14:51:16 -07:00
..