mirror of
https://github.com/apache/superset.git
synced 2026-04-10 11:55:24 +00:00
* Initial commit of new filters badge. * refactor applied/rejected filters code * finished filter indicators * filter badge tested * unnecessary imports * formatting and types * fixes * license * code quality tweaks * state management for showing focused filter scope * clean up filter key extraction code * remove unnecessary styles * temp css to demonstrate highlighting * fix focused filter logic * no more color badges * new toys for highlighting dash components (#11144) * tweak style for the filter chart when filter is focused * style: Filters p0 css2 (#11151) * nixing background tweak * src paths * another quick theme color * src paths, adjusting pill icon color, changing icons, showing applied/busted counts * linting stuff * fixing and tweaking tests * show filter indicator when filters are not active * chart title bar cleanup * open the right panel when popover opens * unused import * fix EditableTitle tests * margin on dashboard header * show the chart dropdown menu * fix blur filter breaking dropdowns * style tweak - no pointer events when irrelevant charts are blurred * fix box shadow on filter highlight * it's an array * attempt fixing e2e * style: filters p0 icon churn (#11215) * new filters icon * icon styling * bigger icons in list views * better sizing of table actions and favStars * more icon sizing... * fixing more button size jankiness * linting * Filters performance (#11255) * fixing time filter "ok" button * making unset filter menu collapsible * sort alphabetically * fix highlighting when removing items * try a flex layout (for browser render perf) * more specific transitioning * temp: comment out some code as a test * temp: comment out more code * temp: remove possibly expensive computations from ChartHolder * Revert "temp: comment out some code as a test" This reverts commit309b880e90. * Revert "temp: comment out more code" This reverts commit64c88b2cba. * Revert "temp: remove possibly expensive computations from ChartHolder" This reverts commit37ce0214f0. * experiment: upgrade react-select to v3 * Revert "experiment: upgrade react-select to v3" This reverts commitc3972ba486. * fix the damn problem * remove code used for testing purposes * awful hack to avoid adding a class to a container * approaching infinity... and not beyond! * fix ref forwarding * add theme to tests as necessary * fix(extra-filters): add logic for identifying applied extra filters (#11325) * fix: use dashboard id for stable cache key (#11293) * fix: button translations missing (#11187) * button translations missing * blank space before text * feat: update time_compare description and choices (#11294) * feat: update time_compare description and choices * Update sections.jsx * fix(extra-filters): add logic for identifying applied extra filters * lint Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: rubenSastre <ruben.sastre@decathlon.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> * address design feedback * slight tweak to panel logic, keep panels open that user has opened * rearrange code to be more graceful * fix: bump superset-ui/core (#11385) * use is_dttm instead of is_temporal * types, names * only show unset filter panel if there are unset filters * fix highlighting the filter control * fix filterbox layout * translations * fix cypress * actually add the test attribute * Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * formatting * add link comment to hack * Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * stop importing lodash * Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * skip broken test * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * adjust colors of titles * linting * no indicators when chart is loading * support all time fields * fix lock file Co-authored-by: Natalie Ruhe <natalie@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: rubenSastre <ruben.sastre@decathlon.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
145 lines
5.1 KiB
JavaScript
145 lines
5.1 KiB
JavaScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import { Provider } from 'react-redux';
|
|
import React from 'react';
|
|
import { styledMount as mount } from 'spec/helpers/theming';
|
|
import sinon from 'sinon';
|
|
|
|
import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
|
|
import DeleteComponentModal from 'src/dashboard/components/DeleteComponentModal';
|
|
import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
|
|
import EditableTitle from 'src/components/EditableTitle';
|
|
import WithPopoverMenu from 'src/dashboard/components/menu/WithPopoverMenu';
|
|
import Tab, {
|
|
RENDER_TAB,
|
|
RENDER_TAB_CONTENT,
|
|
} from 'src/dashboard/components/gridComponents/Tab';
|
|
import WithDragDropContext from '../../helpers/WithDragDropContext';
|
|
import { dashboardLayoutWithTabs } from '../../fixtures/mockDashboardLayout';
|
|
import { mockStoreWithTabs } from '../../fixtures/mockStore';
|
|
|
|
describe('Tabs', () => {
|
|
const props = {
|
|
id: 'TAB_ID',
|
|
parentId: 'TABS_ID',
|
|
component: dashboardLayoutWithTabs.present.TAB_ID,
|
|
parentComponent: dashboardLayoutWithTabs.present.TABS_ID,
|
|
index: 0,
|
|
depth: 1,
|
|
editMode: false,
|
|
renderType: RENDER_TAB,
|
|
onDropOnTab() {},
|
|
onDeleteTab() {},
|
|
availableColumnCount: 12,
|
|
columnWidth: 50,
|
|
onResizeStart() {},
|
|
onResize() {},
|
|
onResizeStop() {},
|
|
createComponent() {},
|
|
handleComponentDrop() {},
|
|
onChangeTab() {},
|
|
deleteComponent() {},
|
|
updateComponents() {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
// We have to wrap provide DragDropContext for the underlying DragDroppable
|
|
// otherwise we cannot assert on DragDroppable children
|
|
const wrapper = mount(
|
|
<Provider store={mockStoreWithTabs}>
|
|
<WithDragDropContext>
|
|
<Tab {...props} {...overrideProps} />
|
|
</WithDragDropContext>
|
|
</Provider>,
|
|
);
|
|
return wrapper;
|
|
}
|
|
|
|
describe('renderType=RENDER_TAB', () => {
|
|
it('should render a DragDroppable', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(DragDroppable)).toExist();
|
|
});
|
|
|
|
it('should render an EditableTitle with meta.text', () => {
|
|
const wrapper = setup();
|
|
const title = wrapper.find(EditableTitle);
|
|
expect(title).toHaveLength(1);
|
|
expect(title.find('.editable-title')).toHaveText(
|
|
props.component.meta.text,
|
|
);
|
|
});
|
|
|
|
it('should call updateComponents when EditableTitle changes', () => {
|
|
const updateComponents = sinon.spy();
|
|
const wrapper = setup({ editMode: true, updateComponents });
|
|
wrapper.find(EditableTitle).prop('onSaveTitle')('New title');
|
|
|
|
expect(updateComponents.callCount).toBe(1);
|
|
expect(updateComponents.getCall(0).args[0].TAB_ID.meta.text).toBe(
|
|
'New title',
|
|
);
|
|
});
|
|
|
|
it('should render a WithPopoverMenu', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(WithPopoverMenu)).toExist();
|
|
});
|
|
|
|
it('should render a DeleteComponentModal when focused if its not the only tab', () => {
|
|
let wrapper = setup();
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
expect(wrapper.find(DeleteComponentModal)).not.toExist();
|
|
|
|
wrapper = setup({ editMode: true });
|
|
wrapper.find(WithPopoverMenu).simulate('click');
|
|
expect(wrapper.find(DeleteComponentModal)).toExist();
|
|
|
|
wrapper = setup({
|
|
editMode: true,
|
|
parentComponent: {
|
|
...props.parentComponent,
|
|
children: props.parentComponent.children.slice(0, 1),
|
|
},
|
|
});
|
|
wrapper.find(WithPopoverMenu).simulate('click');
|
|
expect(wrapper.find(DeleteComponentModal)).not.toExist();
|
|
});
|
|
|
|
it('should show modal when clicked delete icon', () => {
|
|
const deleteComponent = sinon.spy();
|
|
const wrapper = setup({ editMode: true, deleteComponent });
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
wrapper.find('.icon-button').simulate('click');
|
|
|
|
const modal = document.getElementsByClassName('ant-modal');
|
|
expect(modal).toHaveLength(1);
|
|
expect(deleteComponent.callCount).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('renderType=RENDER_TAB_CONTENT', () => {
|
|
it('should render a DashboardComponent', () => {
|
|
const wrapper = setup({ renderType: RENDER_TAB_CONTENT });
|
|
// We expect 2 because this Tab has a Row child and the row has a Chart
|
|
expect(wrapper.find(DashboardComponent)).toHaveLength(2);
|
|
});
|
|
});
|
|
});
|