mirror of
https://github.com/apache/superset.git
synced 2026-04-15 22:25:15 +00:00
* Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Fix the white background shown in SQL editor on drag (#7021) This PR sets the background-color css property on `.ace_scroller` instead of `.ace_content` to prevent the white background shown during resizing of the SQL editor before drag ends. * Show tooltip with time frame (#6979) * Fix time filter control (#6978) * Enhancement of query context and object. (#6962) * added more functionalities for query context and object. * fixed cache logic * added default value for groupby * updated comments and removed print (cherry picked from commitd5b9795f87) * [fix] /superset/slice/id url is too long (#6989) (cherry picked from commit6a4d507ab6) * [WIP] fix user specified JSON metadata not updating dashboard on refresh (#7027) (cherry picked from commitcc58f0e661) * feat: add ability to change font size in big number (#7003) * Add ability to change font sizes in Big Number * rename big number to header * Add comment to clarify font size values * Allow LIMIT to be specified in parameters (#7052) * [fix] Cursor jumping when editing chart and dashboard titles (#7038) (cherry picked from commitfc1770f7b7) * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit7f3c145b1f) * [db-engine-spec] Aligning Hive/Presto partition logic (#7007) (cherry picked from commit05be866117) * [fix] explore chart from dashboard missed slice title (#7046) (cherry picked from commita6d48d4052) * fix inaccurate data calculation with adata rolling and contribution (#7035) (cherry picked from commit0782e831cd) * Adding warning message for sqllab save query (#7028) (cherry picked from commitead3d48133) * [datasource] Ensuring consistent behavior of datasource editing/saving. (#7037) * Update datasource.py * Update datasource.py (cherry picked from commitc771625f10) * [csv-upload] Fixing message encoding (#6971) (cherry picked from commit48431ab5b9) * [sql-parse] Fixing LIMIT exceptions (#6963) (cherry picked from commit3e076cb60b) * Adding custom control overrides (#6956) * Adding extraOverrides to line chart * Updating extraOverrides to fit with more cases * Moving extraOverrides to index.js * Removing webpack-merge in package.json * Fixing metrics control clearing metric (cherry picked from commite6194051f4) * [sqlparse] Fixing table name extraction for ill-defined query (#7029) (cherry picked from commit07c340cf82) * [missing values] Removing replacing missing values (#4905) (cherry picked from commit61add606ca) * [SQL Lab] Improved query and results tabs rendering reliability (#7082) closes #7080 (cherry picked from commit9b58e9f492) * Fix filter_box migration PR #6523 (#7066) * Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commitb210742ad2) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit71f1bbd2ec) * [forms] Fix handling of NULLs (cherry picked from commite83a07d3df) * handle null column_name in sqla and druid models (cherry picked from commit2ff721ae07) * Use metric name instead of metric in filter box (#7106) (cherry picked from commit003364e74e) * Bump python lib croniter to an existing version (#7132) Package maintainers should really never delete packages, but it appears this happened with croniter and resulted in breaking our builds. This PR bumps to a more recent existing version of the library (cherry picked from commit215ed392a1) * Revert PR #6933 (#7162) * Add decorator for etag cache * Fetch charts with GET * Small fixes * Fix typo * Compute correct cache key; fix logging * Check perms on cached response * Revert change * If perms fail, return naked response * Fix lint * Compute cache key from all form data * Pass extra_filters in GET request * Fix pylint * Fix flake8 * Use ETags even if no cache is set * Handle adhoc filters * Raise in debug mode * Rename actions * Fix integration tests * Do POST request on new charts * Set extra/adhoc filters only in GET requests * Raise if check_perms fails * Refactor auth * Fix flake8 * Fix js unit tests * Fix js unit tests that fail in lyftga * Fix js * Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit7f3c145b1f) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit71f1bbd2ec) * Add decorator for etag cache * Fetch charts with GET * Small fixes * Fix typo * Compute correct cache key; fix logging * Check perms on cached response * Revert change * If perms fail, return naked response * Fix lint * Compute cache key from all form data * Pass extra_filters in GET request * Fix pylint * Fix flake8 * Use ETags even if no cache is set * Handle adhoc filters * Raise in debug mode * Rename actions * Fix integration tests * Do POST request on new charts * Set extra/adhoc filters only in GET requests * Raise if check_perms fails * Refactor auth * Fix flake8 * Fix js unit tests * Fix js unit tests that fail in lyftga * Fix js * Fix bad merge * Use far future when max_age=0
260 lines
8.2 KiB
JavaScript
260 lines
8.2 KiB
JavaScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import Dashboard from '../../../../src/dashboard/components/Dashboard';
|
|
import DashboardBuilder from '../../../../src/dashboard/containers/DashboardBuilder';
|
|
|
|
// mock data
|
|
import chartQueries, { sliceId as chartId } from '../fixtures/mockChartQueries';
|
|
import datasources from '../../../fixtures/mockDatasource';
|
|
import dashboardInfo from '../fixtures/mockDashboardInfo';
|
|
import { dashboardLayout } from '../fixtures/mockDashboardLayout';
|
|
import dashboardState from '../fixtures/mockDashboardState';
|
|
import { sliceEntitiesForChart as sliceEntities } from '../fixtures/mockSliceEntities';
|
|
|
|
import { CHART_TYPE } from '../../../../src/dashboard/util/componentTypes';
|
|
import newComponentFactory from '../../../../src/dashboard/util/newComponentFactory';
|
|
|
|
describe('Dashboard', () => {
|
|
const props = {
|
|
actions: {
|
|
addSliceToDashboard() {},
|
|
removeSliceFromDashboard() {},
|
|
postChartFormData() {},
|
|
logEvent() {},
|
|
},
|
|
initMessages: [],
|
|
dashboardState,
|
|
dashboardInfo,
|
|
charts: chartQueries,
|
|
slices: sliceEntities.slices,
|
|
datasources,
|
|
layout: dashboardLayout.present,
|
|
timeout: 60,
|
|
userId: dashboardInfo.userId,
|
|
impressionId: 'id',
|
|
loadStats: {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
const wrapper = shallow(<Dashboard {...props} {...overrideProps} />);
|
|
return wrapper;
|
|
}
|
|
|
|
it('should render a DashboardBuilder', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(DashboardBuilder)).toHaveLength(1);
|
|
});
|
|
|
|
describe('refreshExcept', () => {
|
|
const overrideCharts = {
|
|
...chartQueries,
|
|
1001: {
|
|
...chartQueries[chartId],
|
|
id: 1001,
|
|
},
|
|
};
|
|
|
|
const overrideSlices = {
|
|
...props.slices,
|
|
1001: {
|
|
...props.slices[chartId],
|
|
slice_id: 1001,
|
|
},
|
|
};
|
|
|
|
it('should call postChartFormData for all non-exempt slices', () => {
|
|
const wrapper = setup({ charts: overrideCharts, slices: overrideSlices });
|
|
const spy = sinon.spy(props.actions, 'postChartFormData');
|
|
wrapper.instance().refreshExcept('1001');
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(Object.keys(overrideCharts).length - 1);
|
|
});
|
|
|
|
it('should not call postChartFormData for filter_immune_slices', () => {
|
|
const wrapper = setup({
|
|
charts: overrideCharts,
|
|
dashboardInfo: {
|
|
...dashboardInfo,
|
|
metadata: {
|
|
...dashboardInfo.metadata,
|
|
filter_immune_slices: Object.keys(overrideCharts).map(id =>
|
|
Number(id),
|
|
),
|
|
},
|
|
},
|
|
});
|
|
const spy = sinon.spy(props.actions, 'postChartFormData');
|
|
wrapper.instance().refreshExcept();
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('componentWillReceiveProps', () => {
|
|
const layoutWithExtraChart = {
|
|
...props.layout,
|
|
1001: newComponentFactory(CHART_TYPE, { chartId: 1001 }),
|
|
};
|
|
|
|
it('should call addSliceToDashboard if a new slice is added to the layout', () => {
|
|
const wrapper = setup();
|
|
const spy = sinon.spy(props.actions, 'addSliceToDashboard');
|
|
wrapper.instance().componentWillReceiveProps({
|
|
...props,
|
|
layout: layoutWithExtraChart,
|
|
});
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call removeSliceFromDashboard if a slice is removed from the layout', () => {
|
|
const wrapper = setup({ layout: layoutWithExtraChart });
|
|
const spy = sinon.spy(props.actions, 'removeSliceFromDashboard');
|
|
const nextLayout = { ...layoutWithExtraChart };
|
|
delete nextLayout[1001];
|
|
|
|
wrapper.instance().componentWillReceiveProps({
|
|
...props,
|
|
layout: nextLayout,
|
|
});
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe('componentDidUpdate', () => {
|
|
const overrideDashboardState = {
|
|
...dashboardState,
|
|
filters: {
|
|
1: { region: [] },
|
|
2: { country_name: ['USA'] },
|
|
},
|
|
refresh: true,
|
|
};
|
|
|
|
it('should not call refresh when there is no change', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
const prevProps = wrapper.instance().props;
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
},
|
|
});
|
|
wrapper.instance().componentDidUpdate(prevProps);
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(0);
|
|
});
|
|
|
|
it('should call refresh if a filter is added', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
3: { another_filter: ['please'] },
|
|
},
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call refresh if a filter is removed', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {},
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call refresh if a filter is changed', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
2: { country_name: ['Canada'] },
|
|
},
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should not call refresh if filters change and refresh is false', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
2: { country_name: ['Canada'] },
|
|
},
|
|
refresh: false,
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(0);
|
|
});
|
|
|
|
it('should not refresh filter_immune_slices', () => {
|
|
const wrapper = setup({
|
|
dashboardState: overrideDashboardState,
|
|
dashboardInfo: {
|
|
...dashboardInfo,
|
|
metadata: {
|
|
...dashboardInfo.metadata,
|
|
filter_immune_slices: [chartId],
|
|
},
|
|
},
|
|
});
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
const prevProps = wrapper.instance().props;
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
2: { country_name: ['Canada'] },
|
|
},
|
|
refresh: false,
|
|
},
|
|
});
|
|
wrapper.instance().componentDidUpdate(prevProps);
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(0);
|
|
});
|
|
});
|
|
});
|