mirror of
https://github.com/apache/superset.git
synced 2026-04-24 10:35:01 +00:00
* Changed security permissions for annotations and annotation layers * Updated permissions in annotation layers list * Created test for retrieving premissions info. Updated uris from f-strings to strings * Updated annotations in security_tests and added annotations to NEW_SECURITY_CONVERGE_VIEWS * Added migration for annotations security converge * Updated current revision after rebase master * Updated migration name to annotations security converge * Updated annotations permissions names in AnnotationLayersList and updated test since 'can_write' has wider permissions * Updated annotations migration to current
85 lines
3.0 KiB
Python
85 lines
3.0 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
"""security converge annotations
|
|
|
|
Revision ID: c25cb2c78727
|
|
Revises: ccb74baaa89b
|
|
Create Date: 2020-12-11 17:02:21.213046
|
|
|
|
"""
|
|
|
|
from alembic import op
|
|
from sqlalchemy.exc import SQLAlchemyError
|
|
from sqlalchemy.orm import Session
|
|
|
|
# revision identifiers, used by Alembic.
|
|
from superset.migrations.shared.security_converge import (
|
|
add_pvms,
|
|
get_reversed_new_pvms,
|
|
get_reversed_pvm_map,
|
|
migrate_roles,
|
|
Pvm,
|
|
)
|
|
|
|
revision = "c25cb2c78727"
|
|
down_revision = "ccb74baaa89b"
|
|
|
|
|
|
NEW_PVMS = {"Annotation": ("can_read", "can_write",)}
|
|
PVM_MAP = {
|
|
Pvm("AnnotationLayerModelView", "can_delete"): (Pvm("Annotation", "can_write"),),
|
|
Pvm("AnnotationLayerModelView", "can_list"): (Pvm("Annotation", "can_read"),),
|
|
Pvm("AnnotationLayerModelView", "can_show",): (Pvm("Annotation", "can_read"),),
|
|
Pvm("AnnotationLayerModelView", "can_add",): (Pvm("Annotation", "can_write"),),
|
|
Pvm("AnnotationLayerModelView", "can_edit",): (Pvm("Annotation", "can_write"),),
|
|
Pvm("AnnotationModelView", "can_annotation",): (Pvm("Annotation", "can_read"),),
|
|
Pvm("AnnotationModelView", "can_show",): (Pvm("Annotation", "can_read"),),
|
|
Pvm("AnnotationModelView", "can_add",): (Pvm("Annotation", "can_write"),),
|
|
Pvm("AnnotationModelView", "can_delete",): (Pvm("Annotation", "can_write"),),
|
|
Pvm("AnnotationModelView", "can_edit",): (Pvm("Annotation", "can_write"),),
|
|
Pvm("AnnotationModelView", "can_list",): (Pvm("Annotation", "can_read"),),
|
|
}
|
|
|
|
|
|
def upgrade():
|
|
bind = op.get_bind()
|
|
session = Session(bind=bind)
|
|
|
|
# Add the new permissions on the migration itself
|
|
add_pvms(session, NEW_PVMS)
|
|
migrate_roles(session, PVM_MAP)
|
|
try:
|
|
session.commit()
|
|
except SQLAlchemyError as ex:
|
|
print(f"An error occurred while upgrading annotation permissions: {ex}")
|
|
session.rollback()
|
|
|
|
|
|
def downgrade():
|
|
bind = op.get_bind()
|
|
session = Session(bind=bind)
|
|
|
|
# Add the old permissions on the migration itself
|
|
add_pvms(session, get_reversed_new_pvms(PVM_MAP))
|
|
migrate_roles(session, get_reversed_pvm_map(PVM_MAP))
|
|
try:
|
|
session.commit()
|
|
except SQLAlchemyError as ex:
|
|
print(f"An error occurred while downgrading annotation permissions: {ex}")
|
|
session.rollback()
|
|
pass
|