Files
superset2/superset/utils/excel_streaming.py
Hugh A Miles II 7668f4d75c feat(export): streaming xlsx writer with sheet-name sanitization
Add StreamingXlsxWriter, a constant-memory xlsxwriter wrapper that writes one
sheet per chart row-by-row, so multi-chart dashboard exports never hold more
than one row per sheet in memory. Includes sheet-name sanitization (forbidden
chars, 31-char cap, reserved 'History', case-insensitive de-duplication) and
per-cell sanitization (formula-injection quoting mirroring excel.quote_formulas,
Excel int/float precision limits, ISO temporal rendering). Reuses the neutral
document properties from utils.excel. Adds unit tests with an openpyxl
round-trip.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-13 09:58:22 -07:00

191 lines
7.2 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""
Streaming, constant-memory XLSX writer for multi-sheet dashboard exports.
Unlike :mod:`superset.utils.excel`, which materializes a whole DataFrame in
memory, this writer streams rows one at a time into an ``xlsxwriter`` workbook
opened in ``constant_memory`` mode, so a dashboard with many large charts never
holds more than one row per sheet in memory at once.
"""
from __future__ import annotations
import math
import numbers
import re
from collections.abc import Iterable, Sequence
from datetime import date, datetime
from decimal import Decimal
from typing import Any
import xlsxwriter
from superset.utils.excel import NEUTRAL_DOCUMENT_PROPERTIES
# Excel limits a sheet name to 31 characters and forbids these characters.
MAX_SHEET_NAME_LEN = 31
_INVALID_SHEET_CHARS_RE = re.compile(r"[\[\]:*?/\\]")
# Excel reserves the sheet name "History" (case-insensitive).
_RESERVED_SHEET_NAME = "history"
# A worksheet holds at most 1,048,576 rows; one is reserved for the header.
MAX_DATA_ROWS_PER_SHEET = 1_048_576 - 1
# Leading characters that turn a cell into a formula in spreadsheet apps. Mirrors
# superset.utils.excel.quote_formulas so streamed exports get the same guard.
_FORMULA_PREFIXES = {"=", "+", "-", "@"}
# Excel cannot represent integers beyond 10**15 without precision loss.
_MAX_EXCEL_INT = 10**15
def sanitize_sheet_name(raw: str, used: set[str]) -> str:
"""
Produce a valid, unique Excel sheet name from ``raw``.
Replaces forbidden characters, strips surrounding apostrophes/whitespace,
avoids the reserved name "History", truncates to 31 characters, and
disambiguates case-insensitive collisions with ``~2``/``~3`` suffixes.
The chosen name (lower-cased) is added to ``used``.
:param raw: The desired sheet name (e.g. ``"42 - Sales by Region"``)
:param used: Lower-cased names already taken; mutated with the result
:returns: A sanitized, unique sheet name no longer than 31 characters
"""
name = _INVALID_SHEET_CHARS_RE.sub("_", raw or "")
name = name.strip().strip("'").strip()
if not name:
name = "Sheet"
if name.lower() == _RESERVED_SHEET_NAME:
name = f"{name}_"
name = name[:MAX_SHEET_NAME_LEN]
if name.lower() not in used:
used.add(name.lower())
return name
suffix = 2
while True:
marker = f"~{suffix}"
candidate = name[: MAX_SHEET_NAME_LEN - len(marker)] + marker
if candidate.lower() not in used:
used.add(candidate.lower())
return candidate
suffix += 1
def _sanitize_cell(value: Any) -> Any:
"""
Coerce a single cell value into something safe for ``xlsxwriter``.
Quotes formula-like strings (defense against formula injection), stringifies
integers/floats Excel cannot represent precisely, renders temporal values as
ISO strings (timezones are not natively supported), and blanks out ``None``
and non-finite floats.
"""
if value is None:
return ""
# bool is a subclass of int; preserve it before the numeric branches.
if isinstance(value, bool):
return value
if isinstance(value, str):
return f"'{value}" if value and value[0] in _FORMULA_PREFIXES else value
if isinstance(value, (datetime, date)):
return value.isoformat()
if isinstance(value, Decimal):
number = float(value)
return str(number) if abs(number) > _MAX_EXCEL_INT else number
if isinstance(value, numbers.Integral):
number = int(value)
return str(number) if abs(number) > _MAX_EXCEL_INT else number
if isinstance(value, numbers.Real):
number = float(value)
if not math.isfinite(number):
return ""
return str(number) if abs(number) > _MAX_EXCEL_INT else number
# Anything else (lists, dicts, custom objects) is stringified, still guarding
# against formula injection on the resulting text.
text = str(value)
return f"'{text}" if text and text[0] in _FORMULA_PREFIXES else text
class StreamingXlsxWriter:
"""
A thin wrapper over ``xlsxwriter`` in constant-memory mode that writes one
sheet per chart, row by row.
Sheet names are sanitized and de-duplicated, cell values are sanitized for
safety/compatibility, and per-sheet row counts are capped at Excel's limit.
Always call :meth:`close` (e.g. in a ``finally`` block) to finalize the file.
"""
def __init__(self, path: str) -> None:
self._workbook = xlsxwriter.Workbook(path, {"constant_memory": True})
# Reset document properties so the file carries no identifying details.
self._workbook.set_properties(NEUTRAL_DOCUMENT_PROPERTIES)
self._used_sheet_names: set[str] = set()
self.sheet_count = 0
def add_sheet(
self,
name: str,
columns: Sequence[Any],
rows: Iterable[Sequence[Any]],
) -> int:
"""
Write a header row followed by data rows into a new sheet.
:param name: Desired sheet name (sanitized/de-duplicated automatically)
:param columns: Column headers
:param rows: Iterable of row sequences, streamed one at a time
:returns: The number of data rows actually written (capped at Excel's
per-sheet limit)
"""
sheet_name = sanitize_sheet_name(name, self._used_sheet_names)
worksheet = self._workbook.add_worksheet(sheet_name)
worksheet.write_row(0, 0, [_sanitize_cell(col) for col in columns])
written = 0
for row in rows:
if written >= MAX_DATA_ROWS_PER_SHEET:
break
worksheet.write_row(written + 1, 0, [_sanitize_cell(cell) for cell in row])
written += 1
self.sheet_count += 1
return written
def add_summary_sheet(self, name: str, lines: Sequence[str]) -> None:
"""
Write a single-column informational sheet (e.g. a list of skipped charts).
Lines are written as string cells, so formula-like text is never executed.
"""
sheet_name = sanitize_sheet_name(name, self._used_sheet_names)
worksheet = self._workbook.add_worksheet(sheet_name)
for index, line in enumerate(lines):
worksheet.write_string(index, 0, str(line))
self.sheet_count += 1
def close(self) -> None:
"""Finalize and write the workbook to disk."""
if self.sheet_count == 0:
# Excel requires at least one worksheet for a valid file.
self._workbook.add_worksheet("Export")
self._workbook.close()