rusackasandClaude Opus 4.8 2e8931ab8d fix(charts): make SavedQuery a working chart datasource, not just past the first AttributeError ...

CreateChartCommand/UpdateChartCommand.validate() only reads
datasource.name; SavedQuery still crashed one step later for
non-admin callers (SecurityManager.raise_for_access needs .perm and
.data) and for every caller at flush time (Slice's
before_insert/before_update listener copies .perm/.catalog_perm/
.schema_perm onto the chart unconditionally). Add those properties
plus a None-safe fallback for name/perm when label is unset, and
test the real (unmocked) raise_for_access and set_related_perm paths
so a saved_query chart can actually be created end to end.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-08-24 23:31:50 -07:00

..

common

refactor: update Connection.execute() to use queries with text() (#40277)

2026-06-22 15:36:15 -07:00

consts

…

example_data

refactor: replace Engine.execute() with Connection.execute() (#41917)

2026-07-13 09:40:33 -07:00

fixtures

…

integration_tests

fix(sqllab): allow SQL Lab query owners to create charts without all_datasource_access (#42479)

2026-08-24 16:51:57 -07:00

unit_tests

fix(charts): make SavedQuery a working chart datasource, not just past the first AttributeError

2026-08-24 23:31:50 -07:00

__init__.py

…

conftest.py

…