mirror of
https://github.com/apache/superset.git
synced 2026-04-07 10:31:50 +00:00
315a11dfe2
* fix: shut off all uneeded endpoints We recently added a new feature to FAB allowing to whitelist the needed endpoints in ModelView and ModelRestApi. First, we set our base wrapper class to an empty set, forcing each class inheriting from it to explicitely turn on the endpoints that Superset intends to use. Second, we go ModelView by ModelView to whitelist the actual endpoints used in the app. Notes: * as a result a large set of [unneeded] permissions should be cleaned up * outside of the "private" use of endpoints in the app, people that have been using endpoints in their environment for other purposes may experience loss of functionality * Tweaking * Reduce the amount of endpoints using white lists * Fix, included needed endpoints for dashboard and druid * Drying things up * fixes * limiting more endpoints * Read only on some FAB model views * fixing some tests * fixes * Fixing more tests * Addressing comments * Drying up route_methods * further drying Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
110 lines
3.5 KiB
Python
110 lines
3.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
from flask_appbuilder.models.sqla.interface import SQLAInterface
|
|
from flask_babel import lazy_gettext as _
|
|
from wtforms.validators import StopValidation
|
|
|
|
from superset.constants import RouteMethod
|
|
from superset.models.annotations import Annotation, AnnotationLayer
|
|
|
|
from .base import DeleteMixin, SupersetModelView
|
|
|
|
|
|
class StartEndDttmValidator: # pylint: disable=too-few-public-methods
|
|
"""
|
|
Validates dttm fields.
|
|
"""
|
|
|
|
def __call__(self, form, field):
|
|
if not form["start_dttm"].data and not form["end_dttm"].data:
|
|
raise StopValidation(_("annotation start time or end time is required."))
|
|
elif (
|
|
form["end_dttm"].data
|
|
and form["start_dttm"].data
|
|
and form["end_dttm"].data < form["start_dttm"].data
|
|
):
|
|
raise StopValidation(
|
|
_("Annotation end time must be no earlier than start time.")
|
|
)
|
|
|
|
|
|
class AnnotationModelView(
|
|
SupersetModelView, DeleteMixin
|
|
): # pylint: disable=too-many-ancestors
|
|
datamodel = SQLAInterface(Annotation)
|
|
include_route_methods = RouteMethod.CRUD_SET
|
|
|
|
list_title = _("List Annotation")
|
|
show_title = _("Show Annotation")
|
|
add_title = _("Add Annotation")
|
|
edit_title = _("Edit Annotation")
|
|
|
|
list_columns = ["layer", "short_descr", "start_dttm", "end_dttm"]
|
|
edit_columns = [
|
|
"layer",
|
|
"short_descr",
|
|
"long_descr",
|
|
"start_dttm",
|
|
"end_dttm",
|
|
"json_metadata",
|
|
]
|
|
|
|
add_columns = edit_columns
|
|
|
|
label_columns = {
|
|
"layer": _("Layer"),
|
|
"short_descr": _("Short Descr"),
|
|
"start_dttm": _("Start Dttm"),
|
|
"end_dttm": _("End Dttm"),
|
|
"long_descr": _("Long Descr"),
|
|
"json_metadata": _("JSON Metadata"),
|
|
}
|
|
|
|
description_columns = {
|
|
"json_metadata": "This JSON represents any additional metadata this \
|
|
annotation needs to add more context."
|
|
}
|
|
|
|
validators_columns = {"start_dttm": [StartEndDttmValidator()]}
|
|
|
|
def pre_add(self, item):
|
|
if not item.start_dttm:
|
|
item.start_dttm = item.end_dttm
|
|
elif not item.end_dttm:
|
|
item.end_dttm = item.start_dttm
|
|
|
|
def pre_update(self, item):
|
|
self.pre_add(item)
|
|
|
|
|
|
class AnnotationLayerModelView(
|
|
SupersetModelView, DeleteMixin
|
|
): # pylint: disable=too-many-ancestors
|
|
datamodel = SQLAInterface(AnnotationLayer)
|
|
include_route_methods = RouteMethod.CRUD_SET
|
|
|
|
list_title = _("List Annotation Layer")
|
|
show_title = _("Show Annotation Layer")
|
|
add_title = _("Add Annotation Layer")
|
|
edit_title = _("Edit Annotation Layer")
|
|
|
|
list_columns = ["id", "name"]
|
|
edit_columns = ["name", "descr"]
|
|
add_columns = edit_columns
|
|
|
|
label_columns = {"name": _("Name"), "descr": _("Description")}
|