mirror of
https://github.com/apache/superset.git
synced 2026-04-09 19:35:21 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
312 lines
9.5 KiB
JavaScript
312 lines
9.5 KiB
JavaScript
/* eslint-disable no-unused-expressions */
|
|
import React from 'react';
|
|
import sinon from 'sinon';
|
|
import { shallow } from 'enzyme';
|
|
|
|
import MetricsControl from '../../../../src/explore/components/controls/MetricsControl';
|
|
import { AGGREGATES } from '../../../../src/explore/constants';
|
|
import OnPasteSelect from '../../../../src/components/OnPasteSelect';
|
|
import AdhocMetric, { EXPRESSION_TYPES } from '../../../../src/explore/AdhocMetric';
|
|
|
|
const defaultProps = {
|
|
name: 'metrics',
|
|
label: 'Metrics',
|
|
value: undefined,
|
|
multi: true,
|
|
columns: [
|
|
{ type: 'VARCHAR(255)', column_name: 'source' },
|
|
{ type: 'VARCHAR(255)', column_name: 'target' },
|
|
{ type: 'DOUBLE', column_name: 'value' },
|
|
],
|
|
savedMetrics: [
|
|
{ metric_name: 'sum__value', expression: 'SUM(energy_usage.value)' },
|
|
{ metric_name: 'avg__value', expression: 'AVG(energy_usage.value)' },
|
|
],
|
|
datasourceType: 'sqla',
|
|
};
|
|
|
|
function setup(overrides) {
|
|
const onChange = sinon.spy();
|
|
const props = {
|
|
onChange,
|
|
...defaultProps,
|
|
...overrides,
|
|
};
|
|
const wrapper = shallow(<MetricsControl {...props} />);
|
|
return { wrapper, onChange };
|
|
}
|
|
|
|
const valueColumn = { type: 'DOUBLE', column_name: 'value' };
|
|
|
|
const sumValueAdhocMetric = new AdhocMetric({
|
|
column: valueColumn,
|
|
aggregate: AGGREGATES.SUM,
|
|
label: 'SUM(value)',
|
|
});
|
|
|
|
describe('MetricsControl', () => {
|
|
|
|
it('renders an OnPasteSelect', () => {
|
|
const { wrapper } = setup();
|
|
expect(wrapper.find(OnPasteSelect)).toHaveLength(1);
|
|
});
|
|
|
|
describe('constructor', () => {
|
|
|
|
it('unifies options for the dropdown select with aggregates', () => {
|
|
const { wrapper } = setup();
|
|
expect(wrapper.state('options')).toEqual([
|
|
{ optionName: '_col_source', type: 'VARCHAR(255)', column_name: 'source' },
|
|
{ optionName: '_col_target', type: 'VARCHAR(255)', column_name: 'target' },
|
|
{ optionName: '_col_value', type: 'DOUBLE', column_name: 'value' },
|
|
...Object.keys(AGGREGATES).map(
|
|
aggregate => ({ aggregate_name: aggregate, optionName: '_aggregate_' + aggregate }),
|
|
),
|
|
{ optionName: 'sum__value', metric_name: 'sum__value', expression: 'SUM(energy_usage.value)' },
|
|
{ optionName: 'avg__value', metric_name: 'avg__value', expression: 'AVG(energy_usage.value)' },
|
|
]);
|
|
});
|
|
|
|
it('coerces Adhoc Metrics from form data into instances of the AdhocMetric class and leaves saved metrics', () => {
|
|
const { wrapper } = setup({
|
|
value: [
|
|
{
|
|
expressionType: EXPRESSION_TYPES.SIMPLE,
|
|
column: { type: 'double', column_name: 'value' },
|
|
aggregate: AGGREGATES.SUM,
|
|
label: 'SUM(value)',
|
|
optionName: 'blahblahblah',
|
|
},
|
|
'avg__value',
|
|
],
|
|
});
|
|
|
|
const adhocMetric = wrapper.state('value')[0];
|
|
expect(adhocMetric instanceof AdhocMetric).toBe(true);
|
|
expect(adhocMetric.optionName.length).toBeGreaterThan(10);
|
|
expect(wrapper.state('value')).toEqual([
|
|
{
|
|
expressionType: EXPRESSION_TYPES.SIMPLE,
|
|
column: { type: 'double', column_name: 'value' },
|
|
aggregate: AGGREGATES.SUM,
|
|
fromFormData: true,
|
|
label: 'SUM(value)',
|
|
hasCustomLabel: false,
|
|
optionName: 'blahblahblah',
|
|
sqlExpression: null,
|
|
},
|
|
'avg__value',
|
|
]);
|
|
});
|
|
|
|
});
|
|
|
|
describe('onChange', () => {
|
|
|
|
it('handles saved metrics being selected', () => {
|
|
const { wrapper, onChange } = setup();
|
|
const select = wrapper.find(OnPasteSelect);
|
|
select.simulate('change', [{ metric_name: 'sum__value' }]);
|
|
expect(onChange.lastCall.args).toEqual([['sum__value']]);
|
|
});
|
|
|
|
it('handles columns being selected', () => {
|
|
const { wrapper, onChange } = setup();
|
|
const select = wrapper.find(OnPasteSelect);
|
|
select.simulate('change', [valueColumn]);
|
|
|
|
const adhocMetric = onChange.lastCall.args[0][0];
|
|
expect(adhocMetric instanceof AdhocMetric).toBe(true);
|
|
expect(onChange.lastCall.args).toEqual([[{
|
|
expressionType: EXPRESSION_TYPES.SIMPLE,
|
|
column: valueColumn,
|
|
aggregate: AGGREGATES.SUM,
|
|
label: 'SUM(value)',
|
|
fromFormData: false,
|
|
hasCustomLabel: false,
|
|
optionName: adhocMetric.optionName,
|
|
sqlExpression: null,
|
|
}]]);
|
|
});
|
|
|
|
it('handles aggregates being selected', () => {
|
|
const { wrapper, onChange } = setup();
|
|
const select = wrapper.find(OnPasteSelect);
|
|
|
|
// mock out the Select ref
|
|
const setInputSpy = sinon.spy();
|
|
const handleInputSpy = sinon.spy();
|
|
wrapper.instance().select = {
|
|
setInputValue: setInputSpy,
|
|
handleInputChange: handleInputSpy,
|
|
input: { input: {} },
|
|
};
|
|
|
|
select.simulate('change', [{ aggregate_name: 'SUM', optionName: 'SUM' }]);
|
|
|
|
expect(setInputSpy.calledWith('SUM()')).toBe(true);
|
|
expect(handleInputSpy.calledWith({ target: { value: 'SUM()' } })).toBe(true);
|
|
expect(onChange.lastCall.args).toEqual([[]]);
|
|
});
|
|
|
|
it('preserves existing selected AdhocMetrics', () => {
|
|
const { wrapper, onChange } = setup();
|
|
const select = wrapper.find(OnPasteSelect);
|
|
select.simulate('change', [{ metric_name: 'sum__value' }, sumValueAdhocMetric]);
|
|
expect(onChange.lastCall.args).toEqual([['sum__value', sumValueAdhocMetric]]);
|
|
});
|
|
});
|
|
|
|
describe('onMetricEdit', () => {
|
|
it('accepts an edited metric from an AdhocMetricEditPopover', () => {
|
|
const { wrapper, onChange } = setup({
|
|
value: [sumValueAdhocMetric],
|
|
});
|
|
|
|
const editedMetric = sumValueAdhocMetric.duplicateWith({ aggregate: AGGREGATES.AVG });
|
|
wrapper.instance().onMetricEdit(editedMetric);
|
|
|
|
expect(onChange.lastCall.args).toEqual([[
|
|
editedMetric,
|
|
]]);
|
|
});
|
|
});
|
|
|
|
describe('checkIfAggregateInInput', () => {
|
|
it('handles an aggregate in the input', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(wrapper.state('aggregateInInput')).toBeNull();
|
|
wrapper.instance().checkIfAggregateInInput('AVG(');
|
|
expect(wrapper.state('aggregateInInput')).toBe(AGGREGATES.AVG);
|
|
});
|
|
|
|
it('handles no aggregate in the input', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(wrapper.state('aggregateInInput')).toBeNull();
|
|
wrapper.instance().checkIfAggregateInInput('colu');
|
|
expect(wrapper.state('aggregateInInput')).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe('option filter', () => {
|
|
it('includes user defined metrics', () => {
|
|
const { wrapper } = setup({ datasourceType: 'druid' });
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{
|
|
metric_name: 'a_metric',
|
|
optionName: 'a_metric',
|
|
expression: 'SUM(FANCY(metric))',
|
|
},
|
|
'a',
|
|
)).toBe(true);
|
|
});
|
|
|
|
it('includes auto generated avg metrics for druid', () => {
|
|
const { wrapper } = setup({ datasourceType: 'druid' });
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{
|
|
metric_name: 'avg__metric',
|
|
optionName: 'avg__metric',
|
|
expression: 'AVG(metric)',
|
|
},
|
|
'a',
|
|
)).toBe(true);
|
|
});
|
|
|
|
it('includes columns and aggregates', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{ type: 'VARCHAR(255)', column_name: 'source', optionName: '_col_source' },
|
|
'sou',
|
|
)).toBe(true);
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{ aggregate_name: 'AVG', optionName: '_aggregate_AVG' },
|
|
'av',
|
|
)).toBe(true);
|
|
});
|
|
|
|
it('includes columns based on verbose_name', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{ metric_name: 'sum__num', verbose_name: 'babies', optionName: '_col_sum_num' },
|
|
'bab',
|
|
)).toBe(true);
|
|
});
|
|
|
|
it('excludes auto generated avg metrics for sqla', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{
|
|
metric_name: 'avg__metric',
|
|
optionName: 'avg__metric',
|
|
expression: 'AVG(metric)',
|
|
},
|
|
'a',
|
|
)).toBe(false);
|
|
});
|
|
|
|
it('includes custom made simple saved metrics', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{
|
|
metric_name: 'my_fancy_sum_metric',
|
|
optionName: 'my_fancy_sum_metric',
|
|
expression: 'SUM(value)',
|
|
},
|
|
'sum',
|
|
)).toBe(true);
|
|
});
|
|
|
|
it('excludes auto generated metrics', () => {
|
|
const { wrapper } = setup();
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{
|
|
metric_name: 'sum__value',
|
|
optionName: 'sum__value',
|
|
expression: 'SUM(value)',
|
|
},
|
|
'sum',
|
|
)).toBe(false);
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{
|
|
metric_name: 'sum__value',
|
|
optionName: 'sum__value',
|
|
expression: 'SUM("table"."value")',
|
|
},
|
|
'sum',
|
|
)).toBe(false);
|
|
});
|
|
|
|
it('filters out metrics if the input begins with an aggregate', () => {
|
|
const { wrapper } = setup();
|
|
wrapper.setState({ aggregateInInput: true });
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{ metric_name: 'metric', expression: 'SUM(FANCY(metric))' },
|
|
'SUM(',
|
|
)).toBe(false);
|
|
});
|
|
|
|
it('includes columns if the input begins with an aggregate', () => {
|
|
const { wrapper } = setup();
|
|
wrapper.setState({ aggregateInInput: true });
|
|
|
|
expect(!!wrapper.instance().selectFilterOption(
|
|
{ type: 'DOUBLE', column_name: 'value' },
|
|
'SUM(',
|
|
)).toBe(true);
|
|
});
|
|
});
|
|
});
|