mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
224 lines
7.2 KiB
JavaScript
224 lines
7.2 KiB
JavaScript
import React from 'react';
|
|
import configureStore from 'redux-mock-store';
|
|
import thunk from 'redux-thunk';
|
|
|
|
import { shallow, mount } from 'enzyme';
|
|
import { Modal, Button, Radio } from 'react-bootstrap';
|
|
import sinon from 'sinon';
|
|
|
|
import * as exploreUtils from '../../../../src/explore/exploreUtils';
|
|
import * as saveModalActions from '../../../../src/explore/actions/saveModalActions';
|
|
import SaveModal from '../../../../src/explore/components/SaveModal';
|
|
|
|
const $ = window.$ = require('jquery');
|
|
|
|
describe('SaveModal', () => {
|
|
const middlewares = [thunk];
|
|
const mockStore = configureStore(middlewares);
|
|
const initialState = {
|
|
chart: {},
|
|
saveModal: {
|
|
dashboards: [],
|
|
},
|
|
explore: {
|
|
can_overwrite: true,
|
|
user_id: '1',
|
|
datasource: {},
|
|
slice: {
|
|
slice_id: 1,
|
|
slice_name: 'title',
|
|
},
|
|
alert: null,
|
|
},
|
|
};
|
|
const store = mockStore(initialState);
|
|
|
|
const defaultProps = {
|
|
onHide: () => ({}),
|
|
actions: saveModalActions,
|
|
form_data: { datasource: '107__table' },
|
|
};
|
|
const mockEvent = {
|
|
target: {
|
|
value: 'mock event target',
|
|
},
|
|
value: 'mock value',
|
|
};
|
|
const getWrapper = () => (shallow(<SaveModal {...defaultProps} />, {
|
|
context: { store },
|
|
}).dive());
|
|
|
|
it('renders a Modal with 7 inputs and 2 buttons', () => {
|
|
const wrapper = getWrapper();
|
|
expect(wrapper.find(Modal)).toHaveLength(1);
|
|
expect(wrapper.find('input')).toHaveLength(2);
|
|
expect(wrapper.find(Button)).toHaveLength(2);
|
|
expect(wrapper.find(Radio)).toHaveLength(5);
|
|
});
|
|
|
|
it('does not show overwrite option for new slice', () => {
|
|
const wrapperNewSlice = getWrapper();
|
|
wrapperNewSlice.setProps({ slice: null });
|
|
expect(wrapperNewSlice.find('#overwrite-radio')).toHaveLength(0);
|
|
expect(wrapperNewSlice.find('#saveas-radio')).toHaveLength(1);
|
|
});
|
|
|
|
it('disable overwrite option for non-owner', () => {
|
|
const wrapperForNonOwner = getWrapper();
|
|
wrapperForNonOwner.setProps({ can_overwrite: false });
|
|
const overwriteRadio = wrapperForNonOwner.find('#overwrite-radio');
|
|
expect(overwriteRadio).toHaveLength(1);
|
|
expect(overwriteRadio.prop('disabled')).toBe(true);
|
|
});
|
|
|
|
it('saves a new slice', () => {
|
|
const wrapperForNewSlice = getWrapper();
|
|
wrapperForNewSlice.setProps({ can_overwrite: false });
|
|
wrapperForNewSlice.instance().changeAction('saveas');
|
|
const saveasRadio = wrapperForNewSlice.find('#saveas-radio');
|
|
saveasRadio.simulate('click');
|
|
expect(wrapperForNewSlice.state().action).toBe('saveas');
|
|
});
|
|
|
|
it('overwrite a slice', () => {
|
|
const wrapperForOverwrite = getWrapper();
|
|
const overwriteRadio = wrapperForOverwrite.find('#overwrite-radio');
|
|
overwriteRadio.simulate('click');
|
|
expect(wrapperForOverwrite.state().action).toBe('overwrite');
|
|
});
|
|
|
|
it('componentDidMount', () => {
|
|
sinon.spy(SaveModal.prototype, 'componentDidMount');
|
|
sinon.spy(saveModalActions, 'fetchDashboards');
|
|
mount(<SaveModal {...defaultProps} />, {
|
|
context: { store },
|
|
});
|
|
expect(SaveModal.prototype.componentDidMount.calledOnce).toBe(true);
|
|
expect(saveModalActions.fetchDashboards.calledOnce).toBe(true);
|
|
|
|
SaveModal.prototype.componentDidMount.restore();
|
|
saveModalActions.fetchDashboards.restore();
|
|
});
|
|
|
|
it('onChange', () => {
|
|
const wrapper = getWrapper();
|
|
|
|
wrapper.instance().onChange('newSliceName', mockEvent);
|
|
expect(wrapper.state().newSliceName).toBe(mockEvent.target.value);
|
|
|
|
wrapper.instance().onChange('saveToDashboardId', mockEvent);
|
|
expect(wrapper.state().saveToDashboardId).toBe(mockEvent.value);
|
|
|
|
wrapper.instance().onChange('newDashboardName', mockEvent);
|
|
expect(wrapper.state().newDashboardName).toBe(mockEvent.target.value);
|
|
});
|
|
|
|
describe('saveOrOverwrite', () => {
|
|
beforeEach(() => {
|
|
sinon.stub(exploreUtils, 'getExploreUrlAndPayload').callsFake(() => ({ url: 'mockURL', payload: defaultProps.form_data }));
|
|
sinon.stub(saveModalActions, 'saveSlice').callsFake(() => {
|
|
const d = $.Deferred();
|
|
d.resolve('done');
|
|
return d.promise();
|
|
});
|
|
});
|
|
afterEach(() => {
|
|
exploreUtils.getExploreUrlAndPayload.restore();
|
|
saveModalActions.saveSlice.restore();
|
|
});
|
|
|
|
it('should save slice', () => {
|
|
const wrapper = getWrapper();
|
|
wrapper.instance().saveOrOverwrite(true);
|
|
const args = saveModalActions.saveSlice.getCall(0).args;
|
|
expect(args[0]).toEqual(defaultProps.form_data);
|
|
});
|
|
it('existing dashboard', () => {
|
|
const wrapper = getWrapper();
|
|
const saveToDashboardId = 100;
|
|
|
|
wrapper.setState({ addToDash: 'existing' });
|
|
wrapper.instance().saveOrOverwrite(true);
|
|
expect(wrapper.state().alert).toBe('Please select a dashboard');
|
|
|
|
wrapper.setState({ saveToDashboardId });
|
|
wrapper.instance().saveOrOverwrite(true);
|
|
const args = saveModalActions.saveSlice.getCall(0).args;
|
|
expect(args[1].save_to_dashboard_id).toBe(saveToDashboardId);
|
|
});
|
|
it('new dashboard', () => {
|
|
const wrapper = getWrapper();
|
|
const newDashboardName = 'new dashboard name';
|
|
|
|
wrapper.setState({ addToDash: 'new' });
|
|
wrapper.instance().saveOrOverwrite(true);
|
|
expect(wrapper.state().alert).toBe('Please enter a dashboard name');
|
|
|
|
wrapper.setState({ newDashboardName });
|
|
wrapper.instance().saveOrOverwrite(true);
|
|
const args = saveModalActions.saveSlice.getCall(0).args;
|
|
expect(args[1].new_dashboard_name).toBe(newDashboardName);
|
|
});
|
|
});
|
|
|
|
describe('should fetchDashboards', () => {
|
|
let dispatch;
|
|
let request;
|
|
let ajaxStub;
|
|
const userID = 1;
|
|
beforeEach(() => {
|
|
dispatch = sinon.spy();
|
|
ajaxStub = sinon.stub($, 'ajax');
|
|
});
|
|
afterEach(() => {
|
|
ajaxStub.restore();
|
|
});
|
|
const mockDashboardData = {
|
|
pks: ['value'],
|
|
result: [
|
|
{ dashboard_title: 'dashboard title' },
|
|
],
|
|
};
|
|
const makeRequest = () => {
|
|
request = saveModalActions.fetchDashboards(userID);
|
|
request(dispatch);
|
|
};
|
|
|
|
it('makes the ajax request', () => {
|
|
makeRequest();
|
|
expect(ajaxStub.callCount).toBe(1);
|
|
});
|
|
|
|
it('calls correct url', () => {
|
|
const url = '/dashboardasync/api/read?_flt_0_owners=' + userID;
|
|
makeRequest();
|
|
expect(ajaxStub.getCall(0).args[0].url).toBe(url);
|
|
});
|
|
|
|
it('calls correct actions on error', () => {
|
|
ajaxStub.yieldsTo('error', { responseJSON: { error: 'error text' } });
|
|
makeRequest();
|
|
expect(dispatch.callCount).toBe(1);
|
|
expect(dispatch.getCall(0).args[0].type).toBe(saveModalActions.FETCH_DASHBOARDS_FAILED);
|
|
});
|
|
|
|
it('calls correct actions on success', () => {
|
|
ajaxStub.yieldsTo('success', mockDashboardData);
|
|
makeRequest();
|
|
expect(dispatch.callCount).toBe(1);
|
|
expect(dispatch.getCall(0).args[0].type).toBe(saveModalActions.FETCH_DASHBOARDS_SUCCEEDED);
|
|
});
|
|
});
|
|
|
|
it('removeAlert', () => {
|
|
sinon.spy(saveModalActions, 'removeSaveModalAlert');
|
|
const wrapper = getWrapper();
|
|
wrapper.setProps({ alert: 'old alert' });
|
|
|
|
wrapper.instance().removeAlert();
|
|
expect(saveModalActions.removeSaveModalAlert.callCount).toBe(1);
|
|
expect(wrapper.state().alert).toBeNull();
|
|
saveModalActions.removeSaveModalAlert.restore();
|
|
});
|
|
});
|