mirror of
https://github.com/apache/superset.git
synced 2026-04-24 18:44:53 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
170 lines
5.5 KiB
JavaScript
170 lines
5.5 KiB
JavaScript
import React from 'react';
|
|
import configureStore from 'redux-mock-store';
|
|
import thunk from 'redux-thunk';
|
|
import URI from 'urijs';
|
|
|
|
import { Tab } from 'react-bootstrap';
|
|
import { shallow, mount } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import { table, initialState } from './fixtures';
|
|
import TabbedSqlEditors from '../../../src/SqlLab/components/TabbedSqlEditors';
|
|
import SqlEditor from '../../../src/SqlLab/components/SqlEditor';
|
|
|
|
describe('TabbedSqlEditors', () => {
|
|
const middlewares = [thunk];
|
|
const mockStore = configureStore(middlewares);
|
|
const store = mockStore(initialState);
|
|
|
|
const tabHistory = [
|
|
'dfsadfs',
|
|
'newEditorId',
|
|
];
|
|
|
|
const tables = [Object.assign({}, table[0], {
|
|
dataPreviewQueryId: 'B1-VQU1zW',
|
|
queryEditorId: 'newEditorId',
|
|
})];
|
|
|
|
const queryEditors = [{
|
|
autorun: false,
|
|
dbId: 1,
|
|
id: 'newEditorId',
|
|
latestQueryId: 'B1-VQU1zW',
|
|
schema: null,
|
|
selectedText: null,
|
|
sql: 'SELECT ds...',
|
|
title: 'Untitled Query',
|
|
}];
|
|
const queries = {
|
|
'B1-VQU1zW': {
|
|
id: 'B1-VQU1zW',
|
|
sqlEditorId: 'newEditorId',
|
|
},
|
|
};
|
|
const mockedProps = {
|
|
actions: {},
|
|
databases: {},
|
|
tables: [],
|
|
queries: {},
|
|
queryEditors: initialState.sqlLab.queryEditors,
|
|
tabHistory: initialState.sqlLab.tabHistory,
|
|
editorHeight: '',
|
|
getHeight: () => ('100px'),
|
|
database: {},
|
|
};
|
|
const getWrapper = () => (
|
|
shallow(<TabbedSqlEditors {...mockedProps} />, {
|
|
context: { store },
|
|
}).dive());
|
|
|
|
let wrapper;
|
|
it('is valid', () => {
|
|
expect(
|
|
React.isValidElement(<TabbedSqlEditors {...mockedProps} />),
|
|
).toBe(true);
|
|
});
|
|
describe('componentDidMount', () => {
|
|
let uriStub;
|
|
beforeEach(() => {
|
|
sinon.stub(window.history, 'replaceState');
|
|
sinon.spy(TabbedSqlEditors.prototype, 'componentDidMount');
|
|
uriStub = sinon.stub(URI.prototype, 'search');
|
|
});
|
|
afterEach(() => {
|
|
window.history.replaceState.restore();
|
|
TabbedSqlEditors.prototype.componentDidMount.restore();
|
|
uriStub.restore();
|
|
});
|
|
it('should handle id', () => {
|
|
uriStub.returns({ id: 1 });
|
|
wrapper = mount(<TabbedSqlEditors {...mockedProps} />, {
|
|
context: { store },
|
|
});
|
|
expect(TabbedSqlEditors.prototype.componentDidMount.calledOnce).toBe(true);
|
|
expect(window.history.replaceState.getCall(0).args[2]).toBe('/superset/sqllab');
|
|
});
|
|
it('should handle savedQueryId', () => {
|
|
uriStub.returns({ savedQueryId: 1 });
|
|
wrapper = mount(<TabbedSqlEditors {...mockedProps} />, {
|
|
context: { store },
|
|
});
|
|
expect(TabbedSqlEditors.prototype.componentDidMount.calledOnce).toBe(true);
|
|
expect(window.history.replaceState.getCall(0).args[2]).toBe('/superset/sqllab');
|
|
});
|
|
it('should handle sql', () => {
|
|
uriStub.returns({ sql: 1, dbid: 1 });
|
|
wrapper = mount(<TabbedSqlEditors {...mockedProps} />, {
|
|
context: { store },
|
|
});
|
|
expect(TabbedSqlEditors.prototype.componentDidMount.calledOnce).toBe(true);
|
|
expect(window.history.replaceState.getCall(0).args[2]).toBe('/superset/sqllab');
|
|
});
|
|
});
|
|
describe('componentWillReceiveProps', () => {
|
|
let spy;
|
|
beforeEach(() => {
|
|
wrapper = getWrapper();
|
|
spy = sinon.spy(TabbedSqlEditors.prototype, 'componentWillReceiveProps');
|
|
wrapper.setProps({ queryEditors, queries, tabHistory, tables });
|
|
});
|
|
afterEach(() => {
|
|
spy.restore();
|
|
});
|
|
it('should update queriesArray and dataPreviewQueries', () => {
|
|
expect(wrapper.state().queriesArray.slice(-1)[0]).toBe(queries['B1-VQU1zW']);
|
|
expect(wrapper.state().dataPreviewQueries.slice(-1)[0]).toBe(queries['B1-VQU1zW']);
|
|
});
|
|
});
|
|
it('should rename Tab', () => {
|
|
global.prompt = () => ('new title');
|
|
wrapper = getWrapper();
|
|
sinon.stub(wrapper.instance().props.actions, 'queryEditorSetTitle');
|
|
|
|
wrapper.instance().renameTab(queryEditors[0]);
|
|
expect(wrapper.instance().props.actions.queryEditorSetTitle.getCall(0).args[1]).toBe('new title');
|
|
|
|
delete global.prompt;
|
|
});
|
|
it('should removeQueryEditor', () => {
|
|
wrapper = getWrapper();
|
|
sinon.stub(wrapper.instance().props.actions, 'removeQueryEditor');
|
|
|
|
wrapper.instance().removeQueryEditor(queryEditors[0]);
|
|
expect(wrapper.instance().props.actions.removeQueryEditor.getCall(0).args[0])
|
|
.toBe(queryEditors[0]);
|
|
});
|
|
it('should add new query editor', () => {
|
|
wrapper = getWrapper();
|
|
sinon.stub(wrapper.instance().props.actions, 'addQueryEditor');
|
|
|
|
wrapper.instance().newQueryEditor();
|
|
expect(wrapper.instance().props.actions.addQueryEditor.getCall(0).args[0].title)
|
|
.toContain('Untitled Query');
|
|
});
|
|
it('should handle select', () => {
|
|
wrapper = getWrapper();
|
|
sinon.spy(wrapper.instance(), 'newQueryEditor');
|
|
sinon.stub(wrapper.instance().props.actions, 'setActiveQueryEditor');
|
|
|
|
wrapper.instance().handleSelect('add_tab');
|
|
expect(wrapper.instance().newQueryEditor.callCount).toBe(1);
|
|
|
|
wrapper.instance().handleSelect('123');
|
|
expect(wrapper.instance().props.actions.setActiveQueryEditor.getCall(0).args[0].id)
|
|
.toContain(123);
|
|
wrapper.instance().newQueryEditor.restore();
|
|
});
|
|
it('should render', () => {
|
|
wrapper = getWrapper();
|
|
wrapper.setState({ hideLeftBar: true });
|
|
|
|
const firstTab = wrapper.find(Tab).first();
|
|
expect(firstTab.props().eventKey).toContain(initialState.sqlLab.queryEditors[0].id);
|
|
expect(firstTab.find(SqlEditor)).toHaveLength(1);
|
|
|
|
const lastTab = wrapper.find(Tab).last();
|
|
expect(lastTab.props().eventKey).toContain('add_tab');
|
|
});
|
|
});
|