mirror of
https://github.com/apache/superset.git
synced 2026-05-12 11:25:56 +00:00
* wip: filter create modal * add a feature flag * automatic changes to package lock * wip * filter sidebar and basic state management * move create button to the sidebar * first step for edit filterconfig * partially fix tests... * edits to types and comments * respect feature flag on the filter sidebar * add filterconfig form * get input state working * feat: tree filter scopes UI * fix: turn on flag * sticky filter bar * stop preferring default export * feat: finish filter scoping * fix: under toggle * fix: title * fix: add licence * refactor: update TS * fix: fix on reopen modal + validation * new filter bar menu * adding, but commenting out, bulk scoping action * adding some placeholder buttons and styles therefor * feat: add filter chart * add relative path to package.json * update modal * a little input styling... just getting warmed up * Revert "feat: add filter chart" This reverts commitb1302d35b6. * Revert "add relative path to package.json" This reverts commit26a7b40e18. * https package lock idk * feat: add filter chart * add relative path to package.json * flexboxes all the way down * dynamically generate groupby and datasource in select control * big wip * fix target column name * no importing nonexistent things * styles and name editing * Add hook for retrieval of all filter states * start with a new filter when clicking add filter * handle removed filters gracefully * fix incorrect default filter configuration * add fields to useAllFilterState * add redux for filterconfigs * add support for native_filters * remove consoles * improve filter removal * unbreak infinite loop * basic sidebar toggling working! * collapsing and menu working more smoothly * linting * make dataset and column inputs work * save filter values properly * add dashboard event for filter updates * guarded * apply filters properly * fix schema * making New Filter button a link * gridunits ftw * centering modal * tis not a button anymore! nixing type. * plus and collapse buttons instead of "more" menu * updating full size filter icons * adding icons to filter collapsing/expanding * turning off animation, but leaving class-based animation css * fix linting error * fix native filters for legacy charts * updates test * no individual apply buttons * fix bugs with filter config modal * remove redundant code * switch to the filter with validation errors on submit * separate form validation * switch config button from add to edit * update tests * oops forgot to add the fancy new useChangeEffect hook * comments and code reorganization * rename native_filters to extr_form_data and move hook * disable native filters in viz selector * add cascading * implement new extra form data api * cleanup * updates tests * bump npm packages * fix bad merge on package.json + lock * lint * replace in and not in with uppercase * lint * lint * lint * lint * bulk test fix * Sort select input alphabetically * Change type for sorting elements * fix rest of unit tests * make filter operators all uppercase * Hide Filter bar when there are no filters * Show edit button for dashboard owners only * Add visible argument to filters toggle function to avoid future regression * Improve Toggle filters bar function * lint * fix js lint + set createNewOnOpen * Handle setting extra form data in Filter Bar instead of Filter Control * Add Handle apply filter function to Apply button * Allow applying changes instantly * Fix types * remove console logs * Add Error Boundary component to Filter bar and Filter Config Modal * fix jest tests * update native filters tests to pass * reset cypress baseUrl * remove unnecessary field * cleanup: remove unused state fields * move unrelated types to an appropriate location * remove misplaced resource fetch error logic * fix cascadeParentIds error * fix cypress password * initial attempt at fixing scope issue * fix bad merge * fix lint * trying out makeApi for saving filters * remove unused import * fix test * silence bad test * add native-filter feat flag config * oops fix here * remove space * Update superset-frontend/src/common/components/index.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts Co-authored-by: Evan Rusackas <evan@preset.io> * use styledMount in tests * comment Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * address PR feedback * fix package lock * null guards * Fix charts resizing * fix cypress tests * add in nativefilters to form data * fix lint and test Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Simcha Shats <simcha.shats@nielsen.com> Co-authored-by: amitNielsen <amit.miran@nielsen.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
194 lines
6.8 KiB
Python
194 lines
6.8 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
import json
|
|
import re
|
|
from typing import Any, Dict, Union
|
|
|
|
from marshmallow import fields, post_load, Schema
|
|
from marshmallow.validate import Length, ValidationError
|
|
|
|
from superset.exceptions import SupersetException
|
|
from superset.utils import core as utils
|
|
|
|
get_delete_ids_schema = {"type": "array", "items": {"type": "integer"}}
|
|
get_export_ids_schema = {"type": "array", "items": {"type": "integer"}}
|
|
get_fav_star_ids_schema = {"type": "array", "items": {"type": "integer"}}
|
|
thumbnail_query_schema = {
|
|
"type": "object",
|
|
"properties": {"force": {"type": "boolean"}},
|
|
}
|
|
|
|
dashboard_title_description = "A title for the dashboard."
|
|
slug_description = "Unique identifying part for the web address of the dashboard."
|
|
owners_description = (
|
|
"Owner are users ids allowed to delete or change this dashboard. "
|
|
"If left empty you will be one of the owners of the dashboard."
|
|
)
|
|
position_json_description = (
|
|
"This json object describes the positioning of the widgets "
|
|
"in the dashboard. It is dynamically generated when "
|
|
"adjusting the widgets size and positions by using "
|
|
"drag & drop in the dashboard view"
|
|
)
|
|
css_description = "Override CSS for the dashboard."
|
|
json_metadata_description = (
|
|
"This JSON object is generated dynamically when clicking "
|
|
"the save or overwrite button in the dashboard view. "
|
|
"It is exposed here for reference and for power users who may want to alter "
|
|
" specific parameters."
|
|
)
|
|
published_description = (
|
|
"Determines whether or not this dashboard is visible in "
|
|
"the list of all dashboards."
|
|
)
|
|
|
|
|
|
openapi_spec_methods_override = {
|
|
"get": {"get": {"description": "Get a dashboard detail information."}},
|
|
"get_list": {
|
|
"get": {
|
|
"description": "Get a list of dashboards, use Rison or JSON query "
|
|
"parameters for filtering, sorting, pagination and "
|
|
" for selecting specific columns and metadata.",
|
|
}
|
|
},
|
|
"info": {
|
|
"get": {
|
|
"description": "Several metadata information about dashboard API "
|
|
"endpoints.",
|
|
}
|
|
},
|
|
"related": {
|
|
"get": {"description": "Get a list of all possible owners for a dashboard."}
|
|
},
|
|
}
|
|
|
|
|
|
def validate_json(value: Union[bytes, bytearray, str]) -> None:
|
|
try:
|
|
utils.validate_json(value)
|
|
except SupersetException:
|
|
raise ValidationError("JSON not valid")
|
|
|
|
|
|
def validate_json_metadata(value: Union[bytes, bytearray, str]) -> None:
|
|
if not value:
|
|
return
|
|
try:
|
|
value_obj = json.loads(value)
|
|
except json.decoder.JSONDecodeError:
|
|
raise ValidationError("JSON not valid")
|
|
errors = DashboardJSONMetadataSchema().validate(value_obj, partial=False)
|
|
if errors:
|
|
raise ValidationError(errors)
|
|
|
|
|
|
class DashboardJSONMetadataSchema(Schema):
|
|
# filter_configuration is for dashboard-native filters
|
|
filter_configuration = fields.List(fields.Dict(), allow_none=True)
|
|
timed_refresh_immune_slices = fields.List(fields.Integer())
|
|
# deprecated wrt dashboard-native filters
|
|
filter_scopes = fields.Dict()
|
|
expanded_slices = fields.Dict()
|
|
refresh_frequency = fields.Integer()
|
|
# deprecated wrt dashboard-native filters
|
|
default_filters = fields.Str()
|
|
stagger_refresh = fields.Boolean()
|
|
stagger_time = fields.Integer()
|
|
color_scheme = fields.Str(allow_none=True)
|
|
label_colors = fields.Dict()
|
|
|
|
|
|
class BaseDashboardSchema(Schema):
|
|
# pylint: disable=no-self-use,unused-argument
|
|
@post_load
|
|
def post_load(self, data: Dict[str, Any], **kwargs: Any) -> Dict[str, Any]:
|
|
if data.get("slug"):
|
|
data["slug"] = data["slug"].strip()
|
|
data["slug"] = data["slug"].replace(" ", "-")
|
|
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
|
|
return data
|
|
|
|
# pylint: disable=no-self-use,unused-argument
|
|
|
|
|
|
class DashboardPostSchema(BaseDashboardSchema):
|
|
dashboard_title = fields.String(
|
|
description=dashboard_title_description,
|
|
allow_none=True,
|
|
validate=Length(0, 500),
|
|
)
|
|
slug = fields.String(
|
|
description=slug_description, allow_none=True, validate=[Length(1, 255)]
|
|
)
|
|
owners = fields.List(fields.Integer(description=owners_description))
|
|
position_json = fields.String(
|
|
description=position_json_description, validate=validate_json
|
|
)
|
|
css = fields.String()
|
|
json_metadata = fields.String(
|
|
description=json_metadata_description, validate=validate_json_metadata,
|
|
)
|
|
published = fields.Boolean(description=published_description)
|
|
|
|
|
|
class DashboardPutSchema(BaseDashboardSchema):
|
|
dashboard_title = fields.String(
|
|
description=dashboard_title_description,
|
|
allow_none=True,
|
|
validate=Length(0, 500),
|
|
)
|
|
slug = fields.String(
|
|
description=slug_description, allow_none=True, validate=Length(0, 255)
|
|
)
|
|
owners = fields.List(
|
|
fields.Integer(description=owners_description, allow_none=True)
|
|
)
|
|
position_json = fields.String(
|
|
description=position_json_description, allow_none=True, validate=validate_json
|
|
)
|
|
css = fields.String(description=css_description, allow_none=True)
|
|
json_metadata = fields.String(
|
|
description=json_metadata_description,
|
|
allow_none=True,
|
|
validate=validate_json_metadata,
|
|
)
|
|
published = fields.Boolean(description=published_description, allow_none=True)
|
|
|
|
|
|
class ChartFavStarResponseResult(Schema):
|
|
id = fields.Integer(description="The Chart id")
|
|
value = fields.Boolean(description="The FaveStar value")
|
|
|
|
|
|
class GetFavStarIdsSchema(Schema):
|
|
result = fields.List(
|
|
fields.Nested(ChartFavStarResponseResult),
|
|
description="A list of results for each corresponding chart in the request",
|
|
)
|
|
|
|
|
|
class ImportV1DashboardSchema(Schema):
|
|
dashboard_title = fields.String(required=True)
|
|
description = fields.String(allow_none=True)
|
|
css = fields.String(allow_none=True)
|
|
slug = fields.String(allow_none=True)
|
|
uuid = fields.UUID(required=True)
|
|
position = fields.Dict()
|
|
metadata = fields.Dict()
|
|
version = fields.String(required=True)
|