mirror of
https://github.com/apache/superset.git
synced 2026-09-01 13:01:33 +00:00
Superset Dev
44d7ef13e9
The `cockroachdb` PyPI package (last released 2021) is abandoned, and its SQLAlchemy dialect references sqlalchemy.dialects.postgresql.psycopg2's PGCompiler_psycopg2, which SQLAlchemy 2.0 removed. Constructing a cockroachdb:// engine has raised ImportError since the SQLAlchemy 2.0 bump (#42803) landed, with nothing catching it: the driver isn't part of the default dev/CI install, and the existing test_crdb.py only exercises convert_dttm(), never a real engine. Switches the `cockroachdb` extra to sqlalchemy-cockroachdb, the actively maintained replacement already linked from CockroachDbEngineSpec's own docs_url, adds it to the default dev install so this keeps getting exercised, and adds a regression test that constructs a real engine (verified to fail against the old package, pass against the new one).
61 lines
2.3 KiB
Python
61 lines
2.3 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
# pylint: disable=unused-argument, import-outside-toplevel, protected-access
|
|
from datetime import datetime
|
|
from typing import Optional
|
|
|
|
import pytest
|
|
|
|
from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm
|
|
from tests.unit_tests.fixtures.common import dttm # noqa: F401
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"target_type,expected_result",
|
|
[
|
|
("Date", "'2019-01-02'"),
|
|
("TimeStamp", "'2019-01-02 03:04:05'"),
|
|
("UnknownType", None),
|
|
],
|
|
)
|
|
def test_convert_dttm(
|
|
target_type: str,
|
|
expected_result: Optional[str],
|
|
dttm: datetime, # noqa: F811
|
|
) -> None:
|
|
from superset.db_engine_specs.cockroachdb import (
|
|
CockroachDbEngineSpec as spec, # noqa: N813
|
|
)
|
|
|
|
assert_convert_dttm(spec, target_type, expected_result, dttm)
|
|
|
|
|
|
def test_dialect_loads_under_installed_sqlalchemy() -> None:
|
|
"""
|
|
``create_engine`` resolves and imports the ``cockroachdb`` SQLAlchemy
|
|
dialect entry point without connecting anywhere. This is a regression
|
|
test for the ``cockroachdb`` PyPI package (last released 2021, replaced
|
|
by ``sqlalchemy-cockroachdb`` -- see the ``cockroachdb`` extra in
|
|
pyproject.toml): its dialect referenced
|
|
``sqlalchemy.dialects.postgresql.psycopg2.PGCompiler_psycopg2``, which
|
|
SQLAlchemy 2.0 removed, so merely constructing an engine raised
|
|
``ImportError`` before any connection was attempted.
|
|
"""
|
|
from sqlalchemy import create_engine
|
|
|
|
create_engine("cockroachdb://root@localhost:26257/defaultdb?sslmode=disable")
|