mirror of
https://github.com/apache/superset.git
synced 2026-05-21 15:55:10 +00:00
471b4bafc4
- Patch Object.defineProperties in jsDomWithFetchAPI.ts to make window.location configurable, enabling jest.spyOn in tests with jest-environment-jsdom 30 (which bundles jsdom 26) - Update TableChart.test.tsx: jsdom 26 returns rgba(0,0,0,0) for elements with no background, replacing empty string expectations - Apply prettier formatting fixes to logger.test.ts and RedirectWarning/utils.test.ts Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
76 lines
3.2 KiB
TypeScript
76 lines
3.2 KiB
TypeScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
|
|
import JSDOMEnvironment from 'jest-environment-jsdom';
|
|
|
|
// jest-environment-jsdom 30 bundles jsdom 26, which marks window.location as
|
|
// [LegacyUnforgeable] (configurable: false). jest 30's spyOn now strictly
|
|
// checks the configurable flag and throws when it's false, breaking every test
|
|
// that uses jest.spyOn(window, 'location', 'get').
|
|
//
|
|
// We intercept Object.defineProperties at module-load time (before any JSDOM
|
|
// instance is created). The interceptor makes window.location configurable
|
|
// every time jsdom creates a new Window, restoring the ability to spy on it.
|
|
// This file is only required by Jest in the test environment so the
|
|
// monkey-patch is safe.
|
|
const _originalDefineProperties = Object.defineProperties.bind(Object);
|
|
(Object as any).defineProperties = function (
|
|
obj: object,
|
|
props: PropertyDescriptorMap,
|
|
) {
|
|
if (
|
|
props !== null &&
|
|
typeof props === 'object' &&
|
|
Object.prototype.hasOwnProperty.call(props, 'location') &&
|
|
(props as any).location?.configurable === false
|
|
) {
|
|
// Allow jest.spyOn(window, 'location', 'get') to work in tests by making
|
|
// the property configurable. This deviates from the browser spec's
|
|
// [LegacyUnforgeable] requirement but is acceptable in a test environment.
|
|
props = {
|
|
...props,
|
|
location: { ...(props as any).location, configurable: true },
|
|
};
|
|
}
|
|
return _originalDefineProperties(obj, props);
|
|
};
|
|
|
|
// https://github.com/facebook/jest/blob/v29.4.3/website/versioned_docs/version-29.4/Configuration.md#testenvironment-string
|
|
export default class FixJSDOMEnvironment extends JSDOMEnvironment {
|
|
constructor(...args: ConstructorParameters<typeof JSDOMEnvironment>) {
|
|
super(...args);
|
|
|
|
// FIXME https://github.com/jsdom/jsdom/issues/1724
|
|
this.global.fetch = fetch;
|
|
this.global.Headers = Headers;
|
|
this.global.Request = Request;
|
|
this.global.Response = Response;
|
|
this.global.AbortSignal = AbortSignal;
|
|
this.global.AbortController = AbortController;
|
|
this.global.ReadableStream = ReadableStream;
|
|
|
|
// Mock MessageChannel to prevent hanging Jest tests with rc-overflow@1.4.1
|
|
// Forces rc-overflow to use requestAnimationFrame fallback instead
|
|
// Can be removed when rc-overflow properly cleans up MessagePorts in test environments
|
|
// See: https://github.com/apache/superset/pull/34871
|
|
this.global.MessageChannel = undefined as any;
|
|
this.global.MessagePort = undefined as any;
|
|
}
|
|
}
|