mirror of
https://github.com/apache/superset.git
synced 2026-05-22 00:05:15 +00:00
Split an 89-char comment line and an over-limit condition in update_chart.py to satisfy the ruff E501 rule. Also applied ruff format. Two TestUpdateChartValidationGate tests expected CHART_VALIDATION_FAILED but received CHART_DATASET_NOT_FOUND because _validate_update_against_dataset calls DatasetValidator.validate_against_dataset before validate_and_compile, and the existing mocks provided a Mock() object for chart.datasource whose .id attribute is an auto-generated MagicMock (not a real int). Added a patch for DatasetValidator.validate_against_dataset returning (True, None) so the column-validation tier is bypassed and the test reaches the mocked validate_and_compile response as intended. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>