mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
eac97ce9f2
* [WiP] [explore] proper filtering of NULLs and ''
TODO: handling of Druid equivalents
* Unit tests
* Some refactoring
* [druid] fix 'Unorderable types' when col has nuls
Error "unorderable types: str() < int()" occurs when grouping by a
numerical Druid colummn that contains null values.
* druid/pydruid returns strings in the datafram with NAs for nulls
* Superset has custom logic around get_fillna_for_col that fills in the
NULLs based on declared column type (FLOAT here), so now we have a mixed
bag of type in the series
* pandas chokes on pivot_table or groupby operations as it cannot sorts
mixed types
The approach here is to stringify and fillna('<NULL>') to get a
consistent series.
* typo
* Fix druid_func tests
* Addressing more comments
* last touches
54 lines
2.1 KiB
JavaScript
54 lines
2.1 KiB
JavaScript
import { it, describe } from 'mocha';
|
|
import { expect } from 'chai';
|
|
import { isTruthy, optionFromValue } from '../../../src/utils/common';
|
|
|
|
describe('utils/common', () => {
|
|
describe('isTruthy', () => {
|
|
it('evals false-looking strings properly', () => {
|
|
expect(isTruthy('f')).to.equal(false);
|
|
expect(isTruthy('false')).to.equal(false);
|
|
expect(isTruthy('no')).to.equal(false);
|
|
expect(isTruthy('n')).to.equal(false);
|
|
expect(isTruthy('F')).to.equal(false);
|
|
expect(isTruthy('False')).to.equal(false);
|
|
expect(isTruthy('NO')).to.equal(false);
|
|
expect(isTruthy('N')).to.equal(false);
|
|
});
|
|
it('evals true-looking strings properly', () => {
|
|
expect(isTruthy('t')).to.equal(true);
|
|
expect(isTruthy('true')).to.equal(true);
|
|
expect(isTruthy('yes')).to.equal(true);
|
|
expect(isTruthy('y')).to.equal(true);
|
|
expect(isTruthy('Y')).to.equal(true);
|
|
expect(isTruthy('True')).to.equal(true);
|
|
expect(isTruthy('Yes')).to.equal(true);
|
|
expect(isTruthy('YES')).to.equal(true);
|
|
});
|
|
it('evals bools properly', () => {
|
|
expect(isTruthy(false)).to.equal(false);
|
|
expect(isTruthy(true)).to.equal(true);
|
|
});
|
|
it('evals ints properly', () => {
|
|
expect(isTruthy(0)).to.equal(false);
|
|
expect(isTruthy(1)).to.equal(true);
|
|
});
|
|
it('evals constants properly', () => {
|
|
expect(isTruthy(null)).to.equal(false);
|
|
expect(isTruthy(undefined)).to.equal(false);
|
|
});
|
|
it('string auto is false', () => {
|
|
expect(isTruthy('false')).to.equal(false);
|
|
});
|
|
});
|
|
describe('optionFromValue', () => {
|
|
it('converts values as expected', () => {
|
|
expect(optionFromValue(false)).to.deep.equal({ value: false, label: '<false>' });
|
|
expect(optionFromValue(true)).to.deep.equal({ value: true, label: '<true>' });
|
|
expect(optionFromValue(null)).to.deep.equal({ value: '<NULL>', label: '<NULL>' });
|
|
expect(optionFromValue('')).to.deep.equal({ value: '', label: '<empty string>' });
|
|
expect(optionFromValue('foo')).to.deep.equal({ value: 'foo', label: 'foo' });
|
|
expect(optionFromValue(5)).to.deep.equal({ value: 5, label: '5' });
|
|
});
|
|
});
|
|
});
|