mirror of
https://github.com/apache/superset.git
synced 2026-07-12 09:45:43 +00:00
91 lines
3.2 KiB
Python
91 lines
3.2 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
"""Unit tests for RestoreChartCommand."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import datetime, timezone
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from superset.commands.chart.exceptions import (
|
|
ChartForbiddenError,
|
|
ChartNotFoundError,
|
|
)
|
|
from superset.commands.chart.restore import RestoreChartCommand
|
|
from superset.exceptions import SupersetSecurityException
|
|
|
|
|
|
def test_restore_chart_clears_deleted_at(app_context: None) -> None:
|
|
"""RestoreChartCommand.run() restores a soft-deleted chart."""
|
|
chart = MagicMock()
|
|
chart.deleted_at = datetime(2026, 1, 1, tzinfo=timezone.utc)
|
|
chart.id = 1
|
|
|
|
with (
|
|
patch(
|
|
"superset.daos.chart.ChartDAO.find_by_id", return_value=chart
|
|
) as mock_find,
|
|
patch("superset.commands.restore.security_manager") as mock_sec,
|
|
):
|
|
mock_sec.raise_for_editorship.return_value = None
|
|
|
|
cmd = RestoreChartCommand("1")
|
|
cmd.run()
|
|
|
|
mock_find.assert_called_once()
|
|
chart.restore.assert_called_once()
|
|
|
|
|
|
def test_restore_chart_not_found_raises(app_context: None) -> None:
|
|
"""RestoreChartCommand raises ChartNotFoundError for missing chart."""
|
|
with patch("superset.daos.chart.ChartDAO.find_by_id", return_value=None):
|
|
cmd = RestoreChartCommand("999")
|
|
with pytest.raises(ChartNotFoundError):
|
|
cmd.run()
|
|
|
|
|
|
def test_restore_active_chart_raises_not_found(app_context: None) -> None:
|
|
"""RestoreChartCommand raises ChartNotFoundError for non-deleted chart."""
|
|
chart = MagicMock()
|
|
chart.deleted_at = None # not soft-deleted
|
|
|
|
with patch("superset.daos.chart.ChartDAO.find_by_id", return_value=chart):
|
|
cmd = RestoreChartCommand("1")
|
|
with pytest.raises(ChartNotFoundError):
|
|
cmd.run()
|
|
|
|
|
|
def test_restore_chart_forbidden_raises(app_context: None) -> None:
|
|
"""RestoreChartCommand raises ChartForbiddenError on permission check."""
|
|
chart = MagicMock()
|
|
chart.deleted_at = datetime(2026, 1, 1, tzinfo=timezone.utc)
|
|
|
|
def raise_security(*args: object, **kwargs: object) -> None:
|
|
raise SupersetSecurityException(MagicMock())
|
|
|
|
with (
|
|
patch("superset.daos.chart.ChartDAO.find_by_id", return_value=chart),
|
|
patch("superset.commands.restore.security_manager") as mock_sec,
|
|
):
|
|
mock_sec.raise_for_editorship = raise_security
|
|
|
|
cmd = RestoreChartCommand("1")
|
|
with pytest.raises(ChartForbiddenError):
|
|
cmd.run()
|