mirror of
https://github.com/apache/superset.git
synced 2026-07-08 15:55:33 +00:00
5d9f0780fc
Shared vertical-dots menu component for dashboard grid components. Generic `items: ComponentMenuItem[]` API — each component (Chart, Markdown, Row, Column, Tabs) plugs in its own list; the visual chrome (dots icon trigger, dropdown surface, accessible label, divider handling, danger/disabled styling) lives in this one component. Built on `MenuDotsDropdown` from `@superset-ui/core/components` so the trigger styling matches Chart's existing `SliceHeaderControls` — Phase 4's per-component PRs will converge `SliceHeaderControls` and the other menu patterns (Markdown's `MarkdownModeDropdown`, Row/Col's gear-icon + `WithPopoverMenu`) onto this same component. Phase 2 lands the component + tests only. The actual per-component menu conversions are user-visible UX changes (e.g. Markdown loses its toggle-style Edit/Preview switcher and gains a dots menu) and ship in Phase 4 alongside theme wiring per component, so each can be reviewed in isolation rather than as a sweeping refactor. 4 passing tests: empty items renders nothing, trigger renders, onClick fires from menu selection, disabled items don't fire onClick. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
67 lines
2.3 KiB
TypeScript
67 lines
2.3 KiB
TypeScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import { render, screen, userEvent } from 'spec/helpers/testing-library';
|
|
import ComponentHeaderControls from '.';
|
|
|
|
test('renders nothing when items is empty', () => {
|
|
const { container } = render(<ComponentHeaderControls items={[]} />);
|
|
expect(container).toBeEmptyDOMElement();
|
|
});
|
|
|
|
test('renders the trigger when items are provided', () => {
|
|
render(
|
|
<ComponentHeaderControls
|
|
items={[{ key: 'edit', label: 'Edit', onClick: () => {} }]}
|
|
/>,
|
|
);
|
|
expect(screen.getByTestId('dropdown-trigger')).toBeInTheDocument();
|
|
});
|
|
|
|
test('fires onClick when a menu item is selected', async () => {
|
|
const onEdit = jest.fn();
|
|
const onPreview = jest.fn();
|
|
render(
|
|
<ComponentHeaderControls
|
|
items={[
|
|
{ key: 'edit', label: 'Edit', onClick: onEdit },
|
|
{ key: 'preview', label: 'Preview', onClick: onPreview },
|
|
]}
|
|
/>,
|
|
);
|
|
await userEvent.click(screen.getByTestId('dropdown-trigger'));
|
|
await userEvent.click(await screen.findByRole('menuitem', { name: 'Edit' }));
|
|
expect(onEdit).toHaveBeenCalledTimes(1);
|
|
expect(onPreview).not.toHaveBeenCalled();
|
|
});
|
|
|
|
test('disabled items are still rendered but do not fire onClick', async () => {
|
|
const onClick = jest.fn();
|
|
render(
|
|
<ComponentHeaderControls
|
|
items={[
|
|
{ key: 'gone', label: 'Gone', onClick, disabled: true },
|
|
]}
|
|
/>,
|
|
);
|
|
await userEvent.click(screen.getByTestId('dropdown-trigger'));
|
|
const item = await screen.findByRole('menuitem', { name: 'Gone' });
|
|
await userEvent.click(item);
|
|
expect(onClick).not.toHaveBeenCalled();
|
|
});
|