Evan 63603ec369 fix(sqllab): keep RLS schema probe out of the session + always run the schema gate ...

Addresses review feedback on the cost-estimate security-parity path:

- The transient Query built to resolve the per-query schema joined the
  session via the `database` backref's `cascade="all, delete-orphan"`.
  With no `client_id` (nullable=False) it autoflushed into an IntegrityError
  the moment `apply_rls` issued its own session query, 500-ing every
  RLS-enabled estimate that references a table. Mirror the probe pattern in
  `SupersetSecurityManager.raise_for_access`: set `client_id`/`user_id` and
  `db.session.expunge` the probe.
- `get_default_schema_for_query` was skipped whenever the caller pinned a
  schema, bypassing the engine's per-query gate (e.g. Postgres rejecting
  `SET search_path`) that the executor runs unconditionally. Always resolve
  through it; an explicit schema still wins as the RLS predicate target.

Unit tests patch the session (so they can't see the autoflush); add an
integration test exercising a real session + real `apply_rls` that would
have caught the regression, and flip the explicit-schema test to assert the
gate now runs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-06-10 14:59:51 -07:00

..

permalink

chore: move some rules from ruff -> pylint (#34292)

2025-07-24 09:40:49 -07:00

__init__.py

…

api_tests.py

chore: bump rison to 2.0.0 (#39529)

2026-04-24 15:52:42 -04:00

commands_tests.py

fix(sqllab): keep RLS schema probe out of the session + always run the schema gate

2026-06-10 14:59:51 -07:00

conftest.py

chore: use contextlib.surpress instead of passing on error (#24896)

2023-08-29 10:09:01 -06:00

test_execute_sql_statements.py

fix(sqllab): validate results backend writes and enhance 410 diagnostics (#36222)

2025-11-21 15:05:48 +00:00