mirror of
https://github.com/apache/superset.git
synced 2026-05-22 00:05:15 +00:00
795d6e67df
Addresses sadpandajoe's review on #39448: 1. Adds tests/unit_tests/scripts/translations/backfill_po_test.py with 19 cases covering parse_response (singular/plural/markdown-fence stripping/non-ASCII/non-numeric keys/list-and-scalar rejection/JSON errors) and _apply_translation (singular path, plural-dict path, plural-scalar fallback, plural invalid-JSON fallback, fuzzy flag, attribution append/dedup, end-to-end round-trip from parse_response into _apply_translation). The script is loaded via importlib since it lives outside the package tree. 2. translate_batch now pipes the prompt over stdin instead of passing it as argv. With --batch-size 50 and many reference languages a single batch can grow into the tens of KB and approach ARG_MAX on some platforms; stdin removes that ceiling. 3. _process_batches now saves the catalog after each batch that wrote at least one translation (when not in --dry-run). For sparse languages with thousands of missing strings, a crash mid-run now only loses the in-flight batch rather than every batch translated so far. The full save at end of backfill() is removed since the per-batch save covers it. 4. Module docstring referenced --fuzzy/--no-fuzzy but argparse only registers --no-fuzzy; doc updated to match the actual flag. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>