mirror of
https://github.com/apache/superset.git
synced 2026-09-09 16:54:29 +00:00
sadpandajoe
7eaed06b08
Some comments (useSticky.tsx, useSticky.test.tsx, RCA.md) still framed the scrollbar-gutter/scrollBarStyles matching as the mechanism that prevents the reported clipping, contradicting this branch's own hit-testing conclusion that it's the unconditional width: maxWidth change that's load-bearing, with gutter/style matching kept only as an unverified, secondary consistency measure for combined horizontal+vertical scrolling. Rewrite those comments and RCA sections to say so explicitly, and fix a getScrollBarSize.test.ts comment that still described the removed maxWidth - scrollBarSize subtraction as the header's "shrink amount". Also remove the `as any` casts from the sticky regression test: type `columns` as `Column<Row>[]` and pass `useSticky` directly, letting `headerGroups`/`rows`/`cells` infer their existing react-table types (already declared in `src/DataTable/types/react-table.d.ts`) instead of bypassing type-checking of the exercised contract. Refs #21063
53 lines
2.0 KiB
TypeScript
53 lines
2.0 KiB
TypeScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import getScrollBarSize, {
|
|
CUSTOM_SCROLLBAR_SIZE,
|
|
getCustomScrollBarSize,
|
|
} from '../../../src/DataTable/utils/getScrollBarSize';
|
|
|
|
test('getScrollBarSize measures the native scrollbar without any custom styling probe', () => {
|
|
const appendSpy = jest.spyOn(document.head, 'append');
|
|
|
|
getScrollBarSize(true);
|
|
|
|
expect(appendSpy).not.toHaveBeenCalled();
|
|
|
|
appendSpy.mockRestore();
|
|
});
|
|
|
|
test('getCustomScrollBarSize measures the probe using the shared custom scrollbar size', () => {
|
|
const appendSpy = jest.spyOn(document.head, 'append');
|
|
|
|
getCustomScrollBarSize(true);
|
|
|
|
const styleEl = appendSpy.mock.calls
|
|
.map(args => args[0])
|
|
.find((node): node is HTMLStyleElement => node instanceof HTMLStyleElement);
|
|
expect(styleEl?.textContent).toContain(`width: ${CUSTOM_SCROLLBAR_SIZE}px`);
|
|
|
|
appendSpy.mockRestore();
|
|
});
|
|
|
|
test('CUSTOM_SCROLLBAR_SIZE matches the custom scrollbar width rendered in the sticky table', () => {
|
|
// useSticky.tsx's scrollBarStyles sets `::-webkit-scrollbar { width: ... }`
|
|
// from this constant, so it must stay in sync with it or the real
|
|
// scrollbar body/sizer render won't match what this constant claims.
|
|
expect(CUSTOM_SCROLLBAR_SIZE).toBe(8);
|
|
});
|