mirror of
https://github.com/apache/superset.git
synced 2026-09-06 07:21:35 +00:00
rusackasandClaude Opus 4.8
80928bdb6c
The "paginated query returns correct rows in order" test body was duplicated verbatim across cockroachdb/crate/db2/mssql/oracle/trino's testcontainers suites. Factor the shared table-setup/assert logic into _pagination.py, with an optional post-insert hook for CrateDB's eventual-consistency REFRESH TABLE step; each call site keeps its own test function and dialect-specific docstring. Addresses bito-code-review feedback on #43502. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
99 lines
3.5 KiB
Python
99 lines
3.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
"""
|
|
Tests db_engine_specs.crate against a real CrateDB instance, spun up on
|
|
demand via testcontainers. Run nightly (see
|
|
.github/workflows/nightly-testcontainers.yml), not on every merge.
|
|
|
|
crate/crate only publishes an amd64 image (no arm64 build), and requires a
|
|
host CPU supporting the x86-64-v3 instruction set -- QEMU emulation on
|
|
Apple Silicon cannot satisfy that, so this file cannot run locally on an
|
|
Apple Silicon machine even with `docker pull --platform linux/amd64`. It
|
|
runs natively on GitHub Actions' x86_64 runners.
|
|
"""
|
|
|
|
from collections.abc import Iterator
|
|
|
|
import pytest
|
|
from sqlalchemy import (
|
|
Column,
|
|
create_engine,
|
|
inspect,
|
|
Integer,
|
|
MetaData,
|
|
Table as SATable,
|
|
)
|
|
from sqlalchemy.engine import Connection, Engine
|
|
|
|
from superset.db_engine_specs.crate import CrateEngineSpec
|
|
from superset.sql.parse import Table
|
|
|
|
pytest.importorskip("testcontainers.community.cratedb")
|
|
|
|
from testcontainers.community.cratedb import CrateDBContainer # noqa: E402
|
|
|
|
from ._pagination import assert_paginated_query_returns_correct_rows_in_order
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def engine() -> Iterator[Engine]:
|
|
with CrateDBContainer() as container:
|
|
yield create_engine(container.get_connection_url())
|
|
|
|
|
|
def _refresh_pilot_pagination(conn: Connection) -> None:
|
|
# CrateDB is eventually consistent: a row is not guaranteed visible to
|
|
# subsequent selects immediately after insert.
|
|
conn.exec_driver_sql("REFRESH TABLE pilot_pagination")
|
|
|
|
|
|
def test_paginated_query_returns_correct_rows_in_order(engine: Engine) -> None:
|
|
"""
|
|
A plain SQLAlchemy Core LIMIT/OFFSET query, compiled and executed against
|
|
a real instance. Mocked tests cannot catch a dialect compiling this
|
|
incorrectly (see apache/superset#42899, where Trino emitted OFFSET
|
|
before LIMIT) -- only real execution can.
|
|
"""
|
|
assert_paginated_query_returns_correct_rows_in_order(
|
|
engine, after_insert=_refresh_pilot_pagination
|
|
)
|
|
|
|
|
|
def test_get_columns_maps_native_types(engine: Engine) -> None:
|
|
"""
|
|
CrateEngineSpec.get_columns wraps a real SQLAlchemy Inspector; this
|
|
exercises that against actual server-reported column metadata rather
|
|
than a mocked Inspector.
|
|
"""
|
|
metadata = MetaData()
|
|
SATable(
|
|
"pilot_types",
|
|
metadata,
|
|
Column("id", Integer, primary_key=True),
|
|
Column("amount", Integer),
|
|
)
|
|
metadata.create_all(engine)
|
|
|
|
inspector = inspect(engine)
|
|
columns = CrateEngineSpec.get_columns(inspector, Table("pilot_types"))
|
|
|
|
by_name = {col["column_name"]: col for col in columns}
|
|
assert set(by_name) == {"id", "amount"}
|
|
for col in by_name.values():
|
|
spec = CrateEngineSpec.get_column_spec(str(col["type"]))
|
|
assert spec is not None
|