mirror of
https://github.com/apache/superset.git
synced 2026-05-07 17:04:58 +00:00
8c102174b8
* rename key_value to temporary_cache
* add migration
* create new key_value package
* add commands
* lots of new stuff
* fix schema reference
* remove redundant filter state from bootstrap data
* add missing license headers
* fix pylint
* fix dashboard permalink access
* use valid json mocks for filter state tests
* fix temporary cache tests
* add anchors to dashboard state
* lint
* fix util test
* fix url shortlink button tests
* remove legacy shortner
* remove unused imports
* fix js tests
* fix test
* add native filter state to anchor link
* add UPDATING.md section
* address comments
* address comments
* lint
* fix test
* add utils tests + other test stubs
* add key_value integration tests
* add filter box state to permalink state
* fully support persisting url parameters
* lint, add redirects and a few integration tests
* fix test + clean up trailing comma
* fix anchor bug
* change value to LargeBinary to support persisting binary values
* fix urlParams type and simplify urlencode
* lint
* add optional entry expiration
* fix incorrect chart id + add test
(cherry picked from commit b7a0559aaf)
158 lines
6.2 KiB
Python
158 lines
6.2 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
from flask.ctx import AppContext
|
|
from flask_appbuilder.security.sqla.models import User
|
|
from pytest import raises
|
|
from pytest_mock import MockFixture
|
|
|
|
from superset.charts.commands.exceptions import (
|
|
ChartAccessDeniedError,
|
|
ChartNotFoundError,
|
|
)
|
|
from superset.datasets.commands.exceptions import (
|
|
DatasetAccessDeniedError,
|
|
DatasetNotFoundError,
|
|
)
|
|
|
|
dataset_find_by_id = "superset.datasets.dao.DatasetDAO.find_by_id"
|
|
chart_find_by_id = "superset.charts.dao.ChartDAO.find_by_id"
|
|
is_user_admin = "superset.explore.utils.is_user_admin"
|
|
is_owner = "superset.explore.utils.is_owner"
|
|
can_access_datasource = (
|
|
"superset.security.SupersetSecurityManager.can_access_datasource"
|
|
)
|
|
can_access = "superset.security.SupersetSecurityManager.can_access"
|
|
|
|
|
|
def test_unsaved_chart_no_dataset_id(app_context: AppContext) -> None:
|
|
from superset.explore.utils import check_access
|
|
|
|
with raises(DatasetNotFoundError):
|
|
check_access(dataset_id=0, chart_id=0, actor=User())
|
|
|
|
|
|
def test_unsaved_chart_unknown_dataset_id(
|
|
mocker: MockFixture, app_context: AppContext
|
|
) -> None:
|
|
from superset.explore.utils import check_access
|
|
|
|
with raises(DatasetNotFoundError):
|
|
mocker.patch(dataset_find_by_id, return_value=None)
|
|
check_access(dataset_id=1, chart_id=0, actor=User())
|
|
|
|
|
|
def test_unsaved_chart_unauthorized_dataset(
|
|
mocker: MockFixture, app_context: AppContext
|
|
) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore import utils
|
|
|
|
with raises(DatasetAccessDeniedError):
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=False)
|
|
utils.check_access(dataset_id=1, chart_id=0, actor=User())
|
|
|
|
|
|
def test_unsaved_chart_authorized_dataset(
|
|
mocker: MockFixture, app_context: AppContext
|
|
) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore.utils import check_access
|
|
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=True)
|
|
assert check_access(dataset_id=1, chart_id=0, actor=User()) == True
|
|
|
|
|
|
def test_saved_chart_unknown_chart_id(
|
|
mocker: MockFixture, app_context: AppContext
|
|
) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore.utils import check_access
|
|
|
|
with raises(ChartNotFoundError):
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=True)
|
|
mocker.patch(chart_find_by_id, return_value=None)
|
|
check_access(dataset_id=1, chart_id=1, actor=User())
|
|
|
|
|
|
def test_saved_chart_unauthorized_dataset(
|
|
mocker: MockFixture, app_context: AppContext
|
|
) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore import utils
|
|
|
|
with raises(DatasetAccessDeniedError):
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=False)
|
|
utils.check_access(dataset_id=1, chart_id=1, actor=User())
|
|
|
|
|
|
def test_saved_chart_is_admin(mocker: MockFixture, app_context: AppContext) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore.utils import check_access
|
|
from superset.models.slice import Slice
|
|
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=True)
|
|
mocker.patch(is_user_admin, return_value=True)
|
|
mocker.patch(chart_find_by_id, return_value=Slice())
|
|
assert check_access(dataset_id=1, chart_id=1, actor=User()) is True
|
|
|
|
|
|
def test_saved_chart_is_owner(mocker: MockFixture, app_context: AppContext) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore.utils import check_access
|
|
from superset.models.slice import Slice
|
|
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=True)
|
|
mocker.patch(is_user_admin, return_value=False)
|
|
mocker.patch(is_owner, return_value=True)
|
|
mocker.patch(chart_find_by_id, return_value=Slice())
|
|
assert check_access(dataset_id=1, chart_id=1, actor=User()) == True
|
|
|
|
|
|
def test_saved_chart_has_access(mocker: MockFixture, app_context: AppContext) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore.utils import check_access
|
|
from superset.models.slice import Slice
|
|
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=True)
|
|
mocker.patch(is_user_admin, return_value=False)
|
|
mocker.patch(is_owner, return_value=False)
|
|
mocker.patch(can_access, return_value=True)
|
|
mocker.patch(chart_find_by_id, return_value=Slice())
|
|
assert check_access(dataset_id=1, chart_id=1, actor=User()) == True
|
|
|
|
|
|
def test_saved_chart_no_access(mocker: MockFixture, app_context: AppContext) -> None:
|
|
from superset.connectors.sqla.models import SqlaTable
|
|
from superset.explore.utils import check_access
|
|
from superset.models.slice import Slice
|
|
|
|
with raises(ChartAccessDeniedError):
|
|
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
|
|
mocker.patch(can_access_datasource, return_value=True)
|
|
mocker.patch(is_user_admin, return_value=False)
|
|
mocker.patch(is_owner, return_value=False)
|
|
mocker.patch(can_access, return_value=False)
|
|
mocker.patch(chart_find_by_id, return_value=Slice())
|
|
check_access(dataset_id=1, chart_id=1, actor=User())
|