Files
superset2/superset/views/datasource.py
ʈᵃᵢ a94464b9c9 guard against duplicate columns in datasource save (#8712)
* catch IntegrityError in datasource save

* catch duplicate columns and wrap in exception handling decorators

* use 409

* isort
2019-12-04 11:05:06 -08:00

114 lines
4.0 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# pylint: disable=C,R,W
import json
from collections import Counter
from flask import request
from flask_appbuilder import expose
from flask_appbuilder.security.decorators import has_access_api
from sqlalchemy.exc import IntegrityError
from superset import appbuilder, db
from superset.connectors.connector_registry import ConnectorRegistry
from superset.models.core import Database
from .base import api, BaseSupersetView, handle_api_exception, json_error_response
class Datasource(BaseSupersetView):
"""Datasource-related views"""
@expose("/save/", methods=["POST"])
@has_access_api
@api
@handle_api_exception
def save(self):
datasource = json.loads(request.form.get("data"))
datasource_id = datasource.get("id")
datasource_type = datasource.get("type")
orm_datasource = ConnectorRegistry.get_datasource(
datasource_type, datasource_id, db.session
)
if "owners" in datasource:
datasource["owners"] = (
db.session.query(orm_datasource.owner_class)
.filter(orm_datasource.owner_class.id.in_(datasource["owners"]))
.all()
)
duplicates = [
name
for name, count in Counter(
[col["column_name"] for col in datasource["columns"]]
).items()
if count > 1
]
if duplicates:
return json_error_response(
f"Duplicate column name(s): {','.join(duplicates)}", status="409"
)
orm_datasource.update_from_object(datasource)
data = orm_datasource.data
db.session.commit()
return self.json_response(data)
@expose("/get/<datasource_type>/<datasource_id>/")
@has_access_api
@api
@handle_api_exception
def get(self, datasource_type, datasource_id):
orm_datasource = ConnectorRegistry.get_datasource(
datasource_type, datasource_id, db.session
)
if not orm_datasource:
return json_error_response("This datasource does not exist", status="400")
elif not orm_datasource.data:
return json_error_response("Error fetching datasource data.", status="500")
return self.json_response(orm_datasource.data)
@expose("/external_metadata/<datasource_type>/<datasource_id>/")
@has_access_api
@api
@handle_api_exception
def external_metadata(self, datasource_type=None, datasource_id=None):
"""Gets column info from the source system"""
if datasource_type == "druid":
datasource = ConnectorRegistry.get_datasource(
datasource_type, datasource_id, db.session
)
elif datasource_type == "table":
database = (
db.session.query(Database).filter_by(id=request.args.get("db_id")).one()
)
Table = ConnectorRegistry.sources["table"]
datasource = Table(
database=database,
table_name=request.args.get("table_name"),
schema=request.args.get("schema") or None,
)
external_metadata = datasource.external_metadata()
return self.json_response(external_metadata)
appbuilder.add_view_no_menu(Datasource)