mirror of
https://github.com/apache/superset.git
synced 2026-09-09 00:34:49 +00:00
Two unit test failures, one real and one a fixture gap. has_embedded_chart_access queried the slice before establishing that a guest user exists, so it issued a database lookup on every datasource check that reached it, including paths where the grant could never hold. Resolving the guest user first skips the query entirely in that case. The embedded guest chart test builds its security manager as a mock specced against the real class, so has_guest_access_to_chart returned a truthy mock and the denial assertion no longer held. It is closed by default alongside the other paths the helper already closes, and the chart-direct grant now has a test of its own rather than only being exercised implicitly.