mirror of
https://github.com/apache/superset.git
synced 2026-04-09 19:35:21 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
82 lines
1.9 KiB
JavaScript
82 lines
1.9 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import { chart as initChart } from '../../../src/chart/chartReducer';
|
|
import Chart from '../../../src/chart/Chart';
|
|
import ChartBody from '../../../src/chart/ChartBody';
|
|
import Loading from '../../../src/components/Loading';
|
|
|
|
describe('Chart', () => {
|
|
const chart = {
|
|
...initChart,
|
|
queryResponse: {
|
|
form_data: {},
|
|
error: null,
|
|
status: 'success',
|
|
},
|
|
};
|
|
const mockedProps = {
|
|
...chart,
|
|
id: 223,
|
|
containerId: 'slice-container-223',
|
|
datasource: {},
|
|
formData: {},
|
|
vizType: 'pie',
|
|
height: 300,
|
|
width: 400,
|
|
actions: {
|
|
runQuery: () => {},
|
|
},
|
|
};
|
|
|
|
let wrapper;
|
|
beforeEach(() => {
|
|
wrapper = shallow(
|
|
<Chart {...mockedProps} />,
|
|
);
|
|
});
|
|
describe('renderVis', () => {
|
|
let stub;
|
|
beforeEach(() => {
|
|
stub = sinon.stub(wrapper.instance(), 'renderVis');
|
|
});
|
|
afterEach(() => {
|
|
stub.restore();
|
|
});
|
|
|
|
it('should not call when loading', () => {
|
|
const prevProp = wrapper.props();
|
|
wrapper.setProps({
|
|
height: 100,
|
|
});
|
|
wrapper.instance().componentDidUpdate(prevProp);
|
|
expect(stub.callCount).toBe(0);
|
|
});
|
|
|
|
it('should call after chart stop loading', () => {
|
|
const prevProp = wrapper.props();
|
|
wrapper.setProps({
|
|
chartStatus: 'success',
|
|
});
|
|
wrapper.instance().componentDidUpdate(prevProp);
|
|
expect(stub.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call after resize', () => {
|
|
wrapper.setProps({
|
|
chartStatus: 'rendered',
|
|
height: 100,
|
|
});
|
|
expect(stub.callCount).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe('render', () => {
|
|
it('should render ChartBody after loading is completed', () => {
|
|
expect(wrapper.find(Loading)).toHaveLength(1);
|
|
expect(wrapper.find(ChartBody)).toHaveLength(0);
|
|
});
|
|
});
|
|
});
|