mirror of
https://github.com/apache/superset.git
synced 2026-04-09 03:16:07 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
101 lines
3.3 KiB
JavaScript
101 lines
3.3 KiB
JavaScript
/* eslint-disable no-unused-expressions */
|
|
import React from 'react';
|
|
import Select, { Creatable } from 'react-select';
|
|
import VirtualizedSelect from 'react-virtualized-select';
|
|
import sinon from 'sinon';
|
|
import { shallow } from 'enzyme';
|
|
import OnPasteSelect from '../../../../src/components/OnPasteSelect';
|
|
import VirtualizedRendererWrap from '../../../../src/components/VirtualizedRendererWrap';
|
|
import SelectControl from '../../../../src/explore/components/controls/SelectControl';
|
|
|
|
const defaultProps = {
|
|
choices: [['1 year ago', '1 year ago'], ['today', 'today']],
|
|
name: 'row_limit',
|
|
label: 'Row Limit',
|
|
onChange: sinon.spy(),
|
|
};
|
|
|
|
const options = [
|
|
{ value: '1 year ago', label: '1 year ago' },
|
|
{ value: 'today', label: 'today' },
|
|
];
|
|
|
|
describe('SelectControl', () => {
|
|
let wrapper;
|
|
|
|
beforeEach(() => {
|
|
wrapper = shallow(<SelectControl {...defaultProps} />);
|
|
});
|
|
|
|
it('renders an OnPasteSelect', () => {
|
|
expect(wrapper.find(OnPasteSelect)).toHaveLength(1);
|
|
});
|
|
|
|
it('calls onChange when toggled', () => {
|
|
const select = wrapper.find(OnPasteSelect);
|
|
select.simulate('change', { value: 50 });
|
|
expect(defaultProps.onChange.calledWith(50)).toBe(true);
|
|
});
|
|
|
|
it('passes VirtualizedSelect as selectWrap', () => {
|
|
const select = wrapper.find(OnPasteSelect);
|
|
expect(select.props().selectWrap).toBe(VirtualizedSelect);
|
|
});
|
|
|
|
it('passes Creatable as selectComponent when freeForm=true', () => {
|
|
wrapper = shallow(<SelectControl {...defaultProps} freeForm />);
|
|
const select = wrapper.find(OnPasteSelect);
|
|
expect(select.props().selectComponent).toBe(Creatable);
|
|
});
|
|
|
|
it('passes Select as selectComponent when freeForm=false', () => {
|
|
const select = wrapper.find(OnPasteSelect);
|
|
expect(select.props().selectComponent).toBe(Select);
|
|
});
|
|
|
|
it('wraps optionRenderer in a VirtualizedRendererWrap', () => {
|
|
const select = wrapper.find(OnPasteSelect);
|
|
const defaultOptionRenderer = SelectControl.defaultProps.optionRenderer;
|
|
const wrappedRenderer = VirtualizedRendererWrap(defaultOptionRenderer);
|
|
expect(typeof select.props().optionRenderer).toBe('function');
|
|
// different instances of wrapper with same inner renderer are unequal
|
|
expect(select.props().optionRenderer.name).toBe(wrappedRenderer.name);
|
|
});
|
|
|
|
describe('getOptions', () => {
|
|
it('returns the correct options', () => {
|
|
expect(wrapper.instance().getOptions(defaultProps)).toEqual(options);
|
|
});
|
|
|
|
it('returns the correct options when freeform is set to true', () => {
|
|
const freeFormProps = Object.assign(defaultProps, {
|
|
choices: [],
|
|
freeForm: true,
|
|
value: ['one', 'two'],
|
|
});
|
|
const newOptions = [
|
|
{ value: 'one', label: 'one' },
|
|
{ value: 'two', label: 'two' },
|
|
];
|
|
expect(wrapper.instance().getOptions(freeFormProps)).toEqual(newOptions);
|
|
});
|
|
});
|
|
|
|
describe('componentWillReceiveProps', () => {
|
|
it('sets state.options if props.choices has changed', () => {
|
|
const updatedOptions = [
|
|
{ value: 'three', label: 'three' },
|
|
{ value: 'four', label: 'four' },
|
|
];
|
|
const newProps = {
|
|
choices: [['three', 'three'], ['four', 'four']],
|
|
name: 'name',
|
|
freeForm: false,
|
|
value: null,
|
|
};
|
|
wrapper.setProps(newProps);
|
|
expect(wrapper.state().options).toEqual(updatedOptions);
|
|
});
|
|
});
|
|
});
|