Files
superset2/superset/assets/spec/javascripts/modules/Registry_spec.js
Christine Chambers 9029701f24 [refactor] Migrate from Mocha+Chai to Jest (#6079)
* [refactor] Migrate from Mocha+Chai to Jest

This change migrates all the existing unit tests
- to Jest's global expect and matchers from chai's imported expect, asserts and matchers.
- to Jest's describe/test from mocha's describe/it

The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks:
1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank.
2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :)

This change also removes dependencies to Mocha and Chai.

* Remove the test:one command as it now does the same thing as test.

* Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix`

The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest.

* Adding eslint-plugin-jest and further modify tests.

- One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing.
- Deletion of a duplicated test caught by eslint-plugin-jest.

* - Make istanbul coverage work with Jest.

- Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes!

* Attempt to fix dynamic imports in tests.

* run sequentially and log heap usage

* - tweaking maxworkers for travis and specifying coverageDirectory for codecov

- remove dynamic import in shim.js now that it is set in babelrc for tests only.
2018-10-15 13:10:18 -07:00

192 lines
6.4 KiB
JavaScript

import Registry from '../../../src/modules/Registry';
describe('Registry', () => {
it('exists', () => {
expect(Registry !== undefined).toBe(true);
});
describe('new Registry(name)', () => {
it('can create a new registry when name is not given', () => {
const registry = new Registry();
expect(registry).toBeInstanceOf(Registry);
});
it('can create a new registry when name is given', () => {
const registry = new Registry('abc');
expect(registry).toBeInstanceOf(Registry);
expect(registry.name).toBe('abc');
});
});
describe('.has(key)', () => {
it('returns true if an item with the given key exists', () => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
expect(registry.has('a')).toBe(true);
registry.registerLoader('b', () => 'testValue2');
expect(registry.has('b')).toBe(true);
});
it('returns false if an item with the given key does not exist', () => {
const registry = new Registry();
expect(registry.has('a')).toBe(false);
});
});
describe('.registerValue(key, value)', () => {
it('registers the given value with the given key', () => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
expect(registry.has('a')).toBe(true);
expect(registry.get('a')).toBe('testValue');
});
it('returns the registry itself', () => {
const registry = new Registry();
expect(registry.registerValue('a', 'testValue')).toBe(registry);
});
});
describe('.registerLoader(key, loader)', () => {
it('registers the given loader with the given key', () => {
const registry = new Registry();
registry.registerLoader('a', () => 'testValue');
expect(registry.has('a')).toBe(true);
expect(registry.get('a')).toBe('testValue');
});
it('returns the registry itself', () => {
const registry = new Registry();
expect(registry.registerLoader('a', () => 'testValue')).toBe(registry);
});
});
describe('.get(key)', () => {
it('given the key, returns the value if the item is a value', () => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
expect(registry.get('a')).toBe('testValue');
});
it(
'given the key, returns the result of the loader function if the item is a loader',
() => {
const registry = new Registry();
registry.registerLoader('b', () => 'testValue2');
expect(registry.get('b')).toBe('testValue2');
},
);
it('returns null if the item with specified key does not exist', () => {
const registry = new Registry();
expect(registry.get('a')).toBeNull();
});
it(
'If the key was registered multiple times, returns the most recent item.',
() => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
expect(registry.get('a')).toBe('testValue');
registry.registerLoader('a', () => 'newValue');
expect(registry.get('a')).toBe('newValue');
},
);
});
describe('.getAsPromise(key)', () => {
it(
'given the key, returns a promise of item value if the item is a value',
() => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
return registry.getAsPromise('a').then((value) => {
expect(value).toBe('testValue');
});
},
);
it(
'given the key, returns a promise of result of the loader function if the item is a loader ',
() => {
const registry = new Registry();
registry.registerLoader('a', () => 'testValue');
return registry.getAsPromise('a').then((value) => {
expect(value).toBe('testValue');
});
},
);
it(
'returns a rejected promise if the item with specified key does not exist',
() => {
const registry = new Registry();
return registry.getAsPromise('a').then(null, (err) => {
expect(err).toBe('Item with key "a" is not registered.');
});
},
);
it(
'If the key was registered multiple times, returns a promise of the most recent item.',
() => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
const promise1 = registry.getAsPromise('a').then((value) => {
expect(value).toBe('testValue');
});
registry.registerLoader('a', () => 'newValue');
const promise2 = registry.getAsPromise('a').then((value) => {
expect(value).toBe('newValue');
});
return Promise.all([promise1, promise2]);
},
);
});
describe('.keys()', () => {
it('returns an array of keys', () => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
registry.registerLoader('b', () => 'test2');
expect(registry.keys()).toEqual(['a', 'b']);
});
});
describe('.entries()', () => {
it('returns an array of { key, value }', () => {
const registry = new Registry();
registry.registerValue('a', 'test1');
registry.registerLoader('b', () => 'test2');
expect(registry.entries()).toEqual([
{ key: 'a', value: 'test1' },
{ key: 'b', value: 'test2' },
]);
});
});
describe('.entriesAsPromise()', () => {
it('returns a Promise of an array { key, value }', () => {
const registry = new Registry();
registry.registerValue('a', 'test1');
registry.registerLoader('b', () => 'test2');
registry.registerLoader('c', () => Promise.resolve('test3'));
return registry.entriesAsPromise().then((entries) => {
expect(entries).toEqual([
{ key: 'a', value: 'test1' },
{ key: 'b', value: 'test2' },
{ key: 'c', value: 'test3' },
]);
});
});
});
describe('.remove(key)', () => {
it('removes the item with given key', () => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
registry.remove('a');
expect(registry.get('a')).toBeNull();
});
it('does not throw error if the key does not exist', () => {
const registry = new Registry();
expect(() => registry.remove('a')).not.toThrowError();
});
it('returns itself', () => {
const registry = new Registry();
registry.registerValue('a', 'testValue');
expect(registry.remove('a')).toBe(registry);
});
});
});