mirror of
https://github.com/apache/superset.git
synced 2026-07-28 17:42:40 +00:00
Fixes two issues with the drill-through chart configuration: 1. **SelectAsyncControl crash on clear**: Fixed isLabeledValue function to handle null values properly when clearing selections 2. **Missing field in Explore path**: Added drill_through_chart_id to both dataset API response and SqlaTable.data property serialization This ensures the drill-through chart field loads and saves correctly whether accessed from: - Datasets CRUD interface - Explore → Edit Dataset flow 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
119 lines
3.7 KiB
TypeScript
119 lines
3.7 KiB
TypeScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import fetchMock from 'fetch-mock';
|
|
import { render, screen, userEvent } from 'spec/helpers/testing-library';
|
|
import SelectAsyncControl from '.';
|
|
|
|
const datasetsOwnersEndpoint = 'glob:*/api/v1/dataset/related/owners*';
|
|
|
|
jest.mock('@superset-ui/core/components/Select/Select', () => ({
|
|
__esModule: true,
|
|
default: (props: any) => (
|
|
<div
|
|
data-test="select-test"
|
|
data-value={JSON.stringify(props.value)}
|
|
data-placeholder={props.placeholder}
|
|
data-multi={props.mode}
|
|
>
|
|
<button
|
|
type="button"
|
|
onClick={() => props.onChange(props.multi ? [] : {})}
|
|
>
|
|
onChange
|
|
</button>
|
|
<button type="button" onClick={() => props.mutator()}>
|
|
mutator
|
|
</button>
|
|
</div>
|
|
),
|
|
propertyComparator: jest.fn(),
|
|
}));
|
|
|
|
fetchMock.get(datasetsOwnersEndpoint, {
|
|
result: [],
|
|
});
|
|
|
|
const createProps = () => ({
|
|
ariaLabel: 'SelectAsyncControl',
|
|
value: [],
|
|
dataEndpoint: datasetsOwnersEndpoint,
|
|
multi: true,
|
|
placeholder: 'Select ...',
|
|
onChange: jest.fn(),
|
|
mutator: jest.fn(),
|
|
});
|
|
|
|
beforeEach(() => {
|
|
jest.resetAllMocks();
|
|
});
|
|
|
|
test('Should render', async () => {
|
|
const props = createProps();
|
|
render(<SelectAsyncControl {...props} />, { useRedux: true });
|
|
expect(await screen.findByTestId('select-test')).toBeInTheDocument();
|
|
});
|
|
|
|
test('Should send correct props to Select component - value props', async () => {
|
|
const props = createProps();
|
|
render(<SelectAsyncControl {...props} />, { useRedux: true });
|
|
|
|
expect(await screen.findByTestId('select-test')).toHaveAttribute(
|
|
'data-value',
|
|
JSON.stringify(props.value),
|
|
);
|
|
expect(screen.getByTestId('select-test')).toHaveAttribute(
|
|
'data-placeholder',
|
|
props.placeholder,
|
|
);
|
|
expect(screen.getByTestId('select-test')).toHaveAttribute(
|
|
'data-multi',
|
|
'multiple',
|
|
);
|
|
});
|
|
|
|
test('Should send correct props to Select component - function onChange multi:true', async () => {
|
|
const props = createProps();
|
|
render(<SelectAsyncControl {...props} />, { useRedux: true });
|
|
expect(props.onChange).toHaveBeenCalledTimes(0);
|
|
userEvent.click(await screen.findByText('onChange'));
|
|
expect(props.onChange).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('Should send correct props to Select component - function onChange multi:false', async () => {
|
|
const props = createProps();
|
|
render(<SelectAsyncControl {...{ ...props, multi: false }} />, {
|
|
useRedux: true,
|
|
});
|
|
expect(props.onChange).toHaveBeenCalledTimes(0);
|
|
userEvent.click(await screen.findByText('onChange'));
|
|
expect(props.onChange).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('Should handle null value without crashing when clearing selection', () => {
|
|
const props = createProps();
|
|
const { rerender } = render(<SelectAsyncControl {...props} />, {
|
|
useRedux: true,
|
|
});
|
|
|
|
// Simulate clearing the selection by passing null value
|
|
expect(() => {
|
|
rerender(<SelectAsyncControl {...props} value={null} />);
|
|
}).not.toThrow();
|
|
});
|