Files
superset2/tests/unit_tests/reports/logs_api_test.py
T

38 lines
1.6 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from superset.reports.filters import ReportExecutionLogFilter
from superset.reports.logs.api import ReportExecutionLogRestApi
def test_execution_log_api_has_ownership_base_filter() -> None:
"""
Regression test: the schedule id in the ``/log/`` and ``/log/<id>``
routes is caller-controlled (folded into the rison filters), so an
editor-scoped base filter must be applied to both the list and item
routes -- otherwise any role with generic ReportSchedule read can iterate
every schedule's logs.
"""
assert ReportExecutionLogRestApi.base_filters, (
"ReportExecutionLogRestApi must apply an ownership base filter; "
"without one, logs are readable across schedules regardless of "
"ownership"
)
assert any(
filter_class is ReportExecutionLogFilter
for _, filter_class, _ in ReportExecutionLogRestApi.base_filters
)