mirror of
https://github.com/apache/superset.git
synced 2026-05-29 20:29:34 +00:00
d8335c0e1b
Three CI failures rooted in the route_base="" migration: * Backend `test_explore_redirect`: `Superset.explore` and `ExploreView.root` both register at `/explore/`; ExploreView wins, leaving the form_data → form_data_key cache-and-redirect contract dead. Move that early-return into `ExploreView.root` (delegates to `Superset.get_redirect_url()`). * Cypress `actions.test.js` / `editmode.test.ts`: `cypress/utils/urls.ts` still hardcoded `/superset/dashboard/...` for 4 dashboard constants; drop the prefix. * Playwright `auth/login.spec.ts`: `playwright/utils/urls.ts` `WELCOME` was `'superset/welcome/'`; login redirects to `/welcome/` now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
64 lines
2.5 KiB
Python
64 lines
2.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
from flask import redirect, request
|
|
from flask_appbuilder import permission_name
|
|
from flask_appbuilder.api import expose
|
|
from flask_appbuilder.security.decorators import has_access
|
|
|
|
from superset import event_logger
|
|
from superset.superset_typing import FlaskResponse
|
|
|
|
from .base import BaseSupersetView
|
|
|
|
|
|
class ExploreView(BaseSupersetView):
|
|
route_base = "/explore"
|
|
class_permission_name = "Explore"
|
|
|
|
@expose("/")
|
|
@has_access
|
|
@permission_name("read")
|
|
@event_logger.log_this
|
|
def root(self) -> FlaskResponse:
|
|
# After `Superset.route_base = ""`, both `Superset.explore` and this
|
|
# view register at `/explore/`; this view wins. Preserve the legacy
|
|
# form_data → form_data_key cache-and-redirect contract here so
|
|
# callers passing `?form_data=...` still get the short cache-key URL.
|
|
if request.args.get("form_data"):
|
|
from superset.views.core import Superset # avoid circular import
|
|
|
|
return redirect(Superset.get_redirect_url())
|
|
return super().render_app_template()
|
|
|
|
|
|
class ExplorePermalinkView(BaseSupersetView):
|
|
# Mirror `Superset.route_base = ""` (see `views/core.py`): Flask-AppBuilder
|
|
# auto-derives `/explorepermalink` from the class name, but the rule pattern
|
|
# already encodes the full path. Leaving the auto-derived value collides
|
|
# with `AppRootMiddleware` under subdirectory deployments and doubles the
|
|
# prefix emitted by `url_for("ExplorePermalinkView.permalink")`.
|
|
route_base = ""
|
|
class_permission_name = "Explore"
|
|
|
|
@expose("/explore/p/<key>/")
|
|
@has_access
|
|
@permission_name("read")
|
|
@event_logger.log_this
|
|
# pylint: disable=unused-argument
|
|
def permalink(self, key: str) -> FlaskResponse:
|
|
return super().render_app_template()
|