mirror of
https://github.com/apache/superset.git
synced 2026-06-07 16:49:17 +00:00
959b15eeca
* feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access
46 lines
1.6 KiB
Python
46 lines
1.6 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
import logging
|
|
from abc import ABC, abstractmethod
|
|
|
|
from sqlalchemy.exc import SQLAlchemyError
|
|
|
|
from superset.commands.base import BaseCommand
|
|
from superset.key_value.commands.exceptions import KeyValueDeleteFailedError
|
|
from superset.key_value.commands.parameters import CommandParameters
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class DeleteKeyValueCommand(BaseCommand, ABC):
|
|
def __init__(self, cmd_params: CommandParameters):
|
|
self._cmd_params = cmd_params
|
|
|
|
def run(self) -> bool:
|
|
try:
|
|
return self.delete(self._cmd_params)
|
|
except SQLAlchemyError as ex:
|
|
logger.exception("Error running delete command")
|
|
raise KeyValueDeleteFailedError() from ex
|
|
|
|
def validate(self) -> None:
|
|
pass
|
|
|
|
@abstractmethod
|
|
def delete(self, cmd_params: CommandParameters) -> bool:
|
|
...
|