mirror of
https://github.com/apache/superset.git
synced 2026-09-01 13:01:33 +00:00
Claude Code
04bd07ad6e
Addresses @sadpandajoe's follow-up review comment on #41714: an original query_context with "queries": [] backs up as a falsy-but- present empty list, not None. downgrade_slice's truthiness check (`if queries_bak:`) treated that the same as "no context was ever stored" and set query_context to None, discarding the slice's original datasource and form_data instead of restoring it. Also fixes the same ambiguity at the source: QUERIES_BAK_FIELD_NAME defaulted to {} rather than None when absent from form_data, which could be misread as a real (if malformed) backup rather than "key not present". Changed to the natural None default so "no backup" and "an empty list backup" stay distinguishable, and dedented the query_context assignment that was incorrectly nested inside the "form_data" in query_context check (a context missing "form_data" would restore params/viz_type but silently leave query_context at its upgraded value). Also updates the stale UPDATING.md note for this PR: the percent- re-basing and deck_multi autozoom limitations it warned about were both resolved earlier in this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>